dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
113,742 Commits 2 Branches 0 Tags
tonycloud/dev
Commit Graph

13 Commits

Author SHA1 Message Date
Ryan Macnak 605b211c89 Reapply "[build] Don't list Dart sources up front when creating application snapshots." 
Fix `application_snapshot`'s depfile to track the sources of the application instead of the compiler. Split compiling the compiler into a separate GN target with its own depfile.

Bug: https://github.com/flutter/flutter/issues/81074
Change-Id: I0fb23ada40a6241ee3dde7f6cfebdd121b9a4224
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197020
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-04-27 17:22:54 +00:00
Ryan Macnak 1305295051 Revert "[build] Don't list Dart sources up front when creating application snapshots." 
This reverts commit a23c31bf8d.

Reason for revert: The bootstrapping compilations are a bit confused about whose deps they're writing

Original change's description:
> [build] Don't list Dart sources up front when creating application snapshots.
>
> GN/Ninja will discover them via the depfile created alongside the snapshot.
>
> Bug: https://github.com/flutter/flutter/issues/81074
> Change-Id: I6e0f07214e8ea29e6d23261c71558da06fd2223a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196982
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

TBR=bkonyi@google.com,rmacnak@google.com,chinmaygarde@google.com

Change-Id: I267b6bac2676a18f57291c8472fab5c2aaa60284
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/flutter/flutter/issues/81074
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197000
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-04-26 23:53:39 +00:00
Ryan Macnak a23c31bf8d [build] Don't list Dart sources up front when creating application snapshots. 
GN/Ninja will discover them via the depfile created alongside the snapshot.

Bug: https://github.com/flutter/flutter/issues/81074
Change-Id: I6e0f07214e8ea29e6d23261c71558da06fd2223a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196982
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-04-26 22:52:47 +00:00
asiva e33d023fa0 [BUILD] - Format gn files, this is being done to ensure the unfork CL 
doesn't show these formatting changes as diffs.

Change-Id: I69ccbf4adabc66d88371cece785a2c1bce60f133
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138962
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2020-03-10 21:56:11 +00:00
Zachary Anderson ccfafee023 Make list_files.py and list_dart_files.py return absolute paths for GN 
This makes doing an SDK build in the Fuchsia tree easier.

The previous attempt at this change failed in gyp builds targeting xcode.
They failed because input lists for actions of the same target (e.g. the
actions for dartanalyzer) are merged and de-duped when the lists contain
relative paths, but merged and *not* de-duped when the lists contain
absolute paths. gyp rejects xcode files that it generated itself
when they contain duplicate entries.

This CL works around that bug, by using absolute paths in the GN build
and keeping relative paths in the gyp build.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2567213002 .
 2016-12-13 10:01:28 -08:00
Zachary Anderson b873e2b8e3 Revert "Make list_files.py and list_dart_files.py return absolute paths" 
This reverts commit a858542c89.

mac gyp build fails.

Review-Url: https://codereview.chromium.org/2574523002 .
 2016-12-12 13:14:53 -08:00
Zachary Anderson a858542c89 Make list_files.py and list_dart_files.py return absolute paths 
This makes doing an SDK build in the Fuchsia tree easier

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2564413004 .
 2016-12-12 13:09:26 -08:00
Zachary Anderson c1313a5ec7 Format GN files and add a presubmit check that GN is properly formatted 
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2451613005 .
 2016-10-26 08:50:54 -07:00
Zachary Anderson ee21a2261d Use list_dart_files.py instead of list_files.py in GN build. 
To track https://codereview.chromium.org/2391863002/ on the
gyp side, and use it in more places.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2392253002 .
 2016-10-05 07:50:40 -07:00
Zachary Anderson 7c784cea9f Linux create_sdk GN build for host 
This CL enables GN builds of all targets from dart.gyp
on Linux for the host (i.e. ia32, x64).

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2379803002 .
 2016-09-29 13:23:00 -07:00
William Hesse 0695b1db3a Remove package root target and support scripts 
BUG=https://github.com/dart-lang/sdk/issues/23565
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2346163005 .
 2016-09-20 13:32:50 +02:00
Adam Barth f7c8140aa3 Fix gn build 
We need to update the call to make_link.py in the same way the GYP build was
updated.
 2016-09-16 15:27:42 -07:00
Zachary Anderson 1b303e64fe [fuchsia] Fix build. Build packages/ output. Add Directory::Exists(). 
The build was broken by the addition of OS::MaxRSS, which I've added
unimplemented. I need the packages/ output to get the Dart language
tests going. I've added Directory::Exists() so that we can give
the right error message on a missing package: import instead of
crashing.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2259613002 .
 2016-08-18 09:21:14 -07:00