3a3dfcbb7d
[dart2js] Remove references to new-rti/old-rti.
...
The "new" rti library has been standard for years now and no one should
be passing `--experiment-new-rti` or `--use-old-rti`. We can now clean
up any references to different versions of rtis.
Change-Id: I4421b8943fe5034ed4d259477e8112b25ba0c763
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/416326
Reviewed-by: Nate Biggs <natebiggs@google.com >
Commit-Queue: Mayank Patke <fishythefish@google.com >
2025-03-19 11:54:57 -07:00
e4c8b49dcc
Format benchmarks/.
...
Change-Id: I1362ada67a02b0ed352612fc29c727e94d8cd254
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394901
Commit-Queue: Daco Harkes <dacoharkes@google.com >
Auto-Submit: Bob Nystrom <rnystrom@google.com >
Reviewed-by: Daco Harkes <dacoharkes@google.com >
2024-11-18 10:06:01 +00:00
4c20cedd30
Fix analysis issues in benchmarks/ directory
...
Now that I'm able to open the entire SDK in VSC, I'm fixing some
of the analysis issues in various files (carefully) without changing
their meaning.
In this case, I removed unnecessary imports from benchmarks.
In regexp_benchmark I ignored one warning which likely would
have changed the behavior of the code.
BUG=https://github.com/dart-lang/sdk/issues/52419
Change-Id: I9a195a4e45121313bd9f065f2579a165c3fec05b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/303901
Auto-Submit: Eric Seidel <eric@shorebird.dev >
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2023-05-17 09:14:50 +00:00
08e73523f6
- migrate sound_splay_tree.dart to null safety
...
- exclude from analysis all dart 2 benchmarks
This reduces the analysis errors when opening up the SDK significantly.
Change-Id: I9e1c4f7e4b790e4962ea2112a293bf0ef5402b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/292440
Reviewed-by: Stephen Adams <sra@google.com >
Reviewed-by: Kallen Tu <kallentu@google.com >
Commit-Queue: Jake Macdonald <jakemac@google.com >
2023-04-05 15:57:33 +00:00
b9b6511ca6
Spelling sdk
...
Closes https://github.com/dart-lang/sdk/pull/50918
Co-authored-by: Josh Soref <jsoref@gmail.com >
GitOrigin-RevId: 1fd275051c561b63d374fb47e76a22424c4a12a9
Change-Id: I97790d9c79ff659f2c1fa2d2d46d041fe67957cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278530
Reviewed-by: William Hesse <whesse@google.com >
Commit-Queue: Alexander Thomas <athom@google.com >
Reviewed-by: Tess Strickland <sstrickl@google.com >
2023-01-20 12:37:49 +00:00
5fe480b788
Fix typos
...
Fix #49864
TEST=ci
Change-Id: I9a7e06d604cd0b4f56f2ac229ab3fc9f01cb9d76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256824
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Lasse Nielsen <lrn@google.com >
Reviewed-by: Liam Appelbe <liama@google.com >
Reviewed-by: Mayank Patke <fishythefish@google.com >
2022-09-16 19:35:00 +00:00
1db1a837f8
Added SoundSplayTreeSieve benchmark for variantly sound interfaces.
...
Dart2JS
sdk/bin/dart2js_developer sieve.dart --enable-experiment=variance --experiment-new-rti --omit-implicit-checks --out=soundsplay.js --lax-runtime-type-to-string
CollectionSieves-SplayTreeSet-removeLoop(RunTime): 4307.52688172043 us.
CollectionSieves-SoundSplayTreeSet-removeLoop(RunTime): 4344.902386117137 us.
sdk/bin/dart2js_developer sieve.dart --enable-experiment=variance --experiment-new-rti --out=soundsplay.js
CollectionSieves-SplayTreeSet-removeLoop(RunTime): 73714.28571428572 us.
CollectionSieves-SoundSplayTreeSet-removeLoop(RunTime): 73714.28571428572 us.
DDK
pkg/dev_compiler/tool/ddb -d -r chrome --enable-experiment=variance -k sieve.dart
CollectionSieves-SplayTreeSet-removeLoop(RunTime): 29097.17391304348
CollectionSieves-SoundSplayTreeSet-removeLoop(RunTime): 22948.409090909092 us.
Change-Id: Ie78febebe57295d7d5fd10e07d95da118f285cce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129303
Commit-Queue: Kallen Tu <kallentu@google.com >
Reviewed-by: Leaf Petersen <leafp@google.com >
2019-12-20 23:54:15 +00:00
Mayank Patke