dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
113,740 Commits 2 Branches 0 Tags
main
Commit Graph

169 Commits

Author SHA1 Message Date
Kallen Tu 63b49dfc8e Deprecate checkValidIndex and avoid using it in the core library. 
TEST=No new behaviour, existing tests pass.

Change-Id: Ia7a8e58543bd5e1d8dd14bd46c5083759333845b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259104
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Commit-Queue: Kallen Tu <kallentu@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2022-11-08 19:02:35 +00:00
Alexander Thomas b5c63ce757 [infra] Migrate scripts to python3 
* Migrate to python3; drop python support.
* Update Windows toolchain support.
* Remove some unused methods.
* Python 2.7 is still needed on Windows.
* Update gsutil to a version that supports python3.

Fixes: https://github.com/dart-lang/sdk/issues/28793

TEST=Manually tested common user journeys.

Change-Id: I663a22b237a548bb82dc2e601e399e3bc3649211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192182
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2021-04-15 10:10:20 +00:00
Nate Bosch 0f1d5fa7e6 Centralize functions to convert Promise 
Merge the two copies of a function that convert a JS promise to a Dart
Future. Reuse this function for the specialized case of converting to a
`Future<Map>`.

- Rename `convertNativePromiseToDartFuture` to the shorter and more
  widely used `promiseToFuture`. Update one existing use of the old
  name.
- Make the method generic to match the previous implementation of
  `promiseToFuture`.
- Update the code generator template to not emit the second copy of the
  method.
- Use the existing `promiseToFuture` with a `.then` call to implement
  `promiseToFutureAsMap`. Update the doc comment to follow best
  practices.
- Duplicate all above changes to nnbd SDK copy.

Change-Id: Ib3bbf17477efec3666b24fd4019ca8ce68f0b5b3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119174
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2019-10-08 21:33:42 +00:00
Nate Bosch 55f81f2210 Mass format python with yapf 
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.

Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-08-05 20:34:31 +00:00
Terry Lucas 8fedfc7f8c Removed DomName, DosEditable, and experimental annoations they are unused. 
R=kevmoo@google.com,vsm@google.com

Fixes #32304

Change-Id: Ia2c8f99f0125c4d4bd0f95a792ff2af8a58e3599
Reviewed-on: https://dart-review.googlesource.com/60400
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
 2018-06-18 18:48:03 +00:00
Stephen Adams 14c7c3c556 Redo "Refined types for most HtmlElement factory constructors" 
Fix: ShadowElement is not always present.

Original:
Committed: https://github.com/dart-lang/sdk/commit/b7b12b564a3e1811ccfca3e28fe30dde685f6633
Reverted:  https://github.com/dart-lang/sdk/commit/963df1e3e1a3bac0013d191d2b02898bbebefa9d

BUG=

Review-Url: https://codereview.chromium.org/2718713003 .
 2017-02-24 14:28:58 -08:00
Stephen Adams 963df1e3e1 Revert "Refined types for most HtmlElement factory constructors" 
Need to fix ShadowElement

TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2710323004 .
 2017-02-24 14:15:37 -08:00
Stephen Adams b7b12b564a Refined types for most HtmlElement factory constructors 
The body of new DivElement() is marked as returning a DivElement, instead of inferred to return Element.
The more precise receiver type allows svg polyfills to be excluded, allowsing the HtmlElement methods to be identified as the single target and inlined.

This tends to improve the code generated for idioms like

    new DivElement()..classes.add('foo')

    var e1 = new DivElement();
    e1.children.add(e2);

BUG=
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2705213003 .
 2017-02-24 11:23:06 -08:00
Harry Terkelsen 1d749a2fec record that Gamepad.buttons creates GamepadButtons 
This also extends the html generator to be able to generate List implementations with nullable element types

Fixes https://github.com/dart-lang/sdk/issues/27073

R=sra@google.com, terry@google.com

Review URL: https://codereview.chromium.org/2242203002 .
 2016-08-16 13:56:32 -07:00
Jacob Richman f26e522f84 Strip unused functionality from dart:html and fix strong mode errors. Switch from blacklisting pure interfaces to determining pure interfaces from the idl and whitelisting impure interfaces we need for dart2js. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1987073002 .
 2016-05-18 12:49:09 -07:00
Jacob Richman 08c171d3e5 Revert "Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects."" 
Fix missing case that was breaking co19 tests.
This reverts commit 688eeb555c.

BUG=

Review URL: https://codereview.chromium.org/1883513004 .
 2016-04-12 17:16:06 -07:00
Jacob Richman 688eeb555c Revert "Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects." 
This reverts commit f382890e1a.
Reverting while tests are fixed.

BUG=

Review URL: https://codereview.chromium.org/1879093002 .
 2016-04-12 11:28:05 -07:00
Jacob Richman f382890e1a Fix handling of cross-origin windows in dartium and better align general handling of different frame window and location objects. 
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1873933002 .
 2016-04-12 10:23:32 -07:00
Jacob Richman c65854d2e4 Optimize dartium dart:html bindings so real world application performance is acceptable. Improves dart:html performance by 2X-30X for microbenchmarks. Real world improvement is typically 2X-3X. 
BUG=

Review URL: https://codereview.chromium.org/1832713002 .
 2016-03-29 18:32:52 -07:00
Terry Lucas e1a33e9981 Moved ChromiumSubscribeUniform to web_gl 
Fixed to return null if dictionary returned form blink is null
Cleanup up logging/error reporting

TBR=alanknight@google.com,jacobr@google.com

Committed: https://github.com/dart-lang/sdk/commit/01f6e4ed0f8882001e5a308cc8e36dcb62e9b5bc

Review URL: https://codereview.chromium.org/1752983003 .
 2016-03-02 08:15:45 -08:00
Terry Lucas a3350d9b06 Generation of sdk/lib files from 45 roll 
TBR=alanknight@google.com,jacobr@google.com

Review URL: https://codereview.chromium.org/1720743005 .
 2016-02-22 10:59:12 -08:00
Alan Knight a98388886a Wrap DomStringList, but don't wrap DomString[] as return types 
BUG=

Review URL: https://codereview.chromium.org/1410853005 .
 2015-11-03 11:22:37 -08:00
Alan Knight c92a2450b4 Switch dart:html objects not to be NativeFieldWrapper subclasses with JsInterop 
BUG=

Review URL: https://codereview.chromium.org/1392723003 .
 2015-10-07 17:42:39 -07:00
Alan Knight aebb870b13 Start using the dart2js type conversions in Dartium as well. 
BUG=

Review URL: https://codereview.chromium.org//1349293006 .
 2015-09-18 12:44:36 -07:00
Terry L. Lucas 7b322c246c Dartium JS Enabled take 2 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1348173002 .
 2015-09-16 07:13:53 -07:00
Terry L. Lucas 09c804aa78 Revert "Dartium JS Interop enabled." 
This reverts commit 403bd1698d.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1345083002 .
 2015-09-15 19:44:26 -07:00
Terry L. Lucas 403bd1698d Dartium JS Interop enabled. 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1349493003 .
 2015-09-15 17:36:47 -07:00
Terry L. Lucas 9b0d2582fc Revert "Dartium w/ JsInterop enabled" 
This reverts commit 346af54711.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1330163010 .
 2015-09-09 17:33:24 -07:00
Terry L. Lucas 346af54711 Dartium w/ JsInterop enabled 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1321613005 .
 2015-09-09 17:01:40 -07:00
Terry L. Lucas 012c998f64 Revert "Patched in Dartium JsInterop" 
This reverts commit 4bb2e617db.

TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1327083002 .
 2015-09-08 13:35:03 -07:00
Terry L. Lucas 4bb2e617db Patched in Dartium JsInterop 
TBR=alanknight@google.com

Review URL: https://codereview.chromium.org//1310363006 .
 2015-09-08 12:46:41 -07:00
Terry L. Lucas 5e52d8dc5d Updates for dart:js fixes after initial --gen-interop 
TBR=vsm@google.com,alanknight@google.com

Review URL: https://codereview.chromium.org//1228093007 .
 2015-07-16 09:52:44 -07:00
Terry L. Lucas cec5812335 Fixed Dictionary and Event hookup w/o --gen-interop 
TBR=vsm@google.com

Review URL: https://codereview.chromium.org//1233083004 .
 2015-07-14 14:18:48 -07:00
Terry L. Lucas 4947e570d4 Changed to use JSInterop 
Review URL: https://codereview.chromium.org//1173403004 .
 2015-07-13 12:38:16 -07:00
alanknight@google.com 5397482fcc Make dartj2s do type conversions on constructor arguments 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1023363002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44688 260f80e4-7a28-3924-810f-c04153c831b5
 2015-03-25 17:39:49 +00:00
terry@google.com e0fff4e457 Changes to support roll 39 IDLs 
Reviewers=vsm@google.com,asiva@google.com

Review URL: https://codereview.chromium.org//952133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44099 260f80e4-7a28-3924-810f-c04153c831b5
 2015-02-27 18:10:08 +00:00
lrn@google.com 42dac4c7b4 Add some ArgumentError and RangeError constructors that capture more information. 
Switch some uses of RangeError.range to RangeError.index.
Fix bug in Queue where elementAt allowed `length` as input.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//711003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41653 260f80e4-7a28-3924-810f-c04153c831b5
 2014-11-11 07:55:47 +00:00
leafp@google.com be08f872c5 Redirect blink calls through instance 
Use a singleton instance object for dispatching calls from dart:html to dart:blink to make code more resilient against changes in web idl.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//684783005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41379 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-28 23:11:51 +00:00
leafp@google.com e7dfea4301 Stop generating dart:blink from dart scripts 
This removes the dart:blink generation code from the dart html scripts.  The _blink_dartium template is removed, and the blink_nativeDOMImplementation html_nativeDOMImplementation split is eliminated, with the code for the former in the dartium generated code, and the latter moved back to native_DOMImplementation.dart.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//680913006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41346 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-27 23:59:26 +00:00
leafp@google.com 78e328a2f2 More dart:html and dart:blink tweaks 
Methods with no arguments mangled properly (python None and 0 are both false...).

Abstract classes generated from pure interfaces have no method bodies.

Add missing pure interfaces.

Emit dart:blink methods in sorted order.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//671023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41288 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-24 17:47:14 +00:00
leafp@google.com 6de1786199 Arity indexing in dart:blink entry points 
This CL replaces type mangling on the blink entry points with arity indexing.  So overloaded methods or methods with optional arguments now dispatch to blink entries specific to their number of arguments (but not their types).  This relies on C++ overload resolution being in place on the blink side (see https://codereview.chromium.org/668733002/).  For the time being, the dart side overload resolution code is left in place.

Resolver strings now have no type or arity info as well.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//667983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41236 260f80e4-7a28-3924-810f-c04153c831b5
 2014-10-21 20:46:55 +00:00
vsm@google.com 94095d64a2 Merge 38 changes to bleeding edge 
TBR=terry@google.com,leafp@google.com
BUG=

Review URL: https://codereview.chromium.org//605083004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40774 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-29 15:56:25 +00:00
vsm@google.com 1c4bb5f363 Revert "Chrome 38 script changes from integration branch" 
This reverts commit r40567.

TBR=leafp@google.com

Review URL: https://codereview.chromium.org//589253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40570 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 21:11:34 +00:00
vsm@google.com 9e25106514 Chrome 38 script changes from integration branch 
TBR=leafp@google.com

Review URL: https://codereview.chromium.org//593853002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40567 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-22 20:45:57 +00:00
terry@google.com 9fa7c2cff9 Suppport DartCustom for proper native callback 
Reviews:vsm,leafp

R=vsm@google.com

Review URL: https://codereview.chromium.org//558173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40096 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-10 16:22:08 +00:00
terry@google.com ddf659197c Reviewers=vsm,leafp 
Fixed emitting problems with default/optional.

R=leafp@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//551713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40054 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 20:59:03 +00:00
leafp@google.com 8e3aaa4e75 Blink uses types in entry points 
This CL changes the way that blink entry points are named to
use the type signature uniformly.  This makes us somewhat
more robust against changes in the idl.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//552533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40006 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 00:17:15 +00:00
leafp@google.com 445e8fda3d Eliminate the old non blink code paths from idl generation 
During the transition to the dart:html dart:blink split, we needed to support generating the old style and the new style.  This CL eliminates the code paths for the old style generation now that they're no longer needed.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//450693005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39005 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-07 20:04:18 +00:00
leafp@google.com a20d4b09d2 Remove dart:blink dependency on dart:html. This CL moves all of the 
overload resolution (dependent on dart specific types) over to the
dart:html side, along with the type resolution maps.  This is a first
step to generating dart:blink from the dartium idl.  There is a paired
blink CL which switches the type map lookup from dart:blink to dart:html.

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//446193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38993 260f80e4-7a28-3924-810f-c04153c831b5
 2014-08-07 16:12:50 +00:00
leafp@google.com 476278985c Refactor dart:_blink into classes to improve startup time. 
This CL reduces the snapshot size by about 20% (580kb).

BUG=
R=jacobr@google.com

Review URL: https://codereview.chromium.org//319283003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37189 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-10 17:38:29 +00:00
jacobr@google.com c4e40bb34d Native method name mismatch cleanups for Dartium 36 roll. 
BUG=
R=efortuna@google.com, leafp@google.com

Review URL: https://codereview.chromium.org//321043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37142 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-09 22:31:05 +00:00
vsm@google.com 593f3fddf5 Revert "Revert 2 CLs to get one last Dartium 34." 
This reapplies Jacob's CLs for Dartium 35 / 1916.

For landing after:
https://codereview.chromium.org/298823004/

R=ricow@google.com

Review URL: https://codereview.chromium.org//294043009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36419 260f80e4-7a28-3924-810f-c04153c831b5
 2014-05-21 11:13:35 +00:00
vsm@google.com 8c33955982 Revert 2 CLs to get one last Dartium 34. 
I will re-apply these after the next trunk push.

Revert "patch from issue 294853002"

This reverts commit r36395.

Revert "Fix Path"

This reverts commit r36401.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//295913006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36409 260f80e4-7a28-3924-810f-c04153c831b5
 2014-05-21 07:20:42 +00:00
jacobr@google.com 0b11d0040f Fix Path 
BUG=

Review URL: https://codereview.chromium.org//291843006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36401 260f80e4-7a28-3924-810f-c04153c831b5
 2014-05-21 00:24:43 +00:00
jacobr@google.com 19c563446e patch from issue 294853002 
BUG=
R=leafp@google.com

Review URL: https://codereview.chromium.org//294993002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36395 260f80e4-7a28-3924-810f-c04153c831b5
 2014-05-20 22:21:01 +00:00