From f5130108ea25f998972a666e542d2b7bf9fe8a79 Mon Sep 17 00:00:00 2001 From: Aske Simon Christensen Date: Mon, 14 May 2018 10:18:17 +0000 Subject: [PATCH] Some triage of missing compile-time errors in Fasta Change-Id: Ia7601f7296e2da66ca234a94c57105c366d94a06 Reviewed-on: https://dart-review.googlesource.com/52800 Commit-Queue: Aske Simon Christensen Reviewed-by: Karl Klose --- .../f_bounded_quantification_test.dart | 2 +- tests/language_2/field3_test.dart | 19 +++- tests/language_2/language_2_analyzer.status | 3 +- tests/language_2/language_2_dart2js.status | 2 +- tests/language_2/language_2_dartdevc.status | 5 +- tests/language_2/language_2_kernel.status | 97 ++++++++++--------- tests/language_2/language_2_vm.status | 3 +- 7 files changed, 73 insertions(+), 58 deletions(-) diff --git a/tests/language_2/f_bounded_quantification_test.dart b/tests/language_2/f_bounded_quantification_test.dart index b1abcb0f433..433df64cd28 100644 --- a/tests/language_2/f_bounded_quantification_test.dart +++ b/tests/language_2/f_bounded_quantification_test.dart @@ -19,5 +19,5 @@ main() { FBound fsb = new FBound(); // //# 01: compile-time error FBound> fbb = new FBound>(); - FBound> fsb = new FBound>(); // //# 02: compile-time error + FBound> fsbb = new FBound>(); // //# 02: compile-time error } diff --git a/tests/language_2/field3_test.dart b/tests/language_2/field3_test.dart index 2f4b8ba228b..901dd06dbd7 100644 --- a/tests/language_2/field3_test.dart +++ b/tests/language_2/field3_test.dart @@ -9,11 +9,22 @@ class C { // illegal: var cannot follow final final var a = 0;// //# 00: syntax error // illegal: final field declaration, must be initialized - final a; // //# 01: compile-time error - final a = 0; // //# none: ok + final b; // //# 01: compile-time error + final c; // //# 02: compile-time error + final d; // //# 03: ok + final e; // //# 04: ok + final f = 0; // //# 05: ok + + C() {} //# 02: continued + C(this.d) {} //# 03: continued + C(x) : e = x {} //# 04: continued } main() { - var val = new C(); - Expect.equals(val.a, 0); + var val = new C(); //# 00: continued + var val = new C(); //# 01: continued + var val = new C(); //# 02: continued + var val = new C(0); //# 03: continued + var val = new C(0); //# 04: continued + var val = new C(); //# 05: continued } diff --git a/tests/language_2/language_2_analyzer.status b/tests/language_2/language_2_analyzer.status index 51b4e398668..25a87aabf5e 100644 --- a/tests/language_2/language_2_analyzer.status +++ b/tests/language_2/language_2_analyzer.status @@ -17,7 +17,7 @@ const_cast2_test/01: CompileTimeError const_cast2_test/none: CompileTimeError const_for_in_variable_test/01: MissingCompileTimeError # Issue 25161 constructor_call_wrong_argument_count_negative_test: Fail # Issue 11585 -constructor_type_parameter_test/00: MissingCompileTimeError +constructor_type_parameter_test/00: MissingCompileTimeError # Issue 33110 deep_nesting1_negative_test: CompileTimeError # Issue 25558 deep_nesting2_negative_test: CompileTimeError # Issue 25558 duplicate_export_negative_test: CompileTimeError @@ -1102,6 +1102,7 @@ const_types_test/15: MissingCompileTimeError # Incorrectly allows using type par constant_type_literal_test/01: MissingCompileTimeError # Issue 28823 default_implementation2_test: CompileTimeError # Issue 30855 error_stacktrace_test/00: Pass +field3_test/02: MissingCompileTimeError # Issue 33022 field3a_negative_test: StaticWarning # Issue 28823 forwarding_stub_tearoff_test: CompileTimeError generic_methods_generic_function_result_test/none: CompileTimeError # Issue #30207 diff --git a/tests/language_2/language_2_dart2js.status b/tests/language_2/language_2_dart2js.status index aa84e3cd636..fc0489ef655 100644 --- a/tests/language_2/language_2_dart2js.status +++ b/tests/language_2/language_2_dart2js.status @@ -8,7 +8,7 @@ async_star_cancel_while_paused_test: RuntimeError # Issue 22853 bit_operations_test: RuntimeError, OK # non JS number semantics config_import_corelib_test: CompileTimeError # we need a special platform.dill file for categories=all. Once we fix that, all dart:* are supported when using '--categories=all' so this will become a RuntimeError, OK. config_import_test: RuntimeError # Test flag is not passed to the compiler. -constructor_type_parameter_test/00: Crash +constructor_type_parameter_test/00: Crash # Issue 33110 double_identical_test: RuntimeError # Negative and positive zero are distinct, but not in dart2js; bug #11551. issue23244_test: RuntimeError # Isolates - enum canonicalization - Issue 23244 library_env_test/has_mirror_support: RuntimeError, OK diff --git a/tests/language_2/language_2_dartdevc.status b/tests/language_2/language_2_dartdevc.status index 8175fe6bdc0..af66f204dc0 100644 --- a/tests/language_2/language_2_dartdevc.status +++ b/tests/language_2/language_2_dartdevc.status @@ -36,7 +36,7 @@ const_types_test/08: MissingCompileTimeError const_types_test/14: MissingCompileTimeError const_types_test/15: MissingCompileTimeError constant_type_literal_test/01: MissingCompileTimeError # DDC allows type parameter type literals in const expressions. -constructor_type_parameter_test/00: MissingCompileTimeError +constructor_type_parameter_test/00: MissingCompileTimeError # Issue 33110 covariance_field_test/03: RuntimeError covariant_override/tear_off_type_test: RuntimeError # Issue 28395 default_implementation2_test: CompileTimeError # Issue 30855 @@ -666,7 +666,8 @@ example_constructor_test: RuntimeError # Expect.equals(expected: <0 1 2 3 4 5 6 exception_test: RuntimeError # DDC doesn't implement NullThrownError?; Expect.isTrue(false) fails. expect_test: RuntimeError # Issue 29920; Expect.identical did not fail f_bounded_quantification3_test: RuntimeError # Issue 29920; Uncaught Error: type arguments should not be null: (F1, F2) => { -field3_test/01: MissingCompileTimeError +field3_test/01: MissingCompileTimeError # Issue 33022 +field3_test/02: MissingCompileTimeError # Issue 33022 field_initialization_order_test/none: RuntimeError # Expect.equals(expected: , actual: ) fails. flatten_test/05: MissingRuntimeError # Issue 29920 flatten_test/08: MissingRuntimeError # Issue 29920 diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status index 6a6e21dd1f0..68e356c05a3 100644 --- a/tests/language_2/language_2_kernel.status +++ b/tests/language_2/language_2_kernel.status @@ -65,71 +65,72 @@ async_return_types_test/nestedFuture: MissingCompileTimeError # Issue 33068 async_return_types_test/wrongReturnType: MissingCompileTimeError # Issue 33068 bad_override_test/01: MissingCompileTimeError # Issue 32984 bad_override_test/02: MissingCompileTimeError # Issue 32984 -call_non_method_field_test/01: MissingCompileTimeError -call_non_method_field_test/02: MissingCompileTimeError -check_member_static_test/01: MissingCompileTimeError -compile_time_constant_o_test/01: MissingCompileTimeError -compile_time_constant_o_test/02: MissingCompileTimeError -const_cast2_test/01: CompileTimeError -const_cast2_test/none: CompileTimeError -const_dynamic_type_literal_test/02: MissingCompileTimeError +call_non_method_field_test/01: MissingCompileTimeError # Issue 32975 +call_non_method_field_test/02: MissingCompileTimeError # Issue 32975 +check_member_static_test/01: MissingCompileTimeError # Issue 32613 +compile_time_constant_o_test/01: MissingCompileTimeError # Issue 32983 +compile_time_constant_o_test/02: MissingCompileTimeError # Issue 32983 +const_cast2_test/01: CompileTimeError # Issue 32517 +const_cast2_test/none: CompileTimeError # Issue 32517 +const_dynamic_type_literal_test/02: MissingCompileTimeError # Issue 32983 const_instance_field_test/01: MissingCompileTimeError # Fasta bug: Const instance field. Issue 32326. const_map2_test/00: MissingCompileTimeError # KernelVM bug: Constant evaluation. const_map3_test/00: MissingCompileTimeError # KernelVM bug: Constant evaluation. const_switch2_test/01: MissingCompileTimeError # KernelVM bug: Constant evaluation. -const_types_test/34: MissingCompileTimeError -const_types_test/39: MissingCompileTimeError -constructor_redirect1_negative_test/01: MissingCompileTimeError -constructor_redirect2_negative_test: MissingCompileTimeError +const_types_test/34: MissingCompileTimeError # Issue 32988 +const_types_test/39: MissingCompileTimeError # Issue 32988 +constructor_redirect1_negative_test/01: MissingCompileTimeError # Issue 30856 +constructor_redirect2_negative_test: MissingCompileTimeError # Issue 30856 constructor_redirect_test/01: MissingCompileTimeError # Fasta bug: Initializer refers to this. -constructor_type_parameter_test/00: MissingCompileTimeError -cyclic_constructor_test/01: MissingCompileTimeError # Fasta bug: Cyclic constructor redirection. +constructor_type_parameter_test/00: MissingCompileTimeError # Issue 33110 +cyclic_constructor_test/01: MissingCompileTimeError # Issue 30856 (cyclic constructor redirection) cyclic_type_variable_test/01: MissingCompileTimeError # Issue 32989 (missing cycle check in bounds) cyclic_type_variable_test/02: MissingCompileTimeError # Issue 32989 (missing cycle check in bounds) cyclic_type_variable_test/03: MissingCompileTimeError # Issue 32989 (missing cycle check in bounds) cyclic_type_variable_test/04: MissingCompileTimeError # Issue 32989 (missing cycle check in bounds) -default_factory2_test/01: MissingCompileTimeError -default_factory_test/01: MissingCompileTimeError +default_factory2_test/01: MissingCompileTimeError # Issue 32988 +default_factory_test/01: MissingCompileTimeError # Issue 32988 deferred_inheritance_constraints_test/extends: MissingCompileTimeError # Fasta/KernelVM bug: Deferred loading kernel issue 30273. deferred_inheritance_constraints_test/implements: MissingCompileTimeError # Fasta/KernelVM bug: Deferred loading kernel issue 30273. deferred_inheritance_constraints_test/mixin: MissingCompileTimeError # Fasta/KernelVM bug: Deferred loading kernel issue 30273. deferred_inheritance_constraints_test/redirecting_constructor: MissingCompileTimeError # Fasta/KernelVM bug: Deferred loading kernel issue 30273. -duplicate_export_negative_test: Fail # Issue 6134 -f_bounded_quantification_test/01: MissingCompileTimeError -f_bounded_quantification_test/02: MissingCompileTimeError -factory4_test/00: MissingCompileTimeError -field3_test/01: MissingCompileTimeError -field_override_test/00: MissingCompileTimeError -field_override_test/01: MissingCompileTimeError -generic_methods_bounds_test/01: MissingCompileTimeError -generic_methods_overriding_test/01: MissingCompileTimeError -generic_methods_recursive_bound_test/02: MissingCompileTimeError -getter_override_test/03: MissingCompileTimeError -identical_const_test/01: MissingCompileTimeError -identical_const_test/02: MissingCompileTimeError -identical_const_test/03: MissingCompileTimeError -identical_const_test/04: MissingCompileTimeError +duplicate_export_negative_test: Fail # Issue 12916 +f_bounded_quantification_test/01: MissingCompileTimeError # Issue 33018 +f_bounded_quantification_test/02: MissingCompileTimeError # Issue 33018 +factory4_test/00: MissingCompileTimeError # Issue 32988 +field3_test/01: MissingCompileTimeError # Issue 33022 +field3_test/02: MissingCompileTimeError # Issue 33022 +field_override_test/00: MissingCompileTimeError # Issue 32613 +field_override_test/01: MissingCompileTimeError # Issue 32613 +generic_methods_bounds_test/01: MissingCompileTimeError # Issue 33018 +generic_methods_overriding_test/01: MissingCompileTimeError # Issue 32613 +generic_methods_recursive_bound_test/02: MissingCompileTimeError # Issue 33018 +getter_override_test/03: MissingCompileTimeError # Issue 32984 +identical_const_test/01: MissingCompileTimeError # Issue 32983 +identical_const_test/02: MissingCompileTimeError # Issue 32983 +identical_const_test/03: MissingCompileTimeError # Issue 32983 +identical_const_test/04: MissingCompileTimeError # Issue 32983 issue31596_override_test/07: MissingCompileTimeError issue31596_override_test/08: MissingCompileTimeError issue31596_super_test/02: MissingCompileTimeError issue31596_super_test/04: MissingCompileTimeError -malbounded_instantiation_test/01: MissingCompileTimeError -malbounded_instantiation_test/02: MissingCompileTimeError -malbounded_instantiation_test/03: MissingCompileTimeError -malbounded_redirecting_factory_test/02: MissingCompileTimeError -malbounded_redirecting_factory_test/03: MissingCompileTimeError -malbounded_redirecting_factory_test/04: MissingCompileTimeError -malbounded_redirecting_factory_test/05: MissingCompileTimeError -malbounded_type_cast2_test: MissingCompileTimeError -malbounded_type_cast_test/00: MissingCompileTimeError -malbounded_type_cast_test/01: MissingCompileTimeError -malbounded_type_cast_test/02: MissingCompileTimeError -malbounded_type_literal_test/00: MissingCompileTimeError -malbounded_type_test2_test/00: MissingCompileTimeError -malbounded_type_test_test/00: MissingCompileTimeError -malbounded_type_test_test/01: MissingCompileTimeError -malbounded_type_test_test/02: MissingCompileTimeError -method_override7_test/03: MissingCompileTimeError +malbounded_instantiation_test/01: MissingCompileTimeError # Issue 33018 +malbounded_instantiation_test/02: MissingCompileTimeError # Issue 33018 +malbounded_instantiation_test/03: MissingCompileTimeError # Issue 33018 +malbounded_redirecting_factory_test/02: MissingCompileTimeError # Issue 33018 +malbounded_redirecting_factory_test/03: MissingCompileTimeError # Issue 33018 +malbounded_redirecting_factory_test/04: MissingCompileTimeError # Issue 33018 +malbounded_redirecting_factory_test/05: MissingCompileTimeError # Issue 33018 +malbounded_type_cast2_test: MissingCompileTimeError # Issue 33018 +malbounded_type_cast_test/00: MissingCompileTimeError # Issue 33018 +malbounded_type_cast_test/01: MissingCompileTimeError # Issue 33018 +malbounded_type_cast_test/02: MissingCompileTimeError # Issue 33018 +malbounded_type_literal_test/00: MissingCompileTimeError # Issue 33018 +malbounded_type_test2_test/00: MissingCompileTimeError # Issue 33018 +malbounded_type_test_test/00: MissingCompileTimeError # Issue 33018 +malbounded_type_test_test/01: MissingCompileTimeError # Issue 33018 +malbounded_type_test_test/02: MissingCompileTimeError # Issue 33018 +method_override7_test/03: MissingCompileTimeError # Issue 32984 mixin_forwarding_constructor4_test/01: MissingCompileTimeError # KernelVM bug: Issue 15101 mixin_forwarding_constructor4_test/02: MissingCompileTimeError # KernelVM bug: Issue 15101 mixin_forwarding_constructor4_test/03: MissingCompileTimeError # KernelVM bug: Issue 15101 diff --git a/tests/language_2/language_2_vm.status b/tests/language_2/language_2_vm.status index fcd9492ea83..4c49535d031 100644 --- a/tests/language_2/language_2_vm.status +++ b/tests/language_2/language_2_vm.status @@ -375,7 +375,8 @@ factory_redirection_test/13: MissingCompileTimeError factory_redirection_test/14: MissingCompileTimeError factory_redirection_test/none: MissingCompileTimeError factory_return_type_checked_test/00: MissingCompileTimeError -field3_test/01: MissingCompileTimeError +field3_test/01: MissingCompileTimeError # Issue 33022 +field3_test/02: MissingCompileTimeError # Issue 33022 field_method4_test: MissingCompileTimeError field_override2_test: MissingCompileTimeError field_override_test/00: MissingCompileTimeError