From ee3a86d8ab003de1085b9ed60c7be04ebb7f6724 Mon Sep 17 00:00:00 2001 From: Ryan Macnak Date: Mon, 5 Apr 2021 22:48:16 +0000 Subject: [PATCH] [vm] Avoid data race querying the new-space page cache. This access is extremely infrequent, so we may as well consistently use the mutex. TEST=tsan Bug: https://github.com/dart-lang/sdk/issues/45521 Change-Id: I17b276f671e20c2eed8bf26735cc11c386fba9e6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194013 Reviewed-by: Alexander Aprelev Commit-Queue: Ryan Macnak --- runtime/vm/heap/scavenger.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/runtime/vm/heap/scavenger.cc b/runtime/vm/heap/scavenger.cc index bdc785c6aad..f0dee566817 100644 --- a/runtime/vm/heap/scavenger.cc +++ b/runtime/vm/heap/scavenger.cc @@ -670,6 +670,7 @@ void SemiSpace::Cleanup() { } intptr_t SemiSpace::CachedSize() { + MutexLocker ml(page_cache_mutex); return page_cache_size * kNewPageSize; }