From ea75975e03068b8cfc49381be2ca1b89444d21a2 Mon Sep 17 00:00:00 2001 From: Alexander Markov Date: Mon, 24 Nov 2025 09:59:27 -0800 Subject: [PATCH] [vm,ia32] Avoid clobbering callee-save register in assembler test TEST=ci Fixes https://github.com/dart-lang/sdk/issues/62061 Change-Id: I453a7f30927562dace1d0189f29a7bd91646e3a0 Cq-Include-Trybots: luci.dart.try:vm-linux-debug-ia32-try,vm-linux-release-ia32-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/463702 Commit-Queue: Ryan Macnak Auto-Submit: Alexander Markov Reviewed-by: Ryan Macnak --- runtime/vm/compiler/assembler/assembler_ia32_test.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/runtime/vm/compiler/assembler/assembler_ia32_test.cc b/runtime/vm/compiler/assembler/assembler_ia32_test.cc index 27dd5637507..8c97ffe629f 100644 --- a/runtime/vm/compiler/assembler/assembler_ia32_test.cc +++ b/runtime/vm/compiler/assembler/assembler_ia32_test.cc @@ -5092,7 +5092,8 @@ void CheckIsIdentity(Expect& expect, AssemblerTest* test) { } } -static const Register kRegRegImmTempReg = EBX; +// Use a volatile register so we don't have to save it. +static const Register kRegRegImmTempReg = ECX; void CheckMovesInputToReturnOnly(Expect& expect, AssemblerTest* test,