From e44af61dd13d85e32de3ee776b72a487ddc5a53e Mon Sep 17 00:00:00 2001 From: Nicholas Shahan Date: Thu, 3 Feb 2022 18:51:16 +0000 Subject: [PATCH] [ddc] Update warning message with dwds version Change-Id: I26b5393256506f4ca1773baea15e71bee4b54683 Issue: https://github.com/dart-lang/sdk/issues/48103 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226964 Reviewed-by: Anna Gringauze Commit-Queue: Nicholas Shahan --- .../_internal/js_dev_runtime/patch/developer_patch.dart | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sdk/lib/_internal/js_dev_runtime/patch/developer_patch.dart b/sdk/lib/_internal/js_dev_runtime/patch/developer_patch.dart index cf1bdbd50b4..761bf6e7eff 100644 --- a/sdk/lib/_internal/js_dev_runtime/patch/developer_patch.dart +++ b/sdk/lib/_internal/js_dev_runtime/patch/developer_patch.dart @@ -15,7 +15,7 @@ var _issuedPostEventWarning = false; var _issuedRegisterExtensionWarning = false; final _developerSupportWarning = 'from dart:developer is only supported in ' 'build/run/test environments where the developer event method hooks have ' - 'been set.'; + 'been set by package:dwds v11.1.0 or higher.'; /// Returns `true` if the debugger service has been attached to the app. // TODO(46377) Update this check when we have a documented API for DDC apps. @@ -85,8 +85,7 @@ _registerExtension(String method, ServiceExtensionHandler handler) { JS('', r'#.$emitRegisterEvent(#)', dart.global_, method); return; } - // TODO(nshahan) Remove use of debug log after package:dwds removes support. - // https://github.com/dart-lang/webdev/issues/1342 + // TODO(48103) Remove use of debug log in Dart 3.0.0. JS('', 'console.debug("dart.developer.registerExtension", #)', method); } @@ -134,8 +133,7 @@ void _postEvent(String eventKind, String eventData) { JS('', r'#.$emitDebugEvent(#, #)', dart.global_, eventKind, eventData); return; } - // TODO(nshahan) Remove use of debug log after package:dwds removes support. - // https://github.com/dart-lang/webdev/issues/1342 + // TODO(48103) Remove use of debug log in Dart 3.0.0. JS('', 'console.debug("dart.developer.postEvent", #, #)', eventKind, eventData); }