From e07f7eddd8b94f8fbbebc79843487da13eed2cff Mon Sep 17 00:00:00 2001 From: Ryan Macnak Date: Wed, 29 Apr 2026 08:10:43 -0700 Subject: [PATCH] [vm] Remove dead regexp code. TEST=ci Change-Id: I976bcb7bf24f4a8134d5c1c5e20e8f98dc85cfbf Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/499082 Commit-Queue: Ryan Macnak Reviewed-by: Alexander Aprelev --- runtime/vm/heap/heap.cc | 5 ----- runtime/vm/thread.h | 10 ---------- 2 files changed, 15 deletions(-) diff --git a/runtime/vm/heap/heap.cc b/runtime/vm/heap/heap.cc index 32053fcaefd..51ef442ec8b 100644 --- a/runtime/vm/heap/heap.cc +++ b/runtime/vm/heap/heap.cc @@ -543,11 +543,6 @@ void Heap::CollectOldSpaceGarbage(Thread* thread, } } - thread->isolate_group()->ForEachMutatorAtASafepoint([&](Thread* mutator) { - // Discard regexp backtracking stacks to further reduce memory usage. - mutator->CacheRegexpBacktrackStack(nullptr); - }); - RecordBeforeGC(type, reason); NOT_IN_PRODUCT(VMTagScope tagScope(thread, VMTag::kGCOldSpaceTagId)); TIMELINE_FUNCTION_GC_DURATION(thread, "CollectOldGeneration"); diff --git a/runtime/vm/thread.h b/runtime/vm/thread.h index a887d96e640..4ec3fc6554b 100644 --- a/runtime/vm/thread.h +++ b/runtime/vm/thread.h @@ -1378,14 +1378,6 @@ class Thread : public ThreadState, public IntrusiveDListEntry { return OFFSET_OF(Thread, thread_locals_); } - std::unique_ptr TakeRegexpBacktrackStack() { - return std::move(regexp_backtracking_stack_cache_); - } - - void CacheRegexpBacktrackStack(std::unique_ptr stack) { - regexp_backtracking_stack_cache_ = std::move(stack); - } - private: template T* AllocateReusableHandle(); @@ -1662,8 +1654,6 @@ class Thread : public ThreadState, public IntrusiveDListEntry { MallocGrowableArray pointers_to_verify_at_exit_; - std::unique_ptr regexp_backtracking_stack_cache_ = nullptr; - explicit Thread(bool is_vm_isolate); void StoreBufferRelease(