dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[vm/shared] Introduce ScopedThreadLocal to allow keeping state on

Browse Source 
thread, outside of isolate, on isolate-group bound callback.

Fixes https://github.com/dart-lang/sdk/issues/61523
TEST=scoped_thread_local_test

Change-Id: I0c8280d2808d940a5fb0d628db191932400a5edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/451402
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
This commit is contained in:
Alexander Aprelev
2025-11-13 09:50:34 -08:00
committed by Commit Queue
parent 438da65eb3
commit de77c6b766
42 changed files with 800 additions and 419 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/thread.cc
+8
View File
@@ -96,6 +96,7 @@ Thread::Thread(bool is_vm_isolate)
thread_lock_(),
reusable_handles_(),
sticky_error_(Error::null()),
thread_locals_(GrowableObjectArray::null()),
REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_INITIALIZERS)
REUSABLE_HANDLE_LIST(REUSABLE_HANDLE_SCOPE_INIT)
#if !defined(PRODUCT) || defined(FORCE_INCLUDE_SAMPLING_HEAP_PROFILER)
@@ -267,6 +268,10 @@ void Thread::set_default_tag(const UserTag& tag) {
default_tag_ = tag.ptr();
}
void Thread::set_thread_locals(const GrowableObjectArray& thread_locals) {
thread_locals_ = thread_locals.ptr();
}
ErrorPtr Thread::StealStickyError() {
NoSafepointScope no_safepoint;
ErrorPtr return_value = sticky_error_;
@@ -357,6 +362,7 @@ void Thread::AssertEmptyThreadInvariants() {
ASSERT(default_tag_ == UserTag::null());
ASSERT(current_tag_ == UserTag::null());
ASSERT(thread_locals_ == GrowableObjectArray::null());
// Avoid running these asserts for `vm-isolate`.
if (active_stacktrace_.untag() != 0) {
@@ -768,6 +774,7 @@ void Thread::FreeActiveThread(Thread* thread,
thread->ResetStateLocked();
thread->current_tag_ = UserTag::null();
thread->default_tag_ = UserTag::null();
thread->thread_locals_ = GrowableObjectArray::null();
thread->AssertEmptyThreadInvariants();
thread_registry->ReturnThreadLocked(thread);
@@ -1151,6 +1158,7 @@ void Thread::VisitObjectPointers(ObjectPointerVisitor* visitor,
visitor->VisitPointer(reinterpret_cast<ObjectPtr*>(&current_tag_));
visitor->VisitPointer(reinterpret_cast<ObjectPtr*>(&default_tag_));
visitor->VisitPointer(reinterpret_cast<ObjectPtr*>(&thread_locals_));
}
class RestoreWriteBarrierInvariantVisitor : public ObjectPointerVisitor {