dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[vm/sendports] Introduce an api that can be safely used to rebuild SendPort.

Browse Source 
Existing api is not aware of origin_id, which leads to problems when a port gets closed, origin_id can't be properly restored.

Fixes https://github.com/dart-lang/sdk/issues/55605
TEST=vm/dart/sendport_api_test

Change-Id: Ia8a5978a968f6ea643d7921c64146cebf17d2e0e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365120
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
This commit is contained in:
Alexander Aprelev
2024-05-01 17:19:16 +00:00
committed by Commit Queue
parent b026068313
commit de4029ee1b
6 changed files with 126 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/include/dart_api.h
+27
View File
@@ -1522,6 +1522,10 @@ DART_EXPORT DART_WARN_UNUSED_RESULT char* Dart_IsolateMakeRunnable(
* A port is used to send or receive inter-isolate messages
*/
typedef int64_t Dart_Port;
typedef struct {
int64_t port_id;
int64_t origin_id;
} Dart_PortEx;
/**
* ILLEGAL_PORT is a port number guaranteed never to be associated with a valid
@@ -1773,6 +1777,10 @@ DART_EXPORT bool Dart_Post(Dart_Port port_id, Dart_Handle object);
/**
* Returns a new SendPort with the provided port id.
*
* If there is a possibility of a port closing since port_id was acquired
* for a SendPort, one should use Dart_NewSendPortEx and
* Dart_SendPortGetIdEx.
*
* \param port_id The destination port.
*
* \return A new SendPort if no errors occurs. Otherwise returns
@@ -1780,6 +1788,16 @@ DART_EXPORT bool Dart_Post(Dart_Port port_id, Dart_Handle object);
*/
DART_EXPORT Dart_Handle Dart_NewSendPort(Dart_Port port_id);
/**
* Returns a new SendPort with the provided port id and origin id.
*
* \param portex_id The destination composte port id.
*
* \return A new SendPort if no errors occurs. Otherwise returns
* an error handle.
*/
DART_EXPORT Dart_Handle Dart_NewSendPortEx(Dart_PortEx portex_id);
/**
* Gets the SendPort id for the provided SendPort.
* \param port A SendPort object whose id is desired.
@@ -1790,6 +1808,15 @@ DART_EXPORT Dart_Handle Dart_NewSendPort(Dart_Port port_id);
DART_EXPORT Dart_Handle Dart_SendPortGetId(Dart_Handle port,
Dart_Port* port_id);
/**
* Gets the SendPort and Origin ids for the provided SendPort.
* \param port A SendPort object whose id is desired.
* \param portex_id Returns composite id of the SendPort.
* \return Success if no error occurs. Otherwise returns
* an error handle.
*/
DART_EXPORT Dart_Handle Dart_SendPortGetIdEx(Dart_Handle port,
Dart_PortEx* portex_id);
/*
* ======
* Scopes