From ddab69463306a31ff987dcdfbe367fcf77ed554b Mon Sep 17 00:00:00 2001
From: Danny Tuppeny <danny@tuppeny.com>
Date: Wed, 28 Aug 2024 21:39:47 +0000
Subject: [PATCH] [analysis_server] Add failing test for auto-import extensions

See https://github.com/dart-lang/sdk/issues/56320

Change-Id: I6a21ef528d6d67a34e7f845c6cb279f246fe2762
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/382621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
---
 .../test/lsp/completion_dart_test.dart        | 59 +++++++++++++++++++
 1 file changed, 59 insertions(+)

diff --git a/pkg/analysis_server/test/lsp/completion_dart_test.dart b/pkg/analysis_server/test/lsp/completion_dart_test.dart
index 379d273c61c..0e42a7d9eb7 100644
--- a/pkg/analysis_server/test/lsp/completion_dart_test.dart
+++ b/pkg/analysis_server/test/lsp/completion_dart_test.dart
@@ -3271,6 +3271,65 @@ void f() {
     expect(resolved.detail, isNot(contains('Auto import from')));
   }
 
+  /// Verify extensions can be auto-imported if not already in-scope.
+  @FailingTest(issue: 'https://github.com/dart-lang/sdk/issues/56320')
+  Future<void> test_unimportedSymbols_extension() async {
+    // Define extensions in 'extensions.dart'.
+    newFile(
+      join(projectFolderPath, 'lib', 'extensions.dart'),
+      '''
+extension StringExtensions on String {
+  String get empty => '';
+}
+''',
+    );
+
+    // Also import the extensions into an unrelated file to ensure this doesn't
+    // cause extra suggestions (https://github.com/dart-lang/sdk/issues/56320).
+    newFile(
+      join(projectFolderPath, 'lib', 'other.dart'),
+      'import "extensions.dart";',
+    );
+
+    var content = '''
+void f(String a) {
+  a.empt^
+}
+''';
+
+    await initialize();
+    var code = TestCode.parse(content);
+    await openFile(mainFileUri, code.code);
+    await initialAnalysis;
+    var res = await getCompletion(mainFileUri, code.position.position);
+
+    // Expect only a single entry for the 'empty' extension member.
+    var completions = res.where((c) => c.label == 'empty');
+    expect(completions, hasLength(1));
+
+    // Expect it to auto-import from 'extensions.dart'.
+    var resolved = await resolveCompletion(completions.single);
+    expect(
+      resolved.detail,
+      startsWith("Auto import from 'package:test/extensions.dart'"),
+    );
+
+    // Verify the edits.
+    var newContent = applyTextEdits(
+      code.code,
+      [toTextEdit(resolved.textEdit!)]
+          .followedBy(resolved.additionalTextEdits!)
+          .toList(),
+    );
+    expect(newContent, equals('''
+import 'package:test/extensions.dart';
+
+void f(String a) {
+  a.empty
+}
+'''));
+  }
+
   Future<void> test_unimportedSymbols_filtersOutAlreadyImportedSymbols() async {
     newFile(
       join(projectFolderPath, 'lib', 'source_file.dart'),