From daea7e69ca357dda487e4eda02f2bbb0b3abc5ce Mon Sep 17 00:00:00 2001 From: Florian Schneider Date: Tue, 19 Jul 2016 10:44:58 -0700 Subject: [PATCH] Revert "Fix use-after-free in isolate reload." This reverts commit 16e577741d1772cba404d2780216438640ff490d. TBR=johnmccutchan@google.com, BUG= Review URL: https://codereview.chromium.org/2162113002 . --- runtime/vm/isolate.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc index 0b8b5bbf0c4..c20def45467 100644 --- a/runtime/vm/isolate.cc +++ b/runtime/vm/isolate.cc @@ -1095,8 +1095,6 @@ void Isolate::ReloadSources(bool test_mode) { has_attempted_reload_ = true; reload_context_ = new IsolateReloadContext(this, test_mode); reload_context_->StartReload(); - delete reload_context_; - reload_context_ = NULL; } #endif // !PRODUCT @@ -1117,6 +1115,8 @@ void Isolate::DoneFinalizing() { if (!reload_context_->has_error()) { reload_context_->ReportSuccess(); } + delete reload_context_; + reload_context_ = NULL; } ) }