From d7c294b4e28342db723377009dead758b01f03af Mon Sep 17 00:00:00 2001 From: "ricow@google.com" Date: Thu, 7 Aug 2014 12:59:35 +0000 Subject: [PATCH] Remove observatory symlink from the repository - they have unforseen issues when copying around stuff for testing. Long storry short: for testing the ability to do pub get and pub build we copy in the packages and test them if they have a pubspec yaml file. If you copy a symlink, like the one added in r38788, without -L to cp you will just get the relative symlink copied in, which will, of course, not work. I generally think it is a bad idea to add symlinks to the repo, we have had enough issues with the ones for packages/pub Instead, to keep the testing, add the runtime/bin/vmservice to the location of where we look for packages R=koda@google.com Review URL: https://codereview.chromium.org//434883002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38983 260f80e4-7a28-3924-810f-c04153c831b5 --- pkg/observatory | 1 - pkg/pkgbuild.status | 2 -- tools/testing/dart/test_suite.dart | 3 +++ 3 files changed, 3 insertions(+), 3 deletions(-) delete mode 120000 pkg/observatory diff --git a/pkg/observatory b/pkg/observatory deleted file mode 120000 index a4c002cbd83..00000000000 --- a/pkg/observatory +++ /dev/null @@ -1 +0,0 @@ -../runtime/bin/vmservice/client \ No newline at end of file diff --git a/pkg/pkgbuild.status b/pkg/pkgbuild.status index 7d463348a00..a2d170e1292 100644 --- a/pkg/pkgbuild.status +++ b/pkg/pkgbuild.status @@ -8,8 +8,6 @@ samples/pop_pop_win: Pass, Slow samples/searchable_list: Pass, Slow pkg/docgen: Pass, Slow -pkg/observatory: Skip # Issue 20306 - [ $use_repository_packages ] pkg/analyzer: PubGetError pkg/browser: PubGetError diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart index 57fbd57c6a4..8aeff40bbdc 100644 --- a/tools/testing/dart/test_suite.dart +++ b/tools/testing/dart/test_suite.dart @@ -400,6 +400,7 @@ abstract class TestSuite { * pkg/PACKAGE_NAME * pkg/third_party/PACKAGE_NAME * third_party/pkg/PACKAGE_NAME + * runtime/bin/vmservice/PACKAGE_NAME */ // Directories containing "-" are not valid pub packages and we therefore @@ -412,6 +413,8 @@ abstract class TestSuite { listDir(dartDir.append('pkg'), isValid), listDir(dartDir.append('pkg').append('third_party'), isValid), listDir(dartDir.append('third_party').append('pkg'), isValid), + listDir(dartDir.append('runtime').append('bin').append('vmservice'), + isValid), ]; return Future.wait(futures).then((results) { var packageDirectories = {};