dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Add 'offset' to 'getSuggestionDetails'.

Browse Source 
We need it to know if names in the syntactic scope will shadow
the requested name if unprefixed import is used.

R=brianwilkerson@google.com

Change-Id: I1fd28add9241b27795160c4705a80e0f8aa6c647
Reviewed-on: https://dart-review.googlesource.com/c/92022
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Konstantin Shcheglov
2019-02-05 16:49:55 +00:00
committed by commit-bot@chromium.org
parent 3395550962
commit d236dca9d9
9 changed files with 190 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/analysis_server/tool/spec/generated/java/AnalysisServer.java
+4 -3
View File
@@ -398,12 +398,13 @@ public interface AnalysisServer {
* added. It is an error if the id is no longer valid, for instance if the library has been removed
* after the completion suggestion is accepted.
*
* @param file The path of the file into which this completion is being inserted.
* @param id The identifier of the AvailableSuggestionSet containing the selected label.
* @param label The label from the AvailableSuggestionSet with the `id` for which insertion
* information is requested.
* @param file The path of the file into which this completion is being inserted.
* @param id The identifier of the AvailableSuggestionSet containing the selected name.
* @param offset The offset in the file where the completion will be inserted.
*/
public void completion_getSuggestionDetails(String label, String file, int id, GetSuggestionDetailsConsumer consumer);
public void completion_getSuggestionDetails(String file, int id, String label, int offset, GetSuggestionDetailsConsumer consumer);
/**
* {@code completion.getSuggestions}