From cc1932ca71afc40662f06ff1f6c7e596d2bd8a34 Mon Sep 17 00:00:00 2001 From: "amouravski@google.com" Date: Thu, 7 Mar 2013 23:19:45 +0000 Subject: [PATCH] Don't output tons of messages on apidoc. Review URL: https://codereview.chromium.org//12642004 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19662 260f80e4-7a28-3924-810f-c04153c831b5 --- pkg/webdriver/lib/webdriver.dart | 1 + sdk/lib/_internal/compiler/implementation/library_loader.dart | 4 ++-- .../compiler/implementation/source_file_provider.dart | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/webdriver/lib/webdriver.dart b/pkg/webdriver/lib/webdriver.dart index 41d0cbc73b1..65081532bbc 100644 --- a/pkg/webdriver/lib/webdriver.dart +++ b/pkg/webdriver/lib/webdriver.dart @@ -7,6 +7,7 @@ library webdriver; import 'dart:json' as json; import 'dart:uri'; import 'dart:io'; +import 'dart:async'; part 'src/base64decoder.dart'; diff --git a/sdk/lib/_internal/compiler/implementation/library_loader.dart b/sdk/lib/_internal/compiler/implementation/library_loader.dart index 216bba8f806..46a8b34d412 100644 --- a/sdk/lib/_internal/compiler/implementation/library_loader.dart +++ b/sdk/lib/_internal/compiler/implementation/library_loader.dart @@ -320,12 +320,12 @@ class LibraryLoaderTask extends LibraryLoader { compiler.reportMessage( compiler.spanFromSpannable(tag.name, uri), MessageKind.DUPLICATED_LIBRARY_NAME.error({'libraryName': name}), - api.Diagnostic.WARNING); + api.Diagnostic.VERBOSE_INFO); Uri existingUri = existing.entryCompilationUnit.script.uri; compiler.reportMessage( compiler.spanFromSpannable(existing.libraryTag.name, existingUri), MessageKind.DUPLICATED_LIBRARY_NAME.error({'libraryName': name}), - api.Diagnostic.WARNING); + api.Diagnostic.VERBOSE_INFO); } } } diff --git a/sdk/lib/_internal/compiler/implementation/source_file_provider.dart b/sdk/lib/_internal/compiler/implementation/source_file_provider.dart index fc4e9b24ac0..f82c44e0aac 100644 --- a/sdk/lib/_internal/compiler/implementation/source_file_provider.dart +++ b/sdk/lib/_internal/compiler/implementation/source_file_provider.dart @@ -68,7 +68,6 @@ class FormattingDiagnosticHandler { FormattingDiagnosticHandler(SourceFileProvider this.provider); void info(var message, [api.Diagnostic kind = api.Diagnostic.VERBOSE_INFO]) { - if (!verbose && identical(kind, api.Diagnostic.VERBOSE_INFO)) return; if (enableColors) { print('${colors.green("info:")} $message'); } else { @@ -80,6 +79,7 @@ class FormattingDiagnosticHandler { api.Diagnostic kind) { // TODO(ahe): Remove this when source map is handled differently. if (identical(kind.name, 'source map')) return; + if (!verbose && identical(kind, api.Diagnostic.VERBOSE_INFO)) return; if (isAborting) return; isAborting = identical(kind, api.Diagnostic.CRASH);