dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[ddc] Remove unsound dart2js dependency

Browse Source 
DDC does not depend on the stack trace mapper application being built
with unsound null safety so the unsound .dill files are unused.

Add the unsound .dill files to the `dart2js_bot` target because they
are dependencies of the `dart2js-hostasserts-linux-unsound` and
`dart2js-unit-linux-x64-release` configurations.

Update build step of `front-end-linux-release-x64` configuraton to
build the dart2js_bot target instead of relying on the unsound
dart2js .dill files through the `ddc_stable_test` target.

Change-Id: Ia29740b60f93d1d0b4a978ff5e37080e537401a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403382
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
This commit is contained in:
Nicholas Shahan
2025-01-08 15:10:26 -08:00
committed by Commit Queue
parent b69f6c1294
commit c1ce43fd83
3 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
utils/ddc/BUILD.gn
+1 -6
View File
@@ -62,16 +62,11 @@ template("dart2js_compile") {
abs_output = rebase_path(out)
prebuilt_dart_action(target_name) {
deps = invoker.deps + [
"../compiler:compile_dart2js_platform",
"../compiler:compile_dart2js_platform_unsound",
]
deps = invoker.deps + [ "../compiler:compile_dart2js_platform" ]
inputs = [
"$root_out_dir/dart2js_platform.dill",
"$root_out_dir/dart2js_platform_unsound.dill",
"$root_out_dir/dart2js_outline.dill",
"$root_out_dir/dart2js_outline_unsound.dill",
]
outputs = [ out ]