From c19adedfa5e51d320de306f520e241c2eb3bdc16 Mon Sep 17 00:00:00 2001 From: "ahe@google.com" Date: Wed, 5 Sep 2012 12:02:53 +0000 Subject: [PATCH] Test dart2js checked mode. Review URL: https://chromiumcodereview.appspot.com//10911094 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11873 260f80e4-7a28-3924-810f-c04153c831b5 --- utils/compiler/buildbot.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/utils/compiler/buildbot.py b/utils/compiler/buildbot.py index 5020e4df6f4..14f096d62e4 100644 --- a/utils/compiler/buildbot.py +++ b/utils/compiler/buildbot.py @@ -165,6 +165,11 @@ def TestCompiler(runtime, mode, system, option, flags, is_buildbot): os.chdir(DART_PATH) if system.startswith('win') and runtime == 'ie': + # TODO(ahe): This pre-dates the shard feature and should be + # removed. If we want to have a fast and a slow bot, that should + # be accomplished by having several shards distributed on multiple + # virtual builders. + # We don't do proper sharding on the IE bots, since the runtime is # long for both. We have a "fast bot" and a "slow bot" that run specific # tests instead. @@ -234,6 +239,8 @@ def TestCompiler(runtime, mode, system, option, flags, is_buildbot): extras = ['dart2js_extra', 'dart2js_native', 'dart2js_foreign'] TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras, flags) else: + # TODO(ahe): See comment above regarding how to use sharding to + # accomplish the same. if bot_num == '1': TestStep("dart2js", mode, system, 'dart2js', runtime, ['html'], flags) else: @@ -332,8 +339,7 @@ def main(): status = TestCompiler(runtime, mode, system, option, test_flags, is_buildbot) - # We only run checked mode tests when the host is not in checked mode. - if status == 0 and option != 'checked' and runtime == 'd8': + if status == 0: status = TestCompiler(runtime, mode, system, option, test_flags + ['--checked'], is_buildbot)