From c0129418beba0165f90de38b9c1944d451eaa948 Mon Sep 17 00:00:00 2001 From: Martin Kustermann Date: Fri, 16 Oct 2020 16:27:42 +0000 Subject: [PATCH] [gardening] Lower threshold for number of trace events in flaky/time-sensitive test Issue https://github.com/dart-lang/sdk/issues/43713 Change-Id: I6884d08ff08e0e44efcb14b009d9289dba8909ce Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/168021 Commit-Queue: Martin Kustermann Reviewed-by: Tess Strickland Auto-Submit: Martin Kustermann --- .../tests/service/get_cpu_profile_timeline_rpc_test.dart | 2 +- .../tests/service_2/get_cpu_profile_timeline_rpc_test.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/runtime/observatory/tests/service/get_cpu_profile_timeline_rpc_test.dart b/runtime/observatory/tests/service/get_cpu_profile_timeline_rpc_test.dart index 2bbf22f8fbd..414de09b05a 100644 --- a/runtime/observatory/tests/service/get_cpu_profile_timeline_rpc_test.dart +++ b/runtime/observatory/tests/service/get_cpu_profile_timeline_rpc_test.dart @@ -38,7 +38,7 @@ Future checkTimeline(VM vm) async { } List events = result['traceEvents']; - expect(events.length, greaterThan(10), reason: "Should have many samples"); + expect(events.length, greaterThan(0), reason: "Should have samples"); for (Map event in events) { expect(event['ph'], equals('P')); expect(event['pid'], isInt); diff --git a/runtime/observatory_2/tests/service_2/get_cpu_profile_timeline_rpc_test.dart b/runtime/observatory_2/tests/service_2/get_cpu_profile_timeline_rpc_test.dart index 40db79e60b3..e5d578b98e8 100644 --- a/runtime/observatory_2/tests/service_2/get_cpu_profile_timeline_rpc_test.dart +++ b/runtime/observatory_2/tests/service_2/get_cpu_profile_timeline_rpc_test.dart @@ -38,7 +38,7 @@ Future checkTimeline(VM vm) async { } List events = result['traceEvents']; - expect(events.length, greaterThan(10), reason: "Should have many samples"); + expect(events.length, greaterThan(0), reason: "Should have samples"); for (Map event in events) { expect(event['ph'], equals('P')); expect(event['pid'], isInt);