From bb47e41ab203a8b571b3b18cf8a8ff89bb1048ce Mon Sep 17 00:00:00 2001 From: pq Date: Wed, 27 Apr 2022 00:29:34 +0000 Subject: [PATCH] rename local functions with `_`s These will be flagged by the next linter release which updates `non_constant_identifier_names` to flag local functions. Change-Id: I873400f61748a145f3c2a6630a21bcd1975c309c Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242503 Reviewed-by: Alexander Aprelev Commit-Queue: Phil Quitslund --- pkg/native_stack_traces/lib/src/elf.dart | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/native_stack_traces/lib/src/elf.dart b/pkg/native_stack_traces/lib/src/elf.dart index ac7cb502d7b..c29b1e412c6 100644 --- a/pkg/native_stack_traces/lib/src/elf.dart +++ b/pkg/native_stack_traces/lib/src/elf.dart @@ -1045,7 +1045,7 @@ class Elf { entry.setName(sectionHeaderStringTable); sectionsByName.putIfAbsent(entry.name, () => {}).add(section); } - void _cacheSymbolNames(String stringTableTag, String symbolTableTag) { + void cacheSymbolNames(String stringTableTag, String symbolTableTag) { final stringTables = sectionsByName[stringTableTag]?.cast(); if (stringTables == null) { return; @@ -1068,8 +1068,8 @@ class Elf { } } - _cacheSymbolNames('.strtab', '.symtab'); - _cacheSymbolNames('.dynstr', '.dynsym'); + cacheSymbolNames('.strtab', '.symtab'); + cacheSymbolNames('.dynstr', '.dynsym'); // Set the wordSize and endian of the original reader before returning. elfReader.wordSize = reader.wordSize; elfReader.endian = reader.endian;