[benchmarks] Fix benchmarks warming up incorrectly.

The benchmarks were using a range of antipatterns that did not do what
the authors thought they did. It seems that the authors thought the
warmup method has to run for a while and do the full warmup, but the
truth is that the harness will do that for you by running the warmup
function in a timed loop. Instead these patterns just wasted time by
making the warmup more expensive and complex than needed.

This change just removes the warmup overrides since none of them do
anything positive. This change prepares us for future improvements to
the benchmark harness.

Fixes: b/324874055
Change-Id: Ib7c282123a2151614bc95a105a30e67221f11315
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/352022
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>

This commit is contained in:

Jonas Termansen

2024-02-22 14:38:19 +00:00

committed by

Commit Queue

parent e680eb4c4f

commit b6aa2976dc

16 changed files with 8 additions and 92 deletions

									
										benchmarks/Utf8DecodeComplex/dart/benchmarks.dart
									
		-5
	
												View File
												
				@@ -164,11 +164,6 @@ class Utf8DecodeBenchmarkBase extends BenchmarkBase {

				    run();

				  }

				  @override

				  void warmup() {

				    BenchmarkBase.measureFor(run, 100);

				  }

				  @override

				  double measure() {

				    // Report time per input byte.