dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[vm] Reland: Move the interpreter under a flag.

Browse Source 
After this CL, the interpreter is included by default in the
JIT VM under the flag --enable-interpreter.

Reland with fix to NativeArgument setup in simulator_arm.cc

Change-Id: Ib9b4df6eb4d997dfbe361188b8a127828c1d9c6f
Reviewed-on: https://dart-review.googlesource.com/74003
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
This commit is contained in:
Zach Anderson
2018-09-07 19:25:31 +00:00
committed by commit-bot@chromium.org
parent dc2f43b74a
commit b4004f6476
49 changed files with 470 additions and 460 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/stack_frame.h
-21
View File
@@ -161,11 +161,7 @@ class StackFrame : public ValueObject {
virtual bool IsStubFrame() const;
virtual bool IsEntryFrame() const { return false; }
virtual bool IsExitFrame() const { return false; }
#if defined(DART_USE_INTERPRETER)
virtual bool is_interpreted() const { return is_interpreted_; }
#else
virtual bool is_interpreted() const { return false; }
#endif
RawFunction* LookupDartFunction() const;
RawCode* LookupDartCode() const;
@@ -179,13 +175,8 @@ class StackFrame : public ValueObject {
protected:
explicit StackFrame(Thread* thread)
#if defined(DART_USE_INTERPRETER)
: fp_(0), sp_(0), pc_(0), thread_(thread), is_interpreted_(false) {
}
#else
: fp_(0), sp_(0), pc_(0), thread_(thread) {
}
#endif
// Name of the frame, used for generic frame printing functionality.
virtual const char* GetName() const {
@@ -229,9 +220,7 @@ class StackFrame : public ValueObject {
uword sp_;
uword pc_;
Thread* thread_;
#if defined(DART_USE_INTERPRETER)
bool is_interpreted_;
#endif
// The iterators FrameSetIterator and StackFrameIterator set the private
// fields fp_ and sp_ when they return the respective frame objects.
@@ -349,7 +338,6 @@ class StackFrameIterator : public ValueObject {
StackFrame* NextFrame(bool validate);
private:
#if defined(DART_USE_INTERPRETER)
explicit FrameSetIterator(Thread* thread)
: fp_(0),
sp_(0),
@@ -359,20 +347,13 @@ class StackFrameIterator : public ValueObject {
is_interpreted_(false) {}
bool is_interpreted() const { return is_interpreted_; }
void CheckIfInterpreted(uword exit_marker);
#else
explicit FrameSetIterator(Thread* thread)
: fp_(0), sp_(0), pc_(0), stack_frame_(thread), thread_(thread) {}
bool is_interpreted() const { return false; }
#endif
uword fp_;
uword sp_;
uword pc_;
StackFrame stack_frame_; // Singleton frame returned by NextFrame().
Thread* thread_;
#if defined(DART_USE_INTERPRETER)
bool is_interpreted_;
#endif
friend class StackFrameIterator;
DISALLOW_COPY_AND_ASSIGN(FrameSetIterator);
@@ -393,9 +374,7 @@ class StackFrameIterator : public ValueObject {
void SetupLastExitFrameData();
void SetupNextExitFrameData();
#if defined(DART_USE_INTERPRETER)
void CheckInterpreterExitFrame(uword exit_marker);
#endif
bool validate_; // Validate each frame as we traverse the frames.
EntryFrame entry_; // Singleton entry frame returned by NextEntryFrame().