dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[vm/compiler] Speed up the compiler part which deals with kernel reading up in DEBUG mode

Browse Source 
This reduces our AOT compiler's time - gen_snapshot -  by half in DEBUG mode.

Issue https://github.com/dart-lang/sdk/issues/32603

Change-Id: I235afc40acba32036d4127c31c93f3b22f522314
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103441
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
This commit is contained in:
Martin Kustermann
2019-05-22 22:16:30 +00:00
committed by commit-bot@chromium.org
parent 0c891451a8
commit b316210d94
3 changed files with 41 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/kernel_binary.h
+17 -16
View File
@@ -177,15 +177,7 @@ class Reader : public ValueObject {
offset_(0) {
// The reader expects that the actual data is external, though allows
// having a view into this external typed data.
#if defined(DEBUG)
if (typed_data_->IsTypedDataView()) {
const auto& backing_store =
TypedDataBase::Handle(TypedDataView::Cast(*typed_data_).typed_data());
ASSERT(backing_store.IsExternalTypedData());
} else {
ASSERT(typed_data_->IsExternalTypedData());
}
#endif
DEBUG_ASSERT(typed_data_->IsBackedByExternalTypedData());
}
uint32_t ReadFromIndex(intptr_t end_offset,
@@ -199,10 +191,15 @@ class Reader : public ValueObject {
return result;
}
uint32_t ReadUInt32At(intptr_t offset) const {
ASSERT((size_ >= 4) && (offset >= 0) && (offset <= size_ - 4));
uint32_t value;
value = typed_data_->GetUint32(offset);
DART_FORCE_INLINE uint32_t ReadUInt32At(intptr_t offset) const {
ASSERT(size_ >= 4 && offset >= 0 && (offset <= size_ - 4));
// We validated in the [Reader] constructor that we have either an
// ExternalTypedData or a view on top of an ExternalTypedData.
//
// This means the data pointer will not change and we can use
// [DataAddrUnsafe].
const uint32_t value =
*static_cast<uint32_t*>(typed_data_->DataAddrUnsafe(offset));
return Utils::BigEndianToHost32(value);
}
@@ -358,9 +355,13 @@ class Reader : public ValueObject {
}
private:
const uint8_t* buffer() const {
NoSafepointScope no_safepoint(thread_);
return reinterpret_cast<uint8_t*>(typed_data_->DataAddr(0));
DART_FORCE_INLINE const uint8_t* buffer() const {
// We validated in the [Reader] constructor that we have either an
// ExternalTypedData or a view on top of an ExternalTypedData.
//
// This means the data pointer will not change and we can use
// [DataAddrUnsafe].
return reinterpret_cast<uint8_t*>(typed_data_->DataAddrUnsafe(0));
}
Thread* thread_;