diff --git a/pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart b/pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart index f3e8e95a85d..706f4bd7450 100644 --- a/pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart +++ b/pkg/analysis_server/lib/plugin/protocol/protocol_dart.dart @@ -13,7 +13,7 @@ import 'package:analyzer/src/dart/element/element.dart'; import 'package:analyzer/src/utilities/extensions/element.dart'; import 'package:path/path.dart' as path; -Element convertElement(engine.Element2 element) { +Element convertElement(engine.Element element) { var kind = convertElementToElementKind(element); var name = getElementDisplayName(element); var elementTypeParameters = _getTypeParametersString(element); @@ -120,14 +120,14 @@ ElementKind convertElementKind(engine.ElementKind kind) { return ElementKind.UNKNOWN; } -/// Return an [ElementKind] corresponding to the given [engine.Element2]. -ElementKind convertElementToElementKind(engine.Element2 element) { - if (element is engine.EnumElement2) { +/// Return an [ElementKind] corresponding to the given [engine.Element]. +ElementKind convertElementToElementKind(engine.Element element) { + if (element is engine.EnumElement) { return ElementKind.ENUM; - } else if (element is engine.MixinElement2) { + } else if (element is engine.MixinElement) { return ElementKind.MIXIN; } - if (element is engine.FieldElement2 && element.isEnumConstant) { + if (element is engine.FieldElement && element.isEnumConstant) { return ElementKind.ENUM_CONSTANT; } return convertElementKind(element.kind); @@ -145,7 +145,7 @@ Element convertLibraryFragment(CompilationUnitElementImpl fragment) { ); } -String getElementDisplayName(engine.Element2 element) { +String getElementDisplayName(engine.Element element) { if (element is engine.LibraryFragment) { return path.basename((element as engine.LibraryFragment).source.fullName); } else { @@ -153,17 +153,17 @@ String getElementDisplayName(engine.Element2 element) { } } -String? getParametersString(engine.Element2 element) { +String? getParametersString(engine.Element element) { // TODO(scheglov): expose the corresponding feature from ExecutableElement List parameters; - if (element is engine.ExecutableElement2) { + if (element is engine.ExecutableElement) { // valid getters don't have parameters if (element.kind == engine.ElementKind.GETTER && element.formalParameters.isEmpty) { return null; } parameters = element.formalParameters.toList(); - } else if (element is engine.TypeAliasElement2) { + } else if (element is engine.TypeAliasElement) { var aliasedType = element.aliasedType; if (aliasedType is FunctionType) { parameters = aliasedType.formalParameters.toList(); @@ -202,11 +202,11 @@ String? getParametersString(engine.Element2 element) { return '($sb)'; } -String? _getTypeParametersString(engine.Element2 element) { - List? typeParameters; - if (element is engine.InterfaceElement2) { +String? _getTypeParametersString(engine.Element element) { + List? typeParameters; + if (element is engine.InterfaceElement) { typeParameters = element.typeParameters2; - } else if (element is engine.TypeAliasElement2) { + } else if (element is engine.TypeAliasElement) { typeParameters = element.typeParameters2; } if (typeParameters == null || typeParameters.isEmpty) { @@ -215,41 +215,41 @@ String? _getTypeParametersString(engine.Element2 element) { return '<${typeParameters.join(', ')}>'; } -bool _isAbstract(engine.Element2 element) { - if (element is engine.ClassElement2) { +bool _isAbstract(engine.Element element) { + if (element is engine.ClassElement) { return element.isAbstract; } - if (element is engine.MethodElement2) { + if (element is engine.MethodElement) { return element.isAbstract; } - if (element is engine.MixinElement2) { + if (element is engine.MixinElement) { return true; } return false; } -bool _isConst(engine.Element2 element) { - if (element is engine.ConstructorElement2) { +bool _isConst(engine.Element element) { + if (element is engine.ConstructorElement) { return element.isConst; } - if (element is engine.VariableElement2) { + if (element is engine.VariableElement) { return element.isConst; } return false; } -bool _isFinal(engine.Element2 element) { - if (element is engine.VariableElement2) { +bool _isFinal(engine.Element element) { + if (element is engine.VariableElement) { return element.isFinal; } return false; } -bool _isStatic(engine.Element2 element) { - if (element is engine.ExecutableElement2) { +bool _isStatic(engine.Element element) { + if (element is engine.ExecutableElement) { return element.isStatic; } - if (element is engine.PropertyInducingElement2) { + if (element is engine.PropertyInducingElement) { return element.isStatic; } return false; diff --git a/pkg/analysis_server/lib/src/analysis_server.dart b/pkg/analysis_server/lib/src/analysis_server.dart index bec7c09259d..db7e3fd1629 100644 --- a/pkg/analysis_server/lib/src/analysis_server.dart +++ b/pkg/analysis_server/lib/src/analysis_server.dart @@ -639,10 +639,10 @@ abstract class AnalysisServer { /// Gets the current version number of a document (if known). int? getDocumentVersion(String path); - /// Return a [Future] that completes with the [Element2] at the given + /// Return a [Future] that completes with the [Element] at the given /// [offset] of the given [file], or with `null` if there is no node at the /// [offset] or the node does not have an element. - Future getElementAtOffset(String file, int offset) async { + Future getElementAtOffset(String file, int offset) async { var unitResult = await getResolvedUnit(file); if (unitResult == null) { return null; diff --git a/pkg/analysis_server/lib/src/cider/completion.dart b/pkg/analysis_server/lib/src/cider/completion.dart index fb44d008575..cbe296fdf29 100644 --- a/pkg/analysis_server/lib/src/cider/completion.dart +++ b/pkg/analysis_server/lib/src/cider/completion.dart @@ -190,7 +190,7 @@ class CiderCompletionComputer { /// Return cached, or compute unprefixed suggestions for all elements /// exported from the library. List _importedLibrarySuggestions({ - required LibraryElement2 element, + required LibraryElement element, required OperationPerformanceImpl performance, }) { performance.getDataInt('libraryCount').increment(); @@ -212,7 +212,7 @@ class CiderCompletionComputer { /// Compute all unprefixed suggestions for all elements exported from /// the library. List _librarySuggestions( - LibraryElement2 element, + LibraryElement element, ) { var suggestionBuilder = SuggestionBuilder( _dartCompletionRequest, diff --git a/pkg/analysis_server/lib/src/cider/fixes.dart b/pkg/analysis_server/lib/src/cider/fixes.dart index f58343f43a6..f88db999ad6 100644 --- a/pkg/analysis_server/lib/src/cider/fixes.dart +++ b/pkg/analysis_server/lib/src/cider/fixes.dart @@ -83,10 +83,10 @@ class _CiderDartFixContextImpl extends DartFixContext { }) : super(instrumentationService: InstrumentationService.NULL_SERVICE); @override - Future> getTopLevelDeclarations( + Future> getTopLevelDeclarations( String name, ) async { - var result = {}; + var result = {}; var files = _fileResolver.getFilesWithTopLevelDeclarations(name); for (var file in files) { var kind = file.kind; @@ -101,5 +101,5 @@ class _CiderDartFixContextImpl extends DartFixContext { } @override - Stream librariesWithExtensions(Name memberName) async* {} + Stream librariesWithExtensions(Name memberName) async* {} } diff --git a/pkg/analysis_server/lib/src/cider/local_library_contributor.dart b/pkg/analysis_server/lib/src/cider/local_library_contributor.dart index a3e7cb53c98..7ec4b9e682a 100644 --- a/pkg/analysis_server/lib/src/cider/local_library_contributor.dart +++ b/pkg/analysis_server/lib/src/cider/local_library_contributor.dart @@ -29,7 +29,7 @@ class LibraryElementSuggestionBuilder final String? prefix; /// The set of libraries that have been, or are currently being, visited. - final Set visitedLibraries = {}; + final Set visitedLibraries = {}; factory LibraryElementSuggestionBuilder( DartCompletionRequest request, @@ -59,7 +59,7 @@ class LibraryElementSuggestionBuilder ); @override - void visitClassElement(ClassElement2 element) { + void visitClassElement(ClassElement element) { AstNode node = request.target.containingNode; var libraryElement = request.libraryElement; if (node is ExtendsClause && !element.isExtendableIn2(libraryElement)) { @@ -74,17 +74,17 @@ class LibraryElementSuggestionBuilder } @override - void visitElement(Element2 element) { + void visitElement(Element element) { // ignored } @override - visitEnumElement(EnumElement2 element) { + visitEnumElement(EnumElement element) { _visitInterfaceElement(element); } @override - void visitExtensionElement(ExtensionElement2 element) { + void visitExtensionElement(ExtensionElement element) { if (opType.includeReturnValueSuggestions) { if (element.name3 != null) { builder.suggestExtension(element, kind: kind, prefix: prefix); @@ -93,7 +93,7 @@ class LibraryElementSuggestionBuilder } @override - void visitExtensionTypeElement(ExtensionTypeElement2 element) { + void visitExtensionTypeElement(ExtensionTypeElement element) { _visitInterfaceElement(element); } @@ -105,9 +105,9 @@ class LibraryElementSuggestionBuilder variable != null && variable.isConst)) { var parent = element.enclosingElement2; - if (parent is InterfaceElement2 || parent is ExtensionElement2) { + if (parent is InterfaceElement || parent is ExtensionElement) { if (element.isSynthetic) { - if (variable is FieldElement2) { + if (variable is FieldElement) { builder.suggestField(variable, inheritanceDistance: 0.0); } } else { @@ -120,14 +120,14 @@ class LibraryElementSuggestionBuilder } @override - void visitLibraryElement(LibraryElement2 element) { + void visitLibraryElement(LibraryElement element) { if (visitedLibraries.add(element)) { element.visitChildren2(this); } } @override - visitMixinElement(MixinElement2 element) { + visitMixinElement(MixinElement element) { AstNode node = request.target.containingNode; if (node is ImplementsClause && !element.isImplementableIn2(request.libraryElement)) { @@ -144,7 +144,7 @@ class LibraryElementSuggestionBuilder variable != null && variable.isConst)) { var parent = element.enclosingElement2; - if (parent is InterfaceElement2 || parent is ExtensionElement2) { + if (parent is InterfaceElement || parent is ExtensionElement) { if (!element.isSynthetic) { builder.suggestSetter(element, inheritanceDistance: 0.0); } @@ -169,14 +169,14 @@ class LibraryElementSuggestionBuilder } @override - void visitTopLevelVariableElement(TopLevelVariableElement2 element) { + void visitTopLevelVariableElement(TopLevelVariableElement element) { if (opType.includeReturnValueSuggestions && !element.isSynthetic) { builder.suggestTopLevelVariable(element, prefix: prefix); } } @override - void visitTypeAliasElement(TypeAliasElement2 element) { + void visitTypeAliasElement(TypeAliasElement element) { if (opType.includeTypeNameSuggestions) { builder.suggestTypeAlias(element, prefix: prefix); } @@ -186,10 +186,10 @@ class LibraryElementSuggestionBuilder /// /// If [onlyConst] is `true`, only `const` constructors will be suggested. void _addConstructorSuggestions( - ClassElement2 element, { + ClassElement element, { bool onlyConst = false, }) { - if (element is EnumElement2) { + if (element is EnumElement) { return; } @@ -207,11 +207,11 @@ class LibraryElementSuggestionBuilder } } - void _visitInterfaceElement(InterfaceElement2 element) { + void _visitInterfaceElement(InterfaceElement element) { if (opType.includeTypeNameSuggestions) { builder.suggestInterface(element, prefix: prefix); } - if (element is ClassElement2) { + if (element is ClassElement) { if (opType.includeConstructorSuggestions) { _addConstructorSuggestions(element); } else if (opType.includeAnnotationSuggestions) { diff --git a/pkg/analysis_server/lib/src/cider/rename.dart b/pkg/analysis_server/lib/src/cider/rename.dart index b408051aa77..45be0869927 100644 --- a/pkg/analysis_server/lib/src/cider/rename.dart +++ b/pkg/analysis_server/lib/src/cider/rename.dart @@ -43,21 +43,21 @@ class CanRenameResponse { RefactoringStatus? status; if (element is FormalParameterElement) { status = validateParameterName(name); - } else if (element is VariableElement2) { + } else if (element is VariableElement) { status = validateVariableName(name); } else if (element is LocalFunctionElement || element is TopLevelFunctionElement) { status = validateFunctionName(name); - } else if (element is FieldElement2) { + } else if (element is FieldElement) { status = validateFieldName(name); - } else if (element is MethodElement2) { + } else if (element is MethodElement) { status = validateMethodName(name); - } else if (element is TypeAliasElement2) { + } else if (element is TypeAliasElement) { status = validateTypeAliasName(name); - } else if (element is InterfaceElement2) { + } else if (element is InterfaceElement) { status = validateClassName(name); _flutterWidgetState = _findFlutterStateClass(element, name); - } else if (element is ConstructorElement2) { + } else if (element is ConstructorElement) { status = validateConstructorName(name); _analyzePossibleConflicts(element, status, name); } else if (element is MockLibraryImportElement) { @@ -71,7 +71,7 @@ class CanRenameResponse { } void _analyzePossibleConflicts( - ConstructorElement2 element, + ConstructorElement element, RefactoringStatus result, String newName, ) { @@ -95,8 +95,8 @@ class CanRenameResponse { } } - FlutterWidgetState? _findFlutterStateClass(Element2 element, String newName) { - if (element is ClassElement2 && element.isStatefulWidgetDeclaration) { + FlutterWidgetState? _findFlutterStateClass(Element element, String newName) { + if (element is ClassElement && element.isStatefulWidgetDeclaration) { var oldStateName = '${element.displayName}State'; var library = element.library2; var state = @@ -128,9 +128,9 @@ class CheckNameResponse { String get oldName => canRename.refactoringElement.element.displayName; Future computeRenameRanges2() async { - var elements = []; + var elements = []; var element = canRename.refactoringElement.element; - if (element is PropertyInducingElement2 && element.isSynthetic) { + if (element is PropertyInducingElement && element.isSynthetic) { var property = element; var getter = property.getter2; var setter = property.setter2; @@ -149,7 +149,7 @@ class CheckNameResponse { flutterRename = await _computeFlutterStateName(); } var replaceMatches = []; - if (element is ConstructorElement2) { + if (element is ConstructorElement) { for (var match in matches) { var replaceInfo = []; for (var ref in match.references) { @@ -231,11 +231,11 @@ class CheckNameResponse { } Future> _addElementDeclaration( - Element2 element, + Element element, String sourcePath, ) async { var infos = []; - if (element is PropertyInducingElement2 && element.isSynthetic) { + if (element is PropertyInducingElement && element.isSynthetic) { var getter = element.getter2; if (getter != null) { infos.add( @@ -433,10 +433,10 @@ class CiderRenameComputer { if (element.library2?.isInSdk == true) { return null; } - if (element is MethodElement2 && element.isOperator) { + if (element is MethodElement && element.isOperator) { return null; } - if (element is PropertyAccessorElement2) { + if (element is PropertyAccessorElement) { element = element.variable3; if (element == null) { return null; @@ -452,20 +452,20 @@ class CiderRenameComputer { return null; } - bool _canRenameElement(Element2 element) { + bool _canRenameElement(Element element) { var enclosingElement = element.enclosingElement2; - if (element is ConstructorElement2) { + if (element is ConstructorElement) { return true; } if (element is MockLibraryImportElement) { return true; } - if (element is LabelElement2 || element is LocalElement2) { + if (element is LabelElement || element is LocalElement) { return true; } - if (enclosingElement is InterfaceElement2 || - enclosingElement is ExtensionElement2 || - enclosingElement is LibraryElement2) { + if (enclosingElement is InterfaceElement || + enclosingElement is ExtensionElement || + enclosingElement is LibraryElement) { return true; } return false; @@ -492,7 +492,7 @@ class FlutterWidgetRename { /// The corresponding `State` declaration of a Flutter `StatefulWidget`. class FlutterWidgetState { - ClassElement2 state; + ClassElement state; String newName; FlutterWidgetState(this.state, this.newName); diff --git a/pkg/analysis_server/lib/src/computer/computer_call_hierarchy.dart b/pkg/analysis_server/lib/src/computer/computer_call_hierarchy.dart index 28506ee64b4..015b5162720 100644 --- a/pkg/analysis_server/lib/src/computer/computer_call_hierarchy.dart +++ b/pkg/analysis_server/lib/src/computer/computer_call_hierarchy.dart @@ -19,7 +19,7 @@ import 'package:analyzer/utilities/extensions/ast.dart'; /// /// This is used to construct (and group calls by) a [CallHierarchyItem] that /// contains calls and also locate their containers for additional labelling. -Element2? _getContainer(Element2 element) { +Element? _getContainer(Element element) { // TODO(brianwilkerson): This used to use the compilation unit as a container // which allowed users to see the path to the containing file, but that's // been lost. Consider trying to restore that behavior. @@ -42,9 +42,9 @@ Element2? _getContainer(Element2 element) { } /// Gets a user-friendly display name for [element]. -String _getDisplayName(Element2 element) { +String _getDisplayName(Element element) { return switch (element) { - LibraryElement2() => element.firstFragment.source.shortName, + LibraryElement() => element.firstFragment.source.shortName, GetterElement() => 'get ${element.displayName}', SetterElement() => 'set ${element.displayName}', _ => element.displayName, @@ -102,7 +102,7 @@ class CallHierarchyItem { required this.codeRange, }); - CallHierarchyItem.forElement(Element2 element) + CallHierarchyItem.forElement(Element element) : displayName = _getDisplayName(element), nameRange = _nameRangeForElement(element), codeRange = _codeRangeForElement(element), @@ -117,7 +117,7 @@ class CallHierarchyItem { } /// Returns the [SourceRange] of the code for [element]. - static SourceRange _codeRangeForElement(Element2 element) { + static SourceRange _codeRangeForElement(Element element) { // For synthetic items (like implicit constructors), use the nonSynthetic // element for the location. element = _nonSynthetic(element); @@ -130,7 +130,7 @@ class CallHierarchyItem { } /// Returns the [SourceRange] of the name for [element]. - static SourceRange _nameRangeForElement(Element2 element) { + static SourceRange _nameRangeForElement(Element element) { // For synthetic items (like implicit constructors), use the nonSynthetic // element for the location. element = _nonSynthetic(element); @@ -143,7 +143,7 @@ class CallHierarchyItem { : SourceRange(fragment.nameOffset, fragment.nameLength); } - static Element2 _nonSynthetic(Element2 element) { + static Element _nonSynthetic(Element element) { element = element.nonSynthetic2; if (element.isSynthetic) { element = element.enclosingElement2 ?? element; @@ -177,7 +177,7 @@ enum CallHierarchyKind { ElementKind.SETTER: property, }; - static CallHierarchyKind forElement(Element2 element) => + static CallHierarchyKind forElement(Element element) => _elementMapping[element.kind] ?? unknown; } @@ -224,14 +224,14 @@ class DartCallHierarchyComputer { // implicit constructors do not have. // Here, we map them back to the synthetic constructor element. var isImplicitConstructor = - element is InterfaceElement2 && + element is InterfaceElement && target.kind == CallHierarchyKind.constructor; if (isImplicitConstructor) { element = element.unnamedConstructor2; } // We only find incoming calls to executable elements. - if (element is! ExecutableElement2) { + if (element is! ExecutableElement) { return []; } @@ -240,7 +240,7 @@ class DartCallHierarchyComputer { // Group results by their container, since we only want to return a single // entry for a body, with a set of ranges within. - var resultsByContainer = {}; + var resultsByContainer = {}; // We may need to fetch parsed results for the other files, reuse them // across calls. var parsedUnits = {}; @@ -293,7 +293,7 @@ class DartCallHierarchyComputer { // Group results by their target, since we only want to return a single // entry for each target, with a set of ranges that call it. - var resultsByTarget = {}; + var resultsByTarget = {}; for (var referenceNode in referenceNodes) { var target = _getElementOfNode(referenceNode); if (target == null) { @@ -316,14 +316,14 @@ class DartCallHierarchyComputer { /// Finds a target for starting call hierarchy navigation at [offset]. /// - /// If [offset] is an invocation, returns information about the [Element2] it + /// If [offset] is an invocation, returns information about the [Element] it /// refers to. CallHierarchyItem? findTarget(int offset) { var node = _findTargetNode(offset); var element = _getElementOfNode(node); // We only return targets that are executable elements. - return element is ExecutableElement2 + return element is ExecutableElement ? CallHierarchyItem.forElement(element) : null; } @@ -359,10 +359,10 @@ class DartCallHierarchyComputer { return node; } - /// Return the [Element2] of the given [node], or `null` if [node] is `null`, + /// Return the [Element] of the given [node], or `null` if [node] is `null`, /// does not have an element, or the element is not a valid target for call /// hierarchy. - Element2? _getElementOfNode(AstNode? node) { + Element? _getElementOfNode(AstNode? node) { if (node == null) { return null; } @@ -382,7 +382,7 @@ class DartCallHierarchyComputer { // Don't consider synthetic getter/setter for a field to be executable // since they don't contain any executable code. - if (element is PropertyAccessorElement2 && element.isSynthetic) { + if (element is PropertyAccessorElement && element.isSynthetic) { return null; } @@ -394,7 +394,7 @@ class DartCallHierarchyComputer { /// This is used to ensure calls are only returned for the expected target /// if source code has changed since the earlier request that provided /// [target] to the client. - bool _isMatchingElement(Element2 element, CallHierarchyItem target) { + bool _isMatchingElement(Element element, CallHierarchyItem target) { return _getDisplayName(element) == target.displayName; } diff --git a/pkg/analysis_server/lib/src/computer/computer_color.dart b/pkg/analysis_server/lib/src/computer/computer_color.dart index f1e0f8d2ee4..e5ae3dffd59 100644 --- a/pkg/analysis_server/lib/src/computer/computer_color.dart +++ b/pkg/analysis_server/lib/src/computer/computer_color.dart @@ -225,15 +225,15 @@ class ColorComputer { } /// Checks whether this elements library is dart:ui. - bool _isDartUi(Element2? element) => element?.library2?.name3 == 'dart.ui'; + bool _isDartUi(Element? element) => element?.library2?.name3 == 'dart.ui'; /// Checks whether this elements library is Flutter Material colors. - bool _isFlutterMaterial(Element2? element) => + bool _isFlutterMaterial(Element? element) => element?.library2?.identifier == 'package:flutter/src/material/colors.dart'; /// Checks whether this elements library is Flutter Painting colors. - bool _isFlutterPainting(Element2? element) => + bool _isFlutterPainting(Element? element) => element?.library2?.identifier == 'package:flutter/src/painting/colors.dart'; diff --git a/pkg/analysis_server/lib/src/computer/computer_documentation.dart b/pkg/analysis_server/lib/src/computer/computer_documentation.dart index 37b46dec05d..18e2419c30b 100644 --- a/pkg/analysis_server/lib/src/computer/computer_documentation.dart +++ b/pkg/analysis_server/lib/src/computer/computer_documentation.dart @@ -7,18 +7,18 @@ import 'package:analysis_server/src/utilities/extensions/element.dart'; import 'package:analyzer/dart/element/element.dart'; import 'package:analyzer/src/dartdoc/dartdoc_directive_info.dart'; -/// Computes documentation for an [Element2]. +/// Computes documentation for an [Element]. class DartDocumentationComputer { final DartdocDirectiveInfo dartdocInfo; DartDocumentationComputer(this.dartdocInfo); Documentation? compute( - Element2 elementBeingDocumented, { + Element elementBeingDocumented, { bool includeSummary = false, }) { var element = switch (elementBeingDocumented) { - FieldFormalParameterElement2() => elementBeingDocumented.field2, + FieldFormalParameterElement() => elementBeingDocumented.field2, FormalParameterElement() => elementBeingDocumented.enclosingElement2, _ => elementBeingDocumented, }; @@ -28,8 +28,8 @@ class DartDocumentationComputer { return null; } - Element2? documentedElement; - Element2? documentedGetter; + Element? documentedElement; + Element? documentedGetter; // Look for documentation comments of overridden members var overridden = findOverriddenElements(element); @@ -37,7 +37,7 @@ class DartDocumentationComputer { element, ...overridden.superElements, ...overridden.interfaceElements, - if (element case PropertyAccessorElement2(variable3: var variable?)) + if (element case PropertyAccessorElement(variable3: var variable?)) variable, ]; for (var candidate in candidates) { @@ -81,7 +81,7 @@ class DartDocumentationComputer { /// Compute documentation for [element] and return either the summary or full /// docs (or `null`) depending on `preference`. String? computePreferred( - Element2 element, + Element element, DocumentationPreference preference, ) { if (preference == DocumentationPreference.none) { diff --git a/pkg/analysis_server/lib/src/computer/computer_highlights.dart b/pkg/analysis_server/lib/src/computer/computer_highlights.dart index 48ce0202bdd..f7f2a4646c3 100644 --- a/pkg/analysis_server/lib/src/computer/computer_highlights.dart +++ b/pkg/analysis_server/lib/src/computer/computer_highlights.dart @@ -102,7 +102,7 @@ class DartUnitHighlightsComputer { void _addIdentifierRegion({ required AstNode parent, required Token nameToken, - required Element2? element, + required Element? element, }) { if (_addIdentifierRegion_keyword(nameToken)) { return; @@ -177,9 +177,9 @@ class DartUnitHighlightsComputer { bool _addIdentifierRegion_class( AstNode parent, Token nameToken, - Element2? element, + Element? element, ) { - if (element is! InterfaceElement2) { + if (element is! InterfaceElement) { return false; } // prepare type @@ -194,9 +194,9 @@ class DartUnitHighlightsComputer { type = HighlightRegionType.CONSTRUCTOR; semanticType = SemanticTokenTypes.class_; semanticModifiers = {CustomSemanticTokenModifiers.constructor}; - } else if (element is EnumElement2) { + } else if (element is EnumElement) { type = HighlightRegionType.ENUM; - } else if (element is ExtensionTypeElement2) { + } else if (element is ExtensionTypeElement) { type = HighlightRegionType.EXTENSION_TYPE; } else { type = HighlightRegionType.CLASS; @@ -224,9 +224,9 @@ class DartUnitHighlightsComputer { bool _addIdentifierRegion_constructor( AstNode parent, Token nameToken, - Element2? element, + Element? element, ) { - if (element is! ConstructorElement2) { + if (element is! ConstructorElement) { return false; } return _addRegion_token( @@ -243,8 +243,8 @@ class DartUnitHighlightsComputer { ); } - bool _addIdentifierRegion_extension(Token nameToken, Element2? element) { - if (element is! ExtensionElement2) { + bool _addIdentifierRegion_extension(Token nameToken, Element? element) { + if (element is! ExtensionElement) { return false; } @@ -254,11 +254,11 @@ class DartUnitHighlightsComputer { bool _addIdentifierRegion_field( AstNode parent, Token nameToken, - Element2? element, + Element? element, ) { // Compute the type of the identifier. HighlightRegionType? type; - if (element is FieldElement2) { + if (element is FieldElement) { if (element.isEnumConstant) { type = HighlightRegionType.ENUM_CONSTANT; } else if (element.isStatic) { @@ -266,14 +266,14 @@ class DartUnitHighlightsComputer { } else { type = HighlightRegionType.INSTANCE_FIELD_REFERENCE; } - } else if (element is TopLevelVariableElement2) { + } else if (element is TopLevelVariableElement) { type = HighlightRegionType.TOP_LEVEL_VARIABLE_DECLARATION; } else if (element is GetterElement) { var accessor = element; var variable = accessor.variable3; - if (variable is TopLevelVariableElement2) { + if (variable is TopLevelVariableElement) { type = HighlightRegionType.TOP_LEVEL_GETTER_REFERENCE; - } else if (variable is FieldElement2 && variable.isEnumConstant) { + } else if (variable is FieldElement && variable.isEnumConstant) { type = HighlightRegionType.ENUM_CONSTANT; } else if (accessor.isStatic) { type = HighlightRegionType.STATIC_GETTER_REFERENCE; @@ -283,9 +283,9 @@ class DartUnitHighlightsComputer { } else if (element is SetterElement) { var accessor = element; var variable = accessor.variable3; - if (variable is TopLevelVariableElement2) { + if (variable is TopLevelVariableElement) { type = HighlightRegionType.TOP_LEVEL_SETTER_REFERENCE; - } else if (variable is FieldElement2 && variable.isEnumConstant) { + } else if (variable is FieldElement && variable.isEnumConstant) { type = HighlightRegionType.ENUM_CONSTANT; } else if (accessor.isStatic) { type = HighlightRegionType.STATIC_SETTER_REFERENCE; @@ -321,7 +321,7 @@ class DartUnitHighlightsComputer { bool _addIdentifierRegion_function( AstNode parent, Token nameToken, - Element2? element, + Element? element, ) { if (element is! TopLevelFunctionElement && element is! LocalFunctionElement) { @@ -345,7 +345,7 @@ class DartUnitHighlightsComputer { bool _addIdentifierRegion_getterSetterDeclaration( AstNode parent, Token nameToken, - Element2? element, + Element? element, ) { // should be declaration if (!(parent is MethodDeclaration || parent is FunctionDeclaration)) { @@ -376,8 +376,8 @@ class DartUnitHighlightsComputer { return _addRegion_token(nameToken, type); } - bool _addIdentifierRegion_importPrefix(Token nameToken, Element2? element) { - if (element is! PrefixElement2) { + bool _addIdentifierRegion_importPrefix(Token nameToken, Element? element) { + if (element is! PrefixElement) { return false; } return _addRegion_token(nameToken, HighlightRegionType.IMPORT_PREFIX); @@ -395,15 +395,15 @@ class DartUnitHighlightsComputer { return false; } - bool _addIdentifierRegion_label(Token nameToken, Element2? element) { - if (element is! LabelElement2) { + bool _addIdentifierRegion_label(Token nameToken, Element? element) { + if (element is! LabelElement) { return false; } return _addRegion_token(nameToken, HighlightRegionType.LABEL); } - bool _addIdentifierRegion_localVariable(Token nameToken, Element2? element) { - if (element is! LocalVariableElement2) { + bool _addIdentifierRegion_localVariable(Token nameToken, Element? element) { + if (element is! LocalVariableElement) { return false; } // OK @@ -417,9 +417,9 @@ class DartUnitHighlightsComputer { bool _addIdentifierRegion_method( AstNode parent, Token nameToken, - Element2? element, + Element? element, ) { - if (element is! MethodElement2) { + if (element is! MethodElement) { return false; } var isStatic = element.isStatic; @@ -444,7 +444,7 @@ class DartUnitHighlightsComputer { bool _addIdentifierRegion_parameter( AstNode parent, Token nameToken, - Element2? element, + Element? element, ) { if (element is! FormalParameterElement) { return false; @@ -458,8 +458,8 @@ class DartUnitHighlightsComputer { return _addRegion_token(nameToken, type, semanticTokenModifiers: modifiers); } - bool _addIdentifierRegion_typeAlias(Token nameToken, Element2? element) { - if (element is TypeAliasElement2) { + bool _addIdentifierRegion_typeAlias(Token nameToken, Element? element) { + if (element is TypeAliasElement) { var type = element.aliasedType is FunctionType ? HighlightRegionType.FUNCTION_TYPE_ALIAS @@ -469,8 +469,8 @@ class DartUnitHighlightsComputer { return false; } - bool _addIdentifierRegion_typeParameter(Token nameToken, Element2? element) { - if (element is! TypeParameterElement2) { + bool _addIdentifierRegion_typeParameter(Token nameToken, Element? element) { + if (element is! TypeParameterElement) { return false; } return _addRegion_token( @@ -483,7 +483,7 @@ class DartUnitHighlightsComputer { bool _addIdentifierRegion_unresolvedInstanceMemberReference( AstNode parent, Token nameToken, - Element2? element, + Element? element, ) { // unresolved if (element != null) { @@ -518,7 +518,7 @@ class DartUnitHighlightsComputer { /// Returns a set of additional semantic token modifiers that apply to /// [element]. Set? _additionalModifiersForElement( - Element2? element, + Element? element, ) { return (element?.isWildcardVariable ?? false) ? {CustomSemanticTokenModifiers.wildcard} @@ -1507,7 +1507,7 @@ class _DartUnitHighlightsComputerVisitor extends RecursiveAstVisitor { // Patterns can be method tear-offs as well as getters: // https://github.com/dart-lang/sdk/issues/59976#issuecomment-2613558317 var type = switch (node.element2) { - MethodElement2() => HighlightRegionType.INSTANCE_METHOD_TEAR_OFF, + MethodElement() => HighlightRegionType.INSTANCE_METHOD_TEAR_OFF, _ => HighlightRegionType.INSTANCE_GETTER_REFERENCE, }; @@ -1794,14 +1794,14 @@ class _DartUnitHighlightsComputerVisitor extends RecursiveAstVisitor { @override void visitVariableDeclaration(VariableDeclaration node) { var element = node.declaredFragment?.element ?? node.declaredElement2; - if (element is FieldElement2) { + if (element is FieldElement) { computer._addRegion_token( node.name, element.isStatic ? HighlightRegionType.STATIC_FIELD_DECLARATION : HighlightRegionType.INSTANCE_FIELD_DECLARATION, ); - } else if (element is LocalVariableElement2) { + } else if (element is LocalVariableElement) { computer._addRegion_token( node.name, element.type is DynamicType @@ -1811,7 +1811,7 @@ class _DartUnitHighlightsComputerVisitor extends RecursiveAstVisitor { element, ), ); - } else if (element is TopLevelVariableElement2) { + } else if (element is TopLevelVariableElement) { computer._addRegion_token( node.name, HighlightRegionType.TOP_LEVEL_VARIABLE_DECLARATION, @@ -1888,7 +1888,7 @@ class _DartUnitHighlightsComputerVisitor extends RecursiveAstVisitor { /// Returns a set of additional semantic token modifiers that apply to /// [element]. Set? _additionalModifiersForElement( - Element2? element, + Element? element, ) { return computer._additionalModifiersForElement(element); } diff --git a/pkg/analysis_server/lib/src/computer/computer_hover.dart b/pkg/analysis_server/lib/src/computer/computer_hover.dart index 6c82c152ab9..bc82f016333 100644 --- a/pkg/analysis_server/lib/src/computer/computer_hover.dart +++ b/pkg/analysis_server/lib/src/computer/computer_hover.dart @@ -72,7 +72,7 @@ class DartUnitHoverComputer { hover.isDeprecated = a.metadata2.hasDeprecated; } // not local element - if (element.enclosingElement2 is! ExecutableElement2) { + if (element.enclosingElement2 is! ExecutableElement) { // containing class hover.containingClassDescription = _containingClass(element); // containing library @@ -98,8 +98,8 @@ class DartUnitHoverComputer { } /// Gets the name of the containing class of [element]. - String? _containingClass(Element2 element) { - var containingClass = element.thisOrAncestorOfType2(); + String? _containingClass(Element element) { + var containingClass = element.thisOrAncestorOfType2(); return containingClass != null && containingClass != element ? containingClass.displayName : null; @@ -110,7 +110,7 @@ class DartUnitHoverComputer { /// This is usually `element.getDisplayString()` but may contain additional /// information to disambiguate things like constructors from types (and /// whether they are const). - String? _elementDisplayString(AstNode node, Element2? element) { + String? _elementDisplayString(AstNode node, Element? element) { var displayString = element?.displayString2(multiline: true); if (displayString != null && @@ -146,7 +146,7 @@ class DartUnitHoverComputer { } /// Returns information about the library that contains [element]. - _LibraryInfo _libraryInfo(Element2 element) { + _LibraryInfo _libraryInfo(Element element) { var library = element.library2; if (library == null) { return null; @@ -218,7 +218,7 @@ class DartUnitHoverComputer { // hovers because information about those functions are already available // by hovering over the function name or the operator. SetterElement() => null, - MethodElement2 method when method.isOperator => null, + MethodElement method when method.isOperator => null, _ => _elementDisplayString(node, parameter), }; } @@ -243,16 +243,16 @@ class DartUnitHoverComputer { } /// Returns information about the static type of [node]. - String? _typeDisplayString(AstNode node, Element2? element) { + String? _typeDisplayString(AstNode node, Element? element) { var parent = node.parent; DartType? staticType; if (node is Expression && (element == null || - element is VariableElement2 || + element is VariableElement || element is GetterElement || element is SetterElement)) { staticType = _getTypeOfDeclarationOrReference(node); - } else if (element is VariableElement2) { + } else if (element is VariableElement) { staticType = element.type; } else if (parent is MethodInvocation && parent.methodName == node) { staticType = parent.staticInvokeType; @@ -270,7 +270,7 @@ class DartUnitHoverComputer { static DartType? _getTypeOfDeclarationOrReference(Expression node) { if (node is SimpleIdentifier) { var element = node.element; - if (element is VariableElement2) { + if (element is VariableElement) { if (node.inDeclarationContext()) { return element.type; } diff --git a/pkg/analysis_server/lib/src/computer/computer_inlay_hint.dart b/pkg/analysis_server/lib/src/computer/computer_inlay_hint.dart index e2f105bcb32..ab04556ea84 100644 --- a/pkg/analysis_server/lib/src/computer/computer_inlay_hint.dart +++ b/pkg/analysis_server/lib/src/computer/computer_inlay_hint.dart @@ -203,7 +203,7 @@ class DartInlayHintComputer { } } - Location? _locationForElement(Element2? element) { + Location? _locationForElement(Element? element) { if (element == null) { return null; } @@ -272,7 +272,7 @@ class _DartInlayHintComputerVisitor extends GeneralizingAstVisitor { } var declaration = node.declaredElement2; - if (declaration is LocalVariableElement2) { + if (declaration is LocalVariableElement) { _computer._addTypePrefix(node.name, declaration.type); } } diff --git a/pkg/analysis_server/lib/src/computer/computer_lazy_type_hierarchy.dart b/pkg/analysis_server/lib/src/computer/computer_lazy_type_hierarchy.dart index 364a3497949..7d5724b0f06 100644 --- a/pkg/analysis_server/lib/src/computer/computer_lazy_type_hierarchy.dart +++ b/pkg/analysis_server/lib/src/computer/computer_lazy_type_hierarchy.dart @@ -35,20 +35,20 @@ class DartLazyTypeHierarchyComputer { DartLazyTypeHierarchyComputer(this._result); - /// Finds subtypes for the [Element2] at [location]. + /// Finds subtypes for the [Element] at [location]. Future?> findSubtypes( ElementLocation location, SearchEngine searchEngine, ) async { var targetElement = await _findTargetElement(location); - if (targetElement is! InterfaceElement2) { + if (targetElement is! InterfaceElement) { return null; } return _getSubtypes(targetElement, searchEngine); } - /// Finds supertypes for the [Element2] at [location]. + /// Finds supertypes for the [Element] at [location]. Future?> findSupertypes( ElementLocation location, ) async { @@ -76,7 +76,7 @@ class DartLazyTypeHierarchyComputer { (node) => _isValidTargetDeclaration(node), ); var element = declaration?.declaredFragment?.element; - if (element is InterfaceElement2) { + if (element is InterfaceElement) { type = element.thisType; } } @@ -86,22 +86,20 @@ class DartLazyTypeHierarchyComputer { : null; } - /// Locate the [Element2] referenced by [location]. - Future _findTargetElement( - ElementLocation location, - ) async { + /// Locate the [Element] referenced by [location]. + Future _findTargetElement(ElementLocation location) async { var element = await location.locateIn(_result.session); - return element is InterfaceElement2 ? element : null; + return element is InterfaceElement ? element : null; } /// Gets immediate subtypes for the class/mixin [target]. Future> _getSubtypes( - InterfaceElement2 target, + InterfaceElement target, SearchEngine searchEngine, ) async { /// Helper to convert a [SearchMatch] to a [TypeHierarchyRelatedItem]. TypeHierarchyRelatedItem? toHierarchyItem(SearchMatch match) { - var element = match.element as InterfaceElement2; + var element = match.element as InterfaceElement; var type = element.thisType; switch (match.kind) { case MatchKind.REFERENCE_IN_EXTENDS_CLAUSE: @@ -122,7 +120,7 @@ class DartLazyTypeHierarchyComputer { target, SearchEngineCache(), ); - var seenElements = {}; + var seenElements = {}; return matches .where((match) => seenElements.add(match.element)) .map(toHierarchyItem) @@ -202,14 +200,14 @@ class TypeHierarchyItem { }); TypeHierarchyItem._forElement({ - required InterfaceElement2 element, + required InterfaceElement element, required this.location, }) : displayName = _displayNameForElement(element), nameRange = _nameRangeForElement(element), codeRange = _codeRangeForElement(element), file = element.firstFragment.libraryFragment.source.fullName; - static TypeHierarchyItem? forElement(InterfaceElement2 element) { + static TypeHierarchyItem? forElement(InterfaceElement element) { var location = ElementLocation.forElement(element); if (location == null) return null; @@ -217,19 +215,19 @@ class TypeHierarchyItem { } /// Returns the [SourceRange] of the code for [element]. - static SourceRange _codeRangeForElement(Element2 element) { + static SourceRange _codeRangeForElement(Element element) { // Non-synthetic elements should always have code locations. var firstFragment = element.nonSynthetic2.firstFragment as ElementImpl; return SourceRange(firstFragment.codeOffset!, firstFragment.codeLength!); } /// Returns a name to display in the hierarchy for [element]. - static String _displayNameForElement(InterfaceElement2 element) { + static String _displayNameForElement(InterfaceElement element) { return element.baseElement.thisType.getDisplayString(); } /// Returns the [SourceRange] of the name for [element]. - static SourceRange _nameRangeForElement(Element2 element) { + static SourceRange _nameRangeForElement(Element element) { var fragment = element.nonSynthetic2.firstFragment; // Some non-synthetic items can still have invalid nameOffsets (for example @@ -288,7 +286,7 @@ class TypeHierarchyRelatedItem extends TypeHierarchyItem { ); static TypeHierarchyRelatedItem? _forElement( - InterfaceElement2 element, { + InterfaceElement element, { required TypeHierarchyItemRelationship relationship, }) { var location = ElementLocation.forElement(element); diff --git a/pkg/analysis_server/lib/src/computer/computer_outline.dart b/pkg/analysis_server/lib/src/computer/computer_outline.dart index 5e79c35a938..9497efa2dd2 100644 --- a/pkg/analysis_server/lib/src/computer/computer_outline.dart +++ b/pkg/analysis_server/lib/src/computer/computer_outline.dart @@ -534,7 +534,7 @@ class _FunctionBodyOutlinesVisitor extends RecursiveAstVisitor { /// Return `true` if the given [element] is the method 'group' defined in the /// test package. - bool isGroup(engine.ExecutableElement2? element) { + bool isGroup(engine.ExecutableElement? element) { if (element != null && element.metadata2.hasIsTestGroup) { return true; } @@ -545,7 +545,7 @@ class _FunctionBodyOutlinesVisitor extends RecursiveAstVisitor { /// Return `true` if the given [element] is the method 'test' defined in the /// test package. - bool isTest(engine.ExecutableElement2? element) { + bool isTest(engine.ExecutableElement? element) { if (element != null && element.metadata2.hasIsTest) { return true; } @@ -597,7 +597,7 @@ class _FunctionBodyOutlinesVisitor extends RecursiveAstVisitor { var nameNode = node.methodName; var nameElement = nameNode.element; - if (nameElement is! engine.ExecutableElement2) { + if (nameElement is! engine.ExecutableElement) { return; } diff --git a/pkg/analysis_server/lib/src/computer/computer_overrides.dart b/pkg/analysis_server/lib/src/computer/computer_overrides.dart index a9105751116..5f83e2dbcb3 100644 --- a/pkg/analysis_server/lib/src/computer/computer_overrides.dart +++ b/pkg/analysis_server/lib/src/computer/computer_overrides.dart @@ -10,11 +10,11 @@ import 'package:analyzer/dart/element/element.dart'; import 'package:collection/collection.dart'; /// Return the elements that the given [element] overrides. -OverriddenElements findOverriddenElements(Element2 element) { - if (element.enclosingElement2 is InterfaceElement2) { +OverriddenElements findOverriddenElements(Element element) { + if (element.enclosingElement2 is InterfaceElement) { return _OverriddenElementsFinder(element).find(); } - return OverriddenElements(element, [], []); + return OverriddenElements(element, [], []); } /// A computer for class member overrides in a Dart [CompilationUnit]. @@ -42,7 +42,7 @@ class DartUnitOverridesComputer { /// Add a new [proto.Override] for the declaration with the given name /// [token]. - void _addOverride(Token token, Element2? element) { + void _addOverride(Token token, Element? element) { if (element != null) { var overridesResult = _OverriddenElementsFinder(element).find(); var superElements = overridesResult.superElements; @@ -98,38 +98,38 @@ class DartUnitOverridesComputer { /// The container with elements that a class member overrides. class OverriddenElements { /// The element that overrides other class members. - final Element2 element; + final Element element; /// The elements that [element] overrides and which is defined in a class that /// is a superclass of the class that defines [element]. - final List superElements; + final List superElements; /// The elements that [element] overrides and which is defined in a class that /// which is implemented by the class that defines [element]. - final List interfaceElements; + final List interfaceElements; OverriddenElements(this.element, this.superElements, this.interfaceElements); } class _OverriddenElementsFinder { - Element2 _seed; - LibraryElement2 _library; - InterfaceElement2 _class; + Element _seed; + LibraryElement _library; + InterfaceElement _class; String _name; List _kinds; - final List _superElements = []; - final List _interfaceElements = []; - final Set _visited = {}; + final List _superElements = []; + final List _interfaceElements = []; + final Set _visited = {}; - factory _OverriddenElementsFinder(Element2 seed) { - var class_ = seed.enclosingElement2 as InterfaceElement2; + factory _OverriddenElementsFinder(Element seed) { + var class_ = seed.enclosingElement2 as InterfaceElement; var library = class_.library2; var name = seed.displayName; List kinds; - if (seed is FieldElement2) { + if (seed is FieldElement) { kinds = [ElementKind.GETTER, if (!seed.isFinal) ElementKind.SETTER]; - } else if (seed is MethodElement2) { + } else if (seed is MethodElement) { kinds = const [ElementKind.METHOD]; } else if (seed is GetterElement) { kinds = const [ElementKind.GETTER]; @@ -159,7 +159,7 @@ class _OverriddenElementsFinder { return OverriddenElements(_seed, _superElements, _interfaceElements); } - void _addInterfaceOverrides(InterfaceElement2? class_, bool checkType) { + void _addInterfaceOverrides(InterfaceElement? class_, bool checkType) { if (class_ == null) { return; } @@ -179,7 +179,7 @@ class _OverriddenElementsFinder { } // super _addInterfaceOverrides(class_.supertype?.element3, checkType); - if (class_ is MixinElement2) { + if (class_ is MixinElement) { for (var constraint in class_.superclassConstraints) { _addInterfaceOverrides(constraint.element3, true); } @@ -187,7 +187,7 @@ class _OverriddenElementsFinder { } void _addSuperOverrides( - InterfaceElement2? class_, { + InterfaceElement? class_, { bool withThisType = true, }) { if (class_ == null) { @@ -208,16 +208,16 @@ class _OverriddenElementsFinder { for (var mixin_ in class_.mixins) { _addSuperOverrides(mixin_.element3); } - if (class_ is MixinElement2) { + if (class_ is MixinElement) { for (var constraint in class_.superclassConstraints) { _addSuperOverrides(constraint.element3); } } } - Element2? _lookupMember(InterfaceElement2 classElement) { - Element2? findMatchingElement(Iterable elements) { - return elements.firstWhereOrNull((Element2 element) { + Element? _lookupMember(InterfaceElement classElement) { + Element? findMatchingElement(Iterable elements) { + return elements.firstWhereOrNull((Element element) { if (!identical(element.library2, _library) && _name.startsWith('_')) { return false; } diff --git a/pkg/analysis_server/lib/src/computer/computer_signature.dart b/pkg/analysis_server/lib/src/computer/computer_signature.dart index 112e68e2dd5..b9831611949 100644 --- a/pkg/analysis_server/lib/src/computer/computer_signature.dart +++ b/pkg/analysis_server/lib/src/computer/computer_signature.dart @@ -38,14 +38,14 @@ class DartUnitSignatureComputer { } var (argumentList, argument) = argumentAndList; String? name; - Element2? element; + Element? element; List? parameters; var parent = argumentList.parent; if (parent is MethodInvocation) { name = parent.methodName.name; element = ElementLocator.locate2(parent); parameters = - element is FunctionTypedElement2 ? element.formalParameters : null; + element is FunctionTypedElement ? element.formalParameters : null; } else if (parent is InstanceCreationExpression) { name = parent.constructorName.type.qualifiedName; var constructorName = parent.constructorName.name; @@ -54,7 +54,7 @@ class DartUnitSignatureComputer { } element = ElementLocator.locate2(parent); parameters = - element is FunctionTypedElement2 ? element.formalParameters : null; + element is FunctionTypedElement ? element.formalParameters : null; } else if (parent case FunctionExpressionInvocation( function: Identifier function, )) { @@ -64,7 +64,7 @@ class DartUnitSignatureComputer { // Standard function expression. element = function.element; parameters = functionType.formalParameters; - } else if (parent.element case ExecutableElement2 executableElement) { + } else if (parent.element case ExecutableElement executableElement) { // Callable class instance (where we'll look at the `call` method). element = executableElement; parameters = executableElement.formalParameters; diff --git a/pkg/analysis_server/lib/src/computer/computer_type_arguments_signature.dart b/pkg/analysis_server/lib/src/computer/computer_type_arguments_signature.dart index a649d2d5864..044348a2e05 100644 --- a/pkg/analysis_server/lib/src/computer/computer_type_arguments_signature.dart +++ b/pkg/analysis_server/lib/src/computer/computer_type_arguments_signature.dart @@ -43,13 +43,13 @@ class DartTypeArgumentsSignatureComputer { return null; } var parent = argumentList.parent; - Element2? element; + Element? element; if (parent is NamedType) { element = parent.element2; } else if (parent is MethodInvocation) { element = ElementLocator.locate2(parent.methodName); } - if (element is! TypeParameterizedElement2 || + if (element is! TypeParameterizedElement || element.typeParameters2.isEmpty) { return null; } @@ -87,7 +87,7 @@ class DartTypeArgumentsSignatureComputer { lsp.SignatureHelp? _toSignatureHelp( String label, String? documentation, - List typeParameters, + List typeParameters, ) { var parameters = typeParameters diff --git a/pkg/analysis_server/lib/src/computer/import_elements_computer.dart b/pkg/analysis_server/lib/src/computer/import_elements_computer.dart index f8655b8cf0c..16a6464a43e 100644 --- a/pkg/analysis_server/lib/src/computer/import_elements_computer.dart +++ b/pkg/analysis_server/lib/src/computer/import_elements_computer.dart @@ -342,7 +342,7 @@ class ImportElementsComputer { /// Computes the best URI to import [what] into [from]. /// /// Copied from DartFileEditBuilderImpl. - String _getLibrarySourceUri(LibraryElement2 from, Source what) { + String _getLibrarySourceUri(LibraryElement from, Source what) { var whatPath = what.fullName; // check if an absolute URI (such as 'dart:' or 'package:') var whatUri = what.uri; @@ -362,7 +362,7 @@ class ImportElementsComputer { if (prefix.isNotEmpty) { var prefixElement = scope.lookup(prefix).getter2; - if (prefixElement is PrefixElement2) { + if (prefixElement is PrefixElement) { scope = prefixElement.scope; } else { return false; diff --git a/pkg/analysis_server/lib/src/computer/imported_elements_computer.dart b/pkg/analysis_server/lib/src/computer/imported_elements_computer.dart index 1c65943844a..503829e43e8 100644 --- a/pkg/analysis_server/lib/src/computer/imported_elements_computer.dart +++ b/pkg/analysis_server/lib/src/computer/imported_elements_computer.dart @@ -108,14 +108,14 @@ class _Visitor extends UnifyingAstVisitor { } } - void _addElement(String prefix, Element2? element) { + void _addElement(String prefix, Element? element) { if (element == null) { return; } - if (element is PrefixElement2) { + if (element is PrefixElement) { return; } - if (element.enclosingElement2 is! LibraryElement2) { + if (element.enclosingElement2 is! LibraryElement) { return; } @@ -139,7 +139,7 @@ class _Visitor extends UnifyingAstVisitor { String _getPrefixFrom(SimpleIdentifier identifier) { if (identifier.offset <= endOffset && identifier.end >= startOffset) { var prefixElement = identifier.element; - if (prefixElement is PrefixElement2) { + if (prefixElement is PrefixElement) { return prefixElement.name3 ?? ''; } } diff --git a/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart b/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart index d8b94545b81..33426420c20 100644 --- a/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart +++ b/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart @@ -32,7 +32,7 @@ class ImplementedComputer { } } - void _addImplementedClass(InterfaceElement2 element) { + void _addImplementedClass(InterfaceElement element) { for (var fragment in element.fragments) { var offset = fragment.nameOffset2; var name = fragment.name2; @@ -42,7 +42,7 @@ class ImplementedComputer { } } - void _addImplementedMember(Element2 element) { + void _addImplementedMember(Element element) { for (var fragment in element.fragments) { var offset = fragment.nameOffset2; var name = fragment.name2; @@ -52,7 +52,7 @@ class ImplementedComputer { } } - void _addMemberIfImplemented(Element2 element) { + void _addMemberIfImplemented(Element element) { if (element.isSynthetic || _isStatic(element)) { return; } @@ -61,9 +61,9 @@ class ImplementedComputer { } } - Future _computeForInterfaceElement(InterfaceElement2 element) async { + Future _computeForInterfaceElement(InterfaceElement element) async { // Always include Object and its members. - if (element is ClassElement2 && element.isDartCoreObject) { + if (element is ClassElement && element.isDartCoreObject) { _addImplementedClass(element); element.getters2.forEach(_addImplementedMember); element.setters2.forEach(_addImplementedMember); @@ -83,16 +83,16 @@ class ImplementedComputer { } } - bool _hasOverride(Element2 element) { + bool _hasOverride(Element element) { var name = element.displayName; return subtypeMembers!.contains(name); } /// Return `true` if the given [element] is a static element. - static bool _isStatic(Element2 element) { - if (element is ExecutableElement2) { + static bool _isStatic(Element element) { + if (element is ExecutableElement) { return element.isStatic; - } else if (element is PropertyInducingElement2) { + } else if (element is PropertyInducingElement) { return element.isStatic; } return false; diff --git a/pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart b/pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart index afd58838ac5..a3aa099bdbb 100644 --- a/pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart +++ b/pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart @@ -35,7 +35,7 @@ void addDartOccurrences(OccurrencesCollector collector, CompilationUnit unit) { } class DartUnitOccurrencesComputerVisitor extends RecursiveAstVisitor { - final Map> elementsOffsetLengths = {}; + final Map> elementsOffsetLengths = {}; @override void visitAssignedVariablePattern(AssignedVariablePattern node) { @@ -100,7 +100,7 @@ class DartUnitOccurrencesComputerVisitor extends RecursiveAstVisitor { @override void visitDeclaredVariablePattern(DeclaredVariablePattern node) { - if (node.declaredElement2 case BindPatternVariableElement2(:var join2?)) { + if (node.declaredElement2 case BindPatternVariableElement(:var join2?)) { _addOccurrence(join2.baseElement, node.name); } else { _addOccurrence(node.declaredElement2!, node.name); @@ -149,7 +149,7 @@ class DartUnitOccurrencesComputerVisitor extends RecursiveAstVisitor { @override void visitFieldFormalParameter(FieldFormalParameter node) { var declaredElement = node.declaredFragment?.element; - if (declaredElement is FieldFormalParameterElement2) { + if (declaredElement is FieldFormalParameterElement) { var field = declaredElement.field2; if (field != null) { _addOccurrence(field, node.name); @@ -285,11 +285,11 @@ class DartUnitOccurrencesComputerVisitor extends RecursiveAstVisitor { super.visitVariableDeclaration(node); } - void _addOccurrence(Element2 element, Token token) { + void _addOccurrence(Element element, Token token) { _addOccurrenceAt(element, token.offset, token.length); } - void _addOccurrenceAt(Element2 element, int offset, int length) { + void _addOccurrenceAt(Element element, int offset, int length) { var canonicalElement = _canonicalizeElement(element); if (canonicalElement == null) { return; @@ -302,11 +302,11 @@ class DartUnitOccurrencesComputerVisitor extends RecursiveAstVisitor { offsetLengths.add((offset, length)); } - Element2? _canonicalizeElement(Element2 element) { - Element2? canonicalElement = element; - if (canonicalElement is FieldFormalParameterElement2) { + Element? _canonicalizeElement(Element element) { + Element? canonicalElement = element; + if (canonicalElement is FieldFormalParameterElement) { canonicalElement = canonicalElement.field2; - } else if (canonicalElement is PropertyAccessorElement2) { + } else if (canonicalElement is PropertyAccessorElement) { canonicalElement = canonicalElement.variable3; } return canonicalElement?.baseElement; diff --git a/pkg/analysis_server/lib/src/handler/legacy/edit_get_available_refactorings.dart b/pkg/analysis_server/lib/src/handler/legacy/edit_get_available_refactorings.dart index 96648691cc8..5ac43bb11a5 100644 --- a/pkg/analysis_server/lib/src/handler/legacy/edit_get_available_refactorings.dart +++ b/pkg/analysis_server/lib/src/handler/legacy/edit_get_available_refactorings.dart @@ -80,7 +80,7 @@ class EditGetAvailableRefactoringsHandler extends LegacyHandler { if (element != null) { var refactoringWorkspace = server.refactoringWorkspace; // try CONVERT_METHOD_TO_GETTER - if (element is ExecutableElement2) { + if (element is ExecutableElement) { if (ConvertMethodToGetterRefactoring( refactoringWorkspace, resolvedUnit.session, diff --git a/pkg/analysis_server/lib/src/handler/legacy/search_find_element_references.dart b/pkg/analysis_server/lib/src/handler/legacy/search_find_element_references.dart index e2d4295bbaa..0fc15e0d2c3 100644 --- a/pkg/analysis_server/lib/src/handler/legacy/search_find_element_references.dart +++ b/pkg/analysis_server/lib/src/handler/legacy/search_find_element_references.dart @@ -32,10 +32,10 @@ class SearchFindElementReferencesHandler extends LegacyHandler { var file = params.file; // prepare element var element = await server.getElementAtOffset(file, params.offset); - if (element is FieldFormalParameterElement2) { + if (element is FieldFormalParameterElement) { element = element.field2; } - if (element is PropertyAccessorElement2) { + if (element is PropertyAccessorElement) { element = element.variable3; } // respond diff --git a/pkg/analysis_server/lib/src/lsp/completion_utils.dart b/pkg/analysis_server/lib/src/lsp/completion_utils.dart index 0d7a4041dde..40356378c9b 100644 --- a/pkg/analysis_server/lib/src/lsp/completion_utils.dart +++ b/pkg/analysis_server/lib/src/lsp/completion_utils.dart @@ -129,10 +129,10 @@ Future toLspCompletionItem( : null; var isCallable = element != null && - (element is ConstructorElement2 || + (element is ConstructorElement || element is LocalFunctionElement || element is TopLevelFunctionElement || - element is MethodElement2); + element is MethodElement); var isInvocation = (suggestion is ExecutableSuggestion && suggestion.kind == server.CompletionSuggestionKind.INVOCATION) || @@ -236,7 +236,7 @@ Future toLspCompletionItem( if (suggestion is ElementBasedSuggestion) { var element = (suggestion as ElementBasedSuggestion).element; - if (element is ExecutableElement2 && element is! PropertyAccessorElement2) { + if (element is ExecutableElement && element is! PropertyAccessorElement) { parameterNames = element.formalParameters.map((parameter) { return parameter.displayName; @@ -440,28 +440,28 @@ lsp.CompletionItemKind? _candidateToCompletionItemKind( return getCompletionKind().firstWhereOrNull(isSupported); } -/// Get the [lsp.CompletionItemKind] based on the [Element2] for +/// Get the [lsp.CompletionItemKind] based on the [Element] for /// an [ElementBasedSuggestion]. List _elementToCompletionItemKind( - Element2 element, + Element element, Set supportedCompletionKinds, ) { - if (element is ClassElement2) { + if (element is ClassElement) { return const [lsp.CompletionItemKind.Class]; } - if (element is ConstructorElement2) { + if (element is ConstructorElement) { return const [lsp.CompletionItemKind.Constructor]; } - if (element is EnumElement2) { + if (element is EnumElement) { return const [lsp.CompletionItemKind.Enum]; } - if (element is ExtensionElement2) { + if (element is ExtensionElement) { return const [lsp.CompletionItemKind.Method]; } - if (element is ExtensionTypeElement2) { + if (element is ExtensionTypeElement) { return const [lsp.CompletionItemKind.Class]; } - if (element is FieldElement2) { + if (element is FieldElement) { if (element.isEnumConstant) { return const [ lsp.CompletionItemKind.EnumMember, @@ -476,37 +476,37 @@ List _elementToCompletionItemKind( if (element is TopLevelFunctionElement) { return const [lsp.CompletionItemKind.Function]; } - if (element is LabelElement2) { + if (element is LabelElement) { return const [lsp.CompletionItemKind.Text]; } - if (element is LibraryElement2) { + if (element is LibraryElement) { return const [lsp.CompletionItemKind.Module]; } - if (element is LocalVariableElement2) { + if (element is LocalVariableElement) { return const [lsp.CompletionItemKind.Variable]; } - if (element is MethodElement2) { + if (element is MethodElement) { return const [lsp.CompletionItemKind.Method]; } - if (element is MixinElement2) { + if (element is MixinElement) { return const [lsp.CompletionItemKind.Class]; } if (element is FormalParameterElement) { return const [lsp.CompletionItemKind.Variable]; } - if (element is PrefixElement2) { + if (element is PrefixElement) { return const [lsp.CompletionItemKind.Variable]; } - if (element is PropertyAccessorElement2) { + if (element is PropertyAccessorElement) { return const [lsp.CompletionItemKind.Property]; } - if (element is TopLevelVariableElement2) { + if (element is TopLevelVariableElement) { return const [lsp.CompletionItemKind.Variable]; } - if (element is TypeAliasElement2) { + if (element is TypeAliasElement) { return const [lsp.CompletionItemKind.Class]; } - if (element is TypeParameterElement2) { + if (element is TypeParameterElement) { return const [ lsp.CompletionItemKind.TypeParameter, lsp.CompletionItemKind.Variable, @@ -666,7 +666,7 @@ String _getDisplayText( /// If the [element] has a documentation comment, return it. _ElementDocumentation? _getDocsFromComputer( - Element2 element, + Element element, DartCompletionRequest request, ) { var doc = request.documentationComputer.compute( @@ -684,7 +684,7 @@ _ElementDocumentation? _getDocsFromComputer( /// If the [element] has a documentation comment, return it. String? _getDocumentation( - Element2 element, + Element element, DartCompletionRequest request, DocumentationPreference includeDocumentation, ) { diff --git a/pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart b/pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart index 4c44998f083..95e1fb3c0b6 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/code_actions/dart.dart @@ -425,7 +425,7 @@ class DartCodeActionsProducer extends AbstractCodeActionsProducer { ); // Method to Getter - if (element is ExecutableElement2 && + if (element is ExecutableElement && ConvertMethodToGetterRefactoring( server.refactoringWorkspace, unitResult.session, diff --git a/pkg/analysis_server/lib/src/lsp/handlers/commands/abstract_refactor.dart b/pkg/analysis_server/lib/src/lsp/handlers/commands/abstract_refactor.dart index 8b1ff6b44d0..bdfe5098119 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/commands/abstract_refactor.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/commands/abstract_refactor.dart @@ -144,7 +144,7 @@ abstract class AbstractRefactorCommandHandler extends SimpleEditCommandHandler case RefactoringKind.CONVERT_METHOD_TO_GETTER: var node = result.unit.nodeCovering(offset: offset); var element = node?.getElement(); - if (element is ExecutableElement2) { + if (element is ExecutableElement) { var refactor = ConvertMethodToGetterRefactoring( server.refactoringWorkspace, result.session, diff --git a/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/editable_arguments_mixin.dart b/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/editable_arguments_mixin.dart index be394218145..6fe68326c17 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/editable_arguments_mixin.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/editable_arguments_mixin.dart @@ -29,7 +29,7 @@ typedef EditableInvocationInfo = mixin EditableArgumentsMixin { DartdocDirectiveInfo getDartdocDirectiveInfoFor(ResolvedUnitResult result); - String? getDocumentation(ResolvedUnitResult result, Element2 element) { + String? getDocumentation(ResolvedUnitResult result, Element element) { var dartDocInfo = getDartdocDirectiveInfoFor(result); var dartDocComputer = DartDocumentationComputer(dartDocInfo); var dartDoc = dartDocComputer.compute(element); @@ -76,7 +76,7 @@ mixin EditableArgumentsMixin { invocation.argumentList, ), MethodInvocation( - methodName: Identifier(element: ExecutableElement2 element), + methodName: Identifier(element: ExecutableElement element), ) => (element.formalParameters, invocation.argumentList), _ => (null, null), @@ -160,11 +160,11 @@ mixin EditableArgumentsMixin { /// Returns a list of the constants of an enum constant prefixed with the enum /// name. - List getQualifiedEnumConstantNames(EnumElement2 element3) => + List getQualifiedEnumConstantNames(EnumElement element3) => element3.constants2.map(getQualifiedEnumConstantName).nonNulls.toList(); /// Returns the name of an enum constant prefixed with the enum name. - static String? getQualifiedEnumConstantName(FieldElement2 enumConstant) { + static String? getQualifiedEnumConstantName(FieldElement enumConstant) { var enumName = enumConstant.enclosingElement2.name3; var name = enumConstant.name3; return enumName != null && name != null ? '$enumName.$name' : null; @@ -183,7 +183,7 @@ extension on InvocationExpressionImpl { // We only support @widgetFactory on extension methods. var element = switch (function) { Identifier(:var element) - when element?.enclosingElement2 is ExtensionElement2 => + when element?.enclosingElement2 is ExtensionElement => element, _ => null, }; diff --git a/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_edit_argument.dart b/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_edit_argument.dart index db4f8d13069..8a6efb28728 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_edit_argument.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_edit_argument.dart @@ -210,7 +210,7 @@ class EditArgumentHandler extends SharedMessageHandler ), ); } else if (parameter.type case InterfaceType( - :EnumElement2 element3, + :EnumElement element3, ) when value is String?) { var allowedValues = getQualifiedEnumConstantNames(element3); if (allowedValues.contains(value)) { diff --git a/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_editable_arguments.dart b/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_editable_arguments.dart index b03c26cada6..8c124fab710 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_editable_arguments.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/custom/editable_arguments/handler_editable_arguments.dart @@ -201,7 +201,7 @@ class EditableArgumentsHandler type = 'string'; value = values.argumentValue?.toStringValue(); defaultValue = values.parameterValue?.toStringValue(); - } else if (parameter.type case InterfaceType(:EnumElement2 element3)) { + } else if (parameter.type case InterfaceType(:EnumElement element3)) { type = 'enum'; options = getQualifiedEnumConstantNames(element3); value = values.argumentValue?.toEnumStringValue(element3); @@ -253,10 +253,10 @@ class EditableArgumentsHandler } extension on DartObject? { - Object? toEnumStringValue(EnumElement2 element3) { + Object? toEnumStringValue(EnumElement element3) { var valueObject = this; if (valueObject?.type case InterfaceType( - element3: EnumElement2 valueElement, + element3: EnumElement valueElement, ) when element3 == valueElement) { var index = valueObject?.getField('index')?.toIntValue(); if (index != null) { diff --git a/pkg/analysis_server/lib/src/lsp/handlers/custom/handler_imports.dart b/pkg/analysis_server/lib/src/lsp/handlers/custom/handler_imports.dart index 7896ef88746..8563578dbb8 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/custom/handler_imports.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/custom/handler_imports.dart @@ -84,7 +84,7 @@ class ImportsHandler } var enclosingElement = element.enclosingElement2; - if (enclosingElement is ExtensionElement2) { + if (enclosingElement is ExtensionElement) { element = enclosingElement; } @@ -99,7 +99,7 @@ class ImportsHandler List _getImportLocations( ResolvedLibraryResult libraryResult, ResolvedUnitResult? unitResult, - Element2 element, + Element element, String? prefix, ) { var elementName = element.name3; @@ -132,7 +132,7 @@ class ImportsHandler /// [unit]. List _getImportsInUnit( CompilationUnit unit, - Element2 element, { + Element element, { required String? prefix, required String elementName, }) { @@ -149,7 +149,7 @@ class ImportsHandler : import.namespace.getPrefixed2(prefix, elementName); var isMatch = - element is MultiplyDefinedElement2 + element is MultiplyDefinedElement ? element.conflictingElements2.contains(importedElement) : element == importedElement; diff --git a/pkg/analysis_server/lib/src/lsp/handlers/custom/handler_super.dart b/pkg/analysis_server/lib/src/lsp/handlers/custom/handler_super.dart index 00179f3aa1d..80316d28047 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/custom/handler_super.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/custom/handler_super.dart @@ -77,26 +77,26 @@ class SuperHandler } class _SuperComputer { - Fragment? computeSuper(Element2 element) { + Fragment? computeSuper(Element element) { return switch (element) { - ConstructorElement2 element => _findSuperConstructor(element), - InterfaceElement2 element => _findSuperClass(element), + ConstructorElement element => _findSuperConstructor(element), + InterfaceElement element => _findSuperClass(element), _ => _findSuperMember(element), }; } - Fragment? _findSuperClass(InterfaceElement2 element) { + Fragment? _findSuperClass(InterfaceElement element) { // For super classes, we use the first fragment (the original declaration). // This differs from methods/getters because we jump to the end of the // augmentation chain for those. return element.supertype?.element3.firstFragment; } - Fragment? _findSuperConstructor(ConstructorElement2 element) { + Fragment? _findSuperConstructor(ConstructorElement element) { return _lastFragment(element.superConstructor2); } - Fragment? _findSuperMember(Element2 element) { + Fragment? _findSuperMember(Element element) { var session = element.session; if (session is! AnalysisSessionImpl) { return null; @@ -104,7 +104,7 @@ class _SuperComputer { var inheritanceManager = session.inheritanceManager; - if (element is! ExecutableElement2 && element is! FieldElement2) { + if (element is! ExecutableElement && element is! FieldElement) { return null; } @@ -113,7 +113,7 @@ class _SuperComputer { return null; } - var interfaceElement = element.thisOrAncestorOfType2(); + var interfaceElement = element.thisOrAncestorOfType2(); if (interfaceElement == null) { return null; } @@ -122,7 +122,7 @@ class _SuperComputer { return _lastFragment(member); } - Fragment? _lastFragment(Element2? element) { + Fragment? _lastFragment(Element? element) { Fragment? fragment = element?.firstFragment; while (fragment?.nextFragment != null) { fragment = fragment?.nextFragment; diff --git a/pkg/analysis_server/lib/src/lsp/handlers/handler_definition.dart b/pkg/analysis_server/lib/src/lsp/handlers/handler_definition.dart index 6ac112931f9..8078ddd3425 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/handler_definition.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/handler_definition.dart @@ -226,7 +226,7 @@ class DefinitionHandler // for the code range because otherwise previews will just show `(int a)` // which is not what the user expects. if (codeFragment.element.enclosingElement2 - case ExtensionTypeElement2 enclosingElement + case ExtensionTypeElement enclosingElement when enclosingElement.primaryConstructor2 == codeFragment.element) { codeFragment = codeFragment.enclosingFragment; } diff --git a/pkg/analysis_server/lib/src/lsp/handlers/handler_document_color_presentation.dart b/pkg/analysis_server/lib/src/lsp/handlers/handler_document_color_presentation.dart index 8bca379cd6b..2eda9808820 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/handler_document_color_presentation.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/handler_document_color_presentation.dart @@ -71,7 +71,7 @@ class DocumentColorPresentationHandler Future _createColorPresentation({ required ResolvedUnitResult unit, required SourceRange editRange, - required InterfaceElement2 colorType, + required InterfaceElement colorType, required String typeName, required String invocationString, required bool includeConstKeyword, @@ -250,8 +250,8 @@ class DocumentColorPresentationHandler parent is PrefixedIdentifier ? parent.element : node.element; return switch (element) { - PropertyAccessorElement2(:var variable3) => variable3?.isConst ?? false, - VariableElement2() => element.isConst, + PropertyAccessorElement(:var variable3) => variable3?.isConst ?? false, + VariableElement() => element.isConst, _ => false, }; } else { diff --git a/pkg/analysis_server/lib/src/lsp/handlers/handler_implementation.dart b/pkg/analysis_server/lib/src/lsp/handlers/handler_implementation.dart index 66722d5b2ac..8c026614868 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/handler_implementation.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/handler_implementation.dart @@ -76,7 +76,7 @@ class ImplementationHandler } var needsMember = helper.findMemberElement(interfaceElement) != null; - var allSubtypes = {}; + var allSubtypes = {}; await performance.runAsync( 'appendAllSubtypes', (performance) => server.searchEngine.appendAllSubtypes( diff --git a/pkg/analysis_server/lib/src/lsp/handlers/handler_inline_value.dart b/pkg/analysis_server/lib/src/lsp/handlers/handler_inline_value.dart index 8da3d2b93e4..de451ff8c98 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/handler_inline_value.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/handler_inline_value.dart @@ -13,7 +13,7 @@ import 'package:analysis_server/src/lsp/registration/feature_registration.dart'; import 'package:analysis_server/src/services/correction/dart/convert_null_check_to_null_aware_element_or_entry.dart'; import 'package:analyzer/dart/ast/ast.dart'; import 'package:analyzer/dart/ast/visitor.dart'; -import 'package:analyzer/dart/element/element.dart'; +import 'package:analyzer/dart/element/element.dart' as analyzer; import 'package:analyzer/dart/element/type.dart'; import 'package:analyzer/source/line_info.dart'; import 'package:analyzer/src/dart/element/extensions.dart'; @@ -124,7 +124,7 @@ class InlineValueRegistrations extends FeatureRegistration /// is recorded multiple times. class _InlineValueCollector { /// A map of elements and their inline value. - final Map values = {}; + final Map values = {}; /// The range for which simple inline values should be returned. /// @@ -153,7 +153,7 @@ class _InlineValueCollector { /// /// Expression values are sent to the client without expressions because the /// client can use the range from the source to get the expression. - void recordExpression(Element2? element, int offset, int length) { + void recordExpression(analyzer.Element? element, int offset, int length) { assert(offset >= 0); assert(length > 0); if (element == null) return; @@ -180,7 +180,7 @@ class _InlineValueCollector { /// Variable inline values are sent to the client without names because the /// client can infer the name from the range and look it up from the debuggers /// Scopes/Variables. - void recordVariableLookup(Element2? element, int offset, int length) { + void recordVariableLookup(analyzer.Element? element, int offset, int length) { assert(offset >= 0); assert(length > 0); if (element == null || element.isWildcardVariable) return; @@ -214,10 +214,10 @@ class _InlineValueCollector { /// Returns whether [element] is something that should never be eagerly /// evaluated because of potential side-effects (such as `iterable.length`). - bool _isExcludedElement(Element2 element) { + bool _isExcludedElement(analyzer.Element element) { return switch (element) { - VariableElement2() => _isExcludedType(element.type), - GetterElement() => _isExcludedType(element.returnType), + analyzer.VariableElement() => _isExcludedType(element.type), + analyzer.GetterElement() => _isExcludedType(element.returnType), _ => false, }; } @@ -236,7 +236,7 @@ class _InlineValueCollector { /// Records an inline value [value] for [element] if it is within range and is /// the latest one in the source for that element. - void _record(InlineValue value, Element2 element) { + void _record(InlineValue value, analyzer.Element element) { // Don't create values for any elements that are excluded types. if (_isExcludedElement(element)) { return; @@ -307,8 +307,8 @@ class _InlineValueVisitor extends GeneralizingAstVisitor { // Never produce values for obvious enum getters (this includes `values`). var isEnumGetter = - node.element is GetterElement && - node.element?.enclosingElement2 is EnumElement2; + node.element is analyzer.GetterElement && + node.element?.enclosingElement2 is analyzer.EnumElement; if (!isTarget && !isEnumGetter) { collector.recordExpression(node.element, node.offset, node.length); @@ -347,8 +347,8 @@ class _InlineValueVisitor extends GeneralizingAstVisitor { var isInvocation = parent is InvocationExpression; if (!isTarget && !isInvocation) { switch (node.element) { - case LocalVariableElement2(name3: _?): - case FormalParameterElement(): + case analyzer.LocalVariableElement(name3: _?): + case analyzer.FormalParameterElement(): collector.recordVariableLookup( node.element, node.offset, diff --git a/pkg/analysis_server/lib/src/lsp/handlers/handler_references.dart b/pkg/analysis_server/lib/src/lsp/handlers/handler_references.dart index fcae3d4bd65..e9ad49b31fc 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/handler_references.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/handler_references.dart @@ -51,7 +51,7 @@ class ReferencesHandler ); } - List _getDeclarations(Element2 element) { + List _getDeclarations(Element element) { return element.nonSynthetic2.fragments .map((fragment) => fragmentToLocation(uriConverter, fragment)) .nonNulls @@ -68,8 +68,8 @@ class ReferencesHandler node = _getReferenceTargetNode(node); var element = switch (node?.getElement()) { - FieldFormalParameterElement2(:var field2?) => field2, - PropertyAccessorElement2(:var variable3?) => variable3, + FieldFormalParameterElement(:var field2?) => field2, + PropertyAccessorElement(:var variable3?) => variable3, var element => element, }; diff --git a/pkg/analysis_server/lib/src/lsp/handlers/handler_rename.dart b/pkg/analysis_server/lib/src/lsp/handlers/handler_rename.dart index 1a0c2da9035..6f5aeb602d3 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/handler_rename.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/handler_rename.dart @@ -321,7 +321,7 @@ class RenameHandler extends LspMessageHandler { bool _isClassRename(RenameRefactoring refactoring) => refactoring is RenameUnitMemberRefactoringImpl && - refactoring.element is InterfaceElement2; + refactoring.element is InterfaceElement; /// Asks the user whether they would like to rename the file along with the /// class. diff --git a/pkg/analysis_server/lib/src/lsp/handlers/handler_type_definition.dart b/pkg/analysis_server/lib/src/lsp/handlers/handler_type_definition.dart index 80542b14f71..4a7dc3b7989 100644 --- a/pkg/analysis_server/lib/src/lsp/handlers/handler_type_definition.dart +++ b/pkg/analysis_server/lib/src/lsp/handlers/handler_type_definition.dart @@ -9,7 +9,7 @@ import 'package:analysis_server/src/lsp/mapping.dart'; import 'package:analysis_server/src/lsp/registration/feature_registration.dart'; import 'package:analyzer/dart/ast/ast.dart'; import 'package:analyzer/dart/ast/syntactic_entity.dart'; -import 'package:analyzer/dart/element/element.dart'; +import 'package:analyzer/dart/element/element.dart' as analyzer; import 'package:analyzer/dart/element/type.dart'; import 'package:analyzer/source/line_info.dart'; import 'package:analyzer/src/dart/ast/extensions.dart'; @@ -85,7 +85,7 @@ class TypeDefinitionHandler if (node is NamedType) { originEntity = node.name2; var element = node.element2; - if (element case InterfaceElement2 element) { + if (element case analyzer.InterfaceElement element) { type = element.thisType; } } else if (node is VariableDeclaration) { @@ -105,13 +105,13 @@ class TypeDefinitionHandler return success(_emptyResult); } - Element2? element; + analyzer.Element? element; if (type is InterfaceType) { element = type.element3; } else if (type is TypeParameterType) { element = type.element3; } - if (element is! Element2) { + if (element is! analyzer.Element) { return success(_emptyResult); } @@ -155,9 +155,9 @@ class TypeDefinitionHandler /// Creates an LSP [Location] for navigating to [targetFragment]. Location _toLocation( - Fragment targetFragment, + analyzer.Fragment targetFragment, Range targetNameRange, - LibraryFragment targetUnit, + analyzer.LibraryFragment targetUnit, ) { return Location( uri: uriConverter.toClientUri(targetUnit.source.fullName), @@ -172,9 +172,9 @@ class TypeDefinitionHandler LocationLink _toLocationLink( SyntacticEntity originEntity, LineInfo originLineInfo, - Fragment targetFragment, + analyzer.Fragment targetFragment, Range targetNameRange, - LibraryFragment targetUnit, + analyzer.LibraryFragment targetUnit, ) { var (codeOffset, codeLength) = switch (targetFragment) { ElementImpl e => (e.codeOffset, e.codeLength), @@ -203,9 +203,9 @@ class TypeDefinitionHandler static DartType? _getType(Expression node) { if (node is SimpleIdentifier) { var element = node.element; - if (element case InterfaceElement2 element) { + if (element case analyzer.InterfaceElement element) { return element.thisType; - } else if (element case VariableElement2 element) { + } else if (element case analyzer.VariableElement element) { if (node.inDeclarationContext()) { return element.type; } @@ -216,8 +216,8 @@ class TypeDefinitionHandler } else if (node.inSetterContext()) { var writeElement = node.writeOrReadElement2; if (writeElement - case GetterElement(:var variable3) || - SetterElement(:var variable3)) { + case analyzer.GetterElement(:var variable3) || + analyzer.SetterElement(:var variable3)) { return variable3?.type; } } diff --git a/pkg/analysis_server/lib/src/protocol_server.dart b/pkg/analysis_server/lib/src/protocol_server.dart index 6465a5728b6..fa996082a2d 100644 --- a/pkg/analysis_server/lib/src/protocol_server.dart +++ b/pkg/analysis_server/lib/src/protocol_server.dart @@ -58,8 +58,8 @@ void doSourceChange_addSourceEdit( change.addEdit(file, isNewFile ? -1 : 0, edit); } -String? getAliasedTypeString(engine.Element2 element) { - if (element is engine.TypeAliasElement2) { +String? getAliasedTypeString(engine.Element element) { + if (element is engine.TypeAliasElement) { var aliasedType = element.aliasedType; return aliasedType.getDisplayString(); } @@ -68,8 +68,8 @@ String? getAliasedTypeString(engine.Element2 element) { /// Returns a color hex code (in the form '#FFFFFF') if [element] represents /// a color. -String? getColorHexString(engine.Element2? element) { - if (element is engine.VariableElement2) { +String? getColorHexString(engine.Element? element) { + if (element is engine.VariableElement) { var dartValue = element.computeConstantValue(); if (dartValue != null) { var color = ColorComputer.getColorForObject(dartValue); @@ -85,17 +85,17 @@ String? getColorHexString(engine.Element2? element) { return null; } -String? getReturnTypeString(engine.Element2 element) { - if (element is engine.ExecutableElement2) { +String? getReturnTypeString(engine.Element element) { + if (element is engine.ExecutableElement) { if (element.kind == engine.ElementKind.SETTER) { return null; } else { return element.returnType.getDisplayString(); } - } else if (element is engine.VariableElement2) { + } else if (element is engine.VariableElement) { var type = element.type; return type.getDisplayString(); - } else if (element is engine.TypeAliasElement2) { + } else if (element is engine.TypeAliasElement) { var aliasedType = element.aliasedType; if (aliasedType is FunctionType) { var returnType = aliasedType.returnType; @@ -236,8 +236,8 @@ DiagnosticMessage newDiagnosticMessage( ); } -/// Create a Location based on an [engine.Element2]. -Location? newLocation_fromElement(engine.Element2? element) { +/// Create a Location based on an [engine.Element]. +Location? newLocation_fromElement(engine.Element? element) { if (element == null) { return null; } @@ -297,7 +297,7 @@ Location newLocation_fromUnit( } /// Construct based on an element from the analyzer engine. -OverriddenMember newOverriddenMember_fromEngine(engine.Element2 member) { +OverriddenMember newOverriddenMember_fromEngine(engine.Element member) { var element = convertElement(member); var className = member.enclosingElement2!.displayName; return OverriddenMember(element, className); @@ -344,7 +344,7 @@ SourceEdit newSourceEdit_range( return SourceEdit(range.offset, range.length, replacement, id: id); } -List _computePath(engine.Element2 element) { +List _computePath(engine.Element element) { var path = []; for (var fragment in element.firstFragment.withAncestors) { if (fragment is engine.LibraryFragment) { @@ -355,8 +355,8 @@ List _computePath(engine.Element2 element) { return path; } -engine.LibraryFragment _getUnitElement(engine.Element2 element) { - if (element is engine.LibraryElement2) { +engine.LibraryFragment _getUnitElement(engine.Element element) { + if (element is engine.LibraryElement) { return element.firstFragment; } var fragment = element.firstFragment.libraryFragment; diff --git a/pkg/analysis_server/lib/src/search/element_references.dart b/pkg/analysis_server/lib/src/search/element_references.dart index 1be0ce14bd6..0d345da0a17 100644 --- a/pkg/analysis_server/lib/src/search/element_references.dart +++ b/pkg/analysis_server/lib/src/search/element_references.dart @@ -17,7 +17,7 @@ class ElementReferencesComputer { /// Computes [SearchMatch]es for [element] references. Future> compute( - Element2 element, + Element element, bool withPotential, { OperationPerformanceImpl? performance, }) async { @@ -47,9 +47,9 @@ class ElementReferencesComputer { } /// Returns a [Future] completing with a [List] of references to [element] or - /// to the corresponding hierarchy [Element2]s. + /// to the corresponding hierarchy [Element]s. Future> _findElementsReferences( - Element2 element, + Element element, OperationPerformanceImpl performance, ) async { var allResults = []; @@ -68,18 +68,18 @@ class ElementReferencesComputer { } /// Returns a [Future] completing with a [List] of references to [element]. - Future> _findSingleElementReferences(Element2 element) { + Future> _findSingleElementReferences(Element element) { return searchEngine.searchReferences(element); } - /// Returns a [Future] completing with [Element2]s to search references to. + /// Returns a [Future] completing with [Element]s to search references to. /// /// If an instance member or a named [FormalParameterElement] is given, each - /// corresponding [Element2] in the hierarchy is returned. + /// corresponding [Element] in the hierarchy is returned. /// /// Otherwise, only references to [element] should be searched. - Future> _getRefElements( - Element2 element, + Future> _getRefElements( + Element element, OperationPerformanceImpl performance, ) async { if (element is FormalParameterElement && element.isNamed) { @@ -88,9 +88,9 @@ class ElementReferencesComputer { (_) => getHierarchyNamedParameters(searchEngine, element), ); } - if (element is MethodElement2 || - element is FieldElement2 || - element is ConstructorElement2) { + if (element is MethodElement || + element is FieldElement || + element is ConstructorElement) { var (members, parameters) = await performance.runAsync( 'getHierarchyMembers', (performance) => getHierarchyMembersAndParameters( @@ -110,10 +110,10 @@ class ElementReferencesComputer { return newSearchResult_fromMatch(match); } - static bool _isMemberElement(Element2 element) { - if (element is ConstructorElement2) { + static bool _isMemberElement(Element element) { + if (element is ConstructorElement) { return false; } - return element.enclosingElement2 is InterfaceElement2; + return element.enclosingElement2 is InterfaceElement; } } diff --git a/pkg/analysis_server/lib/src/search/type_hierarchy.dart b/pkg/analysis_server/lib/src/search/type_hierarchy.dart index 92574f98906..d2de0f87179 100644 --- a/pkg/analysis_server/lib/src/search/type_hierarchy.dart +++ b/pkg/analysis_server/lib/src/search/type_hierarchy.dart @@ -11,17 +11,17 @@ import 'package:analysis_server/src/services/search/search_engine.dart'; import 'package:analyzer/dart/element/element.dart'; import 'package:analyzer/dart/element/type.dart'; -/// A computer for a type hierarchy of an [Element2]. +/// A computer for a type hierarchy of an [Element]. class TypeHierarchyComputer { final SearchEngine _searchEngine; final TypeHierarchyComputerHelper helper; final List _items = []; - final List _itemClassElements = []; - final Map _elementItemMap = - HashMap(); + final List _itemClassElements = []; + final Map _elementItemMap = + HashMap(); - TypeHierarchyComputer(this._searchEngine, Element2 pivotElement) + TypeHierarchyComputer(this._searchEngine, Element pivotElement) : helper = TypeHierarchyComputerHelper.fromElement(pivotElement); /// Returns the computed type hierarchy, maybe `null`. @@ -49,7 +49,7 @@ class TypeHierarchyComputer { Future _createSubclasses( TypeHierarchyItem item, int itemId, - InterfaceElement2 classElement, + InterfaceElement classElement, SearchEngineCache searchEngineCache, ) async { var subElements = await getDirectSubClasses( @@ -100,7 +100,7 @@ class TypeHierarchyComputer { } int _createSuperItem( - InterfaceElement2 classElement, + InterfaceElement classElement, List? typeArguments, ) { // check for recursion @@ -160,12 +160,12 @@ class TypeHierarchyComputer { } class TypeHierarchyComputerHelper { - final Element2 pivotElement; - final LibraryElement2 pivotLibrary; + final Element pivotElement; + final LibraryElement pivotLibrary; final ElementKind pivotKind; final String? pivotName; final bool pivotFieldFinal; - final InterfaceElement2? pivotClass; + final InterfaceElement? pivotClass; TypeHierarchyComputerHelper( this.pivotElement, @@ -176,19 +176,19 @@ class TypeHierarchyComputerHelper { this.pivotClass, ); - factory TypeHierarchyComputerHelper.fromElement(Element2 pivotElement) { + factory TypeHierarchyComputerHelper.fromElement(Element pivotElement) { // try to find enclosing ClassElement - Element2? element = pivotElement; + Element? element = pivotElement; bool pivotFieldFinal = false; - if (pivotElement is FieldElement2) { + if (pivotElement is FieldElement) { pivotFieldFinal = pivotElement.isFinal; element = pivotElement.enclosingElement2; } - if (pivotElement is ExecutableElement2) { + if (pivotElement is ExecutableElement) { element = pivotElement.enclosingElement2; } - InterfaceElement2? pivotClass; - if (element is InterfaceElement2) { + InterfaceElement? pivotClass; + if (element is InterfaceElement) { pivotClass = element; } @@ -202,10 +202,10 @@ class TypeHierarchyComputerHelper { ); } - ExecutableElement2? findMemberElement(InterfaceElement2 clazz) { + ExecutableElement? findMemberElement(InterfaceElement clazz) { // Members of extension types don't override anything. // They redeclare, and resolved statically. - if (pivotClass is ExtensionTypeElement2 || clazz is ExtensionTypeElement2) { + if (pivotClass is ExtensionTypeElement || clazz is ExtensionTypeElement) { return null; } @@ -213,7 +213,7 @@ class TypeHierarchyComputerHelper { if (pivotName == null) { return null; } - ExecutableElement2? result; + ExecutableElement? result; // try to find in the class itself if (pivotKind == ElementKind.METHOD) { result = clazz.getMethod2(pivotName); diff --git a/pkg/analysis_server/lib/src/services/completion/dart/candidate_suggestion.dart b/pkg/analysis_server/lib/src/services/completion/dart/candidate_suggestion.dart index a83e66171eb..df8056bda0c 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/candidate_suggestion.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/candidate_suggestion.dart @@ -50,7 +50,7 @@ sealed class CandidateSuggestion { final class ClassSuggestion extends ImportableSuggestion implements ElementBasedSuggestion { @override - final ClassElement2 element; + final ClassElement element; /// Initialize a newly created candidate suggestion to suggest the [element]. ClassSuggestion({ @@ -146,7 +146,7 @@ final class ClosureSuggestion extends CandidateSuggestion with SuggestionData { final class ConstructorSuggestion extends ExecutableSuggestion implements ElementBasedSuggestion { @override - final ConstructorElement2 element; + final ConstructorElement element; /// Whether the class name is already, implicitly or explicitly, at the call /// site. That is, whether we are completing after a period. @@ -213,7 +213,7 @@ final class ConstructorSuggestion extends ExecutableSuggestion abstract interface class ElementBasedSuggestion { /// The element on which the suggestion is based. - Element2 get element; + Element get element; } /// The information about a candidate suggestion based on a static field in a @@ -222,7 +222,7 @@ abstract interface class ElementBasedSuggestion { final class EnumConstantSuggestion extends ImportableSuggestion implements ElementBasedSuggestion { @override - final FieldElement2 element; + final FieldElement element; /// Whether the name of the enum should be included in the completion. final bool includeEnumName; @@ -250,7 +250,7 @@ final class EnumConstantSuggestion extends ImportableSuggestion final class EnumSuggestion extends ImportableSuggestion implements ElementBasedSuggestion { @override - final EnumElement2 element; + final EnumElement element; /// Initialize a newly created candidate suggestion to suggest the [element]. EnumSuggestion({ @@ -287,7 +287,7 @@ sealed class ExecutableSuggestion extends ImportableSuggestion { final class ExtensionSuggestion extends ExecutableSuggestion implements ElementBasedSuggestion { @override - final ExtensionElement2 element; + final ExtensionElement element; /// Initialize a newly created candidate suggestion to suggest the [element]. ExtensionSuggestion({ @@ -305,7 +305,7 @@ final class ExtensionSuggestion extends ExecutableSuggestion final class ExtensionTypeSuggestion extends ImportableSuggestion implements ElementBasedSuggestion { @override - final ExtensionTypeElement2 element; + final ExtensionTypeElement element; /// Initialize a newly created candidate suggestion to suggest the [element]. ExtensionTypeSuggestion({ @@ -321,12 +321,12 @@ final class ExtensionTypeSuggestion extends ImportableSuggestion /// The information about a candidate suggestion based on a field. final class FieldSuggestion extends CandidateSuggestion with MemberSuggestion { @override - final FieldElement2 element; + final FieldElement element; /// The element defined by the declaration in which the suggestion is to be /// applied, or `null` if the completion is in a static context. @override - final InterfaceElement2? referencingInterface; + final InterfaceElement? referencingInterface; /// Indicates the context, whether the completion is in the body of the /// declaration. @@ -395,7 +395,7 @@ final class GetterSuggestion extends ImportableSuggestion /// The element defined by the declaration in which the suggestion is to be /// applied, or `null` if the completion is in a static context. @override - final InterfaceElement2? referencingInterface; + final InterfaceElement? referencingInterface; /// Whether the accessor is being invoked with a target. final bool withEnclosingName; @@ -424,9 +424,9 @@ final class GetterSuggestion extends ImportableSuggestion /// we either fail with assertion, or return `null`. String? get _enclosingClassOrExtensionName { var enclosing = element.enclosingElement2; - if (enclosing is InterfaceElement2) { + if (enclosing is InterfaceElement) { return enclosing.displayName; - } else if (enclosing is ExtensionElement2) { + } else if (enclosing is ExtensionElement) { return enclosing.displayName; } else { assert(false, 'Expected ClassElement or ExtensionElement'); @@ -523,9 +523,9 @@ final class ImportData { /// A suggestion based on an import prefix. final class ImportPrefixSuggestion extends CandidateSuggestion implements ElementBasedSuggestion { - final LibraryElement2 libraryElement; + final LibraryElement libraryElement; - final PrefixElement2 prefixElement; + final PrefixElement prefixElement; ImportPrefixSuggestion({ required this.libraryElement, @@ -537,7 +537,7 @@ final class ImportPrefixSuggestion extends CandidateSuggestion String get completion => prefixElement.displayName; @override - Element2 get element => prefixElement; + Element get element => prefixElement; } /// The information about a candidate suggestion based on a keyword. @@ -656,7 +656,7 @@ final class LocalFunctionSuggestion extends ExecutableSuggestion final class LocalVariableSuggestion extends CandidateSuggestion implements ElementBasedSuggestion { @override - final LocalVariableElement2 element; + final LocalVariableElement element; /// The number of local variables between the completion location and the /// declaration of this variable. @@ -678,7 +678,7 @@ final class LocalVariableSuggestion extends CandidateSuggestion mixin MemberSuggestion implements ElementBasedSuggestion { /// The element defined by the declaration in which the suggestion is to be /// applied, or `null` if the completion is in a static context. - InterfaceElement2? get referencingInterface; + InterfaceElement? get referencingInterface; /// Returns the value of the inheritance distance feature. /// @@ -686,10 +686,10 @@ mixin MemberSuggestion implements ElementBasedSuggestion { double inheritanceDistance(FeatureComputer featureComputer) { var inheritanceDistance = 0.0; var element = this.element; - if (!(element is FieldElement2 && element.isEnumConstant)) { + if (!(element is FieldElement && element.isEnumConstant)) { var declaringClass = element.enclosingElement2; var referencingInterface = this.referencingInterface; - if (referencingInterface != null && declaringClass is InterfaceElement2) { + if (referencingInterface != null && declaringClass is InterfaceElement) { inheritanceDistance = featureComputer.inheritanceDistanceFeature( referencingInterface, declaringClass, @@ -704,12 +704,12 @@ mixin MemberSuggestion implements ElementBasedSuggestion { final class MethodSuggestion extends ExecutableSuggestion with MemberSuggestion { @override - final MethodElement2 element; + final MethodElement element; /// The element defined by the declaration in which the suggestion is to be /// applied, or `null` if the completion is in a static context. @override - final InterfaceElement2? referencingInterface; + final InterfaceElement? referencingInterface; /// Initialize a newly created candidate suggestion to suggest the [element]. MethodSuggestion({ @@ -728,7 +728,7 @@ final class MethodSuggestion extends ExecutableSuggestion final class MixinSuggestion extends ImportableSuggestion implements ElementBasedSuggestion { @override - final MixinElement2 element; + final MixinElement element; /// Initialize a newly created candidate suggestion to suggest the [element]. MixinSuggestion({ @@ -852,7 +852,7 @@ class OverrideData { final class OverrideSuggestion extends CandidateSuggestion implements ElementBasedSuggestion { @override - final ExecutableElement2 element; + final ExecutableElement element; /// Whether `super` should be invoked in the body of the override. final bool shouldInvokeSuper; @@ -957,12 +957,12 @@ final class RecordLiteralNamedFieldSuggestion extends CandidateSuggestion final class SetStateMethodSuggestion extends ExecutableSuggestion with MemberSuggestion, SuggestionData { @override - final MethodElement2 element; + final MethodElement element; /// The element defined by the declaration in which the suggestion is to be /// applied, or `null` if the completion is in a static context. @override - final InterfaceElement2? referencingInterface; + final InterfaceElement? referencingInterface; /// The identation to be used for a multi-line completion. final String indent; @@ -1009,7 +1009,7 @@ final class SetterSuggestion extends ImportableSuggestion /// The element defined by the declaration in which the suggestion is to be /// applied, or `null` if the completion is in a static context. @override - final InterfaceElement2? referencingInterface; + final InterfaceElement? referencingInterface; /// Whether the accessor is being invoked with a target. final bool withEnclosingName; @@ -1038,9 +1038,9 @@ final class SetterSuggestion extends ImportableSuggestion /// we either fail with assertion, or return `null`. String? get _enclosingClassOrExtensionName { var enclosing = element.enclosingElement2; - if (enclosing is InterfaceElement2) { + if (enclosing is InterfaceElement) { return enclosing.displayName; - } else if (enclosing is ExtensionElement2) { + } else if (enclosing is ExtensionElement) { return enclosing.displayName; } else { assert(false, 'Expected ClassElement or ExtensionElement'); @@ -1063,7 +1063,7 @@ final class SetterSuggestion extends ImportableSuggestion final class StaticFieldSuggestion extends ImportableSuggestion implements ElementBasedSuggestion { @override - final FieldElement2 element; + final FieldElement element; /// Initialize a newly created candidate suggestion to suggest the [element]. StaticFieldSuggestion({ @@ -1174,7 +1174,7 @@ final class TopLevelSetterSuggestion extends ImportableSuggestion final class TopLevelVariableSuggestion extends ImportableSuggestion implements ElementBasedSuggestion { @override - final TopLevelVariableElement2 element; + final TopLevelVariableElement element; /// Initialize a newly created candidate suggestion to suggest the [element]. TopLevelVariableSuggestion({ @@ -1191,7 +1191,7 @@ final class TopLevelVariableSuggestion extends ImportableSuggestion final class TypeAliasSuggestion extends ImportableSuggestion implements ElementBasedSuggestion { @override - final TypeAliasElement2 element; + final TypeAliasElement element; /// Initialize a newly created candidate suggestion to suggest the [element]. TypeAliasSuggestion({ @@ -1208,7 +1208,7 @@ final class TypeAliasSuggestion extends ImportableSuggestion final class TypeParameterSuggestion extends CandidateSuggestion implements ElementBasedSuggestion { @override - final TypeParameterElement2 element; + final TypeParameterElement element; /// Initialize a newly created candidate suggestion to suggest the [element]. TypeParameterSuggestion({required this.element, required super.matcherScore}); diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart index f3b1a578394..587f2e27899 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart @@ -250,7 +250,7 @@ class DartCompletionRequest { final FeatureComputer featureComputer; /// The library element of the file in which completion is requested. - final LibraryElement2 libraryElement; + final LibraryElement libraryElement; /// The library fragment of the file in which completion is requested. final LibraryFragment libraryFragment; diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_state.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_state.dart index e87e9f94386..903c3546a96 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/completion_state.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_state.dart @@ -58,7 +58,7 @@ class CompletionState { } /// The element of the library containing the completion location. - LibraryElement2 get libraryElement => request.libraryElement; + LibraryElement get libraryElement => request.libraryElement; /// The type of quotes preferred for [String]s as specified in [CodeStyleOptions]. String get preferredQuoteForStrings => diff --git a/pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart b/pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart index 8e36af61d5e..67ab2281d49 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/declaration_helper.dart @@ -161,7 +161,7 @@ class DeclarationHelper { } /// Add suggestions for all constructors of [element]. - void addConstructorNamesForElement({required InterfaceElement2 element}) { + void addConstructorNamesForElement({required InterfaceElement element}) { var constructors = element.constructors2; for (var constructor in constructors) { _suggestConstructor( @@ -197,7 +197,7 @@ class DeclarationHelper { } /// Add suggestions for declarations through [prefixElement]. - void addDeclarationsThroughImportPrefix(PrefixElement2 prefixElement) { + void addDeclarationsThroughImportPrefix(PrefixElement prefixElement) { for (var importElement in prefixElement.imports) { var importedLibrary = importElement.importedLibrary2; if (importedLibrary == null) { @@ -232,7 +232,7 @@ class DeclarationHelper { /// be skipped because the cursor is inside that field's name. void addFieldsForInitializers( ConstructorDeclaration constructor, - FieldElement2? fieldToInclude, + FieldElement? fieldToInclude, ) { var constructorElement = constructor.declaredFragment?.element; var containingElement = constructorElement?.enclosingElement2; @@ -240,12 +240,12 @@ class DeclarationHelper { return; } - var fieldsToSkip = {}; + var fieldsToSkip = {}; // Skip fields that are already initialized in the initializer list. for (var initializer in constructor.initializers) { if (initializer is ConstructorFieldInitializer) { var fieldElement = initializer.fieldName.element; - if (fieldElement is FieldElement2) { + if (fieldElement is FieldElement) { fieldsToSkip.add(fieldElement); } } @@ -255,7 +255,7 @@ class DeclarationHelper { parameter = parameter.notDefault; if (parameter is FieldFormalParameter) { var parameterElement = parameter.declaredFragment?.element; - if (parameterElement is FieldFormalParameterElement2) { + if (parameterElement is FieldFormalParameterElement) { var field = parameterElement.field2; if (field != null) { fieldsToSkip.add(field); @@ -279,7 +279,7 @@ class DeclarationHelper { /// Add suggestions for all of the top-level declarations that are exported /// from the [library] except for those whose name is in the set of /// [excludedNames]. - void addFromLibrary(LibraryElement2 library, Set excludedNames) { + void addFromLibrary(LibraryElement library, Set excludedNames) { for (var entry in library.exportNamespace.definedNames2.entries) { if (!excludedNames.contains(entry.key)) { _addImportedElement(entry.value); @@ -430,9 +430,9 @@ class DeclarationHelper { } } - /// Add members from the given [ExtensionElement2]. + /// Add members from the given [ExtensionElement]. void addMembersFromExtensionElement( - ExtensionElement2 extension, { + ExtensionElement extension, { ImportData? importData, required Set excludedGetters, required bool includeMethods, @@ -482,7 +482,7 @@ class DeclarationHelper { /// Adds suggestions for any constructors that are visible within the not yet /// imported [library]. - void addNotImportedConstructors(LibraryElement2 library) { + void addNotImportedConstructors(LibraryElement library) { var importData = ImportData( libraryUri: library.uri, prefix: null, @@ -494,7 +494,7 @@ class DeclarationHelper { /// Add members from all the applicable extensions that are visible in the /// not yet imported [library] that are applicable for the given [type]. void addNotImportedExtensionMethods({ - required LibraryElement2 library, + required LibraryElement library, required DartType type, required Set excludedGetters, required bool includeMethods, @@ -502,7 +502,7 @@ class DeclarationHelper { }) { var libraryElement = library; var applicableExtensions = library.exportNamespace.definedNames2.values - .whereType() + .whereType() .applicableTo( targetLibrary: libraryElement, // Ignore nullability, consistent with non-extension members. @@ -534,7 +534,7 @@ class DeclarationHelper { /// Adds suggestions for any top-level declarations that are visible within /// the not yet imported [library]. - void addNotImportedTopLevelDeclarations(LibraryElement2 library) { + void addNotImportedTopLevelDeclarations(LibraryElement library) { var importData = ImportData( libraryUri: library.uri, prefix: null, @@ -603,8 +603,8 @@ class DeclarationHelper { /// Add suggestions for all of the constructor in the [library] that could be /// a redirection target for the [redirectingConstructor]. void addPossibleRedirectionsInLibrary( - ConstructorElement2 redirectingConstructor, - LibraryElement2 library, + ConstructorElement redirectingConstructor, + LibraryElement library, ) { var classElement = redirectingConstructor.enclosingElement2; var classType = classElement.thisType; @@ -627,15 +627,15 @@ class DeclarationHelper { } /// Add any static members defined by the given [element]. - void addStaticMembersOfElement(Element2 element) { - if (element is TypeAliasElement2) { + void addStaticMembersOfElement(Element element) { + if (element is TypeAliasElement) { var aliasedType = element.aliasedType; if (aliasedType is InterfaceType) { element = aliasedType.element3; } } switch (element) { - case EnumElement2(): + case EnumElement(): _addStaticMembers( getters: element.getters2, setters: element.setters2, @@ -644,7 +644,7 @@ class DeclarationHelper { fields: element.fields2, methods: element.methods2, ); - case ExtensionElement2(): + case ExtensionElement(): _addStaticMembers( getters: element.getters2, setters: element.setters2, @@ -653,7 +653,7 @@ class DeclarationHelper { fields: element.fields2, methods: element.methods2, ); - case InterfaceElement2(): + case InterfaceElement(): _addStaticMembers( getters: element.getters2, setters: element.setters2, @@ -667,7 +667,7 @@ class DeclarationHelper { /// Adds suggestions for any constructors that are declared within the /// [library]. - void _addConstructors(LibraryElement2 library, ImportData importData) { + void _addConstructors(LibraryElement library, ImportData importData) { for (var element in library.classes) { _suggestConstructors( element.constructors2, @@ -689,19 +689,19 @@ class DeclarationHelper { /// Adds suggestions for any constructors that are visible through type /// aliases declared within the `importData.libraryUri`. void _addConstructorsForAliasedElement( - TypeAliasElement2 alias, + TypeAliasElement alias, ImportData? importData, ) { var aliasedElement = alias.aliasedElement2; - if (aliasedElement is ClassElement2) { + if (aliasedElement is ClassElement) { _suggestConstructors( aliasedElement.constructors2, importData, allowNonFactory: !aliasedElement.isAbstract, ); - } else if (aliasedElement is ExtensionTypeElement2) { + } else if (aliasedElement is ExtensionTypeElement) { _suggestConstructors(aliasedElement.constructors2, importData); - } else if (aliasedElement is MixinElement2) { + } else if (aliasedElement is MixinElement) { _suggestConstructors(aliasedElement.constructors2, importData); } } @@ -709,7 +709,7 @@ class DeclarationHelper { /// Adds suggestions for any constructors that are visible within the /// [library]. void _addConstructorsImportedFrom({ - required LibraryElement2 library, + required LibraryElement library, required Namespace namespace, required String? prefix, }) { @@ -720,15 +720,15 @@ class DeclarationHelper { ); for (var element in namespace.definedNames2.values) { switch (element) { - case ClassElement2(): + case ClassElement(): _suggestConstructors( element.constructors2, importData, allowNonFactory: !element.isAbstract, ); - case ExtensionTypeElement2(): + case ExtensionTypeElement(): _suggestConstructors(element.constructors2, importData); - case TypeAliasElement2(): + case TypeAliasElement(): _addConstructorsForAliasedElement(element, importData); } } @@ -737,7 +737,7 @@ class DeclarationHelper { /// Adds suggestions for any top-level declarations that are visible within /// the [library]. void _addDeclarationsImportedFrom({ - required LibraryElement2 library, + required LibraryElement library, required Namespace namespace, required String? prefix, }) { @@ -799,7 +799,7 @@ class DeclarationHelper { } else { // All fields induce a getter. var variable = getter.variable3; - if (variable is FieldElement2) { + if (variable is FieldElement) { _suggestField(field: variable); } } @@ -828,27 +828,27 @@ class DeclarationHelper { /// /// The [importData] indicates how the library is, or should be, imported. void _addExternalTopLevelDeclarations({ - required LibraryElement2 library, + required LibraryElement library, required Namespace namespace, required ImportData importData, }) { for (var element in namespace.definedNames2.values) { switch (element) { - case ClassElement2(): + case ClassElement(): _suggestClass(element, importData); - case EnumElement2(): + case EnumElement(): _suggestEnum(element, importData); - case ExtensionElement2(): + case ExtensionElement(): if (!mustBeType) { _suggestExtension(element, importData); } - case ExtensionTypeElement2(): + case ExtensionTypeElement(): _suggestExtensionType(element, importData); case TopLevelFunctionElement(): if (!mustBeType) { _suggestTopLevelFunction(element, importData); } - case MixinElement2(): + case MixinElement(): _suggestMixin(element, importData); case GetterElement(): if (!mustBeType) { @@ -864,11 +864,11 @@ class DeclarationHelper { } _suggestTopLevelProperty(element, importData); } - case TopLevelVariableElement2(): + case TopLevelVariableElement(): if (!mustBeType) { _suggestTopLevelVariable(element, importData); } - case TypeAliasElement2(): + case TypeAliasElement(): _suggestTypeAlias(element, importData); } } @@ -893,7 +893,7 @@ class DeclarationHelper { /// Adds suggestions for any constructors that are imported into the /// [library]. - void _addImportedConstructors(LibraryElement2 library) { + void _addImportedConstructors(LibraryElement library) { // TODO(brianwilkerson): This will create suggestions for elements that // conflict with different elements imported from a different library. Not // sure whether that's the desired behavior. @@ -911,7 +911,7 @@ class DeclarationHelper { /// Adds suggestions for any top-level declarations that are imported into the /// [library]. - void _addImportedDeclarations(LibraryElement2 library) { + void _addImportedDeclarations(LibraryElement library) { // TODO(brianwilkerson): This will create suggestions for elements that // conflict with different elements imported from a different library. Not // sure whether that's the desired behavior. @@ -937,26 +937,26 @@ class DeclarationHelper { } /// Adds a suggestion for the top-level [element]. - void _addImportedElement(Element2 element) { + void _addImportedElement(Element element) { var matcherScore = state.matcher.score(element.displayName); if (matcherScore != -1) { var suggestion = switch (element) { - ClassElement2() => ClassSuggestion( + ClassElement() => ClassSuggestion( importData: null, element: element, matcherScore: matcherScore, ), - EnumElement2() => EnumSuggestion( + EnumElement() => EnumSuggestion( importData: null, element: element, matcherScore: matcherScore, ), - ExtensionElement2() => ExtensionSuggestion( + ExtensionElement() => ExtensionSuggestion( importData: null, element: element, matcherScore: matcherScore, ), - ExtensionTypeElement2() => ExtensionTypeSuggestion( + ExtensionTypeElement() => ExtensionTypeSuggestion( importData: null, element: element, matcherScore: matcherScore, @@ -967,21 +967,21 @@ class DeclarationHelper { kind: _executableSuggestionKind, matcherScore: matcherScore, ), - MixinElement2() => MixinSuggestion( + MixinElement() => MixinSuggestion( importData: null, element: element, matcherScore: matcherScore, ), - PropertyAccessorElement2() => _createSuggestionFromTopLevelProperty( + PropertyAccessorElement() => _createSuggestionFromTopLevelProperty( element, matcherScore, ), - TopLevelVariableElement2() => TopLevelVariableSuggestion( + TopLevelVariableElement() => TopLevelVariableSuggestion( importData: null, element: element, matcherScore: matcherScore, ), - TypeAliasElement2() => TypeAliasSuggestion( + TypeAliasElement() => TypeAliasSuggestion( importData: null, element: element, matcherScore: matcherScore, @@ -1008,7 +1008,7 @@ class DeclarationHelper { _ => null, }; var element = fragment?.element; - if (!mustBeStatic && element is ExtensionElement2) { + if (!mustBeStatic && element is ExtensionElement) { var thisType = element.thisType; if (thisType is InterfaceType) { _addInstanceMembers( @@ -1020,19 +1020,19 @@ class DeclarationHelper { } return; } - if (element is! InterfaceElement2) { + if (element is! InterfaceElement) { return; } var referencingInterface = _referencingInterfaceFor(element); var members = request.inheritanceManager.getInheritedMap(element); for (var member in members.values) { switch (member) { - case MethodElement2(): + case MethodElement(): _suggestMethod( method: member, referencingInterface: referencingInterface, ); - case PropertyAccessorElement2(): + case PropertyAccessorElement(): _suggestProperty( accessor: member, referencingInterface: referencingInterface, @@ -1064,12 +1064,12 @@ class DeclarationHelper { ? request.inheritanceManager.getInheritedConcreteMap(type.element3) : request.inheritanceManager.getInterface2(type.element3).map2; - var membersByName = >{}; + var membersByName = >{}; for (var rawMember in map.values) { if (_canAccessInstanceMember(rawMember)) { var name = rawMember.displayName; membersByName - .putIfAbsent(name, () => []) + .putIfAbsent(name, () => []) .add(rawMember); } } @@ -1077,7 +1077,7 @@ class DeclarationHelper { for (var entry in membersByName.entries) { var members = entry.value; var rawMember = members.bestMember; - if (rawMember is MethodElement2) { + if (rawMember is MethodElement) { if (includeMethods) { if (rawMember.isOperator) { continue; @@ -1085,7 +1085,7 @@ class DeclarationHelper { // Exclude static methods when completion on an instance. var member = ExecutableMember.from(rawMember, substitution); _suggestMethod( - method: member as MethodElement2, + method: member as MethodElement, referencingInterface: referencingInterface, ); } @@ -1093,7 +1093,7 @@ class DeclarationHelper { if (!excludedGetters.contains(entry.key)) { var member = ExecutableMember.from(rawMember, substitution); _suggestProperty( - accessor: member as PropertyAccessorElement2, + accessor: member as PropertyAccessorElement, referencingInterface: referencingInterface, ); } @@ -1101,7 +1101,7 @@ class DeclarationHelper { if (includeSetters) { var member = ExecutableMember.from(rawMember, substitution); _suggestProperty( - accessor: member as PropertyAccessorElement2, + accessor: member as PropertyAccessorElement, referencingInterface: referencingInterface, ); } @@ -1269,7 +1269,7 @@ class DeclarationHelper { } /// Completion is inside the declaration of the [element]. - void _addMembersOfEnclosingInstance(InstanceElement2 element) { + void _addMembersOfEnclosingInstance(InstanceElement element) { var referencingInterface = _referencingInterfaceFor(element); for (var accessor in element.getters2) { @@ -1370,7 +1370,7 @@ class DeclarationHelper { } case GenericTypeAlias(): var element = declaration.declaredFragment?.element; - if (element is TypeAliasElement2) { + if (element is TypeAliasElement) { _suggestTypeParameters(element.typeParameters2); } case MixinDeclaration(): @@ -1389,10 +1389,10 @@ class DeclarationHelper { void _addStaticMembers({ required List getters, required List setters, - required List constructors, - required Element2 containingElement, - required List fields, - required List methods, + required List constructors, + required Element containingElement, + required List fields, + required List methods, }) { for (var getter in getters) { if (getter.isStatic && @@ -1411,7 +1411,7 @@ class DeclarationHelper { for (var field in fields) { if (field.isStatic && (!field.isSynthetic || - (containingElement is EnumElement2 && field.name3 == 'values')) && + (containingElement is EnumElement && field.name3 == 'values')) && field.isVisibleIn(request.libraryElement)) { if (field.isEnumConstant) { var enumElement = field.enclosingElement2; @@ -1434,7 +1434,7 @@ class DeclarationHelper { } if (!mustBeAssignable) { var allowNonFactory = - containingElement is ClassElement2 && !containingElement.isAbstract; + containingElement is ClassElement && !containingElement.isAbstract; for (var constructor in constructors) { if (constructor.isVisibleIn(request.libraryElement) && (allowNonFactory || constructor.isFactory)) { @@ -1458,7 +1458,7 @@ class DeclarationHelper { /// the [library]. /// /// The [library] is the library in which completion is being requested. - void _addTopLevelDeclarations(LibraryElement2 library) { + void _addTopLevelDeclarations(LibraryElement library) { for (var element in library.classes) { _suggestClass(element, null); } @@ -1505,7 +1505,7 @@ class DeclarationHelper { } } - bool _canAccessInstanceMember(ExecutableElement2 element) { + bool _canAccessInstanceMember(ExecutableElement element) { if (element.isStatic) { return false; } @@ -1527,7 +1527,7 @@ class DeclarationHelper { if (element.isProtected) { var elementInterface = element.enclosingElement2; - if (elementInterface is! InterfaceElement2) { + if (elementInterface is! InterfaceElement) { return false; } @@ -1566,14 +1566,14 @@ class DeclarationHelper { } ImportableSuggestion? _createSuggestionFromTopLevelProperty( - PropertyAccessorElement2 element, + PropertyAccessorElement element, double matcherScore, { ImportData? importData, }) { if (element.isSynthetic) { if (element is GetterElement) { var variable = element.variable3; - if (variable is TopLevelVariableElement2) { + if (variable is TopLevelVariableElement) { return TopLevelVariableSuggestion( importData: importData, element: variable, @@ -1609,12 +1609,12 @@ class DeclarationHelper { /// Returns the interface element for the type of `this` within the /// declaration of the given class-like [element]. - InterfaceElement2? _referencingInterfaceFor(Element2 element) { - if (element is InterfaceElement2) { + InterfaceElement? _referencingInterfaceFor(Element element) { + if (element is InterfaceElement) { return element; - } else if (element is InstanceElement2) { + } else if (element is InstanceElement) { var thisElement = element.thisType.element3; - if (thisElement is InterfaceElement2) { + if (thisElement is InterfaceElement) { return thisElement; } } @@ -1622,7 +1622,7 @@ class DeclarationHelper { } /// Adds a suggestion for the class represented by the [element]. - void _suggestClass(ClassElement2 element, ImportData? importData) { + void _suggestClass(ClassElement element, ImportData? importData) { if (visibilityTracker.isVisible(element: element, importData: importData)) { if ((mustBeExtendable && !element.isExtendableIn2(request.libraryElement)) || @@ -1655,7 +1655,7 @@ class DeclarationHelper { /// Adds a suggestion for the constructor represented by the [element]. void _suggestConstructor( - ConstructorElement2 element, { + ConstructorElement element, { required ImportData? importData, required bool hasClassName, required bool isConstructorRedirect, @@ -1711,7 +1711,7 @@ class DeclarationHelper { /// Adds a suggestion for each of the [constructors]. void _suggestConstructors( - List constructors, + List constructors, ImportData? importData, { bool allowNonFactory = true, }) { @@ -1732,7 +1732,7 @@ class DeclarationHelper { } /// Adds a suggestion for the enum represented by the [element]. - void _suggestEnum(EnumElement2 element, ImportData? importData) { + void _suggestEnum(EnumElement element, ImportData? importData) { if (visibilityTracker.isVisible(element: element, importData: importData)) { if (mustBeExtendable || mustBeImplementable || mustBeMixable) { return; @@ -1759,7 +1759,7 @@ class DeclarationHelper { } /// Adds a suggestion for the extension represented by the [element]. - void _suggestExtension(ExtensionElement2 element, ImportData? importData) { + void _suggestExtension(ExtensionElement element, ImportData? importData) { if (visibilityTracker.isVisible(element: element, importData: importData)) { if (mustBeExtendable || mustBeImplementable || mustBeMixable) { return; @@ -1785,7 +1785,7 @@ class DeclarationHelper { /// Adds a suggestion for the extension type represented by the [element]. void _suggestExtensionType( - ExtensionTypeElement2 element, + ExtensionTypeElement element, ImportData? importData, ) { if (visibilityTracker.isVisible(element: element, importData: importData)) { @@ -1815,8 +1815,8 @@ class DeclarationHelper { /// [referencingInterface] is provided, it should be the class in which /// completion was requested. void _suggestField({ - required FieldElement2 field, - InterfaceElement2? referencingInterface, + required FieldElement field, + InterfaceElement? referencingInterface, bool isInDeclaration = false, }) { if (visibilityTracker.isVisible(element: field, importData: null)) { @@ -1846,7 +1846,7 @@ class DeclarationHelper { } /// Adds a suggestion for the local function represented by the [element]. - void _suggestLocalFunction(ExecutableElement2 element) { + void _suggestLocalFunction(ExecutableElement element) { if (element is LocalFunctionElement && visibilityTracker.isVisible(element: element, importData: null)) { if (mustBeAssignable || @@ -1879,10 +1879,10 @@ class DeclarationHelper { /// [referencingInterface] is provided, it should be the class in which /// completion was requested. void _suggestMethod({ - required MethodElement2 method, + required MethodElement method, bool ignoreVisibility = false, ImportData? importData, - InterfaceElement2? referencingInterface, + InterfaceElement? referencingInterface, }) { if (ignoreVisibility || visibilityTracker.isVisible(element: method, importData: importData)) { @@ -1895,7 +1895,7 @@ class DeclarationHelper { if (matcherScore != -1) { var enclosingElement = method.enclosingElement2; if (method.name3 == 'setState' && - enclosingElement is ClassElement2 && + enclosingElement is ClassElement && enclosingElement.isExactState) { var suggestion = SetStateMethodSuggestion( element: method, @@ -1920,7 +1920,7 @@ class DeclarationHelper { } /// Adds a suggestion for the mixin represented by the [element]. - void _suggestMixin(MixinElement2 element, ImportData? importData) { + void _suggestMixin(MixinElement element, ImportData? importData) { if (visibilityTracker.isVisible(element: element, importData: importData)) { if (mustBeExtendable || (mustBeImplementable && @@ -1971,10 +1971,10 @@ class DeclarationHelper { /// [referencingInterface] is provided, it should be the class in which /// completion was requested. void _suggestProperty({ - required PropertyAccessorElement2 accessor, + required PropertyAccessorElement accessor, bool ignoreVisibility = false, ImportData? importData, - InterfaceElement2? referencingInterface, + InterfaceElement? referencingInterface, bool isInDeclaration = false, }) { if (ignoreVisibility || @@ -1997,7 +1997,7 @@ class DeclarationHelper { // synthetic setter. if (accessor is GetterElement) { var variable = accessor.variable3; - if (variable is FieldElement2) { + if (variable is FieldElement) { var suggestion = FieldSuggestion( element: variable, matcherScore: matcherScore, @@ -2049,7 +2049,7 @@ class DeclarationHelper { /// Adds a suggestion for the enum constant represented by the [element]. /// The [importData] should be provided if the enum is imported. - void _suggestStaticField(FieldElement2 element, ImportData? importData) { + void _suggestStaticField(FieldElement element, ImportData? importData) { if (!element.isStatic || (mustBeAssignable && !(element.isFinal || element.isConst)) || (mustBeConstant && !element.isConst)) { @@ -2082,7 +2082,7 @@ class DeclarationHelper { if (getter != null) { if (getter.isSynthetic) { var variable = getter.variable3; - if (variable is FieldElement2) { + if (variable is FieldElement) { var suggestion = FieldSuggestion( element: variable, matcherScore: matcherScore, @@ -2116,10 +2116,7 @@ class DeclarationHelper { } /// Adds a suggestion for each of the static fields in the list of [fields]. - void _suggestStaticFields( - List fields, - ImportData? importData, - ) { + void _suggestStaticFields(List fields, ImportData? importData) { for (var field in fields) { if (field.isVisibleIn(request.libraryElement)) { _suggestStaticField(field, importData); @@ -2164,7 +2161,7 @@ class DeclarationHelper { /// Adds a suggestion for the getter or setter represented by the [element]. void _suggestTopLevelProperty( - PropertyAccessorElement2 element, + PropertyAccessorElement element, ImportData? importData, ) { if (visibilityTracker.isVisible(element: element, importData: importData)) { @@ -2192,7 +2189,7 @@ class DeclarationHelper { /// Adds a suggestion for the getter or setter represented by the [element]. void _suggestTopLevelVariable( - TopLevelVariableElement2 element, + TopLevelVariableElement element, ImportData? importData, ) { if (visibilityTracker.isVisible(element: element, importData: importData)) { @@ -2214,7 +2211,7 @@ class DeclarationHelper { } /// Adds a suggestion for the type alias represented by the [element]. - void _suggestTypeAlias(TypeAliasElement2 element, ImportData? importData) { + void _suggestTypeAlias(TypeAliasElement element, ImportData? importData) { if (visibilityTracker.isVisible(element: element, importData: importData)) { var matcherScore = state.matcher.score(element.displayName); if (matcherScore != -1) { @@ -2232,7 +2229,7 @@ class DeclarationHelper { } /// Adds a suggestion for the type parameter represented by the [element]. - void _suggestTypeParameter(TypeParameterElement2 element) { + void _suggestTypeParameter(TypeParameterElement element) { if (visibilityTracker.isVisible(element: element, importData: null)) { var matcherScore = state.matcher.score(element.displayName); if (matcherScore != -1) { @@ -2246,7 +2243,7 @@ class DeclarationHelper { } /// Adds a suggestion for each of the [typeParameters]. - void _suggestTypeParameters(List typeParameters) { + void _suggestTypeParameters(List typeParameters) { for (var parameter in typeParameters) { if (!_isWildcard(parameter.name3)) { _suggestTypeParameter(parameter); @@ -2255,7 +2252,7 @@ class DeclarationHelper { } /// Adds a suggestion for the local variable represented by the [element]. - void _suggestVariable(LocalVariableElement2 element) { + void _suggestVariable(LocalVariableElement element) { if (element.isWildcardVariable) return; if (visibilityTracker.isVisible(element: element, importData: null)) { if (mustBeConstant && !element.isConst) { @@ -2324,7 +2321,7 @@ class DeclarationHelper { var variables = node.variables; for (var variable in variables.variables) { var declaredElement = variable.declaredElement2; - if (declaredElement is LocalVariableElement2) { + if (declaredElement is LocalVariableElement) { _suggestVariable(declaredElement); } } @@ -2524,12 +2521,12 @@ class DeclarationHelper { } } -extension on Element2 { +extension on Element { /// Whether this element is visible within the [referencingLibrary]. /// /// An element is visible if it's declared in the [referencingLibrary] or if /// the name is not private. - bool isVisibleIn(LibraryElement2 referencingLibrary) { + bool isVisibleIn(LibraryElement referencingLibrary) { if (library2 == referencingLibrary) { return true; } @@ -2538,13 +2535,13 @@ extension on Element2 { } } -extension on List { +extension on List { /// Returns the element in this list that is the best element to suggest. /// /// Getters are preferred over setters, otherwise the first element in the /// list is returned under the assumption that it's lower in the hierarchy. - ExecutableElement2 get bestMember { - ExecutableElement2 bestMember = this[0]; + ExecutableElement get bestMember { + ExecutableElement bestMember = this[0]; if (bestMember is SetterElement) { for (var i = 1; i < length; i++) { var member = this[i]; @@ -2557,7 +2554,7 @@ extension on List { } } -extension on PropertyAccessorElement2 { +extension on PropertyAccessorElement { /// Whether this accessor is an accessor for a constant variable. bool get isConst { if (isSynthetic) { diff --git a/pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart b/pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart index dee2c1cf4b9..aac3e6ee0fa 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/feature_computer.dart @@ -188,18 +188,18 @@ class FeatureComputer { /// setters are always mapped into a different kind: FIELD for getters and /// setters declared in a class or extension, and TOP_LEVEL_VARIABLE for /// top-level getters and setters. - protocol.ElementKind computeElementKind(Element2 element) { - if (element is LibraryElement2) { + protocol.ElementKind computeElementKind(Element element) { + if (element is LibraryElement) { return protocol.ElementKind.PREFIX; - } else if (element is EnumElement2) { + } else if (element is EnumElement) { return protocol.ElementKind.ENUM; - } else if (element is MixinElement2) { + } else if (element is MixinElement) { return protocol.ElementKind.MIXIN; - } else if (element is ClassElement2) { + } else if (element is ClassElement) { return protocol.ElementKind.CLASS; - } else if (element is FieldElement2 && element.isEnumConstant) { + } else if (element is FieldElement && element.isEnumConstant) { return protocol.ElementKind.ENUM_CONSTANT; - } else if (element is PropertyAccessorElement2) { + } else if (element is PropertyAccessorElement) { var variable = element.variable3; if (variable == null) { return protocol.ElementKind.UNKNOWN; @@ -244,18 +244,18 @@ class FeatureComputer { /// setters are always mapped into a different kind: FIELD for getters and /// setters declared in a class or extension, and TOP_LEVEL_VARIABLE for /// top-level getters and setters. - protocol.ElementKind computeElementKind2(Element2 element) { - if (element is LibraryElement2) { + protocol.ElementKind computeElementKind2(Element element) { + if (element is LibraryElement) { return protocol.ElementKind.PREFIX; - } else if (element is EnumElement2) { + } else if (element is EnumElement) { return protocol.ElementKind.ENUM; - } else if (element is MixinElement2) { + } else if (element is MixinElement) { return protocol.ElementKind.MIXIN; - } else if (element is ClassElement2) { + } else if (element is ClassElement) { return protocol.ElementKind.CLASS; - } else if (element is FieldElement2 && element.isEnumConstant) { + } else if (element is FieldElement && element.isEnumConstant) { return protocol.ElementKind.ENUM_CONSTANT; - } else if (element is PropertyAccessorElement2) { + } else if (element is PropertyAccessorElement) { var variable = element.variable3; if (variable == null) { return protocol.ElementKind.UNKNOWN; @@ -331,7 +331,7 @@ class FeatureComputer { /// completing at the given [completionLocation]. If a [distance] is given it /// will be used to provide finer-grained relevance scores. double elementKindFeature( - Element2 element, + Element element, String? completionLocation, { double? distance, }) { @@ -353,7 +353,7 @@ class FeatureComputer { } // Return the value of the _has deprecated_ feature for the given [element]. - double hasDeprecatedFeature(Element2 element) { + double hasDeprecatedFeature(Element element) { return element.hasOrInheritsDeprecated ? -1.0 : 0.0; } @@ -364,8 +364,8 @@ class FeatureComputer { /// supertype if the two types are not the same. Return `-1` if the [subclass] /// is not a subclass of the [superclass]. int inheritanceDistance( - InterfaceElement2 subclass, - InterfaceElement2 superclass, + InterfaceElement subclass, + InterfaceElement superclass, ) { // This method is only visible for the metrics computation and might be made // private at some future date. @@ -376,24 +376,22 @@ class FeatureComputer { /// defined in the [superclass] that is being accessed through an expression /// whose static type is the [subclass]. double inheritanceDistanceFeature( - InterfaceElement2 subclass, - InterfaceElement2 superclass, + InterfaceElement subclass, + InterfaceElement superclass, ) { var distance = _inheritanceDistance(subclass, superclass, {}); return distanceToPercent(distance); } /// Return the value of the _is constant_ feature for the given [element]. - double isConstantFeature(Element2 element) { - if (element is ConstructorElement2 && element.isConst) { + double isConstantFeature(Element element) { + if (element is ConstructorElement && element.isConst) { return 1.0; - } else if (element is FieldElement2 && - element.isStatic && - element.isConst) { + } else if (element is FieldElement && element.isStatic && element.isConst) { return 1.0; - } else if (element is TopLevelVariableElement2 && element.isConst) { + } else if (element is TopLevelVariableElement && element.isConst) { return 1.0; - } else if (element is PropertyAccessorElement2 && element.isSynthetic) { + } else if (element is PropertyAccessorElement && element.isSynthetic) { var variable = element.variable3; if (variable != null && variable.isStatic && variable.isConst) { return 1.0; @@ -412,7 +410,7 @@ class FeatureComputer { // override of `noSuchMethod`. return 0.0; } - return proposedMemberName == MethodElement2.NO_SUCH_METHOD_METHOD_NAME + return proposedMemberName == MethodElement.NO_SUCH_METHOD_METHOD_NAME ? -1.0 : 0.0; } @@ -469,9 +467,9 @@ class FeatureComputer { /// /// This is the implementation of [inheritanceDistance]. int _inheritanceDistance( - InterfaceElement2? subclass, - InterfaceElement2 superclass, - Set visited, + InterfaceElement? subclass, + InterfaceElement superclass, + Set visited, ) { if (subclass == null) { return -1; @@ -495,7 +493,7 @@ class FeatureComputer { } } - if (subclass is MixinElement2) { + if (subclass is MixinElement) { visitTypes(subclass.superclassConstraints); } visitTypes(subclass.mixins); @@ -664,7 +662,7 @@ class _ContextTypeVisitor extends SimpleAstVisitor { DartType? visitConstructorFieldInitializer(ConstructorFieldInitializer node) { if (node.equals.end <= offset) { var element = node.fieldName.element; - if (element is FieldElement2) { + if (element is FieldElement) { return element.type; } } @@ -1226,7 +1224,7 @@ parent3: ${node.parent?.parent?.parent} // TODO(brianwilkerson): Replace with `patternTypeSchema` (on AST) where // possible. pattern = pattern.unParenthesized; - Element2? element; + Element? element; if (pattern is AssignedVariablePattern) { element = pattern.element2; } else if (pattern is DeclaredVariablePattern) { @@ -1236,7 +1234,7 @@ parent3: ${node.parent?.parent?.parent} } else if (pattern is ListPattern) { return pattern.requiredType; } - if (element is VariableElement2) { + if (element is VariableElement) { return element.type; } return null; @@ -1264,7 +1262,7 @@ parent3: ${node.parent?.parent?.parent} var member = manager.getMember3(type, Name(uri, name)); if (member is GetterElement) { return member.returnType; - } else if (member is MethodElement2) { + } else if (member is MethodElement) { return member.returnType; } return null; diff --git a/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart b/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart index 7d7973eac66..46a5888d8dd 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/in_scope_completion_pass.dart @@ -789,7 +789,7 @@ class InScopeCompletionPass extends SimpleAstVisitor { void visitConstructorName(ConstructorName node) { if (node.parent is ConstructorReference) { var element = node.type.element2; - if (element is InterfaceElement2) { + if (element is InterfaceElement) { declarationHelper( preferNonInvocation: true, ).addStaticMembersOfElement(element); @@ -1278,8 +1278,8 @@ class InScopeCompletionPass extends SimpleAstVisitor { } if (constructor is ConstructorDeclaration) { var declaredElement = node.declaredFragment?.element; - FieldElement2? field; - if (declaredElement is FieldFormalParameterElement2) { + FieldElement? field; + if (declaredElement is FieldFormalParameterElement) { field = declaredElement.field2; } declarationHelper().addFieldsForInitializers(constructor, field); @@ -1679,13 +1679,13 @@ class InScopeCompletionPass extends SimpleAstVisitor { var element = node.element2; DartType type; collector.completionLocation = 'PropertyAccess_propertyName'; - if (element is FunctionTypedElement2) { + if (element is FunctionTypedElement) { if (element is GetterElement) { type = element.type.returnType; } else { type = element.type; } - } else if (element is PrefixElement2) { + } else if (element is PrefixElement) { var isInstanceCreation = node.parent?.parent?.parent is InstanceCreationExpression; declarationHelper( @@ -1694,10 +1694,10 @@ class InScopeCompletionPass extends SimpleAstVisitor { mustBeNonVoid: isInstanceCreation, ).addDeclarationsThroughImportPrefix(element); return; - } else if (element is VariableElement2) { + } else if (element is VariableElement) { type = element.type; } else { - if (element is InterfaceElement2 || element is ExtensionElement2) { + if (element is InterfaceElement || element is ExtensionElement) { declarationHelper().addStaticMembersOfElement(element!); } return; @@ -1944,10 +1944,10 @@ class InScopeCompletionPass extends SimpleAstVisitor { target is Identifier && (!node.isCascaded || offset == operator.offset + 1)) { var element = target.element; - if (element is InterfaceElement2 || element is ExtensionTypeElement2) { + if (element is InterfaceElement || element is ExtensionTypeElement) { declarationHelper().addStaticMembersOfElement(element!); } - if (element is PrefixElement2) { + if (element is PrefixElement) { declarationHelper().addDeclarationsThroughImportPrefix(element); } } @@ -2076,7 +2076,7 @@ class InScopeCompletionPass extends SimpleAstVisitor { var prefixElement = importPrefix?.element2; // `prefix.x^ print(0);` is recovered as `prefix.x print; (0);`. - if (prefixElement is PrefixElement2) { + if (prefixElement is PrefixElement) { if (node.parent case VariableDeclarationList variableList) { if (variableList.parent case VariableDeclarationStatement statement) { if (statement.semicolon.isSynthetic) { @@ -2265,7 +2265,7 @@ class InScopeCompletionPass extends SimpleAstVisitor { var parent = node.parent; var mustBeAssignable = parent is AssignmentExpression && node == parent.leftHandSide; - if (element is PrefixElement2) { + if (element is PrefixElement) { declarationHelper( mustBeAssignable: mustBeAssignable, ).addDeclarationsThroughImportPrefix(element); @@ -2274,13 +2274,13 @@ class InScopeCompletionPass extends SimpleAstVisitor { mustBeAssignable: mustBeAssignable, preferNonInvocation: node.parent is CommentReference || - (element is InterfaceElement2 && + (element is InterfaceElement && state.request.shouldSuggestTearOff(element)), ); if (node.parent is CommentReference) { - if (element is InterfaceElement2) { + if (element is InterfaceElement) { helper.addInstanceMembersOfType(element.thisType); - } else if (element is ExtensionElement2) { + } else if (element is ExtensionElement) { helper.addMembersFromExtensionElement( element, excludedGetters: {}, @@ -2333,10 +2333,10 @@ class InScopeCompletionPass extends SimpleAstVisitor { target is Identifier && (!node.isCascaded || offset == operator.offset + 1)) { var element = target.element; - if (element is InterfaceElement2 || element is ExtensionTypeElement2) { + if (element is InterfaceElement || element is ExtensionTypeElement) { declarationHelper().addStaticMembersOfElement(element!); } - if (element is PrefixElement2) { + if (element is PrefixElement) { declarationHelper().addDeclarationsThroughImportPrefix(element); } } @@ -2579,7 +2579,7 @@ class InScopeCompletionPass extends SimpleAstVisitor { if (type is NamedType) { if (type.importPrefix case var importPrefix?) { var prefixElement = importPrefix.element2; - if (prefixElement is PrefixElement2) { + if (prefixElement is PrefixElement) { if (type.name2.coversOffset(offset)) { declarationHelper( mustBeType: true, @@ -3418,8 +3418,8 @@ class InScopeCompletionPass extends SimpleAstVisitor { ConstructorFieldInitializer? initializer, ) { var element = initializer?.fieldName.element; - FieldElement2? field; - if (element is FieldElement2) { + FieldElement? field; + if (element is FieldElement) { field = element; } keywordHelper.addConstructorInitializerKeywords(constructor, initializer); @@ -3740,7 +3740,7 @@ class InScopeCompletionPass extends SimpleAstVisitor { if (node is NamedType) { if (node.importPrefix case var importPrefix?) { var prefixElement = importPrefix.element2; - if (prefixElement is PrefixElement2) { + if (prefixElement is PrefixElement) { declarationHelper( mustBeExtensible: mustBeExtensible, mustBeImplementable: mustBeImplementable, @@ -3923,7 +3923,7 @@ class InScopeCompletionPass extends SimpleAstVisitor { /// If the budget has been exceeded, then the results are marked as incomplete /// and no suggestions are added. void _suggestOverridesFor({ - required InterfaceElement2? element, + required InterfaceElement? element, bool skipAt = false, }) { if (state.budget.isEmpty) { @@ -4015,7 +4015,7 @@ class InScopeCompletionPass extends SimpleAstVisitor { var lexeme = identifier.lexeme; if (lexeme.isNotEmpty && 'override'.startsWith(lexeme)) { var declaredElement = node.declaredFragment?.element; - if (declaredElement is InterfaceElement2) { + if (declaredElement is InterfaceElement) { _suggestOverridesFor(element: declaredElement, skipAt: true); } } @@ -4212,7 +4212,7 @@ extension on ClassMember { extension on ArgumentList { /// The element being invoked by the expression containing this argument list, /// or `null` if the element is not known. - Element2? get invokedElement { + Element? get invokedElement { switch (parent) { case Annotation invocation: return invocation.element2; @@ -4334,7 +4334,7 @@ extension on CompilationUnit { } } -extension on Element2? { +extension on Element? { /// Returns the parameters associated with this element, or `null` if this /// element doesn't have any parameters associated with it. /// @@ -4346,9 +4346,9 @@ extension on Element2? { var self = this; if (self is GetterElement) { return self.returnType.ifTypeOrNull()?.formalParameters; - } else if (self is ExecutableElement2) { + } else if (self is ExecutableElement) { return self.formalParameters; - } else if (self is VariableElement2) { + } else if (self is VariableElement) { var type = self.type; if (type is FunctionType) { return type.formalParameters; diff --git a/pkg/analysis_server/lib/src/services/completion/dart/not_imported_completion_pass.dart b/pkg/analysis_server/lib/src/services/completion/dart/not_imported_completion_pass.dart index 70ff71354c1..fc092796a24 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/not_imported_completion_pass.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/not_imported_completion_pass.dart @@ -26,7 +26,7 @@ class ConstructorsOperation extends NotImportedOperation { : _declarationHelper = declarationHelper; /// Compute any candidate suggestions for elements in the [library]. - void computeSuggestionsIn(LibraryElement2 library) { + void computeSuggestionsIn(LibraryElement library) { _declarationHelper.addNotImportedConstructors(library); } } @@ -62,7 +62,7 @@ class InstanceExtensionMembersOperation extends NotImportedOperation { _includeSetters = includeSetters; /// Compute any candidate suggestions for elements in the [library]. - void computeSuggestionsIn(LibraryElement2 library) { + void computeSuggestionsIn(LibraryElement library) { _declarationHelper.addNotImportedExtensionMethods( library: library, type: _type, @@ -198,9 +198,9 @@ class StaticMembersOperation extends NotImportedOperation { /// Compute any candidate suggestions for elements in the [library]. void computeSuggestionsIn( - LibraryElement2 library, - List exportElements, - Set importedElements, + LibraryElement library, + List exportElements, + Set importedElements, ) { // TODO(brianwilkerson): Determine whether we need the element parameters. _declarationHelper.addNotImportedTopLevelDeclarations(library); @@ -211,12 +211,12 @@ class StaticMembersOperation extends NotImportedOperation { class _ImportSummary { /// The elements that are imported from libraries that are only partially /// imported. - Set importedElements = Set.identity(); + Set importedElements = Set.identity(); /// The libraries that are imported in their entirety. - Set importedLibraries = Set.identity(); + Set importedLibraries = Set.identity(); - _ImportSummary(LibraryElement2 library) { + _ImportSummary(LibraryElement library) { for (var fragment in library.fragments) { for (var import in fragment.libraryImports2) { var importedLibrary = import.importedLibrary2; diff --git a/pkg/analysis_server/lib/src/services/completion/dart/override_helper.dart b/pkg/analysis_server/lib/src/services/completion/dart/override_helper.dart index 9389e3236f1..e34ab189657 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/override_helper.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/override_helper.dart @@ -29,7 +29,7 @@ class OverrideHelper { : inheritanceManager = state.request.inheritanceManager; void computeOverridesFor({ - required InterfaceElement2 interfaceElement, + required InterfaceElement interfaceElement, required SourceRange replacementRange, required bool skipAt, }) { @@ -73,7 +73,7 @@ class OverrideHelper { } /// Checks if the [element] has the `@nonVirtual` annotation. - bool _hasNonVirtualAnnotation(ExecutableElement2 element) { + bool _hasNonVirtualAnnotation(ExecutableElement element) { if (element is GetterElement && element.isSynthetic) { var variable = element.variable3; if (variable != null && variable.metadata2.hasNonVirtual) { diff --git a/pkg/analysis_server/lib/src/services/completion/dart/relevance_computer.dart b/pkg/analysis_server/lib/src/services/completion/dart/relevance_computer.dart index c29891f3c6c..b6b9b68c5ce 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/relevance_computer.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/relevance_computer.dart @@ -65,9 +65,9 @@ class RelevanceComputer { return _cachedContainingMemberName; } - /// Compute the relevance for [FieldElement2] suggestion. + /// Compute the relevance for [FieldElement] suggestion. int computeFieldElementRelevance( - FieldElement2 element, + FieldElement element, double inheritanceDistance, ) { var contextType = featureComputer.contextTypeFeature( @@ -340,7 +340,7 @@ class RelevanceComputer { /// Return the relevance score for a top-level [element]. int computeTopLevelRelevance( - Element2 element, { + Element element, { required DartType elementType, required bool isNotImportedLibrary, }) { @@ -367,7 +367,7 @@ class RelevanceComputer { /// Return the relevance score for a top-level [element]. int computeTopLevelRelevance2( - Element2 element, { + Element element, { required DartType elementType, required bool isNotImportedLibrary, }) { @@ -395,7 +395,7 @@ class RelevanceComputer { /// Compute the relevance for an [accessor]. int _computeAccessorRelevance( DartType? type, - Element2 accessor, + Element accessor, bool isNotImportedLibrary, { double startsWithDollar = 0.0, double superMatches = 0.0, @@ -420,9 +420,9 @@ class RelevanceComputer { ); } - /// Compute the relevance for [ConstructorElement2]. + /// Compute the relevance for [ConstructorElement]. int _computeConstructorRelevance( - ConstructorElement2 element, + ConstructorElement element, NeverType neverType, bool isNotImportedLibrary, ) { @@ -437,7 +437,7 @@ class RelevanceComputer { /// Compute the value of the _element kind_ feature for the given [element] in /// the completion context. - double _computeElementKind(Element2 element, {double? distance}) { + double _computeElementKind(Element element, {double? distance}) { var location = completionLocation; var elementKind = featureComputer.elementKindFeature( element, @@ -459,7 +459,7 @@ class RelevanceComputer { /// Compute the value of the _element kind_ feature for the given [element] in /// the completion context. - double _computeElementKind2(Element2 element, {double? distance}) { + double _computeElementKind2(Element element, {double? distance}) { var location = completionLocation; var elementKind = featureComputer.elementKindFeature( element, @@ -564,9 +564,9 @@ class RelevanceComputer { ); } - /// Compute the relevance for [MethodElement2]. + /// Compute the relevance for [MethodElement]. int _computeMethodRelevance( - MethodElement2 method, + MethodElement method, double inheritanceDistance, bool isNotImportedLibrary, ) { @@ -605,16 +605,16 @@ class RelevanceComputer { ); } - /// Compute the relevance for [PropertyAccessorElement2]. + /// Compute the relevance for [PropertyAccessorElement]. int _computePropertyAccessorRelevance( - PropertyAccessorElement2 accessor, + PropertyAccessorElement accessor, double inheritanceDistance, bool isNotImportedLibrary, ) { if (accessor.isSynthetic) { if (accessor is GetterElement) { var variable = accessor.variable3; - if (variable is FieldElement2) { + if (variable is FieldElement) { return computeFieldElementRelevance(variable, inheritanceDistance); } } @@ -639,9 +639,9 @@ class RelevanceComputer { return 0; } - /// Compute the relevance for a static [FieldElement2]. + /// Compute the relevance for a static [FieldElement]. int _computeStaticFieldRelevance( - FieldElement2 element, + FieldElement element, double inheritanceDistance, bool isNotImportedLibrary, ) { @@ -649,7 +649,7 @@ class RelevanceComputer { var getter = element.getter2; if (getter != null) { var variable = getter.variable3; - if (variable is FieldElement2) { + if (variable is FieldElement) { return computeFieldElementRelevance(variable, inheritanceDistance); } } @@ -663,15 +663,15 @@ class RelevanceComputer { return 0; } - /// Compute the relevance for top level [PropertyAccessorElement2]. + /// Compute the relevance for top level [PropertyAccessorElement]. int _computeTopLevelPropertyAccessorRelevance( - PropertyAccessorElement2 accessor, + PropertyAccessorElement accessor, bool isNotImportedLibrary, ) { if (accessor.isSynthetic) { if (accessor is GetterElement) { var variable = accessor.variable3; - if (variable is TopLevelVariableElement2) { + if (variable is TopLevelVariableElement) { return computeTopLevelRelevance( variable, elementType: variable.type, @@ -694,8 +694,8 @@ class RelevanceComputer { return 0; } - /// Compute the relevance for [TypeParameterElement2]. - int _computeTypeParameterRelevance(TypeParameterElement2 parameter) { + /// Compute the relevance for [TypeParameterElement]. + int _computeTypeParameterRelevance(TypeParameterElement parameter) { var elementKind = _computeElementKind(parameter); var isConstant = preferConstants ? featureComputer.isConstantFeature(parameter) : 0.0; @@ -704,7 +704,7 @@ class RelevanceComputer { /// Return the type associated with the [accessor], maybe `null` if an /// invalid setter with no parameters at all. - DartType? _getPropertyAccessorType(PropertyAccessorElement2 accessor) { + DartType? _getPropertyAccessorType(PropertyAccessorElement accessor) { if (accessor is GetterElement) { return accessor.returnType; } else { @@ -718,7 +718,7 @@ class RelevanceComputer { } /// Return the [DartType] for an instantiated [TypeAlias]. - DartType _instantiateTypeAlias(TypeAliasElement2 element) { + DartType _instantiateTypeAlias(TypeAliasElement element) { var typeParameters = element.typeParameters2; var typeArguments = const []; if (typeParameters.isNotEmpty) { diff --git a/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart b/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart index 38f9cd3efe9..adfb226ee0d 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart @@ -163,7 +163,7 @@ class SuggestionBuilder { /// can only be referenced using a prefix, and the class name is to be /// included in the completion, then the [prefix] should be provided. void suggestConstructor( - ConstructorElement2 constructor, { + ConstructorElement constructor, { CompletionSuggestionKind kind = CompletionSuggestionKind.INVOCATION, bool suggestUnnamedAsNew = false, bool hasClassName = false, @@ -222,7 +222,7 @@ class SuggestionBuilder { /// Add a suggestion for an enum [constant]. If the enum can only be /// referenced using a prefix, then the [prefix] should be provided. void suggestEnumConstant( - FieldElement2 constant, + FieldElement constant, String completion, { String? prefix, int? relevance, @@ -248,7 +248,7 @@ class SuggestionBuilder { /// used as the kind for the suggestion. If the extension can only be /// referenced using a prefix, then the [prefix] should be provided. void suggestExtension( - ExtensionElement2 extension, { + ExtensionElement extension, { CompletionSuggestionKind kind = CompletionSuggestionKind.INVOCATION, String? prefix, int? relevance, @@ -278,7 +278,7 @@ class SuggestionBuilder { /// The [inheritanceDistance] is the value of the inheritance distance feature /// computed for the field (or `-1.0` if the field is a static field). void suggestField( - FieldElement2 field, { + FieldElement field, { required double inheritanceDistance, int? relevance, }) { @@ -362,7 +362,7 @@ class SuggestionBuilder { void suggestFunctionCall() { var element = protocol.Element( protocol.ElementKind.METHOD, - MethodElement2.CALL_METHOD_NAME, + MethodElement.CALL_METHOD_NAME, protocol.Element.makeFlags(), parameters: '()', returnType: 'void', @@ -371,8 +371,8 @@ class SuggestionBuilder { CompletionSuggestion( CompletionSuggestionKind.INVOCATION, Relevance.callFunction, - MethodElement2.CALL_METHOD_NAME, - MethodElement2.CALL_METHOD_NAME.length, + MethodElement.CALL_METHOD_NAME, + MethodElement.CALL_METHOD_NAME.length, 0, false, false, @@ -453,7 +453,7 @@ class SuggestionBuilder { /// Add a suggestion for an [element]. If the class can only be /// referenced using a prefix, then the [prefix] should be provided. void suggestInterface( - InterfaceElement2 element, { + InterfaceElement element, { String? prefix, int? relevance, }) { @@ -538,7 +538,7 @@ class SuggestionBuilder { /// Add a suggestion for the `loadLibrary` [function] associated with a /// prefix. void suggestLoadLibraryFunction( - ExecutableElement2 function, { + ExecutableElement function, { CompletionSuggestionKind kind = CompletionSuggestionKind.INVOCATION, }) { // TODO(brianwilkerson): This might want to use the context type rather than @@ -584,7 +584,7 @@ class SuggestionBuilder { } void suggestLocalVariable({ - required LocalVariableElement2 element, + required LocalVariableElement element, required int distance, int? relevance, }) { @@ -624,7 +624,7 @@ class SuggestionBuilder { /// as the kind for the suggestion. The [inheritanceDistance] is the value of /// the inheritance distance feature computed for the method. void suggestMethod( - MethodElement2 method, { + MethodElement method, { required CompletionSuggestionKind kind, required double inheritanceDistance, int? relevance, @@ -726,7 +726,7 @@ class SuggestionBuilder { element: convertElement(parameter), ); - if (parameter is FieldFormalParameterElement2) { + if (parameter is FieldFormalParameterElement) { _setDocumentation(suggestion, parameter); } @@ -776,7 +776,7 @@ class SuggestionBuilder { /// [element]. If [invokeSuper] is `true`, then the override will contain an /// invocation of an overridden member. Future suggestOverride({ - required ExecutableElement2 element, + required ExecutableElement element, required bool invokeSuper, required SourceRange replacementRange, required bool skipAt, @@ -855,7 +855,7 @@ class SuggestionBuilder { } /// Add a suggestion for a [prefix] associated with a [library]. - void suggestPrefix(LibraryElement2 library, String prefix, {int? relevance}) { + void suggestPrefix(LibraryElement library, String prefix, {int? relevance}) { var elementKind = _computeElementKind(library); // TODO(brianwilkerson): If we are in a constant context it would be nice // to promote prefixes for libraries that define constants, but that @@ -903,7 +903,7 @@ class SuggestionBuilder { /// Add a suggestion for the Flutter's `setState` method. void suggestSetStateMethod( - MethodElement2 method, { + MethodElement method, { required CompletionSuggestionKind kind, required String completion, required String displayText, @@ -996,7 +996,7 @@ class SuggestionBuilder { /// If the enclosing element can only be referenced using a prefix, then /// the [prefix] should be provided. void suggestStaticField( - FieldElement2 element, { + FieldElement element, { String? prefix, int? relevance, String? completion, @@ -1076,7 +1076,7 @@ class SuggestionBuilder { int? relevance, }) { assert( - getter.enclosingElement2 is LibraryElement2, + getter.enclosingElement2 is LibraryElement, 'Enclosing element of ${getter.runtimeType} is ' '${getter.enclosingElement2.runtimeType}.', ); @@ -1128,7 +1128,7 @@ class SuggestionBuilder { int? relevance, }) { assert( - setter.enclosingElement2 is LibraryElement2, + setter.enclosingElement2 is LibraryElement, 'Enclosing element of ${setter.runtimeType} is ' '${setter.enclosingElement2.runtimeType}.', ); @@ -1175,14 +1175,14 @@ class SuggestionBuilder { /// Add a suggestion for a top-level [variable]. If the variable can only be /// referenced using a prefix, then the [prefix] should be provided. void suggestTopLevelVariable( - TopLevelVariableElement2 variable, { + TopLevelVariableElement variable, { String? prefix, int? relevance, }) { var completion = _getCompletionString(variable); if (completion == null) return; if (_couldMatch(completion, prefix)) { - assert(variable.enclosingElement2 is LibraryElement2); + assert(variable.enclosingElement2 is LibraryElement); relevance ??= relevanceComputer.computeTopLevelRelevance2( variable, elementType: variable.type, @@ -1203,7 +1203,7 @@ class SuggestionBuilder { /// Add a suggestion for a [typeAlias]. If the alias can only be referenced /// using a prefix, then the [prefix] should be provided. void suggestTypeAlias( - TypeAliasElement2 typeAlias, { + TypeAliasElement typeAlias, { String? prefix, int? relevance, }) { @@ -1228,7 +1228,7 @@ class SuggestionBuilder { } /// Add a suggestion for a type [parameter]. - void suggestTypeParameter(TypeParameterElement2 parameter, {int? relevance}) { + void suggestTypeParameter(TypeParameterElement parameter, {int? relevance}) { var elementKind = _computeElementKind(parameter); var isConstant = _preferConstants @@ -1278,11 +1278,11 @@ class SuggestionBuilder { // suggestions are added has been changed by the move to // `InScopeCompletionPass`. var suggestedElement = suggestion.orgElement; - if (suggestedElement is ConstructorElement2) { + if (suggestedElement is ConstructorElement) { var parentName = suggestedElement.enclosingElement2.displayName; var existingSuggestion = _suggestionMap[parentName]; if (existingSuggestion is _CompletionSuggestionBuilderImpl && - existingSuggestion.orgElement is! ClassElement2) { + existingSuggestion.orgElement is! ClassElement) { // We return when the current suggestion is not a class because that // means that the current suggestion shadows the one being added. return; @@ -1322,7 +1322,7 @@ class SuggestionBuilder { /// Compute the value of the _element kind_ feature for the given [element] in /// the completion context. - double _computeElementKind(Element2 element, {double? distance}) { + double _computeElementKind(Element element, {double? distance}) { var location = request.opType.completionLocation; var elementKind = request.featureComputer.elementKindFeature( element, @@ -1367,7 +1367,7 @@ class SuggestionBuilder { /// element. If a [prefix] is provided, then the element name (or completion) /// will be prefixed. The [relevance] is the relevance of the suggestion. CompletionSuggestionBuilder? _createCompletionSuggestionBuilder( - Element2 element, { + Element element, { String? completion, required CompletionSuggestionKind kind, required int relevance, @@ -1395,7 +1395,7 @@ class SuggestionBuilder { ); } - _ElementCompletionData _createElementCompletionData(Element2 element) { + _ElementCompletionData _createElementCompletionData(Element element) { var documentation = _getDocumentation(element); var suggestedElement = protocol.convertElement(element); @@ -1404,7 +1404,7 @@ class SuggestionBuilder { if (element is! FormalParameterElement) { var enclosingElement = element.enclosingElement2; - if (enclosingElement is InterfaceElement2) { + if (enclosingElement is InterfaceElement) { declaringType = enclosingElement.displayName; } } @@ -1417,7 +1417,7 @@ class SuggestionBuilder { int? requiredParameterCount; bool? hasNamedParameters; CompletionDefaultArgumentList? defaultArgumentList; - if (element is ExecutableElement2 && element is! PropertyAccessorElement2) { + if (element is ExecutableElement && element is! PropertyAccessorElement) { parameterNames = element.formalParameters.map((parameter) { return parameter.displayName; @@ -1463,11 +1463,11 @@ class SuggestionBuilder { /// /// The enclosing element must be either a class, or extension; otherwise /// we either fail with assertion, or return `null`. - String? _enclosingClassOrExtensionName(Element2 element) { + String? _enclosingClassOrExtensionName(Element element) { var enclosing = element.enclosingElement2; - if (enclosing is InterfaceElement2) { + if (enclosing is InterfaceElement) { return enclosing.displayName; - } else if (enclosing is ExtensionElement2) { + } else if (enclosing is ExtensionElement) { return enclosing.displayName; } else { assert(false, 'Expected ClassElement or ExtensionElement'); @@ -1475,8 +1475,8 @@ class SuggestionBuilder { } } - String? _getCompletionString(Element2 element) { - if (element is MethodElement2 && element.isOperator) { + String? _getCompletionString(Element element) { + if (element is MethodElement && element.isOperator) { return null; } @@ -1484,7 +1484,7 @@ class SuggestionBuilder { } /// If the [element] has a documentation comment, return it. - _ElementDocumentation? _getDocumentation(Element2 element) { + _ElementDocumentation? _getDocumentation(Element element) { var doc = request.documentationComputer.compute( element, includeSummary: true, @@ -1509,7 +1509,7 @@ class SuggestionBuilder { } } - InterfaceType _instantiateInstanceElement(InterfaceElement2 element) { + InterfaceType _instantiateInstanceElement(InterfaceElement element) { var typeParameters = element.typeParameters2; var typeArguments = const []; if (typeParameters.isNotEmpty) { @@ -1522,7 +1522,7 @@ class SuggestionBuilder { ); } - InterfaceType _instantiateInstanceElement2(InterfaceElement2 element) { + InterfaceType _instantiateInstanceElement2(InterfaceElement element) { var typeParameters = element.typeParameters2; var typeArguments = const []; if (typeParameters.isNotEmpty) { @@ -1535,7 +1535,7 @@ class SuggestionBuilder { ); } - DartType _instantiateTypeAlias(TypeAliasElement2 element) { + DartType _instantiateTypeAlias(TypeAliasElement element) { var typeParameters = element.typeParameters2; var typeArguments = const []; if (typeParameters.isNotEmpty) { @@ -1550,7 +1550,7 @@ class SuggestionBuilder { /// If the [element] has a documentation comment, fill the [suggestion]'s /// documentation fields. - void _setDocumentation(CompletionSuggestion suggestion, Element2 element) { + void _setDocumentation(CompletionSuggestion suggestion, Element element) { var doc = request.documentationComputer.compute( element, includeSummary: true, @@ -1561,8 +1561,8 @@ class SuggestionBuilder { } } - static String _textToMatchOverride(ExecutableElement2 element) { - if (element is MethodElement2 && element.isOperator) { + static String _textToMatchOverride(ExecutableElement element) { + if (element is MethodElement && element.isOperator) { return 'override_operator'; } // Add "override" to match filter when `@override`. @@ -1642,7 +1642,7 @@ class ValueCompletionSuggestionBuilder implements CompletionSuggestionBuilder { /// The implementation of [CompletionSuggestionBuilder] that is based on /// [_ElementCompletionData] and location specific information. class _CompletionSuggestionBuilderImpl implements CompletionSuggestionBuilder { - final Element2 orgElement; + final Element orgElement; final SuggestionBuilder suggestionBuilder; @override @@ -1714,7 +1714,7 @@ class _CompletionSuggestionBuilderImpl implements CompletionSuggestionBuilder { } } -/// Information about an [Element2] that does not depend on the location where +/// Information about an [Element] that does not depend on the location where /// this element is suggested. For some often used elements, such as classes, /// it might be cached, so created only once. class _ElementCompletionData { diff --git a/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart b/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart index 16af3458eb7..53d5bb6c403 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/utilities.dart @@ -88,7 +88,7 @@ String buildClosureParameters( /// Compute default argument list text and ranges based on the given /// [requiredParams] and [namedParams]. CompletionDefaultArgumentList computeCompletionDefaultArgumentList( - Element2 element, + Element element, Iterable requiredParams, Iterable namedParams, ) { @@ -213,9 +213,9 @@ String getTypeString(DartType type) { } } -/// Instantiates the given [InterfaceElement2] +/// Instantiates the given [InterfaceElement] InterfaceType instantiateInstanceElement( - InterfaceElement2 element, + InterfaceElement element, NeverType neverType, ) { var typeParameters = element.typeParameters2; @@ -233,7 +233,7 @@ InterfaceType instantiateInstanceElement( /// `Widget`. bool isFlutterWidgetParameter(FormalParameterElement parameter) { var element = parameter.enclosingElement2; - if (element is ConstructorElement2 && element.enclosingElement2.isWidget) { + if (element is ConstructorElement && element.enclosingElement2.isWidget) { return true; } return false; @@ -247,19 +247,19 @@ String? nameForType(SimpleIdentifier identifier, TypeAnnotation? declaredType) { var element = identifier.element; if (element == null) { return DYNAMIC; - } else if (element is FunctionTypedElement2) { - if (element is PropertyAccessorElement2 && element is SetterElement) { + } else if (element is FunctionTypedElement) { + if (element is PropertyAccessorElement && element is SetterElement) { return null; } type = element.returnType; - } else if (element is TypeAliasElement2) { + } else if (element is TypeAliasElement) { var aliasedType = element.aliasedType; if (aliasedType is FunctionType) { type = aliasedType.returnType; } else { return null; } - } else if (element is VariableElement2) { + } else if (element is VariableElement) { type = element.type; } else { return null; diff --git a/pkg/analysis_server/lib/src/services/completion/dart/visibility_tracker.dart b/pkg/analysis_server/lib/src/services/completion/dart/visibility_tracker.dart index ade38aa514f..eca3029fa68 100644 --- a/pkg/analysis_server/lib/src/services/completion/dart/visibility_tracker.dart +++ b/pkg/analysis_server/lib/src/services/completion/dart/visibility_tracker.dart @@ -21,10 +21,7 @@ class VisibilityTracker { /// by being `null` or by returning `false` from `isNotImported`) and the name /// is visible, it will be added to the list of [_declaredNames] so that it /// will shadow any elements of the same name further up the scope chain. - bool isVisible({ - required Element2? element, - required ImportData? importData, - }) { + bool isVisible({required Element? element, required ImportData? importData}) { var name = element?.displayName; if (name == null) { return false; diff --git a/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart b/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart index c2759a5747b..9e9f9db4a27 100644 --- a/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart +++ b/pkg/analysis_server/lib/src/services/completion/postfix/postfix_completion.dart @@ -623,7 +623,7 @@ final class PostfixCompletionProcessor { } Expression? _findOuterExpression(AstNode? start, InterfaceType builtInType) { - if (start is SimpleIdentifier && start.element is PrefixElement2) { + if (start is SimpleIdentifier && start.element is PrefixElement) { return null; } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart index af97fc8c768..a4bf2de9d7a 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_diagnostic_property_reference.dart @@ -417,7 +417,7 @@ class AddDiagnosticPropertyReference extends ResolvedCorrectionProducer { } case VariableDeclaration(): var element = node.declaredFragment?.element; - if (element is FieldElement2) { + if (element is FieldElement) { return element.type; } } @@ -425,7 +425,7 @@ class AddDiagnosticPropertyReference extends ResolvedCorrectionProducer { } bool _isEnum(DartType type) { - return type is InterfaceType && type.element3 is EnumElement2; + return type is InterfaceType && type.element3 is EnumElement; } bool _isIterable(DartType type) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_enum_constant.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_enum_constant.dart index b053128d46b..64a6014c281 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_enum_constant.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_enum_constant.dart @@ -37,7 +37,7 @@ class AddEnumConstant extends ResolvedCorrectionProducer { var target = parent.prefix; var targetElement = target.element; - if (targetElement is! EnumElement2) return; + if (targetElement is! EnumElement) return; if (targetElement.library2.isInSdk) return; var targetFragment = targetElement.firstFragment; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_field_formal_parameters.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_field_formal_parameters.dart index 83136565d0d..06bcffe313f 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_field_formal_parameters.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_field_formal_parameters.dart @@ -42,7 +42,7 @@ class AddFieldFormalParameters extends ResolvedCorrectionProducer { // Compute uninitialized final fields. var fields = ErrorVerifier.computeNotInitializedFields(constructor); - fields.retainWhere((FieldElement2 field) => field.isFinal); + fields.retainWhere((FieldElement field) => field.isFinal); fields.sort( (a, b) => a.firstFragment.nameOffset2! - b.firstFragment.nameOffset2!, ); @@ -51,7 +51,7 @@ class AddFieldFormalParameters extends ResolvedCorrectionProducer { if (superType.isExactlyStatelessWidgetType || superType.isExactlyStatefulWidgetType) { if (parameters.isNotEmpty && parameters.last.isNamed) { - String parameterForField(FieldElement2 field) { + String parameterForField(FieldElement field) { var prefix = ''; if (typeSystem.isPotentiallyNonNullable(field.type)) { prefix = 'required '; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_key_to_constructors.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_key_to_constructors.dart index 10d04f4b214..0df8a815ed6 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_key_to_constructors.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_key_to_constructors.dart @@ -45,7 +45,7 @@ class AddKeyToConstructors extends ResolvedCorrectionProducer { /// Return `true` if the [classDeclaration] can be instantiated as a `const`. bool _canBeConst( ClassDeclaration classDeclaration, - List constructors, + List constructors, ) { for (var constructor in constructors) { if (constructor.isDefaultConstructor && !constructor.isConst) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_late.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_late.dart index 2c57efafb7b..49b2b907bd6 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_late.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_late.dart @@ -61,7 +61,7 @@ class AddLate extends ResolvedCorrectionProducer { var getter = node.writeOrReadElement2; if (getter is GetterElement && getter.isSynthetic && - getter.enclosingElement2 is InterfaceElement2) { + getter.enclosingElement2 is InterfaceElement) { var variableElement = getter.variable3; if (variableElement != null && !variableElement.isSynthetic && diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_case_clauses.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_case_clauses.dart index 7bbc43e9b24..af4c4e14363 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_case_clauses.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_case_clauses.dart @@ -45,7 +45,7 @@ class AddMissingEnumCaseClauses extends ResolvedCorrectionProducer { var expressionType = statement.expression.staticType; if (expressionType is InterfaceType) { var enumElement = expressionType.element3; - if (enumElement is EnumElement2) { + if (enumElement is EnumElement) { enumName = enumElement.name3; for (var field in enumElement.fields2) { if (field.isEnumConstant) { @@ -122,7 +122,7 @@ class AddMissingEnumCaseClauses extends ResolvedCorrectionProducer { /// Return the shortest prefix for the [element], or an empty String if not /// found. - String _importPrefix(Element2 element) { + String _importPrefix(Element element) { var shortestPrefix = ''; for (var directive in unit.directives) { if (directive is ImportDirective) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_like_case_clauses.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_like_case_clauses.dart index e6fdaf1a22a..569053a2f94 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_like_case_clauses.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_missing_enum_like_case_clauses.dart @@ -101,7 +101,7 @@ class AddMissingEnumLikeCaseClauses extends ResolvedCorrectionProducer { } /// Return the names of the constants defined in [classElement]. - List _constantNames(InterfaceElement2 classElement) { + List _constantNames(InterfaceElement classElement) { var type = classElement.thisType; var constantNames = []; for (var field in classElement.fields2) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_missing_required_argument.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_missing_required_argument.dart index a9c39b06f95..b9a8aa3ab90 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_missing_required_argument.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_missing_required_argument.dart @@ -47,7 +47,7 @@ class AddMissingRequiredArgument extends ResolvedCorrectionProducer { @override Future compute(ChangeBuilder builder) async { InstanceCreationExpression? creation; - Element2? targetElement; + Element? targetElement; ArgumentList? argumentList; if (node is SimpleIdentifier || @@ -91,7 +91,7 @@ class AddMissingRequiredArgument extends ResolvedCorrectionProducer { _missingParameters = errors.length; for (var (index, diagnostic) in errors.indexed) { - if (targetElement is ExecutableElement2 && argumentList != null) { + if (targetElement is ExecutableElement && argumentList != null) { // Format: "Missing required argument 'foo'." var messageParts = diagnostic.problemMessage .messageText(includeUrl: false) diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_super_constructor_invocation.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_super_constructor_invocation.dart index 41d6b7f0710..ec072f56b88 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_super_constructor_invocation.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_super_constructor_invocation.dart @@ -60,7 +60,7 @@ class AddSuperConstructorInvocation extends MultiCorrectionProducer { /// the [AddSuperConstructorInvocation] producer. class _AddInvocation extends ResolvedCorrectionProducer { /// The constructor to be invoked. - final ConstructorElement2 _constructor; + final ConstructorElement _constructor; /// The offset at which the initializer is to be inserted. final int _insertOffset; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/add_type_annotation.dart b/pkg/analysis_server/lib/src/services/correction/dart/add_type_annotation.dart index b7fd1723d8a..3f82622dbcc 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/add_type_annotation.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/add_type_annotation.dart @@ -243,7 +243,7 @@ class _AssignedTypeCollector extends RecursiveAstVisitor { /// The type system used to compute the best type. final TypeSystem typeSystem; - final LocalVariableElement2 variable; + final LocalVariableElement variable; /// The types that are assigned to the variable. final Set assignedTypes = {}; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/ambiguous_import_fix.dart b/pkg/analysis_server/lib/src/services/correction/dart/ambiguous_import_fix.dart index 3b5be07000c..02bdfefa201 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/ambiguous_import_fix.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/ambiguous_import_fix.dart @@ -21,7 +21,7 @@ class AmbiguousImportFix extends MultiCorrectionProducer { @override Future> get producers async { var node = this.node; - Element2? element; + Element? element; String? prefix; if (node is NamedType) { element = node.element2; @@ -34,7 +34,7 @@ class AmbiguousImportFix extends MultiCorrectionProducer { prefix = currentPrefix.name; } } - if (element is! MultiplyDefinedElement2) { + if (element is! MultiplyDefinedElement) { return const []; } var conflictingElements = element.conflictingElements2; @@ -99,7 +99,7 @@ class AmbiguousImportFix extends MultiCorrectionProducer { _getImportDirectives( ResolvedLibraryResult libraryResult, ResolvedUnitResult? unitResult, - List conflictingElements, + List conflictingElements, String name, String? prefix, ) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/change_to.dart b/pkg/analysis_server/lib/src/services/correction/dart/change_to.dart index 66fbc0ae701..4ed697f0a30 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/change_to.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/change_to.dart @@ -16,7 +16,7 @@ import 'package:analyzer_plugin/utilities/fixes/fixes.dart'; import 'package:analyzer_plugin/utilities/range_factory.dart'; /// A predicate is a one-argument function that returns a boolean value. -typedef _ElementPredicate = bool Function(Element2 argument); +typedef _ElementPredicate = bool Function(Element argument); class ChangeTo extends ResolvedCorrectionProducer { /// The kind of elements that should be proposed. @@ -84,7 +84,7 @@ class ChangeTo extends ResolvedCorrectionProducer { } Iterable _formalParameterSuggestions( - FunctionTypedElement2 element, + FunctionTypedElement element, Iterable formalParameters, ) { return element.formalParameters.where( @@ -117,7 +117,7 @@ class ChangeTo extends ResolvedCorrectionProducer { nameToken = node.name2; } else if (node is PrefixedIdentifier && node.parent is NamedType && - node.prefix.element is PrefixElement2) { + node.prefix.element is PrefixElement) { prefixName = node.prefix.name; nameToken = node.identifier.token; } else if (node is SimpleIdentifier) { @@ -128,7 +128,7 @@ class ChangeTo extends ResolvedCorrectionProducer { // Prepare for selecting the closest element. var finder = _ClosestElementFinder( nameToken.lexeme, - (element) => element is InterfaceElement2, + (element) => element is InterfaceElement, ); // Check elements of this library. if (prefixName == null) { @@ -164,7 +164,7 @@ class ChangeTo extends ResolvedCorrectionProducer { } } else if (target is ExtensionOverride) { _updateFinderWithExtensionMembers(finder, target.element2); - } else if (targetIdentifierElement is ExtensionElement2) { + } else if (targetIdentifierElement is ExtensionElement) { _updateFinderWithExtensionMembers(finder, targetIdentifierElement); } else { var interfaceElement = getTargetInterfaceElement(target); @@ -203,7 +203,7 @@ class ChangeTo extends ResolvedCorrectionProducer { var type = node.type?.type; await _proposeClassOrMixinMember(builder, node.name, null, (element) { - return element is FieldElement2 && + return element is FieldElement && !exclusions.contains(element.name3) && !element.isSynthetic && !element.isExternal && @@ -225,7 +225,7 @@ class ChangeTo extends ResolvedCorrectionProducer { var invocation = node.parent; if (invocation is MethodInvocation && invocation.methodName == node) { var target = invocation.target; - if (target is SimpleIdentifier && target.element is PrefixElement2) { + if (target is SimpleIdentifier && target.element is PrefixElement) { prefixName = target.name; } } @@ -273,7 +273,7 @@ class ChangeTo extends ResolvedCorrectionProducer { return wantGetter; } else if (element is SetterElement) { return wantSetter; - } else if (element is FieldElement2) { + } else if (element is FieldElement) { return wantGetter && element.getter2 != null || wantSetter && element.setter2 != null; } @@ -290,7 +290,7 @@ class ChangeTo extends ResolvedCorrectionProducer { builder, node.token, parent.realTarget, - (element) => element is MethodElement2 && !element.isOperator, + (element) => element is MethodElement && !element.isOperator, ); } } @@ -354,7 +354,7 @@ class ChangeTo extends ResolvedCorrectionProducer { void _updateFinderWithClassMembers( _ClosestElementFinder finder, - InterfaceElement2 clazz, + InterfaceElement clazz, ) { var members = getMembers(clazz); finder._updateList(members); @@ -362,7 +362,7 @@ class ChangeTo extends ResolvedCorrectionProducer { void _updateFinderWithExtensionMembers( _ClosestElementFinder finder, - ExtensionElement2? element, + ExtensionElement? element, ) { if (element != null) { finder._updateList(getExtensionMembers(element)); @@ -370,7 +370,7 @@ class ChangeTo extends ResolvedCorrectionProducer { } } -/// Helper for finding [Element2] with name closest to the given. +/// Helper for finding [Element] with name closest to the given. class _ClosestElementFinder { /// The maximum Levenshtein distance between the existing name and a possible /// replacement before the replacement is deemed to not be worth offering. @@ -385,11 +385,11 @@ class _ClosestElementFinder { int _distance = _maxDistance; - Element2? _element; + Element? _element; _ClosestElementFinder(this._targetName, this._predicate); - void _update(Element2 element) { + void _update(Element element) { if (_predicate(element)) { var name = element.name3; if (name != null) { @@ -402,7 +402,7 @@ class _ClosestElementFinder { } } - void _updateList(Iterable elements) { + void _updateList(Iterable elements) { for (var element in elements) { _update(element); } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/change_to_static_access.dart b/pkg/analysis_server/lib/src/services/correction/dart/change_to_static_access.dart index 6680d8b226e..c187e7a2f63 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/change_to_static_access.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/change_to_static_access.dart @@ -50,13 +50,13 @@ class ChangeToStaticAccess extends ResolvedCorrectionProducer { } var invokedElement = identifier.element; - if (invokedElement is! ExecutableElement2) { + if (invokedElement is! ExecutableElement) { return; } var declaringElement = invokedElement.enclosingElement2; - if (declaringElement is InterfaceElement2) { + if (declaringElement is InterfaceElement) { var declaringElementName = declaringElement.name3; if (declaringElementName != null) { _className = declaringElementName; @@ -66,7 +66,7 @@ class ChangeToStaticAccess extends ResolvedCorrectionProducer { }); }); } - } else if (declaringElement is ExtensionElement2) { + } else if (declaringElement is ExtensionElement) { var extensionName = declaringElement.name3; if (extensionName != null) { _className = extensionName; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_enum.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_enum.dart index a781d6656e0..0acf5be3a0e 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_enum.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_enum.dart @@ -71,7 +71,7 @@ class ConvertClassToEnum extends ResolvedCorrectionProducer { /// A superclass for the [_EnumVisitor] and [_NonEnumVisitor]. class _BaseVisitor extends RecursiveAstVisitor { /// The element representing the enum declaration that's being visited. - final ClassElement2 classElement; + final ClassElement classElement; _BaseVisitor(this.classElement); @@ -97,7 +97,7 @@ class _CannotConvertException implements Exception { /// replaced by an enum constant. class _ConstantField extends _Field { /// The element representing the constructor used to initialize the field. - ConstructorElement2 constructorElement; + ConstructorElement constructorElement; /// The invocation of the constructor. final InstanceCreationExpression instanceCreation; @@ -122,7 +122,7 @@ class _Constructor { final ConstructorDeclaration declaration; /// The element representing the constructor. - final ConstructorElement2 element; + final ConstructorElement element; _Constructor(this.declaration, this.element); } @@ -130,7 +130,7 @@ class _Constructor { /// Information about the constructors in the class being converted. class _Constructors { /// A map from elements to constructors. - final Map byElement = {}; + final Map byElement = {}; _Constructors(); @@ -143,7 +143,7 @@ class _Constructors { } /// Return the constructor with the given [element]. - _Constructor? forElement(ConstructorElement2 element) { + _Constructor? forElement(ConstructorElement element) { return byElement[element]; } } @@ -449,7 +449,7 @@ class _EnumDescription { _Constructors constructors, _Fields fields, ) { - var usedElements = {}; + var usedElements = {}; for (var field in fields.fieldsToConvert) { usedElements.add(field.constructorElement); } @@ -533,7 +533,7 @@ class _EnumDescription { var indexFieldElement = indexField.element; for (var i = 0; i < parameters.length; i++) { var element = parameters[i].declaredFragment!.element; - if (element is FieldFormalParameterElement2) { + if (element is FieldFormalParameterElement) { if (element.field2 == indexFieldElement) { if (element.isPositional) { return _Parameter(i, element); @@ -552,13 +552,13 @@ class _EnumDescription { /// The [classElement] must be the element declared by the [classDeclaration]. static _Constructors? _validateConstructors( ClassDeclaration classDeclaration, - ClassElement2 classElement, + ClassElement classElement, ) { var constructors = _Constructors(); for (var member in classDeclaration.members) { if (member is ConstructorDeclaration) { var constructor = member.declaredFragment?.element; - if (constructor is ConstructorElement2) { + if (constructor is ConstructorElement) { if (!classElement.isPrivate && !constructor.isPrivate) { // Public constructor in public enum. return null; @@ -582,7 +582,7 @@ class _EnumDescription { /// The [classElement] must be the element declared by the [classDeclaration]. static _Fields? _validateFields( ClassDeclaration classDeclaration, - ClassElement2 classElement, { + ClassElement classElement, { required bool strictCasts, }) { var potentialFieldsToConvert = >{}; @@ -595,7 +595,7 @@ class _EnumDescription { if (member.isStatic) { for (var field in fields) { var fieldElement = field.declaredFragment?.element; - if (fieldElement is FieldElement2) { + if (fieldElement is FieldElement) { var fieldType = fieldElement.type; // The field can be converted to be an enum constant if it // - is a const field, @@ -643,7 +643,7 @@ class _EnumDescription { return null; } var fieldElement = field.declaredFragment?.element; - if (fieldElement is FieldElement2) { + if (fieldElement is FieldElement) { var fieldType = fieldElement.type; if (fieldElement.name3 == 'index' && fieldType.isDartCoreInt) { indexField = _Field(fieldElement, field, fieldList, member); @@ -728,7 +728,7 @@ class _EnumVisitor extends _BaseVisitor { /// A representation of a field of interest in the class being converted. class _Field { /// The element representing the field. - final FieldElement2 element; + final FieldElement element; /// The declaration of the field. final VariableDeclaration declaration; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_mixin.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_mixin.dart index 892c197ecad..7d6ceb3b859 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_mixin.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_class_to_mixin.dart @@ -91,7 +91,7 @@ class ConvertClassToMixin extends ResolvedCorrectionProducer { /// A visitor used to find all of the classes that define members referenced via /// `super`. class _SuperclassReferenceFinder extends RecursiveAstVisitor { - final List referencedClasses = []; + final List referencedClasses = []; _SuperclassReferenceFinder(); @@ -112,10 +112,10 @@ class _SuperclassReferenceFinder extends RecursiveAstVisitor { return super.visitSuperExpression(node); } - void _addElement(Element2? element) { - if (element is ExecutableElement2) { + void _addElement(Element? element) { + if (element is ExecutableElement) { var enclosingElement = element.enclosingElement2; - if (enclosingElement is ClassElement2) { + if (enclosingElement is ClassElement) { referencedClasses.add(enclosingElement); } } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_into_block_body.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_into_block_body.dart index 1b85b1c4dfe..f0fd3d9ef32 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_into_block_body.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_into_block_body.dart @@ -179,7 +179,7 @@ class ConvertIntoBlockBody extends ResolvedCorrectionProducer { return [returnCode]; } - ExecutableElement2? _getFunctionElement(AstNode? node) { + ExecutableElement? _getFunctionElement(AstNode? node) { if (node is MethodDeclaration) { return node.declaredFragment?.element; } else if (node is ConstructorDeclaration) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_into_final_field.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_into_final_field.dart index 94983265f23..458ee143f2a 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_into_final_field.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_into_final_field.dart @@ -57,7 +57,7 @@ class ConvertIntoFinalField extends ResolvedCorrectionProducer { // static. if (!getterElement.isStatic) { switch (getterElement.enclosingElement2) { - case ExtensionElement2() || ExtensionTypeElement2(): + case ExtensionElement() || ExtensionTypeElement(): return; } } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_into_for_index.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_into_for_index.dart index c097f6973a3..319b5e393f7 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_into_for_index.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_into_for_index.dart @@ -51,7 +51,7 @@ class ConvertIntoForIndex extends ResolvedCorrectionProducer { // iterable should be VariableElement String listName; var iterable = forEachParts.iterable; - if (iterable is SimpleIdentifier && iterable.element is VariableElement2) { + if (iterable is SimpleIdentifier && iterable.element is VariableElement) { listName = iterable.name; } else { return; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_null_check_to_null_aware_element_or_entry.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_null_check_to_null_aware_element_or_entry.dart index 251c174a9fb..ce4cd69ef49 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_null_check_to_null_aware_element_or_entry.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_null_check_to_null_aware_element_or_entry.dart @@ -143,7 +143,7 @@ class ConvertNullCheckToNullAwareElementOrEntry } extension AstNodeNullableExtension on AstNode? { - Element2? get canonicalElement { + Element? get canonicalElement { var self = this; if (self is Expression) { var node = self.unParenthesized; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_if_case_statement.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_if_case_statement.dart index b3191a33ef5..3433e8d1b3f 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_if_case_statement.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_if_case_statement.dart @@ -180,7 +180,7 @@ class ConvertToIfCaseStatement extends ResolvedCorrectionProducer { class _DeclaredVariable { final VariableDeclarationStatement statement; final VariableDeclaration declaration; - final LocalVariableElement2 element; + final LocalVariableElement element; final Expression initializer; _DeclaredVariable({ @@ -196,7 +196,7 @@ class _DeclaredVariable { } class _ReferenceVisitor extends RecursiveAstVisitor { - final LocalVariableElement2 element; + final LocalVariableElement element; bool hasReference = false; _ReferenceVisitor(this.element); @@ -240,7 +240,7 @@ extension on Statement { } var declaredElement = declaration.declaredElement2; - if (declaredElement is! LocalVariableElement2) { + if (declaredElement is! LocalVariableElement) { return null; } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_initializing_formal.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_initializing_formal.dart index 859379a3ca4..3d5c617bcab 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_initializing_formal.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_initializing_formal.dart @@ -82,7 +82,7 @@ class ConvertToInitializingFormal extends ResolvedCorrectionProducer { } var fieldElement = node.fieldName.element; - if (fieldElement is! VariableElement2) { + if (fieldElement is! VariableElement) { return; } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_map_literal.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_map_literal.dart index 039b5958d41..7f6fd247c36 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_map_literal.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_map_literal.dart @@ -83,7 +83,7 @@ class ConvertToMapLiteral extends ResolvedCorrectionProducer { /// Return `true` if the [element] represents either the class `Map` or /// `LinkedHashMap`. - bool _isMapClass(InterfaceElement2 element) => + bool _isMapClass(InterfaceElement element) => element == typeProvider.mapElement2 || (element.name3 == 'LinkedHashMap' && element.library2.name3 == 'dart.collection'); diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_switch_expression.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_switch_expression.dart index 195f6789068..b0de957b7f7 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_switch_expression.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_switch_expression.dart @@ -19,7 +19,7 @@ import 'package:analyzer_plugin/utilities/range_factory.dart'; class ConvertToSwitchExpression extends ResolvedCorrectionProducer { /// Local variable reference used in assignment switch expression generation. - LocalVariableElement2? writeElement; + LocalVariableElement? writeElement; /// Assignment operator used in assignment switch expression generation. TokenType? assignmentOperator; @@ -488,7 +488,7 @@ class ConvertToSwitchExpression extends ResolvedCorrectionProducer { if (leftHandSide is! SimpleIdentifierImpl) return null; if (writeElement == null) { var element = leftHandSide.element; - if (element is! LocalVariableElement2) return null; + if (element is! LocalVariableElement) return null; writeElement = element; assignmentOperator = expression.operator.type; } else if (writeElement != leftHandSide.element || diff --git a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_wildcard_variable.dart b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_wildcard_variable.dart index 4e46ae39499..6a023f1be02 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/convert_to_wildcard_variable.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/convert_to_wildcard_variable.dart @@ -47,7 +47,7 @@ class ConvertToWildcardVariable extends ResolvedCorrectionProducer { var nameToken = node.name; var element = node.declaredElement2; - if (element is! LocalVariableElement2) { + if (element is! LocalVariableElement) { return; } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_class.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_class.dart index 220a8f13421..33d043f6bc9 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_class.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_class.dart @@ -30,7 +30,7 @@ class CreateClass extends ResolvedCorrectionProducer { @override Future compute(ChangeBuilder builder) async { var targetNode = node; - Element2? prefixElement; + Element? prefixElement; ArgumentList? arguments; String? className; @@ -94,7 +94,7 @@ class CreateClass extends ResolvedCorrectionProducer { prefix = '$eol$eol'; } else { for (var import in libraryElement2.firstFragment.libraryImports2) { - if (prefixElement is PrefixElement2 && + if (prefixElement is PrefixElement && import.prefix2?.element == prefixElement) { var library = import.importedLibrary2; if (library != null) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_constructor.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_constructor.dart index 954aad527e0..07d83c0c853 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_constructor.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_constructor.dart @@ -176,7 +176,7 @@ class CreateConstructor extends ResolvedCorrectionProducer { } var targetElement = constructorElement.enclosingElement2; - var targetFragment = (targetElement as ClassElement2).firstFragment; + var targetFragment = (targetElement as ClassElement).firstFragment; var targetElementName = targetElement.name3; if (targetElementName == null) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_constructor_super.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_constructor_super.dart index cf8ccb45b74..102e10c0c6d 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_constructor_super.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_constructor_super.dart @@ -45,7 +45,7 @@ class CreateConstructorSuper extends MultiCorrectionProducer { /// the [CreateConstructorSuper] producer. class _CreateConstructor extends ResolvedCorrectionProducer { /// The constructor to be invoked. - final ConstructorElement2 _constructor; + final ConstructorElement _constructor; /// The class in which the constructor will be added. final ClassDeclaration _targetClass; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_extension_member.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_extension_member.dart index 14f8e7adc2a..850b3a0a255 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_extension_member.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_extension_member.dart @@ -418,7 +418,7 @@ abstract class _CreateExtensionMember extends ResolvedCorrectionProducer { return CorrectionApplicability.singleLocation; } - ExecutableElement2? get methodBeingCopied => + ExecutableElement? get methodBeingCopied => _enclosingFunction?.declaredFragment?.element; FunctionDeclaration? get _enclosingFunction => node.thisOrAncestorOfType(); @@ -517,7 +517,7 @@ extension on List { /// it uses and get any type parameters they use by using this same getter. /// /// These types are added internally to a set so that we don't add duplicates. - List get typeParameters => + List get typeParameters => { for (var type in whereType()) ...[ type.element3, @@ -528,10 +528,10 @@ extension on List { }.toList(); } -extension on Element2? { +extension on Element? { bool get declaresIndex { var element = this; - if (element is! InterfaceElement2) { + if (element is! InterfaceElement) { return false; } var inheritanceManager3 = InheritanceManager3(); diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_field.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_field.dart index 13279718a3d..50dcc9fd8bf 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_field.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_field.dart @@ -33,7 +33,7 @@ class CreateField extends CreateFieldOrGetter { @override Future addForObjectPattern({ required ChangeBuilder builder, - required InterfaceElement2? targetElement, + required InterfaceElement? targetElement, required String fieldName, required DartType? fieldType, }) async { @@ -64,7 +64,7 @@ class CreateField extends CreateFieldOrGetter { Future _addDeclaration({ required ChangeBuilder builder, required bool staticModifier, - required InterfaceElement2? targetElement, + required InterfaceElement? targetElement, required DartType? fieldType, }) async { if (targetElement == null) { @@ -153,7 +153,7 @@ class CreateField extends CreateFieldOrGetter { }; // Prepare target `ClassElement`. var staticModifier = false; - InterfaceElement2? targetClassElement; + InterfaceElement? targetClassElement; if (target != null) { targetClassElement = getTargetInterfaceElement(target); // Maybe static. @@ -172,7 +172,7 @@ class CreateField extends CreateFieldOrGetter { var fieldTypeNode = climbPropertyAccess(nameNode); var fieldTypeParent = fieldTypeNode.parent; - if (targetClassElement is EnumElement2 && + if (targetClassElement is EnumElement && fieldTypeParent is AssignmentExpression && fieldTypeNode == fieldTypeParent.leftHandSide) { // Any field on an enum must be final; creating a final field does not diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_getter.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_getter.dart index b8ebae7c514..b652e5f22ea 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_getter.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_getter.dart @@ -23,7 +23,7 @@ abstract class CreateFieldOrGetter extends ResolvedCorrectionProducer { /// Adds the declaration that makes a [fieldName] available. Future addForObjectPattern({ required ChangeBuilder builder, - required InterfaceElement2? targetElement, + required InterfaceElement? targetElement, required String fieldName, required DartType? fieldType, }); @@ -103,7 +103,7 @@ class CreateGetter extends CreateFieldOrGetter { @override Future addForObjectPattern({ required ChangeBuilder builder, - required InterfaceElement2? targetElement, + required InterfaceElement? targetElement, required String fieldName, required DartType? fieldType, }) async { @@ -142,11 +142,11 @@ class CreateGetter extends CreateFieldOrGetter { } // prepare target element var staticModifier = false; - InstanceElement2? targetElement; + InstanceElement? targetElement; if (target is ExtensionOverride) { targetElement = target.element2; - } else if (target is Identifier && target.element is ExtensionElement2) { - targetElement = target.element as InstanceElement2?; + } else if (target is Identifier && target.element is ExtensionElement) { + targetElement = target.element as InstanceElement?; staticModifier = true; } else if (target != null) { // prepare target interface type @@ -185,7 +185,7 @@ class CreateGetter extends CreateFieldOrGetter { Future _addDeclaration({ required ChangeBuilder builder, required bool staticModifier, - required InstanceElement2? targetElement, + required InstanceElement? targetElement, required DartType? fieldType, }) async { if (targetElement == null) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_method.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_method.dart index 7fdd40b658d..502822dd79a 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_method.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_method.dart @@ -66,7 +66,7 @@ class CreateMethod extends ResolvedCorrectionProducer { await builder.addDartFileEdit(file, (fileBuilder) { fileBuilder.insertIntoUnitMember(classDecl, (builder) { - ExecutableElement2? element; + ExecutableElement? element; if (missingEquals) { _memberName = '=='; element = inheritanceManager.getInherited4( @@ -109,8 +109,8 @@ class CreateMethod extends ResolvedCorrectionProducer { return; } } - } else if (target is Identifier && target.element is ExtensionElement2) { - targetFragment = (target.element as ExtensionElement2).firstFragment; + } else if (target is Identifier && target.element is ExtensionElement) { + targetFragment = (target.element as ExtensionElement).firstFragment; if (targetFragment is ExtensionFragment) { targetNode = await getExtensionDeclaration(targetFragment); if (targetNode == null) { @@ -141,16 +141,16 @@ class CreateMethod extends ResolvedCorrectionProducer { return; } // Prepare target ClassDeclaration. - if (targetClassElement is MixinElement2) { + if (targetClassElement is MixinElement) { var fragment = targetClassElement.firstFragment; targetNode = await getMixinDeclaration(fragment); - } else if (targetClassElement is ClassElement2) { + } else if (targetClassElement is ClassElement) { var fragment = targetClassElement.firstFragment; targetNode = await getClassDeclaration(fragment); - } else if (targetClassElement is ExtensionTypeElement2) { + } else if (targetClassElement is ExtensionTypeElement) { var fragment = targetClassElement.firstFragment; targetNode = await getExtensionTypeDeclaration(fragment); - } else if (targetClassElement is EnumElement2) { + } else if (targetClassElement is EnumElement) { var fragment = targetClassElement.firstFragment; targetNode = await getEnumDeclaration(fragment); } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart index a81de9183e7..1b4dc6e7075 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_method_or_function.dart @@ -40,7 +40,7 @@ class CreateMethodOrFunction extends ResolvedCorrectionProducer { var nameNode = node; if (nameNode is SimpleIdentifier) { // prepare argument expression (to get parameter) - InterfaceElement2? targetElement; + InterfaceElement? targetElement; Expression argument; var target = getQualifiedPropertyTarget(node); if (target != null) { @@ -49,7 +49,7 @@ class CreateMethodOrFunction extends ResolvedCorrectionProducer { targetElement = targetType.element3; argument = target.parent as Expression; } else if (target case SimpleIdentifier( - :InterfaceElement2? element, + :InterfaceElement? element, :Expression parent, )) { isStatic = true; @@ -207,7 +207,7 @@ class CreateMethodOrFunction extends ResolvedCorrectionProducer { /// [FunctionType] inside the target element. Future _createMethod( ChangeBuilder builder, - InterfaceElement2 targetClassElement, + InterfaceElement targetClassElement, FunctionType functionType, { required bool isStatic, }) async { @@ -217,19 +217,19 @@ class CreateMethodOrFunction extends ResolvedCorrectionProducer { // prepare insert offset CompilationUnitMember? targetNode; List? classMembers; - if (targetClassElement is MixinElement2) { + if (targetClassElement is MixinElement) { var fragment = targetClassElement.firstFragment; var node = targetNode = await getMixinDeclaration(fragment); classMembers = node?.members; - } else if (targetClassElement is ClassElement2) { + } else if (targetClassElement is ClassElement) { var fragment = targetClassElement.firstFragment; var node = targetNode = await getClassDeclaration(fragment); classMembers = node?.members; - } else if (targetClassElement is ExtensionTypeElement2) { + } else if (targetClassElement is ExtensionTypeElement) { var fragment = targetClassElement.firstFragment; var node = targetNode = await getExtensionTypeDeclaration(fragment); classMembers = node?.members; - } else if (targetClassElement is EnumElement2) { + } else if (targetClassElement is EnumElement) { var fragment = targetClassElement.firstFragment; var node = targetNode = await getEnumDeclaration(fragment); classMembers = node?.members; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_missing_overrides.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_missing_overrides.dart index 87926684a9c..9194a4efd61 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_missing_overrides.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_missing_overrides.dart @@ -46,7 +46,7 @@ class CreateMissingOverrides extends ResolvedCorrectionProducer { ...InheritanceOverrideVerifier.missingMustBeOverridden(targetDeclaration), ]; // Sort by name, getters before setters. - signatures.sort((ExecutableElement2 a, ExecutableElement2 b) { + signatures.sort((ExecutableElement a, ExecutableElement b) { var names = compareStrings(a.displayName, b.displayName); if (names != 0) { return names; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_mixin.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_mixin.dart index 5a74db3b7d6..da06e0e58d2 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_mixin.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_mixin.dart @@ -29,7 +29,7 @@ class CreateMixin extends ResolvedCorrectionProducer { @override Future compute(ChangeBuilder builder) async { - Element2? prefixElement; + Element? prefixElement; var node = this.node; if (node is NamedType) { var importPrefix = node.importPrefix; @@ -85,7 +85,7 @@ class CreateMixin extends ResolvedCorrectionProducer { prefix = '$eol$eol'; } else { for (var import in libraryElement2.firstFragment.libraryImports2) { - if (prefixElement is PrefixElement2 && + if (prefixElement is PrefixElement && import.prefix2?.element == prefixElement) { var library = import.importedLibrary2; if (library != null) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/create_setter.dart b/pkg/analysis_server/lib/src/services/correction/dart/create_setter.dart index cf768dd6e8f..2e0fe4b8c66 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/create_setter.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/create_setter.dart @@ -49,11 +49,11 @@ class CreateSetter extends ResolvedCorrectionProducer { } // prepare target element var staticModifier = false; - InstanceElement2? targetElement; + InstanceElement? targetElement; if (target is ExtensionOverride) { targetElement = target.element2; - } else if (target is Identifier && target.element is ExtensionElement2) { - targetElement = target.element as ExtensionElement2; + } else if (target is Identifier && target.element is ExtensionElement) { + targetElement = target.element as ExtensionElement; staticModifier = true; } else if (target != null) { // prepare target interface type diff --git a/pkg/analysis_server/lib/src/services/correction/dart/data_driven.dart b/pkg/analysis_server/lib/src/services/correction/dart/data_driven.dart index afe264c147e..9a536c39c27 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/data_driven.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/data_driven.dart @@ -59,9 +59,7 @@ class DataDriven extends MultiCorrectionProducer { /// Return the transform sets that are available for fixing issues in the /// given [library]. - List _availableTransformSetsForLibrary( - LibraryElement2 library, - ) { + List _availableTransformSetsForLibrary(LibraryElement library) { var setsForTests = transformSetsForTests; if (setsForTests != null) { return setsForTests; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/destructure_local_variable_assignment.dart b/pkg/analysis_server/lib/src/services/correction/dart/destructure_local_variable_assignment.dart index 9c36471515c..c382ef00db6 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/destructure_local_variable_assignment.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/destructure_local_variable_assignment.dart @@ -253,7 +253,7 @@ abstract class RecordField { } class _ReferenceFinder extends RecursiveAstVisitor { - final LocalVariableElement2? element; + final LocalVariableElement? element; final objectReferences = []; final propertyReferences = >{}; @@ -288,7 +288,7 @@ class _ReferenceFinder extends RecursiveAstVisitor { } } -extension on LocalVariableElement2 { +extension on LocalVariableElement { ({ List objectReferences, Map> propertyReferences, diff --git a/pkg/analysis_server/lib/src/services/correction/dart/encapsulate_field.dart b/pkg/analysis_server/lib/src/services/correction/dart/encapsulate_field.dart index d5fcc28a033..6bdbaf836bb 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/encapsulate_field.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/encapsulate_field.dart @@ -60,7 +60,7 @@ class EncapsulateField extends ResolvedCorrectionProducer { // Should be in a class or mixin. List classMembers; - InterfaceElement2 parentElement; + InterfaceElement parentElement; var parent = fieldDeclaration.parent; switch (parent) { case ClassDeclaration(): @@ -170,7 +170,7 @@ class EncapsulateField extends ResolvedCorrectionProducer { void _updateReferencesInConstructor( DartFileEditBuilder builder, ConstructorDeclaration constructor, - FieldElement2 fieldElement, + FieldElement fieldElement, String name, String fieldTypeCode, ) { @@ -178,7 +178,7 @@ class EncapsulateField extends ResolvedCorrectionProducer { var identifier = parameter.name; var parameterElement = parameter.declaredFragment?.element; if (identifier != null && - parameterElement is FieldFormalParameterElement2 && + parameterElement is FieldFormalParameterElement && parameterElement.field2 == fieldElement) { if (parameter.isNamed && parameter is DefaultFormalParameter) { var normalParam = parameter.parameter; @@ -215,7 +215,7 @@ class EncapsulateField extends ResolvedCorrectionProducer { void _updateReferencesInConstructors( DartFileEditBuilder builder, List classMembers, - FieldElement2 fieldElement, + FieldElement fieldElement, String name, String fieldTypeCode, ) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/extract_local_variable.dart b/pkg/analysis_server/lib/src/services/correction/dart/extract_local_variable.dart index 280050f313f..ab36dd94814 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/extract_local_variable.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/extract_local_variable.dart @@ -79,7 +79,7 @@ class ExtractLocalVariable extends ResolvedCorrectionProducer { Future _rewriteProperty({ required ChangeBuilder builder, required Expression target, - required Element2? targetProperty, + required Element? targetProperty, }) async { if (targetProperty is! GetterElement) { return; @@ -140,12 +140,12 @@ class ExtractLocalVariable extends ResolvedCorrectionProducer { } class _ExpressionEncoder { - final Map _elementIds = {}; + final Map _elementIds = {}; String encode(Expression node) { var tokens = node.tokens; - var tokenToElementMap = Map.identity(); + var tokenToElementMap = Map.identity(); node.accept( _FunctionAstVisitor( simpleIdentifier: (node) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_stateful_widget.dart b/pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_stateful_widget.dart index 27c49239f39..eb2652490a7 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_stateful_widget.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_stateful_widget.dart @@ -71,7 +71,7 @@ class FlutterConvertToStatefulWidget extends ResolvedCorrectionProducer { // Prepare nodes to move. var nodesToMove = {}; - var elementsToMove = {}; + var elementsToMove = {}; for (var member in widgetClass.members) { if (member is FieldDeclaration && !member.isStatic) { for (var fieldNode in member.fields.variables) { @@ -273,12 +273,12 @@ class FlutterConvertToStatefulWidget extends ResolvedCorrectionProducer { } class _FieldFinder extends RecursiveAstVisitor { - Set fieldsAssignedInConstructors = {}; + Set fieldsAssignedInConstructors = {}; @override void visitFieldFormalParameter(FieldFormalParameter node) { var element = node.declaredFragment?.element; - if (element is FieldFormalParameterElement2) { + if (element is FieldFormalParameterElement) { var field = element.field2; if (field != null) { fieldsAssignedInConstructors.add(field); @@ -292,7 +292,7 @@ class _FieldFinder extends RecursiveAstVisitor { void visitSimpleIdentifier(SimpleIdentifier node) { if (node.parent is ConstructorFieldInitializer) { var element = node.element; - if (element is FieldElement2) { + if (element is FieldElement) { fieldsAssignedInConstructors.add(element); } } @@ -300,7 +300,7 @@ class _FieldFinder extends RecursiveAstVisitor { var element = node.writeOrReadElement2; if (element is SetterElement) { var field = element.variable3; - if (field is FieldElement2) { + if (field is FieldElement) { fieldsAssignedInConstructors.add(field); } } @@ -309,9 +309,9 @@ class _FieldFinder extends RecursiveAstVisitor { } class _ReplacementEditBuilder extends RecursiveAstVisitor { - final ClassElement2 widgetClassElement; + final ClassElement widgetClassElement; - final Set elementsToMove; + final Set elementsToMove; final SourceRange linesRange; @@ -329,7 +329,7 @@ class _ReplacementEditBuilder extends RecursiveAstVisitor { return; } var element = node.element; - if (element is ExecutableElement2 && + if (element is ExecutableElement && element.enclosingElement2 == widgetClassElement && !elementsToMove.contains(element)) { var offset = node.offset - linesRange.offset; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_stateless_widget.dart b/pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_stateless_widget.dart index 9d039ad9041..88a28e6e68d 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_stateless_widget.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/flutter_convert_to_stateless_widget.dart @@ -86,7 +86,7 @@ class FlutterConvertToStatelessWidget extends ResolvedCorrectionProducer { // Prepare nodes to move. var nodesToMove = []; - var elementsToMove = {}; + var elementsToMove = {}; for (var member in stateClass.members) { if (member is FieldDeclaration) { if (member.isStatic) { @@ -94,7 +94,7 @@ class FlutterConvertToStatelessWidget extends ResolvedCorrectionProducer { } for (var fieldNode in member.fields.variables) { var fieldElement = - fieldNode.declaredFragment!.element as FieldElement2; + fieldNode.declaredFragment!.element as FieldElement; if (!fieldsAssignedInConstructors.contains(fieldElement)) { nodesToMove.add(member); elementsToMove.add(fieldElement); @@ -195,7 +195,7 @@ class FlutterConvertToStatelessWidget extends ResolvedCorrectionProducer { return null; } - ClassDeclaration? _findStateClass(ClassElement2 widgetClassElement) { + ClassDeclaration? _findStateClass(ClassElement widgetClassElement) { for (var declaration in unit.declarations) { if (declaration is ClassDeclaration) { var type = declaration.extendsClause?.superclass.type; @@ -265,7 +265,7 @@ class FlutterConvertToStatelessWidget extends ResolvedCorrectionProducer { return false; } - static bool _isState(ClassElement2 widgetClassElement, DartType? type) { + static bool _isState(ClassElement widgetClassElement, DartType? type) { if (type is! InterfaceType) return false; var firstArgument = type.typeArguments.singleOrNull; @@ -275,18 +275,18 @@ class FlutterConvertToStatelessWidget extends ResolvedCorrectionProducer { } var classElement = type.element3; - return classElement is ClassElement2 && classElement.isExactState; + return classElement is ClassElement && classElement.isExactState; } } class _FieldFinder extends RecursiveAstVisitor { - Set fieldsAssignedInConstructors = {}; + Set fieldsAssignedInConstructors = {}; @override void visitSimpleIdentifier(SimpleIdentifier node) { if (node.parent is FieldFormalParameter) { var element = node.element; - if (element is FieldFormalParameterElement2) { + if (element is FieldFormalParameterElement) { var field = element.field2; if (field != null) { fieldsAssignedInConstructors.add(field); @@ -295,17 +295,17 @@ class _FieldFinder extends RecursiveAstVisitor { } if (node.parent is ConstructorFieldInitializer) { var element = node.element; - if (element is FieldElement2) { + if (element is FieldElement) { fieldsAssignedInConstructors.add(element); } } if (node.inSetterContext()) { var element = node.writeOrReadElement2; var field = switch (element) { - PropertyAccessorElement2(:var variable3) => variable3, + PropertyAccessorElement(:var variable3) => variable3, _ => null, }; - if (field is FieldElement2) { + if (field is FieldElement) { fieldsAssignedInConstructors.add(field); } } @@ -313,9 +313,9 @@ class _FieldFinder extends RecursiveAstVisitor { } class _ReplacementEditBuilder extends RecursiveAstVisitor { - final ClassElement2 widgetClassElement; + final ClassElement widgetClassElement; - final Set elementsToMove; + final Set elementsToMove; final SourceRange linesRange; @@ -333,7 +333,7 @@ class _ReplacementEditBuilder extends RecursiveAstVisitor { return; } var element = node.element; - if (element is ExecutableElement2 && + if (element is ExecutableElement && element.enclosingElement2 == widgetClassElement && !elementsToMove.contains(element)) { var parent = node.parent; @@ -390,7 +390,7 @@ class _StatelessVerifier extends RecursiveAstVisitor { void visitMethodInvocation(MethodInvocation node) { var methodElement = node.methodName.element?.baseElement; var classElement = methodElement?.enclosingElement2; - if (classElement is ClassElement2 && + if (classElement is ClassElement && classElement.isExactState && !FlutterConvertToStatelessWidget._isDefaultOverride( node.thisOrAncestorOfType(), @@ -404,8 +404,8 @@ class _StatelessVerifier extends RecursiveAstVisitor { class _StateUsageVisitor extends RecursiveAstVisitor { bool used = false; - ClassElement2 widgetClassElement; - ClassElement2 stateClassElement; + ClassElement widgetClassElement; + ClassElement stateClassElement; _StateUsageVisitor(this.widgetClassElement, this.stateClassElement); diff --git a/pkg/analysis_server/lib/src/services/correction/dart/flutter_remove_widget.dart b/pkg/analysis_server/lib/src/services/correction/dart/flutter_remove_widget.dart index 58dfe5fcceb..756581243ac 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/flutter_remove_widget.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/flutter_remove_widget.dart @@ -161,7 +161,7 @@ class FlutterRemoveWidget extends ResolvedCorrectionProducer { } class _UsageFinder extends RecursiveAstVisitor { - final Element2 element; + final Element element; bool used = false; _UsageFinder(this.element); diff --git a/pkg/analysis_server/lib/src/services/correction/dart/flutter_wrap.dart b/pkg/analysis_server/lib/src/services/correction/dart/flutter_wrap.dart index 6397fa283ea..5d9d1743d9a 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/flutter_wrap.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/flutter_wrap.dart @@ -337,7 +337,7 @@ abstract class _WrapSingleWidget extends ResolvedCorrectionProducer { // If the wrapper class is specified, find its element. var parentLibraryUri = _parentLibraryUri; var parentClassName = _parentClassName; - ClassElement2? parentClassElement; + ClassElement? parentClassElement; if (parentLibraryUri != null && parentClassName != null) { parentClassElement = await sessionHelper.getClass( parentLibraryUri, diff --git a/pkg/analysis_server/lib/src/services/correction/dart/import_add_show.dart b/pkg/analysis_server/lib/src/services/correction/dart/import_add_show.dart index 6f06240b0ef..175ff0e430a 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/import_add_show.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/import_add_show.dart @@ -59,7 +59,7 @@ class ImportAddShow extends ResolvedCorrectionProducer { } class _ReferenceFinder extends RecursiveAstVisitor { - final Map namespace; + final Map namespace; Set referencedNames = SplayTreeSet(); @@ -132,15 +132,15 @@ class _ReferenceFinder extends RecursiveAstVisitor { _addName(node.token, element); } - void _addImplicitExtensionName(Element2? enclosingElement) { - if (enclosingElement is ExtensionElement2) { + void _addImplicitExtensionName(Element? enclosingElement) { + if (enclosingElement is ExtensionElement) { if (namespace[enclosingElement.name3] == enclosingElement) { referencedNames.add(enclosingElement.displayName); } } } - void _addName(Token nameToken, Element2? element) { + void _addName(Token nameToken, Element? element) { if (element != null) { var name = nameToken.lexeme; if (namespace[name] == element || namespace['$name='] == element) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/import_library.dart b/pkg/analysis_server/lib/src/services/correction/dart/import_library.dart index f5119ddcf04..8074b4cd691 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/import_library.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/import_library.dart @@ -105,7 +105,7 @@ class ImportLibrary extends MultiCorrectionProducer { Future<(_ImportLibraryCombinator?, _ImportLibraryCombinatorMultiple?)> _importEditCombinators( LibraryImport import, - LibraryElement2 libraryElement, + LibraryElement libraryElement, String uri, String name, { String? prefix, @@ -234,7 +234,7 @@ class ImportLibrary extends MultiCorrectionProducer { var producers = []; // Maybe there is an existing import, but it is with prefix and we don't use // this prefix. - var alreadyImportedWithPrefix = {}; + var alreadyImportedWithPrefix = {}; for (var import in unitResult.libraryFragment.libraryImports2) { // Prepare the element. var libraryElement = import.importedLibrary2; @@ -245,7 +245,7 @@ class ImportLibrary extends MultiCorrectionProducer { if (element == null) { continue; } - if (element is PropertyAccessorElement2) { + if (element is PropertyAccessorElement) { element = element.variable3; if (element == null) { continue; @@ -390,7 +390,7 @@ class ImportLibrary extends MultiCorrectionProducer { } List<_PrefixedName> _namesForExtensionInLibrary( - LibraryElement2 libraryToImport, + LibraryElement libraryToImport, DartType targetType, Name memberName, ) { @@ -946,7 +946,7 @@ class _ImportLibraryCombinatorMultiple extends ResolvedCorrectionProducer { /// extension, but which does so only if the extension applies to a given type. class _ImportLibraryContainingExtension extends ResolvedCorrectionProducer { /// The library defining the extension. - LibraryElement2 library; + LibraryElement library; /// The type of the target that the extension must apply to. DartType targetType; @@ -994,8 +994,8 @@ class _ImportLibraryContainingExtension extends ResolvedCorrectionProducer { /// A correction processor that can add a prefix to an identifier defined in a /// library that is already imported but that is imported with a prefix. class _ImportLibraryPrefix extends ResolvedCorrectionProducer { - final LibraryElement2 _importedLibrary; - final PrefixElement2 _importPrefix; + final LibraryElement _importedLibrary; + final PrefixElement _importPrefix; final String? _nodePrefix; final _ImportLibraryCombinator? _editCombinator; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/make_field_not_final.dart b/pkg/analysis_server/lib/src/services/correction/dart/make_field_not_final.dart index 0c95b4c7f04..890ef2c0446 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/make_field_not_final.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/make_field_not_final.dart @@ -52,7 +52,7 @@ class MakeFieldNotFinal extends ResolvedCorrectionProducer { } // It must be a field declaration. - if (getter.enclosingElement2 is! ClassElement2) { + if (getter.enclosingElement2 is! ClassElement) { return; } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/make_variable_not_final.dart b/pkg/analysis_server/lib/src/services/correction/dart/make_variable_not_final.dart index 696d34b503e..25359e02662 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/make_variable_not_final.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/make_variable_not_final.dart @@ -36,7 +36,7 @@ class MakeVariableNotFinal extends ResolvedCorrectionProducer { } var variable = node.element; - if (variable is! LocalVariableElement2) { + if (variable is! LocalVariableElement) { return; } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/make_variable_nullable.dart b/pkg/analysis_server/lib/src/services/correction/dart/make_variable_nullable.dart index f072e7e1865..9ce87131b3c 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/make_variable_nullable.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/make_variable_nullable.dart @@ -58,7 +58,7 @@ class MakeVariableNullable extends ResolvedCorrectionProducer { /// given [variable] that is located in the given [block] or in a surrounding /// block. Return `null` if the declaration can't be found. VariableDeclarationList? _findDeclaration( - LocalVariableElement2 variable, + LocalVariableElement variable, Block? block, ) { var currentBlock = block; @@ -89,7 +89,7 @@ class MakeVariableNullable extends ResolvedCorrectionProducer { } var element = leftHandSide.element; - if (element is! LocalVariableElement2) { + if (element is! LocalVariableElement) { return; } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/merge_combinators.dart b/pkg/analysis_server/lib/src/services/correction/dart/merge_combinators.dart index 80c1efe4410..98ccbf49d0d 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/merge_combinators.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/merge_combinators.dart @@ -91,8 +91,8 @@ class _MergeCombinators extends ResolvedCorrectionProducer { @override Future compute(ChangeBuilder builder) async { - LibraryElement2? element; - Map namespace; + LibraryElement? element; + Map namespace; Namespace? originalNamespace; switch (directive) { case ExportDirective(:LibraryExportElementImpl libraryExport): diff --git a/pkg/analysis_server/lib/src/services/correction/dart/remove_abstract.dart b/pkg/analysis_server/lib/src/services/correction/dart/remove_abstract.dart index 4688affdc95..e951bf609a6 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/remove_abstract.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/remove_abstract.dart @@ -49,7 +49,7 @@ class RemoveAbstract extends CorrectionProducerWithDiagnostic { Future _compute( ClassDeclaration? classDeclaration, - Element2? fieldElement, + Element? fieldElement, ChangeBuilder builder, ) async { if (classDeclaration == null) return; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/remove_deprecated_new_in_comment_reference.dart b/pkg/analysis_server/lib/src/services/correction/dart/remove_deprecated_new_in_comment_reference.dart index 393be100c27..296da80b93b 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/remove_deprecated_new_in_comment_reference.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/remove_deprecated_new_in_comment_reference.dart @@ -43,12 +43,12 @@ class RemoveDeprecatedNewInCommentReference extends ResolvedCorrectionProducer { var identifier = comment.expression; if (identifier is Identifier) { var element = identifier.element; - if (identifier is SimpleIdentifier && element is ConstructorElement2) { + if (identifier is SimpleIdentifier && element is ConstructorElement) { await builder.addDartFileEdit(file, (builder) { builder.addSimpleInsertion(identifier.end, '.new'); }); } else { - if (element is ClassElement2) { + if (element is ClassElement) { if (element.unnamedConstructor2 != null) { await builder.addDartFileEdit(file, (builder) { builder.addSimpleInsertion(identifier.end, '.new'); diff --git a/pkg/analysis_server/lib/src/services/correction/dart/remove_leading_underscore.dart b/pkg/analysis_server/lib/src/services/correction/dart/remove_leading_underscore.dart index 3399f9c87e8..d87fa3353cf 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/remove_leading_underscore.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/remove_leading_underscore.dart @@ -29,7 +29,7 @@ class RemoveLeadingUnderscore extends ResolvedCorrectionProducer { Future compute(ChangeBuilder builder) async { var node = this.node; Token? nameToken; - Element2? element; + Element? element; if (node is SimpleIdentifier) { nameToken = node.token; element = node.element; @@ -77,7 +77,7 @@ class RemoveLeadingUnderscore extends ResolvedCorrectionProducer { references = findLocalElementReferences(root, element); } } - } else if (element is LocalElement2) { + } else if (element is LocalElement) { var block = node.thisOrAncestorOfType(); if (block != null) { references = findLocalElementReferences(block, element); @@ -96,7 +96,7 @@ class RemoveLeadingUnderscore extends ResolvedCorrectionProducer { } } } - } else if (element is PrefixElement2) { + } else if (element is PrefixElement) { var root = node.thisOrAncestorOfType(); if (root != null) { references = findImportPrefixElementReferences(root, element); diff --git a/pkg/analysis_server/lib/src/services/correction/dart/remove_unused.dart b/pkg/analysis_server/lib/src/services/correction/dart/remove_unused.dart index f70bbacabc6..03c38cae6f0 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/remove_unused.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/remove_unused.dart @@ -36,7 +36,7 @@ class RemoveUnusedElement extends _RemoveUnused { return; } - Element2? element; + Element? element; if (node is Declaration) { element = node.declaredFragment?.element; } @@ -112,7 +112,7 @@ class RemoveUnusedField extends _RemoveUnused { } var element = declaration.declaredFragment!.element; - if (element is! FieldElement2) { + if (element is! FieldElement) { return; } @@ -243,7 +243,7 @@ class RemoveUnusedField extends _RemoveUnused { } class _ElementReferenceCollector extends RecursiveAstVisitor { - final Element2 element; + final Element element; final List references = []; _ElementReferenceCollector(this.element); @@ -272,11 +272,11 @@ class _ElementReferenceCollector extends RecursiveAstVisitor { var staticElement = node.writeOrReadElement2; if (staticElement == element) { references.add(node); - } else if (staticElement is PropertyAccessorElement2) { + } else if (staticElement is PropertyAccessorElement) { if (staticElement.variable3 == element) { references.add(node); } - } else if (staticElement is FieldFormalParameterElement2) { + } else if (staticElement is FieldFormalParameterElement) { if (staticElement.field2 == element) { references.add(node); } @@ -287,7 +287,7 @@ class _ElementReferenceCollector extends RecursiveAstVisitor { abstract class _RemoveUnused extends ResolvedCorrectionProducer { _RemoveUnused({required super.context}); - List _findAllReferences(AstNode root, Element2 element) { + List _findAllReferences(AstNode root, Element element) { var collector = _ElementReferenceCollector(element); root.accept(collector); return collector.references; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/remove_unused_local_variable.dart b/pkg/analysis_server/lib/src/services/correction/dart/remove_unused_local_variable.dart index d89b0ca22a2..16ab0bd8434 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/remove_unused_local_variable.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/remove_unused_local_variable.dart @@ -228,7 +228,7 @@ class RemoveUnusedLocalVariable extends ResolvedCorrectionProducer { bool _deleteReferences() { var element = _localVariableElement(); - if (element is! LocalVariableElement2) { + if (element is! LocalVariableElement) { return false; } @@ -280,7 +280,7 @@ class RemoveUnusedLocalVariable extends ResolvedCorrectionProducer { } } - LocalVariableElement2? _localVariableElement() { + LocalVariableElement? _localVariableElement() { var node = this.node; if (node is DeclaredVariablePattern) { return node.declaredElement2; diff --git a/pkg/analysis_server/lib/src/services/correction/dart/rename_method_parameter.dart b/pkg/analysis_server/lib/src/services/correction/dart/rename_method_parameter.dart index b3e5d63e3b6..fba0b73fbaa 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/rename_method_parameter.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/rename_method_parameter.dart @@ -48,7 +48,7 @@ class RenameMethodParameter extends ResolvedCorrectionProducer { } var classElement = declaredFragment?.element; - if (classElement is! InterfaceElement2) return; + if (classElement is! InterfaceElement) return; var parentMethod = inheritanceManager.getInherited4( classElement, @@ -108,7 +108,7 @@ class _Collector extends RecursiveAstVisitor { super.visitVariableDeclaration(node); } - void _addNameToken(Token? nameToken, Element2? element) { + void _addNameToken(Token? nameToken, Element? element) { if (error) return; if (nameToken != null) { diff --git a/pkg/analysis_server/lib/src/services/correction/dart/rename_to_camel_case.dart b/pkg/analysis_server/lib/src/services/correction/dart/rename_to_camel_case.dart index 14bbbd60686..319a42031d4 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/rename_to_camel_case.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/rename_to_camel_case.dart @@ -35,7 +35,7 @@ class RenameToCamelCase extends ResolvedCorrectionProducer { @override Future compute(ChangeBuilder builder) async { Token? nameToken; - Element2? element; + Element? element; var node = this.node; if (node is SimpleFormalParameter) { nameToken = node.name; @@ -73,7 +73,7 @@ class RenameToCamelCase extends ResolvedCorrectionProducer { // Find references to the identifier. List? references; - if (element is LocalVariableElement2) { + if (element is LocalVariableElement) { var root = node.thisOrAncestorOfType(); if (root != null) { references = findLocalElementReferences(root, element); diff --git a/pkg/analysis_server/lib/src/services/correction/dart/shadow_field.dart b/pkg/analysis_server/lib/src/services/correction/dart/shadow_field.dart index 580dff2a8d9..e048debfe43 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/shadow_field.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/shadow_field.dart @@ -40,7 +40,7 @@ class ShadowField extends ResolvedCorrectionProducer { return; } - if (accessor.enclosingElement2 is! InterfaceElement2) { + if (accessor.enclosingElement2 is! InterfaceElement) { // TODO(brianwilkerson): Should we also require that the getter be synthetic? return; } diff --git a/pkg/analysis_server/lib/src/services/correction/dart/use_different_division_operator.dart b/pkg/analysis_server/lib/src/services/correction/dart/use_different_division_operator.dart index 41d68aa5b97..ea79863d68b 100644 --- a/pkg/analysis_server/lib/src/services/correction/dart/use_different_division_operator.dart +++ b/pkg/analysis_server/lib/src/services/correction/dart/use_different_division_operator.dart @@ -132,7 +132,7 @@ class _UseDifferentDivisionOperator extends ResolvedCorrectionProducer { extension on DartType { Set<_DivisionOperator> get divisionOperators { switch (element3) { - case InterfaceElement2 element: + case InterfaceElement element: return { for (var method in element.methods2) // No need to test for eq operators, as they are not explicitly defined. @@ -142,7 +142,7 @@ extension on DartType { _DivisionOperator.effectiveIntegerDivision, ...element.allSupertypes.expand((type) => type.divisionOperators), }; - case TypeParameterElement2 element: + case TypeParameterElement element: return element.bound?.divisionOperators ?? const {}; } return const {}; diff --git a/pkg/analysis_server/lib/src/services/correction/executable_parameters.dart b/pkg/analysis_server/lib/src/services/correction/executable_parameters.dart index 1280343afdf..b8acc42e3a3 100644 --- a/pkg/analysis_server/lib/src/services/correction/executable_parameters.dart +++ b/pkg/analysis_server/lib/src/services/correction/executable_parameters.dart @@ -6,10 +6,10 @@ import 'package:analyzer/dart/ast/ast.dart'; import 'package:analyzer/dart/element/element.dart'; import 'package:analyzer/src/dart/analysis/session_helper.dart'; -/// [ExecutableElement2], its parameters, and operations on them. +/// [ExecutableElement], its parameters, and operations on them. class ExecutableParameters { final AnalysisSessionHelper sessionHelper; - final ExecutableElement2 executable; + final ExecutableElement executable; final ExecutableFragment firstFragment; final List required = []; @@ -75,7 +75,7 @@ class ExecutableParameters { AnalysisSessionHelper sessionHelper, AstNode? invocation, ) { - Element2? element; + Element? element; // This doesn't handle FunctionExpressionInvocation. if (invocation is Annotation) { element = invocation.element2; @@ -87,7 +87,7 @@ class ExecutableParameters { element = invocation.element; } var firstFragment = element?.firstFragment; - if (element is ExecutableElement2 && + if (element is ExecutableElement && !element.isSynthetic && firstFragment is ExecutableFragment) { return ExecutableParameters._(sessionHelper, element, firstFragment); diff --git a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_descriptor.dart b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_descriptor.dart index 04d92c61f68..fdcd4f4b914 100644 --- a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_descriptor.dart +++ b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_descriptor.dart @@ -142,7 +142,7 @@ class ElementDescriptor { if (type == null && target is SimpleIdentifier) { var element = target.element; // TODO(brianwilkerson): Handle more than `InterfaceElement`. - if (element is InterfaceElement2) { + if (element is InterfaceElement) { type = element.thisType; } } diff --git a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart index 79d508ac083..11f6d6e634e 100644 --- a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart +++ b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/element_matcher.dart @@ -7,12 +7,12 @@ import 'package:analysis_server/src/services/correction/fix/data_driven/element_ import 'package:analyzer/dart/ast/token.dart'; import 'package:analyzer/dart/element/element.dart' show - ExtensionElement2, - InterfaceElement2, - LibraryElement2, + ExtensionElement, + InterfaceElement, + LibraryElement, LibraryFragment, - PrefixElement2, - PropertyAccessorElement2; + PrefixElement, + PropertyAccessorElement; import 'package:analyzer/dart/element/type.dart'; import 'package:analyzer/src/dart/ast/ast.dart'; @@ -93,7 +93,7 @@ class ElementMatcher { } var element = (parent as CompilationUnitMember).declaredFragment?.element; - if (element is! InterfaceElement2) { + if (element is! InterfaceElement) { return false; } var types = element.allSupertypes.map((e) => e.element3.name3); @@ -412,7 +412,7 @@ class _MatcherBuilder { // TODO(brianwilkerson): Use the static element, if there is one, in order to // get a more exact matcher. var prefix = node.prefix; - if (prefix.element is PrefixElement2) { + if (prefix.element is PrefixElement) { var parent = node.parent; if ((parent is NamedType && parent.parent is! ConstructorName) || (parent is PropertyAccess && parent.target == node)) { @@ -459,7 +459,7 @@ class _MatcherBuilder { // It looks like we're accessing a member, but we don't know what kind of // member, so we include all of the member kinds. var container = node.prefix.element; - if (container is InterfaceElement2) { + if (container is InterfaceElement) { _addMatcher( components: [node.identifier.name, container.name3!], kinds: const [ @@ -471,7 +471,7 @@ class _MatcherBuilder { ElementKind.setterKind, ], ); - } else if (container is ExtensionElement2) { + } else if (container is ExtensionElement) { _addMatcher( components: [node.identifier.name, container.displayName], kinds: const [ @@ -545,9 +545,9 @@ class _MatcherBuilder { var element = node.element; // Add enclosing element to the matcher for non top level property // accessors when possible. - if (element is PropertyAccessorElement2) { + if (element is PropertyAccessorElement) { var enclosingElement = element.enclosingElement2; - if (enclosingElement is! LibraryElement2) { + if (enclosingElement is! LibraryElement) { _addMatcher( components: [node.name, enclosingElement.displayName], kinds: [], @@ -587,9 +587,9 @@ class _MatcherBuilder { } if (element != null) { var enclosingElement = element.enclosingElement2; - if (enclosingElement is InterfaceElement2) { + if (enclosingElement is InterfaceElement) { return [identifier.name, enclosingElement.name3!]; - } else if (enclosingElement is ExtensionElement2) { + } else if (enclosingElement is ExtensionElement) { var name = enclosingElement.name3; if (name != null) { return [identifier.name, name]; @@ -601,7 +601,7 @@ class _MatcherBuilder { /// Returns `true` if the [node] is a prefix. static bool _isPrefix(AstNode? node) { - return node is SimpleIdentifier && node.element is PrefixElement2; + return node is SimpleIdentifier && node.element is PrefixElement; } /// Returns the name of the class associated with the given [target]. diff --git a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/rename_parameter.dart b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/rename_parameter.dart index 535a90e22be..b00f818b416 100644 --- a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/rename_parameter.dart +++ b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/rename_parameter.dart @@ -134,13 +134,11 @@ extension on MethodDeclaration { /// Returns the element that this method overrides. /// /// Returns `null` if this method doesn't override any inherited member. - ExecutableElement2? overriddenElement( - InheritanceManager3 inheritanceManager, - ) { + ExecutableElement? overriddenElement(InheritanceManager3 inheritanceManager) { var element = declaredFragment?.element; if (element != null) { var enclosingElement = element.enclosingElement2; - if (enclosingElement is InterfaceElement2) { + if (enclosingElement is InterfaceElement) { var name = Name(enclosingElement.library2.uri, element.name3!); return inheritanceManager.getInherited4(enclosingElement, name); } @@ -164,7 +162,7 @@ extension on MethodDeclaration { } } -extension on ExecutableElement2 { +extension on ExecutableElement { /// Returns the parameter of this executable element whose name matches the /// given [name] /// diff --git a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/replaced_by.dart b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/replaced_by.dart index c7985bb5d14..4ccce4de284 100644 --- a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/replaced_by.dart +++ b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/replaced_by.dart @@ -101,7 +101,7 @@ class ReplacedBy extends Change<_Data> { } if (node is SimpleIdentifier) { var element = node.element; - if (element is ExecutableElement2 && !element.isStatic) { + if (element is ExecutableElement && !element.isStatic) { return _instance(node, element); } @@ -131,7 +131,7 @@ class ReplacedBy extends Change<_Data> { // We have a '.()' pattern, so we replace both parts. return _Data(range.startEnd(target, node)); } else if (target is PrefixedIdentifier) { - if (target.prefix.element is PrefixElement2 && + if (target.prefix.element is PrefixElement && target.identifier.name == containerName) { // We have a '..()' pattern so we leave // the prefix while replacing the rest. @@ -150,7 +150,7 @@ class ReplacedBy extends Change<_Data> { return _Data(range.node(grandparent)); } } else if (parent is PrefixedIdentifier) { - if (parent.prefix.element is PrefixElement2) { + if (parent.prefix.element is PrefixElement) { // We have a '.' pattern so we leave the prefix // while replacing the rest. return _Data(range.node(node)); @@ -225,7 +225,7 @@ class ReplacedBy extends Change<_Data> { } /// Returns a replacement of an instance member. - _Data? _instance(AstNode node, ExecutableElement2 element) { + _Data? _instance(AstNode node, ExecutableElement element) { var newComponents = newElement.components; var newKind = newElement.kind; var suffix = ''; diff --git a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_manager.dart b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_manager.dart index 5c69d871a2c..dafb5941ad2 100644 --- a/pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_manager.dart +++ b/pkg/analysis_server/lib/src/services/correction/fix/data_driven/transform_set_manager.dart @@ -38,7 +38,7 @@ class TransformSetManager { } /// Return the transform sets associated with the [library]. - List forLibrary(LibraryElement2 library) { + List forLibrary(LibraryElement library) { var transformSets = []; var analysisContext = library.session.analysisContext; var workspace = analysisContext.contextRoot.workspace; diff --git a/pkg/analysis_server/lib/src/services/correction/name_suggestion.dart b/pkg/analysis_server/lib/src/services/correction/name_suggestion.dart index 39c9672ada3..c9b65268ebd 100644 --- a/pkg/analysis_server/lib/src/services/correction/name_suggestion.dart +++ b/pkg/analysis_server/lib/src/services/correction/name_suggestion.dart @@ -202,7 +202,7 @@ String? _getBaseNameFromUnwrappedExpression(Expression expression) { return namedType.name2.lexeme; } // new prefix.ClassName() - if (importPrefix.element2 is PrefixElement2) { + if (importPrefix.element2 is PrefixElement) { return namedType.name2.lexeme; } // new ClassName.constructorName() diff --git a/pkg/analysis_server/lib/src/services/correction/namespace.dart b/pkg/analysis_server/lib/src/services/correction/namespace.dart index 0fc57442e43..bf0fe2443ca 100644 --- a/pkg/analysis_server/lib/src/services/correction/namespace.dart +++ b/pkg/analysis_server/lib/src/services/correction/namespace.dart @@ -7,8 +7,8 @@ import 'package:analyzer/dart/element/element.dart'; import 'package:analyzer/src/dart/element/element.dart'; import 'package:analyzer/src/dart/resolver/scope.dart'; -/// Returns the [Element2] exported from the given [LibraryElement2]. -Element2? getExportedElement(LibraryElement2? library, String name) { +/// Returns the [Element] exported from the given [LibraryElement]. +Element? getExportedElement(LibraryElement? library, String name) { if (library == null) { return null; } @@ -30,15 +30,15 @@ LibraryImport? getImportElement(SimpleIdentifier prefixNode) { /// Return the [LibraryImport] that declared [prefix] and imports [element]. /// -/// [libraryElement] - the [LibraryElement2] where reference is. +/// [libraryElement] - the [LibraryElement] where reference is. /// [prefix] - the import prefix, maybe `null`. /// [element] - the referenced element. LibraryImport? _getImportElement( - LibraryElement2 libraryElement, + LibraryElement libraryElement, String prefix, - Element2 element, + Element element, ) { - if (element.enclosingElement2 is! LibraryElement2) { + if (element.enclosingElement2 is! LibraryElement) { return null; } var usedLibrary = element.library2; @@ -74,7 +74,7 @@ LibraryImport? _getImportElement( return candidates[0]; } - var importElementsMap = >{}; + var importElementsMap = >{}; // ensure that each ImportElement has set of elements for (var importElement in candidates) { if (importElementsMap.containsKey(importElement)) { @@ -97,7 +97,7 @@ LibraryImport? _getImportElement( } /// Returns the [LibraryImport] that is referenced by [prefixNode] with a -/// [PrefixElement2], maybe `null`. +/// [PrefixElement], maybe `null`. LibraryImport? _getImportElementInfo(SimpleIdentifier prefixNode) { // prepare environment var parent = prefixNode.parent; @@ -107,7 +107,7 @@ LibraryImport? _getImportElementInfo(SimpleIdentifier prefixNode) { return null; } // prepare used element - Element2? usedElement; + Element? usedElement; if (parent is PrefixedIdentifier) { var prefixed = parent; if (prefixed.prefix == prefixNode) { diff --git a/pkg/analysis_server/lib/src/services/correction/util.dart b/pkg/analysis_server/lib/src/services/correction/util.dart index a4ca3828158..f86a93c8fdf 100644 --- a/pkg/analysis_server/lib/src/services/correction/util.dart +++ b/pkg/analysis_server/lib/src/services/correction/util.dart @@ -37,7 +37,7 @@ Expression climbPropertyAccess(Expression node) { /// Return references to the [element] inside the [root] node. List findImportPrefixElementReferences( AstNode root, - PrefixElement2 element, + PrefixElement element, ) { var collector = _ElementReferenceCollector(element); root.accept(collector); @@ -45,7 +45,7 @@ List findImportPrefixElementReferences( } /// Return references to the [element] inside the [root] node. -List findLocalElementReferences(AstNode root, LocalElement2 element) { +List findLocalElementReferences(AstNode root, LocalElement element) { var collector = _ElementReferenceCollector(element); root.accept(collector); return collector.references; @@ -68,20 +68,20 @@ List getCommentRanges(CompilationUnit unit) { // TODO(scheglov): replace with nodes once there will be // [CompilationUnit.getComments]. -/// Return all [LocalElement2]s defined in the given [node]. -List getDefinedLocalElements(AstNode node) { +/// Return all [LocalElement]s defined in the given [node]. +List getDefinedLocalElements(AstNode node) { var collector = _LocalElementsCollector(); node.accept(collector); return collector.elements; } /// Return the name of the kind of the [element]. -String getElementKindName(Element2 element) { +String getElementKindName(Element element) { return element.kind.displayName; } /// Returns the name to display in the UI for the given [element]. -String getElementQualifiedName(Element2 element) { +String getElementQualifiedName(Element element) { var kind = element.kind; if (kind == ElementKind.FIELD || kind == ElementKind.METHOD) { return '${element.enclosingElement2!.displayName}.${element.displayName}'; @@ -90,7 +90,7 @@ String getElementQualifiedName(Element2 element) { var session = element.session!; var pathContext = session.resourceProvider.pathContext; var rootPath = session.analysisContext.contextRoot.root.path; - var library = element as LibraryElement2; + var library = element as LibraryElement; return pathContext.relative( library.firstFragment.source.fullName, @@ -179,14 +179,14 @@ FormalParameterElement? getFormalParameterElement(SimpleIdentifier node) { } /// Returns the namespace of the given [LibraryImport]. -Map getImportNamespace(LibraryImport imp) { +Map getImportNamespace(LibraryImport imp) { return imp.namespace.definedNames2; } /// Computes the best URI to import [what] into [from]. String getLibrarySourceUri( path.Context pathContext, - LibraryElement2 from, + LibraryElement from, Uri what, ) { if (what.isScheme('file')) { @@ -200,9 +200,9 @@ String getLibrarySourceUri( /// Return the variable's element if [node] is a reference to a local variable. /// /// Returns `null` if it isn't a reference to a local variable. -LocalVariableElement2? getLocalVariableElement(SimpleIdentifier node) { +LocalVariableElement? getLocalVariableElement(SimpleIdentifier node) { var element = node.element; - if (element is LocalVariableElement2) { + if (element is LocalVariableElement) { return element; } return null; @@ -298,7 +298,7 @@ List getStatements(Statement statement) { } /// Checks if the given [element]'s display name equals to the given [name]. -bool hasDisplayName(Element2? element, String name) { +bool hasDisplayName(Element? element, String name) { return element?.displayName == name; } @@ -440,7 +440,7 @@ class _DeclarationCollector extends RecursiveAstVisitor { } class _ElementReferenceCollector extends RecursiveAstVisitor { - final Element2 element; + final Element element; final List references = []; _ElementReferenceCollector(this.element); @@ -483,14 +483,14 @@ class _ElementReferenceCollector extends RecursiveAstVisitor { } } -/// Visitor that collects defined [LocalElement2]s. +/// Visitor that collects defined [LocalElement]s. class _LocalElementsCollector extends RecursiveAstVisitor { - final elements = []; + final elements = []; @override void visitVariableDeclaration(VariableDeclaration node) { var element = node.declaredFragment?.element; - if (element is LocalVariableElement2) { + if (element is LocalVariableElement) { elements.add(element); } diff --git a/pkg/analysis_server/lib/src/services/flutter/class_description.dart b/pkg/analysis_server/lib/src/services/flutter/class_description.dart index 6aebb5f2f5c..be7c77922f3 100644 --- a/pkg/analysis_server/lib/src/services/flutter/class_description.dart +++ b/pkg/analysis_server/lib/src/services/flutter/class_description.dart @@ -18,15 +18,15 @@ import 'package:analyzer/dart/element/type.dart'; /// /// This class provides such "how to materialize" information. class ClassDescription { - final ClassElement2 element; - final ConstructorElement2 constructor; + final ClassElement element; + final ConstructorElement constructor; ClassDescription(this.element, this.constructor); } /// The lazy-fill registry of [ClassDescription]. class ClassDescriptionRegistry { - final Map _map = {}; + final Map _map = {}; /// Flush all data, because there was a change to a file. void flush() { @@ -35,8 +35,8 @@ class ClassDescriptionRegistry { /// If we know how to materialize the [element], return [ClassDescription]. /// Otherwise return `null`. - ClassDescription? get(InterfaceElement2 element) { - if (element is! ClassElement2) { + ClassDescription? get(InterfaceElement element) { + if (element is! ClassElement) { return null; } @@ -58,7 +58,7 @@ class ClassDescriptionRegistry { return false; } - ClassDescription? _classDescription(ClassElement2 element) { + ClassDescription? _classDescription(ClassElement element) { if (!_isOptedInClass(element)) return null; var constructor = element.unnamedConstructor2; @@ -73,8 +73,8 @@ class ClassDescriptionRegistry { return ClassDescription(element, constructor); } - bool _isOptedInClass(InterfaceElement2 element) { - if (element is! ClassElement2) { + bool _isOptedInClass(InterfaceElement element) { + if (element is! ClassElement) { return false; } @@ -90,7 +90,7 @@ class ClassDescriptionRegistry { ); } - static bool _isClass(ClassElement2 element, String uri, String name) { + static bool _isClass(ClassElement element, String uri, String name) { return element.name3 == name && element.library2.uri.toString() == uri; } } diff --git a/pkg/analysis_server/lib/src/services/flutter/property.dart b/pkg/analysis_server/lib/src/services/flutter/property.dart index 0596a7c52ed..6f45116368e 100644 --- a/pkg/analysis_server/lib/src/services/flutter/property.dart +++ b/pkg/analysis_server/lib/src/services/flutter/property.dart @@ -17,13 +17,13 @@ import 'package:analyzer_plugin/utilities/change_builder/change_builder_dart.dar import 'package:analyzer_plugin/utilities/range_factory.dart'; import 'package:collection/collection.dart'; -String? getFieldDocumentation(FieldElement2 field) { +String? getFieldDocumentation(FieldElement field) { var rawComment = field.documentationComment; return getDartDocPlainText(rawComment); } String? getParameterDocumentation(FormalParameterElement? parameter) { - if (parameter is FieldFormalParameterElement2) { + if (parameter is FieldFormalParameterElement) { var rawComment = parameter.field2?.documentationComment; return getDartDocPlainText(rawComment); } @@ -91,7 +91,7 @@ class PropertyDescription { String get name => protocolProperty.name; /// This property has type `EdgeInsets`, add its nested properties. - void addEdgeInsetsNestedProperties(ClassElement2 classEdgeInsets) { + void addEdgeInsetsNestedProperties(ClassElement classEdgeInsets) { _edgeInsetsProperty = _EdgeInsetsProperty(classEdgeInsets, this) ..addNested(); } @@ -106,7 +106,7 @@ class PropertyDescription { var builder = ChangeBuilder(session: resolvedUnit.session); - InterfaceElement2? enumElement; + InterfaceElement? enumElement; var enumValue = value.enumValue; if (enumValue != null) { var helper = AnalysisSessionHelper(resolvedUnit.session); @@ -389,7 +389,7 @@ class PropertyDescription { /// /// This class provides information necessary for such materialization. class VirtualContainerProperty { - final ClassElement2 containerElement; + final ClassElement containerElement; final InstanceCreationExpression widgetCreation; /// The existing wrapper around the widget, with semantic that is a subset @@ -418,13 +418,13 @@ class VirtualContainerProperty { /// /// We try to generate nice looking code for `EdgeInsets` instances. class _EdgeInsetsProperty { - final ClassElement2 classEdgeInsets; + final ClassElement classEdgeInsets; /// The property that has type `EdgeInsets`. final PropertyDescription property; /// The constructor `EdgeInsets.only`. - ConstructorElement2? onlyConstructor; + ConstructorElement? onlyConstructor; double? leftValue; double? topValue; diff --git a/pkg/analysis_server/lib/src/services/flutter/widget_descriptions.dart b/pkg/analysis_server/lib/src/services/flutter/widget_descriptions.dart index 43ea2500b7f..e4a95ecc0cc 100644 --- a/pkg/analysis_server/lib/src/services/flutter/widget_descriptions.dart +++ b/pkg/analysis_server/lib/src/services/flutter/widget_descriptions.dart @@ -129,7 +129,7 @@ class _WidgetDescriptionComputer { /// The set of classes for which we are currently adding properties, /// used to prevent infinite recursion. - final Set elementsBeingProcessed = {}; + final Set elementsBeingProcessed = {}; /// The resolved unit with the widget [InstanceCreationExpression]. final ResolvedUnitResult resolvedUnit; @@ -137,10 +137,10 @@ class _WidgetDescriptionComputer { /// The offset of the widget expression. final int widgetOffset; - ClassElement2? _classAlignment; - ClassElement2? _classAlignmentDirectional; - ClassElement2? _classContainer; - ClassElement2? _classEdgeInsets; + ClassElement? _classAlignment; + ClassElement? _classAlignmentDirectional; + ClassElement? _classContainer; + ClassElement? _classEdgeInsets; _WidgetDescriptionComputer( this.classRegistry, @@ -273,7 +273,7 @@ class _WidgetDescriptionComputer { PropertyDescription? parent, ClassDescription? classDescription, InstanceCreationExpression? instanceCreation, - ConstructorElement2? constructorElement, + ConstructorElement? constructorElement, }) { constructorElement ??= instanceCreation?.constructorName.element; constructorElement ??= classDescription?.constructor; @@ -402,7 +402,7 @@ class _WidgetDescriptionComputer { } List _enumItemsForEnum( - EnumElement2 element, + EnumElement element, ) { return element.fields2 .where((field) => field.isStatic && field.isEnumConstant) @@ -411,7 +411,7 @@ class _WidgetDescriptionComputer { } List _enumItemsForStaticFields( - ClassElement2 classElement, + ClassElement classElement, ) { return classElement.fields2 .where((f) => f.isStatic) @@ -452,7 +452,7 @@ class _WidgetDescriptionComputer { } if (type is InterfaceType) { var classElement = type.element3; - if (classElement is EnumElement2) { + if (classElement is EnumElement) { return protocol.FlutterWidgetPropertyEditor( protocol.FlutterWidgetPropertyEditorKind.ENUM, enumItems: _enumItemsForEnum(classElement), @@ -508,8 +508,8 @@ class _WidgetDescriptionComputer { } } - protocol.FlutterWidgetPropertyValueEnumItem _toEnumItem(FieldElement2 field) { - var interfaceElement = field.enclosingElement2 as InterfaceElement2; + protocol.FlutterWidgetPropertyValueEnumItem _toEnumItem(FieldElement field) { + var interfaceElement = field.enclosingElement2 as InterfaceElement; var libraryUriStr = '${interfaceElement.enclosingElement2.uri}'; var documentation = getFieldDocumentation(field); @@ -534,8 +534,8 @@ class _WidgetDescriptionComputer { var element = valueExpression.element; if (element is GetterElement) { var field = element.variable3!; - if (field is FieldElement2 && field.isStatic) { - var enclosingClass = field.enclosingElement2 as InterfaceElement2; + if (field is FieldElement && field.isStatic) { + var enclosingClass = field.enclosingElement2 as InterfaceElement; if (field.isEnumConstant || enclosingClass.isExactAlignment || enclosingClass.isExactAlignmentDirectional) { diff --git a/pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart b/pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart index 54178e471e4..88c50d2efca 100644 --- a/pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart +++ b/pkg/analysis_server/lib/src/services/kythe/kythe_visitors.dart @@ -13,7 +13,7 @@ import 'schema.dart' as schema; /// /// This is either '' or '.', /// depending on whether the constructor is a named constructor. -String _computeConstructorElementName(ConstructorElement2 constructor) { +String _computeConstructorElementName(ConstructorElement constructor) { var name = constructor.enclosingElement2.name3!; var constructorName = constructor.name3; if (constructorName != null && constructorName != 'new') { @@ -22,16 +22,16 @@ String _computeConstructorElementName(ConstructorElement2 constructor) { return name; } -String? _getNodeKind(Element2 e) { - if (e is FieldElement2 && e.isEnumConstant) { +String? _getNodeKind(Element e) { + if (e is FieldElement && e.isEnumConstant) { // FieldElement is a kind of VariableElement, so this test case must be // before the e is VariableElement check. return schema.CONSTANT_KIND; - } else if (e is VariableElement2 || e is PrefixElement2) { + } else if (e is VariableElement || e is PrefixElement) { return schema.VARIABLE_KIND; - } else if (e is ExecutableElement2) { + } else if (e is ExecutableElement) { return schema.FUNCTION_KIND; - } else if (e is InterfaceElement2 || e is TypeParameterElement2) { + } else if (e is InterfaceElement || e is TypeParameterElement) { // TODO(jwren): this should be using absvar instead, see // https://kythe.io/docs/schema/#absvar return schema.RECORD_KIND; @@ -41,7 +41,7 @@ String? _getNodeKind(Element2 e) { String _getPath( ResourceProvider provider, - Element2? e, { + Element? e, { String? sdkRootPath, String? corpus, }) { @@ -86,7 +86,7 @@ String _getPath( /// returned. String _getSignature( ResourceProvider provider, - Element2? element, + Element? element, String nodeKind, String corpus, { String? sdkRootPath, @@ -95,7 +95,7 @@ String _getSignature( if (element == null) { return schema.DYNAMIC_KIND; } - if (element is LibraryElement2) { + if (element is LibraryElement) { return _getPath( provider, element, @@ -117,14 +117,14 @@ class CiderKytheHelper { CiderKytheHelper(this.resourceProvider, this.corpus, this.sdkRootPath); /// Returns a URI that can be used to query Kythe. - String toKytheUri(Element2 e) { + String toKytheUri(Element e) { var nodeKind = _getNodeKind(e) ?? schema.RECORD_KIND; var vname = _vNameFromElement(e, nodeKind); return 'kythe://$corpus?lang=dart?path=${vname.path}#${vname.signature}'; } /// Returns the Kythe name for the [element]. - _KytheVName _vNameFromElement(Element2? e, String nodeKind) { + _KytheVName _vNameFromElement(Element? e, String nodeKind) { assert(nodeKind != schema.FILE_KIND); // general case return _KytheVName( @@ -158,16 +158,16 @@ class _KytheVName { class _SignatureBuilder { static _SignatureBuilder instance = _SignatureBuilder(); - StringBuffer signatureFor(Element2 element) { + StringBuffer signatureFor(Element element) { var buffer = StringBuffer(); _appendSignatureTo(buffer, element); return buffer; } - void _appendSignatureTo(StringBuffer buffer, Element2 element) { - if (element is LibraryElement2) { + void _appendSignatureTo(StringBuffer buffer, Element element) { + if (element is LibraryElement) { buffer.write('library:${element.displayName}'); - } else if (element is TypeParameterElement2) { + } else if (element is TypeParameterElement) { // It is legal to have a named constructor with the same name as a type // parameter. So we distinguish them by using '.' between the class (or // typedef) name and the type parameter name. @@ -181,16 +181,16 @@ class _SignatureBuilder { if (buffer.isNotEmpty) { buffer.write('#'); } - if (element is MethodElement2 && + if (element is MethodElement && element.name3 == '-' && element.formalParameters.length == 1) { buffer.write('unary-'); - } else if (element is ConstructorElement2) { + } else if (element is ConstructorElement) { buffer.write(_computeConstructorElementName(element)); } else { buffer.write(element.name3); } - if (enclosingElt is ExecutableElement2) { + if (enclosingElt is ExecutableElement) { buffer ..write('@') ..write( diff --git a/pkg/analysis_server/lib/src/services/refactoring/agnostic/change_method_signature.dart b/pkg/analysis_server/lib/src/services/refactoring/agnostic/change_method_signature.dart index ab9a26f1961..81f6af63a6b 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/agnostic/change_method_signature.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/agnostic/change_method_signature.dart @@ -242,7 +242,7 @@ final class ValidSelectionState extends SelectionState { /// The element of the target method, used to find corresponding methods /// in the class hierarchy. - final ExecutableElement2 element; + final ExecutableElement element; /// The current formal parameters. final List formalParameters; @@ -301,7 +301,7 @@ class _AvailabilityAnalyzer { _Declaration? buildDeclaration(Declaration node) { var element = node.declaredFragment?.element; - if (element is ExecutableElement2) { + if (element is ExecutableElement) { return _Declaration(element: element, node: node, selected: selected); } return null; @@ -373,7 +373,7 @@ class _AvailabilityAnalyzer { Availability _executableElement() { var coveringNode = refactoringContext.coveringNode; - Element2? element; + Element? element; if (coveringNode is SimpleIdentifier) { var invocation = coveringNode.parent; if (invocation is MethodInvocation && @@ -382,7 +382,7 @@ class _AvailabilityAnalyzer { } } - if (element is! ExecutableElement2) { + if (element is! ExecutableElement) { return NotAvailableNoExecutableElement(); } @@ -473,7 +473,7 @@ final class _AvailableWithDeclaration extends Available { } final class _AvailableWithExecutableElement extends Available { - final ExecutableElement2 element; + final ExecutableElement element; _AvailableWithExecutableElement({ required super.refactoringContext, @@ -488,7 +488,7 @@ final class _AvailableWithExecutableElement extends Available { /// The target method declaration. class _Declaration { - final ExecutableElement2 element; + final ExecutableElement element; final AstNode node; final List selected; @@ -593,7 +593,7 @@ class _SelectionAnalyzer { } } - Future _elementDeclaration(ExecutableElement2 element) async { + Future _elementDeclaration(ExecutableElement element) async { var helper = refactoringContext.sessionHelper; var nodeResult = await helper.getFragmentDeclaration(element.firstFragment); return nodeResult?.node; @@ -653,27 +653,27 @@ class _SignatureUpdater { /// a function, only the elements itself has to be updated. If the target /// is a class method, then every element in this class hierarchy should /// be updated. - Future> computeElements() async { + Future> computeElements() async { var element = selectionState.element; switch (element) { - case ConstructorElement2(): - case MethodElement2(): + case ConstructorElement(): + case MethodElement(): var set = await getHierarchyMembers(searchEngine, element); - return set.whereType().toList(); + return set.whereType().toList(); default: return [element]; } } - /// Returns the [MethodDeclaration] for a [MethodElement2]. - Future elementDeclaration(ExecutableElement2 element) async { + /// Returns the [MethodDeclaration] for a [MethodElement]. + Future elementDeclaration(ExecutableElement element) async { var helper = sessionHelper; var result = await helper.getFragmentDeclaration(element.firstFragment); return result?.node; } /// Returns the [Selection] for the [reference], using the resolved unit. - /// Used to find [MethodInvocation]s of a [MethodElement2]. + /// Used to find [MethodInvocation]s of a [MethodElement]. Future referenceSelection(SearchMatch reference) async { var unitResult = await referenceUnitResult(reference); return unitResult?.unit.select( @@ -740,7 +740,7 @@ class _SignatureUpdater { /// Replaces formal parameters of [element] with new code as requested /// by the formal parameter updates, reordering, changing kind, etc. Future updateDeclaration({ - required ExecutableElement2 element, + required ExecutableElement element, required ChangeBuilder builder, }) async { var path = element.firstFragment.libraryFragment.source.fullName; @@ -961,7 +961,7 @@ class _SignatureUpdater { /// Updates arguments of invocations of [element]. Future updateReferences({ - required ExecutableElement2 element, + required ExecutableElement element, required ChangeBuilder builder, }) async { var references = await searchEngine.searchReferences(element); diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/convert_getter_to_method.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/convert_getter_to_method.dart index e26e80f46e5..de48070ea47 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/convert_getter_to_method.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/convert_getter_to_method.dart @@ -50,18 +50,18 @@ class ConvertGetterToMethodRefactoringImpl extends RefactoringImpl Future createChange() async { change = SourceChange(refactoringName); // function - if (element.enclosingElement2 is LibraryElement2) { + if (element.enclosingElement2 is LibraryElement) { await _updateElementDeclaration(element); await _updateElementReferences(element); } // method var field = element.variable3; - if (field is FieldElement2 && - (field.enclosingElement2 is InterfaceElement2 || - field.enclosingElement2 is ExtensionElement2)) { + if (field is FieldElement && + (field.enclosingElement2 is InterfaceElement || + field.enclosingElement2 is ExtensionElement)) { var elements = await getHierarchyMembers(searchEngine, field); - await Future.forEach(elements, (Element2 member) async { - if (member is FieldElement2) { + await Future.forEach(elements, (Element member) async { + if (member is FieldElement) { var getter = member.getter2; if (getter != null && !getter.isSynthetic) { await _updateElementDeclaration(getter); @@ -136,7 +136,7 @@ class ConvertGetterToMethodRefactoringImpl extends RefactoringImpl } } - Future _updateElementReferences(Element2 element) async { + Future _updateElementReferences(Element element) async { var matches = await searchEngine.searchReferences(element); var references = getSourceReferences(matches); for (var reference in references) { diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/convert_method_to_getter.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/convert_method_to_getter.dart index 38eb7567f13..f7bee619d74 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/convert_method_to_getter.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/convert_method_to_getter.dart @@ -22,7 +22,7 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl final RefactoringWorkspace workspace; final SearchEngine searchEngine; final AnalysisSessionHelper sessionHelper; - final ExecutableElement2 element; + final ExecutableElement element; late SourceChange change; @@ -57,10 +57,10 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl await _updateElementReferences(element); } // MethodElement - if (element is MethodElement2) { + if (element is MethodElement) { var elements = await getHierarchyMembers(searchEngine, element); - await Future.forEach(elements, (Element2 element) async { - await _updateElementDeclaration(element as ExecutableElement2); + await Future.forEach(elements, (Element element) async { + await _updateElementDeclaration(element as ExecutableElement); return _updateElementReferences(element); }); } @@ -82,7 +82,7 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl } // check Element type - if (element is! MethodElement2 && element is! TopLevelFunctionElement) { + if (element is! MethodElement && element is! TopLevelFunctionElement) { return RefactoringStatus.fatal( 'Only methods or top-level functions can be converted to getters.', ); @@ -103,7 +103,7 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl return RefactoringStatus(); } - Future _updateElementDeclaration(ExecutableElement2 element) async { + Future _updateElementDeclaration(ExecutableElement element) async { // prepare parameters FormalParameterList? parameters; for ( @@ -136,7 +136,7 @@ class ConvertMethodToGetterRefactoringImpl extends RefactoringImpl } } - Future _updateElementReferences(Element2 element) async { + Future _updateElementReferences(Element element) async { var matches = await searchEngine.searchReferences(element); var references = getSourceReferences(matches); for (var reference in references) { diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_local.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_local.dart index 3369aa886cb..b9a3e791a13 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_local.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_local.dart @@ -55,7 +55,7 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl Expression? singleExpression; String? stringLiteralPart; final List occurrences = []; - final Map elementIds = {}; + final Map elementIds = {}; Set _excludedVariableNames = {}; ExtractLocalRefactoringImpl( @@ -340,7 +340,7 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl if (node is MethodInvocation) { var invocation = node; var element = invocation.methodName.element; - if (element is ExecutableElement2 && element.returnType is VoidType) { + if (element is ExecutableElement && element.returnType is VoidType) { if (singleExpression == null) { return RefactoringStatus.fatal( 'Cannot extract the void expression.', @@ -361,7 +361,7 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl } var element = node.element; if (element is LocalFunctionElement || - element is MethodElement2 || + element is MethodElement || element is TopLevelFunctionElement) { continue; } @@ -390,9 +390,9 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl ); } - /// Return an unique identifier for the given [Element2], or `null` if + /// Return an unique identifier for the given [Element], or `null` if /// [element] is `null`. - int? _encodeElement(Element2? element) { + int? _encodeElement(Element? element) { if (element == null) { return null; } @@ -404,8 +404,8 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl return id; } - /// Returns an [Element2]-sensitive encoding of [tokens]. - /// Each [Token] with a [LocalVariableElement2] has a suffix of the element + /// Returns an [Element]-sensitive encoding of [tokens]. + /// Each [Token] with a [LocalVariableElement] has a suffix of the element /// ID. /// /// So, we can distinguish different local variables with the same name, if @@ -413,7 +413,7 @@ class ExtractLocalRefactoringImpl extends RefactoringImpl /// function we are searching occurrences in. String _encodeExpressionTokens(Expression expr, List tokens) { // prepare Token -> LocalElement map - Map map = HashMap( + Map map = HashMap( equals: (Token a, Token b) => a.lexeme == b.lexeme, hashCode: (Token t) => t.lexeme.hashCode, ); @@ -640,14 +640,14 @@ class _OccurrencesVisitor extends GeneralizingAstVisitor { } class _TokenLocalElementVisitor extends RecursiveAstVisitor { - final Map map; + final Map map; _TokenLocalElementVisitor(this.map); @override void visitSimpleIdentifier(SimpleIdentifier node) { var element = node.element; - if (element is LocalVariableElement2) { + if (element is LocalVariableElement) { map[node.token] = element; } } diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_method.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_method.dart index 85222868f76..cc88c9ca25a 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_method.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_method.dart @@ -47,7 +47,7 @@ const String _tokenSeparator = '\uFFFF'; Future addLibraryImports( AnalysisSession session, SourceChange change, - LibraryElement2 targetLibrary2, + LibraryElement targetLibrary2, Set libraries, ) async { var libraryPath = targetLibrary2.firstFragment.source.fullName; @@ -211,13 +211,13 @@ Future addLibraryImports( } } -bool isLocalElement(Element2? element) { - return element is LocalVariableElement2 || +bool isLocalElement(Element? element) { + return element is LocalVariableElement || element is FormalParameterElement || element is LocalFunctionElement; } -Element2? _getLocalElement(SimpleIdentifier node) { +Element? _getLocalElement(SimpleIdentifier node) { var element = node.writeOrReadElement2; if (isLocalElement(element)) { return element; @@ -272,7 +272,7 @@ final class ExtractMethodRefactoringImpl extends RefactoringImpl final List lengths = []; /// The map of local elements to their visibility ranges. - late Map _visibleRangeMap; + late Map _visibleRangeMap; /// The map of local names to their visibility ranges. final Map> _localNames = @@ -640,7 +640,7 @@ final class ExtractMethodRefactoringImpl extends RefactoringImpl return validateCreateFunction(_searchEngine, libraryElement, name); } // method of class - InterfaceElement2? interfaceElement; + InterfaceElement? interfaceElement; if (parent is ClassDeclaration) { interfaceElement = parent.declaredFragment?.element; } else if (parent is EnumDeclaration) { @@ -950,7 +950,7 @@ final class ExtractMethodRefactoringImpl extends RefactoringImpl _parametersMap.clear(); _parameterReferencesMap.clear(); var result = RefactoringStatus(); - var assignedUsedVariables = []; + var assignedUsedVariables = []; var unit = _resolveResult.unit; _visibleRangeMap = VisibleRangesComputer.forNode(unit); @@ -1046,7 +1046,7 @@ final class ExtractMethodRefactoringImpl extends RefactoringImpl } /// Checks if the given [element] is declared in [_selectionRange]. - bool _isDeclaredInSelection(Element2 element) { + bool _isDeclaredInSelection(Element element) { return _selectionRange.contains(element.firstFragment.nameOffset2!); } @@ -1092,7 +1092,7 @@ final class ExtractMethodRefactoringImpl extends RefactoringImpl } /// Checks if [element] is referenced after [_selectionRange]. - bool _isUsedAfterSelection(Element2 element) { + bool _isUsedAfterSelection(Element element) { var visitor = _IsUsedAfterSelectionVisitor(this, element); _parentMember!.accept(visitor); return visitor.result; @@ -1343,11 +1343,11 @@ class _ExtractMethodAnalyzer extends StatementAnalyzer { // method name var element = node.writeOrReadElement2; if (element is LocalFunctionElement || - element is MethodElement2 || + element is MethodElement || element is TopLevelFunctionElement) { invalidSelection('Cannot extract a single method name.'); } - if (element is PrefixElement2) { + if (element is PrefixElement) { invalidSelection('Cannot extract an import prefix.'); } var parent = node.parent; @@ -1415,7 +1415,7 @@ class _GetSourcePatternVisitor extends GeneralizingAstVisitor { super.visitVariableDeclaration(node); } - void _addPatterns({required Token nameToken, required Element2? element}) { + void _addPatterns({required Token nameToken, required Element? element}) { var nameRange = range.token(nameToken); if (partRange.covers(nameRange)) { if (element != null && isLocalElement(element)) { @@ -1438,8 +1438,8 @@ class _GetSourcePatternVisitor extends GeneralizingAstVisitor { } } - DartType _getElementType(Element2 element) { - if (element is VariableElement2) { + DartType _getElementType(Element element) { + if (element is VariableElement) { return element.type; } if (element is LocalFunctionElement) { @@ -1618,7 +1618,7 @@ class _InitializeOccurrencesVisitor extends GeneralizingAstVisitor { class _InitializeParametersVisitor extends GeneralizingAstVisitor { final ExtractMethodRefactoringImpl ref; - final List assignedUsedVariables; + final List assignedUsedVariables; _InitializeParametersVisitor(this.ref, this.assignedUsedVariables); @@ -1669,14 +1669,14 @@ class _InitializeParametersVisitor extends GeneralizingAstVisitor { } // remember, if assigned and used after selection if (isLeftHandOfAssignment(node) && ref._isUsedAfterSelection(element)) { - if (element is VariableElement2 && + if (element is VariableElement && !assignedUsedVariables.contains(element)) { assignedUsedVariables.add(element); } } } // remember information for conflicts checking - if (element is LocalElement2) { + if (element is LocalElement) { // declared local elements if (node.inDeclarationContext()) { var range = ref._visibleRangeMap[element]; @@ -1707,7 +1707,7 @@ class _InitializeParametersVisitor extends GeneralizingAstVisitor { } // remember information for conflicts checking - if (element is LocalVariableElement2) { + if (element is LocalVariableElement) { // declared local elements var range = ref._visibleRangeMap[element]; if (range != null) { @@ -1724,7 +1724,7 @@ class _InitializeParametersVisitor extends GeneralizingAstVisitor { class _IsUsedAfterSelectionVisitor extends GeneralizingAstVisitor { final ExtractMethodRefactoringImpl ref; - final Element2 element; + final Element element; bool result = false; _IsUsedAfterSelectionVisitor(this.ref, this.element); @@ -1776,7 +1776,7 @@ class _SourcePattern { } } -extension on LibraryElement2 { +extension on LibraryElement { /// Returns the source to reference [type] in this [CompilationUnit]. /// /// Fills [librariesToImport] with library elements whose elements are @@ -1862,7 +1862,7 @@ extension on LibraryElement2 { /// library. /// /// Returns `null` if was not imported, i.e. declared in the same library. - LibraryImport? _getImportElement(Element2 element) { + LibraryImport? _getImportElement(Element element) { for (var imp in firstFragment.libraryImports2) { var definedNames = imp.namespace.definedNames2; if (definedNames.containsValue(element)) { @@ -1874,7 +1874,7 @@ extension on LibraryElement2 { String? _getTypeCodeElementArguments({ required Set librariesToImport, - required Element2 element, + required Element element, required bool isNullable, required List typeArguments, }) { diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_widget.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_widget.dart index 93ba951c1bf..5da798c6d68 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_widget.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/extract_widget.dart @@ -37,11 +37,11 @@ class ExtractWidgetRefactoringImpl extends RefactoringImpl late CorrectionUtils utils; - ClassElement2? classBuildContext; - ClassElement2? classKey; - ClassElement2? classStatelessWidget; - ClassElement2? classWidget; - PropertyAccessorElement2? accessorRequired; + ClassElement? classBuildContext; + ClassElement? classKey; + ClassElement? classStatelessWidget; + ClassElement? classWidget; + PropertyAccessorElement? accessorRequired; @override late String name; @@ -50,7 +50,7 @@ class ExtractWidgetRefactoringImpl extends RefactoringImpl ClassDeclaration? _enclosingClassNode; /// If [offset] is in a class, the element of this class, `null` otherwise. - ClassElement2? _enclosingClassElement; + ClassElement? _enclosingClassElement; /// The [CompilationUnitMember] that encloses the [offset]. CompilationUnitMember? _enclosingUnitMember; @@ -244,7 +244,7 @@ class ExtractWidgetRefactoringImpl extends RefactoringImpl Future _initializeClasses() async { var result = RefactoringStatus(); - Future getClass(String name) async { + Future getClass(String name) async { var element = await sessionHelper.getFlutterClass(name); if (element == null) { result.addFatalError("Unable to find '$name' in $widgetsUri"); @@ -252,7 +252,7 @@ class ExtractWidgetRefactoringImpl extends RefactoringImpl return element; } - Future getAccessor( + Future getAccessor( String uri, String name, ) async { @@ -577,7 +577,7 @@ class ExtractWidgetRefactoringImpl extends RefactoringImpl } class _MethodInvocationsCollector extends RecursiveAstVisitor { - final ExecutableElement2 methodElement; + final ExecutableElement methodElement; final List invocations = []; _MethodInvocationsCollector(this.methodElement); @@ -610,14 +610,14 @@ class _Parameter { } class _ParametersCollector extends RecursiveAstVisitor { - final InterfaceElement2? enclosingClass; + final InterfaceElement? enclosingClass; final SourceRange expressionRange; final RefactoringStatus status = RefactoringStatus(); - final Set uniqueElements = {}; + final Set uniqueElements = {}; final List<_Parameter> parameters = []; - List? enclosingClasses; + List? enclosingClasses; _ParametersCollector(this.enclosingClass, this.expressionRange); @@ -630,13 +630,13 @@ class _ParametersCollector extends RecursiveAstVisitor { var elementName = element.displayName; DartType? type; - if (element is MethodElement2) { + if (element is MethodElement) { if (_isMemberOfEnclosingClass(element)) { status.addError( 'Reference to an enclosing class method cannot be extracted.', ); } - } else if (element is LocalVariableElement2) { + } else if (element is LocalVariableElement) { if (!expressionRange.contains(element.firstFragment.nameOffset)) { if (node.inSetterContext()) { status.addError("Write to '$elementName' cannot be extracted."); @@ -644,7 +644,7 @@ class _ParametersCollector extends RecursiveAstVisitor { type = element.type; } } - } else if (element is PropertyAccessorElement2) { + } else if (element is PropertyAccessorElement) { var field = element.variable3; if (field == null) { return; @@ -667,11 +667,11 @@ class _ParametersCollector extends RecursiveAstVisitor { /// Return `true` if the given [element] is a member of the [enclosingClass] /// or one of its supertypes, interfaces, or mixins. - bool _isMemberOfEnclosingClass(Element2 element) { + bool _isMemberOfEnclosingClass(Element element) { var enclosingClass = this.enclosingClass; if (enclosingClass != null) { var enclosingClasses = - this.enclosingClasses ??= [ + this.enclosingClasses ??= [ enclosingClass, ...enclosingClass.allSupertypes.map((t) => t.element3), ]; diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/inline_local.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/inline_local.dart index 47745ff3c01..7c46fffca21 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/inline_local.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/inline_local.dart @@ -52,7 +52,7 @@ class InlineLocalRefactoringImpl extends RefactoringImpl @override Future checkInitialConditions() async { - Element2? element; + Element? element; var offsetNode = resolveResult.unit.nodeCovering(offset: offset); if (offsetNode is SimpleIdentifier) { element = offsetNode.element; @@ -60,7 +60,7 @@ class InlineLocalRefactoringImpl extends RefactoringImpl element = offsetNode.declaredFragment?.element; } - if (element is! LocalVariableElement2) { + if (element is! LocalVariableElement) { return _noLocalVariableStatus(); } @@ -178,7 +178,7 @@ class InlineLocalRefactoringImpl extends RefactoringImpl /// Checks if [offset] is a variable that can be inlined. RefactoringStatus _checkOffset() { - Element2? element; + Element? element; var offsetNode = resolveResult.unit.nodeCovering(offset: offset); if (offsetNode is SimpleIdentifier) { element = offsetNode.element; @@ -186,7 +186,7 @@ class InlineLocalRefactoringImpl extends RefactoringImpl element = offsetNode.declaredFragment?.element; } - if (element is! LocalVariableElement2) { + if (element is! LocalVariableElement) { return _noLocalVariableStatus(); } @@ -257,7 +257,7 @@ class InlineLocalRefactoringImpl extends RefactoringImpl } class _InitialState { - final LocalVariableElement2 element; + final LocalVariableElement element; final VariableDeclaration node; final Expression initializer; final VariableDeclarationStatement declarationStatement; diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/inline_method.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/inline_method.dart index 6f14ae3a40d..13842c03274 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/inline_method.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/inline_method.dart @@ -147,10 +147,7 @@ String _getMethodSourceForInvocation( } // prepare edits to replace conflicting variables var conflictingNames = _getNamesConflictingAt(contextNode); - part._variables.forEach(( - VariableElement2 variable, - List ranges, - ) { + part._variables.forEach((VariableElement variable, List ranges) { var originalName = variable.displayName; // prepare unique name String uniqueName; @@ -226,7 +223,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl bool deleteSource = false; bool inlineAll = true; - ExecutableElement2? _methodElement; + ExecutableElement? _methodElement; late CompilationUnit _methodUnit; late CorrectionUtils _methodUtils; late AstNode _methodNode; @@ -236,7 +233,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl _SourcePart? _methodExpressionPart; _SourcePart? _methodStatementsPart; final List<_ReferenceProcessor> _referenceProcessors = []; - final Set _alreadyMadeAsync = {}; + final Set _alreadyMadeAsync = {}; InlineMethodRefactoringImpl( this.searchEngine, @@ -249,7 +246,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl @override String? get className { var interfaceElement = _methodElement?.enclosingElement2; - if (interfaceElement is InterfaceElement2) { + if (interfaceElement is InterfaceElement) { return interfaceElement.displayName; } return null; @@ -262,7 +259,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl @override String get refactoringName { - if (_methodElement is MethodElement2) { + if (_methodElement is MethodElement) { return 'Inline Method'; } else { return 'Inline Function'; @@ -316,7 +313,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl } // Disallow inlining an operator. - if (methodElement is MethodElement2 && methodElement.isOperator) { + if (methodElement is MethodElement && methodElement.isOperator) { result = RefactoringStatus.fatal("Can't inline an operator."); return result; } @@ -357,7 +354,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl ); var selectedNode = resolveResult.unit.nodeCovering(offset: offset); - Element2? element; + Element? element; if (selectedNode is FunctionDeclaration) { element = selectedNode.declaredFragment?.element; @@ -370,14 +367,14 @@ class InlineMethodRefactoringImpl extends RefactoringImpl } else { return fatalStatus; } - if (element is! ExecutableElement2) { + if (element is! ExecutableElement) { return fatalStatus; } if (element.isSynthetic) { return fatalStatus; } // maybe operator - if (element is MethodElement2 && element.isOperator) { + if (element is MethodElement && element.isOperator) { return RefactoringStatus.fatal("Can't inline an operator."); } // maybe [a]sync* @@ -413,7 +410,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl // prepare selected SimpleIdentifier var selectedNode = resolveResult.unit.nodeCovering(offset: offset); - Element2? element; + Element? element; if (selectedNode is FunctionDeclaration) { element = selectedNode.declaredFragment?.element; isDeclaration = true; @@ -427,7 +424,7 @@ class InlineMethodRefactoringImpl extends RefactoringImpl } // prepare selected ExecutableElement - if (element is! ExecutableElement2) { + if (element is! ExecutableElement) { return fatalStatus; } if (element.isSynthetic) { @@ -515,12 +512,12 @@ class _ParameterOccurrence { }); } -/// Processor for single [SearchMatch] reference to an [Element2]. +/// Processor for single [SearchMatch] reference to an [Element]. class _ReferenceProcessor { final InlineMethodRefactoringImpl ref; final SearchMatch reference; - late Element2 refElement; + late Element refElement; late CorrectionUtils _refUtils; late SimpleIdentifier _node; SourceRange? _refLineRange; @@ -718,8 +715,8 @@ class _ReferenceProcessor { ); return; } - if (refElement is ExecutableElement2) { - var executable = refElement as ExecutableElement2; + if (refElement is ExecutableElement) { + var executable = refElement as ExecutableElement; if (!executable.returnType.isDartAsyncFuture) { status.addFatalError( "Can't inline an 'async' method into a function that doesn't return a 'Future'.", @@ -749,7 +746,7 @@ class _ReferenceProcessor { ); } else { // cannot inline reference to method: var v = new A().method; - if (ref._methodElement is MethodElement2) { + if (ref._methodElement is MethodElement) { status.addFatalError( "Can't inline a class method reference.", newLocation_fromNode(_node), @@ -757,7 +754,7 @@ class _ReferenceProcessor { return; } // PropertyAccessorElement - if (ref._methodElement is PropertyAccessorElement2) { + if (ref._methodElement is PropertyAccessorElement) { Expression usage = _node; Expression? target; var cascade = false; @@ -856,7 +853,7 @@ class _SourcePart { {}; /// The occurrences of the method local variables. - final Map> _variables = {}; + final Map> _variables = {}; /// The offsets of explicit `this` expression references. final List _explicitThisOffsets = []; @@ -907,7 +904,7 @@ class _SourcePart { ); } - void addVariable(VariableElement2 element, SourceRange identifierRange) { + void addVariable(VariableElement element, SourceRange identifierRange) { var ranges = _variables[element]; if (ranges == null) { ranges = []; @@ -920,8 +917,8 @@ class _SourcePart { /// A visitor that fills [_SourcePart] with fields, parameters and variables. class _VariablesVisitor extends GeneralizingAstVisitor { - /// The [ExecutableElement2] being inlined. - final ExecutableElement2 methodElement; + /// The [ExecutableElement] being inlined. + final ExecutableElement methodElement; /// The [SourceRange] of the element body. final SourceRange bodyRange; @@ -979,8 +976,8 @@ class _VariablesVisitor extends GeneralizingAstVisitor { } // should be a method or field reference var element = node.writeOrReadElement2; - if (element is ExecutableElement2) { - if (element is MethodElement2 || element is PropertyAccessorElement2) { + if (element is ExecutableElement) { + if (element is MethodElement || element is PropertyAccessorElement) { // OK } else { return; @@ -988,7 +985,7 @@ class _VariablesVisitor extends GeneralizingAstVisitor { } else { return; } - if (element.enclosingElement2 is! InterfaceElement2) { + if (element.enclosingElement2 is! InterfaceElement) { return; } // record the implicit static or instance reference diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring.dart index 06c7cdbfeba..fd3d3ee3864 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring.dart @@ -66,7 +66,7 @@ abstract class ConvertMethodToGetterRefactoring implements Refactoring { factory ConvertMethodToGetterRefactoring( RefactoringWorkspace workspace, AnalysisSession session, - ExecutableElement2 element, + ExecutableElement element, ) { return ConvertMethodToGetterRefactoringImpl(workspace, session, element); } @@ -397,7 +397,7 @@ class RefactoringWorkspace { RefactoringWorkspace(this.drivers, this.searchEngine); /// Whether the [element] is defined in a file that is in a context root. - bool containsElement(Element2 element) { + bool containsElement(Element element) { if (element is MockLibraryImportElement) { return containsFile(element.libraryFragment.source.fullName); } @@ -447,14 +447,14 @@ abstract class RenameRefactoring implements Refactoring { static RenameRefactoring? create( RefactoringWorkspace workspace, ResolvedUnitResult resolvedUnit, - Element2? element, + Element? element, ) { if (element == null) { return null; } var session = resolvedUnit.session; var sessionHelper = AnalysisSessionHelper(session); - if (element is PropertyAccessorElement2) { + if (element is PropertyAccessorElement) { element = element.variable3; if (element == null) { return null; @@ -468,10 +468,10 @@ abstract class RenameRefactoring implements Refactoring { ); } var enclosingElement = element.enclosingElement2; - if (element is PrefixElement2) { + if (element is PrefixElement) { enclosingElement = element.library2; } - if (enclosingElement is LibraryElement2) { + if (enclosingElement is LibraryElement) { return RenameUnitMemberRefactoringImpl( workspace, sessionHelper, @@ -479,22 +479,22 @@ abstract class RenameRefactoring implements Refactoring { element, ); } - if (element is ConstructorElement2) { + if (element is ConstructorElement) { return RenameConstructorRefactoringImpl( workspace, sessionHelper, element, ); } - if (element is LabelElement2) { + if (element is LabelElement) { return RenameLabelRefactoringImpl(workspace, sessionHelper, element); } - if (element is LibraryElement2) { + if (element is LibraryElement) { return RenameLibraryRefactoringImpl(workspace, sessionHelper, element); } - if (enclosingElement?.thisOrAncestorOfType2() + if (enclosingElement?.thisOrAncestorOfType2() case var enclosingElement?) { - if (element case FieldFormalParameterElement2(:var field2?)) { + if (element case FieldFormalParameterElement(:var field2?)) { return RenameClassMemberRefactoringImpl( workspace, sessionHelper, @@ -506,17 +506,17 @@ abstract class RenameRefactoring implements Refactoring { if (element is FormalParameterElement) { return RenameParameterRefactoringImpl(workspace, sessionHelper, element); } - if (element is LocalElement2) { + if (element is LocalElement) { return RenameLocalRefactoringImpl(workspace, sessionHelper, element); } - if (element is TypeParameterElement2) { + if (element is TypeParameterElement) { return RenameTypeParameterRefactoringImpl( workspace, sessionHelper, element, ); } - if (enclosingElement is InterfaceElement2) { + if (enclosingElement is InterfaceElement) { return RenameClassMemberRefactoringImpl( workspace, sessionHelper, @@ -524,7 +524,7 @@ abstract class RenameRefactoring implements Refactoring { element, ); } - if (enclosingElement is ExtensionElement2) { + if (enclosingElement is ExtensionElement) { return RenameExtensionMemberRefactoringImpl( workspace, sessionHelper, @@ -539,7 +539,7 @@ abstract class RenameRefactoring implements Refactoring { /// example, the class when on the `new` keyword). static RenameRefactoringElement? getElementToRename( AstNode node, - Element2? element, + Element? element, ) { // TODO(scheglov): This is bad code. SyntacticEntity? nameNode; @@ -630,7 +630,7 @@ abstract class RenameRefactoring implements Refactoring { } class RenameRefactoringElement { - final Element2 element; + final Element element; final int offset; final int length; diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_internal.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_internal.dart index b7a5fa9bbe1..c65580ab0a8 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_internal.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_internal.dart @@ -67,7 +67,7 @@ class SourceReference { SourceReference(this._match); - Element2 get element => _match.element; + Element get element => _match.element; /// The full path of the file containing the match. String get file => _match.file; @@ -87,8 +87,8 @@ class SourceReference { bool get isResolved => _match.isResolved; - /// Return the [LibraryElement2] for the [file]. - LibraryElement2 get libraryElement => _match.libraryElement; + /// Return the [LibraryElement] for the [file]. + LibraryElement get libraryElement => _match.libraryElement; SourceRange get range => _match.sourceRange; diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_manager.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_manager.dart index f87dc32be5f..82232ac306e 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_manager.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/refactoring_manager.dart @@ -238,7 +238,7 @@ class RefactoringManager { if (resolvedUnit != null) { var node = resolvedUnit.unit.nodeCovering(offset: offset); var element = node?.getElement(); - if (element is ExecutableElement2) { + if (element is ExecutableElement) { refactoring = ConvertMethodToGetterRefactoring( refactoringWorkspace, resolvedUnit.session, diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename.dart index 2daf159d6eb..1510bd9260c 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename.dart @@ -32,7 +32,7 @@ class RenameProcessor { ); /// Add the edit that updates the [element] declaration. - void addDeclarationEdit(Element2? element) { + void addDeclarationEdit(Element? element) { if (element == null) { return; } else if (element is LibraryElementImpl) { @@ -66,7 +66,7 @@ class RenameProcessor { } /// Update the [element] declaration and references to it. - Future renameElement(Element2 element) async { + Future renameElement(Element element) async { addDeclarationEdit(element); var matches = await workspace.searchEngine.searchReferences(element); addReferenceEdits(matches); @@ -75,7 +75,7 @@ class RenameProcessor { /// Add an edit that replaces the specified region with [code]. /// Uses [referenceElement] to identify the file to update. void replace({ - required Element2 referenceElement, + required Element referenceElement, required int offset, required int length, required String code, @@ -95,7 +95,7 @@ abstract class RenameRefactoringImpl extends RefactoringImpl final RefactoringWorkspace workspace; final AnalysisSessionHelper sessionHelper; final SearchEngine searchEngine; - final Element2 _element; + final Element _element; @override final String elementKindName; @override @@ -104,13 +104,13 @@ abstract class RenameRefactoringImpl extends RefactoringImpl late String newName; - RenameRefactoringImpl(this.workspace, this.sessionHelper, Element2 element) + RenameRefactoringImpl(this.workspace, this.sessionHelper, Element element) : searchEngine = workspace.searchEngine, _element = element, elementKindName = element.kind.displayName, oldName = _getOldName(element); - Element2 get element => _element; + Element get element => _element; @override Future checkInitialConditions() { @@ -161,8 +161,8 @@ abstract class RenameRefactoringImpl extends RefactoringImpl .getAnalysisOptionsForFile(file) .codeStyleOptions; - static String _getOldName(Element2 element) { - if (element is ConstructorElement2) { + static String _getOldName(Element element) { + if (element is ConstructorElement) { var name = element.name3; if (name == null || name == 'new') { return ''; diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_class_member.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_class_member.dart index b59984262f0..ce75dad339b 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_class_member.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_class_member.dart @@ -27,7 +27,7 @@ import 'package:analyzer/src/util/performance/operation_performance.dart'; Future validateCreateMethod( SearchEngine searchEngine, AnalysisSessionHelper sessionHelper, - InterfaceElement2 interfaceElement, + InterfaceElement interfaceElement, String name, ) { return _CreateClassMemberValidator( @@ -40,7 +40,7 @@ Future validateCreateMethod( /// A [Refactoring] for renaming class members. class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl { - final InterfaceElement2 interfaceElement; + final InterfaceElement interfaceElement; late _RenameClassMemberValidator _validator; @@ -48,14 +48,14 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl { RefactoringWorkspace workspace, AnalysisSessionHelper sessionHelper, this.interfaceElement, - Element2 element, + Element element, ) : super(workspace, sessionHelper, element); @override String get refactoringName { - if (element is TypeParameterElement2) { + if (element is TypeParameterElement) { return 'Rename Type Parameter'; - } else if (element is FieldElement2) { + } else if (element is FieldElement) { return 'Rename Field'; } return 'Rename Method'; @@ -76,7 +76,7 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl { @override Future checkInitialConditions() async { var result = await super.checkInitialConditions(); - if (element is MethodElement2 && (element as MethodElement2).isOperator) { + if (element is MethodElement && (element as MethodElement).isOperator) { result.addFatalError('Cannot rename operator.'); } return result; @@ -85,9 +85,9 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl { @override RefactoringStatus checkNewName() { var result = super.checkNewName(); - if (element is FieldElement2) { + if (element is FieldElement) { result.addStatus(validateFieldName(newName)); - } else if (element is MethodElement2) { + } else if (element is MethodElement) { result.addStatus(validateMethodName(newName)); } return result; @@ -98,17 +98,17 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl { var processor = RenameProcessor(workspace, sessionHelper, change, newName); // update declarations for (var renameElement in _validator.elements) { - if (renameElement.isSynthetic && renameElement is FieldElement2) { + if (renameElement.isSynthetic && renameElement is FieldElement) { processor.addDeclarationEdit(renameElement.getter2); processor.addDeclarationEdit(renameElement.setter2); } else { processor.addDeclarationEdit(renameElement); if (!newName.startsWith('_')) { var interfaceElement = renameElement.enclosingElement2; - if (interfaceElement is InterfaceElement2) { + if (interfaceElement is InterfaceElement) { for (var constructor in interfaceElement.constructors2) { for (var parameter in constructor.formalParameters) { - if (parameter is FieldFormalParameterElement2 && + if (parameter is FieldFormalParameterElement && parameter.field2 == renameElement) { await searchEngine .searchReferences(parameter) @@ -142,7 +142,7 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl { Future _addPrivateNamedFormalParameterEdit( SourceReference reference, - FieldFormalParameterElement2 element, + FieldFormalParameterElement element, ) async { FieldFormalParameterFragment? fragment = element.firstFragment; while (fragment != null) { @@ -195,14 +195,14 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl { } if (newName.startsWith('_') && - element is FieldFormalParameterElement2 && + element is FieldFormalParameterElement && element.isNamed) { await _addPrivateNamedFormalParameterEdit(reference, element); continue; } if (unshadowed.contains(reference.element) && - reference.element is ExecutableElement2) { + reference.element is ExecutableElement) { await _addThisEdit(reference, newName); continue; } @@ -216,7 +216,7 @@ class RenameClassMemberRefactoringImpl extends RenameRefactoringImpl { class _BaseClassMemberValidator { final SearchEngine searchEngine; final AnalysisSessionHelper sessionHelper; - final InterfaceElement2 interfaceElement; + final InterfaceElement interfaceElement; final ElementKind elementKind; final String name; @@ -230,7 +230,7 @@ class _BaseClassMemberValidator { this.name, ); - LibraryElement2 get library => interfaceElement.library2; + LibraryElement get library => interfaceElement.library2; void _checkClassAlreadyDeclares() { // check if there is a member with "newName" in the same ClassElement @@ -250,7 +250,7 @@ class _BaseClassMemberValidator { Future _checkHierarchy({ required bool isRename, - required Set subClasses, + required Set subClasses, }) async { var superClasses = interfaceElement.allSupertypes.map((e) => e.element3).toSet(); @@ -294,7 +294,7 @@ class _CreateClassMemberValidator extends _BaseClassMemberValidator { _CreateClassMemberValidator( SearchEngine searchEngine, AnalysisSessionHelper sessionHelper, - InterfaceElement2 interfaceElement, + InterfaceElement interfaceElement, String name, ) : super( searchEngine, @@ -307,7 +307,7 @@ class _CreateClassMemberValidator extends _BaseClassMemberValidator { Future validate() async { _checkClassAlreadyDeclares(); // do chained computations - var subClasses = {}; + var subClasses = {}; await searchEngine.appendAllSubtypes( interfaceElement, subClasses, @@ -330,7 +330,7 @@ class _CreateClassMemberValidator extends _BaseClassMemberValidator { class _LocalElementsCollector extends GeneralizingAstVisitor { final String name; - final List elements = []; + final List elements = []; _LocalElementsCollector(this.name); @@ -367,7 +367,7 @@ class _LocalElementsCollector extends GeneralizingAstVisitor { ) when node == leftHandSide) { element = writeElement2; } - if (element is! PropertyAccessorElement2) { + if (element is! PropertyAccessorElement) { return; } if (element.name3 != name) { @@ -376,7 +376,7 @@ class _LocalElementsCollector extends GeneralizingAstVisitor { if (element is! GetterElement && element is! SetterElement) { return; } - if (element.variable3 case TopLevelVariableElement2 variable) { + if (element.variable3 case TopLevelVariableElement variable) { elements.add(variable); } super.visitSimpleIdentifier(node); @@ -386,7 +386,7 @@ class _LocalElementsCollector extends GeneralizingAstVisitor { void visitVariableDeclaration(VariableDeclaration node) { if (node.name.lexeme == name) { var element = node.declaredFragment?.element; - if (element is LocalVariableElement2) { + if (element is LocalVariableElement) { elements.add(element); } } @@ -397,14 +397,14 @@ class _LocalElementsCollector extends GeneralizingAstVisitor { class _MatchShadowedBy { final SearchMatch match; - final Element2 element; + final Element element; _MatchShadowedBy(this.match, this.element); } class _MatchShadowedByLocal extends _MatchShadowedBy { @override - final LocalElement2 element; + final LocalElement element; _MatchShadowedByLocal(SearchMatch match, this.element) : super(match, element); @@ -412,16 +412,16 @@ class _MatchShadowedByLocal extends _MatchShadowedBy { /// Helper to check if the renamed [element] will cause any conflicts. class _RenameClassMemberValidator extends _BaseClassMemberValidator { - final Element2 element; + final Element element; - Set elements = {}; + Set elements = {}; List references = []; List unshadowed = []; _RenameClassMemberValidator( SearchEngine searchEngine, AnalysisSessionHelper sessionHelper, - InterfaceElement2 elementInterface, + InterfaceElement elementInterface, this.element, String name, ) : super(searchEngine, sessionHelper, elementInterface, element.kind, name); @@ -430,7 +430,7 @@ class _RenameClassMemberValidator extends _BaseClassMemberValidator { _checkClassAlreadyDeclares(); // do chained computations await _prepareReferences(); - var subClasses = {}; + var subClasses = {}; await searchEngine.appendAllSubtypes( interfaceElement, subClasses, @@ -439,7 +439,7 @@ class _RenameClassMemberValidator extends _BaseClassMemberValidator { // check shadowing of class names for (var element in elements) { var enclosingElement = element.enclosingElement2; - if (enclosingElement is InterfaceElement2 && + if (enclosingElement is InterfaceElement && enclosingElement.name3 == name) { result.addError( 'Renamed ${elementKind.displayName} has the same name as the ' @@ -473,10 +473,10 @@ class _RenameClassMemberValidator extends _BaseClassMemberValidator { } Future<_MatchShadowedBy?> _getLocalShadowingElement() async { - var localElementMap = >{}; - var visibleRangeMap = {}; + var localElementMap = >{}; + var visibleRangeMap = {}; - Future> getLocalElements(Element2 element) async { + Future> getLocalElements(Element element) async { var unitFragment = element.firstFragment.libraryFragment; if (unitFragment == null) { return const []; @@ -520,7 +520,7 @@ class _RenameClassMemberValidator extends _BaseClassMemberValidator { var elementRange = visibleRangeMap[localElement]; if (elementRange != null && elementRange.intersects(match.sourceRange)) { - if (localElement is LocalElement2) { + if (localElement is LocalElement) { return _MatchShadowedByLocal(match, localElement); } return _MatchShadowedBy(match, localElement); @@ -530,10 +530,10 @@ class _RenameClassMemberValidator extends _BaseClassMemberValidator { return null; } - /// Fills [elements] with [Element2]s to rename. + /// Fills [elements] with [Element]s to rename. Future _prepareElements() async { var element = this.element; - if (element is FieldElement2 || element is MethodElement2) { + if (element is FieldElement || element is MethodElement) { elements = await getHierarchyMembers(searchEngine, element); } else { elements = {element}; @@ -543,7 +543,7 @@ class _RenameClassMemberValidator extends _BaseClassMemberValidator { /// Fills [references] with all references to [elements]. Future _prepareReferences() async { await _prepareElements(); - await Future.forEach(elements, (Element2 element) async { + await Future.forEach(elements, (Element element) async { var elementReferences = await searchEngine.searchReferences(element); references.addAll(elementReferences); }); @@ -569,7 +569,7 @@ class _RenameClassMemberValidator extends _BaseClassMemberValidator { } } -extension on Element2 { +extension on Element { bool get canAvoidShadowForField { return switch (kind) { ElementKind.LOCAL_VARIABLE || @@ -580,8 +580,8 @@ extension on Element2 { } } -extension on List { - List get avoidableShadowsForField { +extension on List { + List get avoidableShadowsForField { return where((e) => e.canAvoidShadowForField).toList(); } } diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_constructor.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_constructor.dart index 885d986f210..b93ef73030c 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_constructor.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_constructor.dart @@ -19,16 +19,16 @@ import 'package:analyzer/source/source_range.dart'; import 'package:analyzer/src/generated/java_core.dart'; import 'package:analyzer_plugin/utilities/range_factory.dart'; -/// A [Refactoring] for renaming [ConstructorElement2]s. +/// A [Refactoring] for renaming [ConstructorElement]s. class RenameConstructorRefactoringImpl extends RenameRefactoringImpl { RenameConstructorRefactoringImpl( super.workspace, super.sessionHelper, - ConstructorElement2 super.element, + ConstructorElement super.element, ) : super(); @override - ConstructorElement2 get element => super.element as ConstructorElement2; + ConstructorElement get element => super.element as ConstructorElement; @override String get refactoringName { diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_extension_member.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_extension_member.dart index b5bd500ad0b..823157590d7 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_extension_member.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_extension_member.dart @@ -19,9 +19,9 @@ import 'package:analyzer/source/source_range.dart'; import 'package:analyzer/src/dart/analysis/session_helper.dart'; import 'package:analyzer/src/generated/java_core.dart'; -/// A [Refactoring] for renaming extension member [Element2]s. +/// A [Refactoring] for renaming extension member [Element]s. class RenameExtensionMemberRefactoringImpl extends RenameRefactoringImpl { - final ExtensionElement2 extensionElement; + final ExtensionElement extensionElement; late _ExtensionMemberValidator _validator; @@ -34,9 +34,9 @@ class RenameExtensionMemberRefactoringImpl extends RenameRefactoringImpl { @override String get refactoringName { - if (element is TypeParameterElement2) { + if (element is TypeParameterElement) { return 'Rename Type Parameter'; - } else if (element is FieldElement2) { + } else if (element is FieldElement) { return 'Rename Field'; } return 'Rename Method'; @@ -57,7 +57,7 @@ class RenameExtensionMemberRefactoringImpl extends RenameRefactoringImpl { @override Future checkInitialConditions() async { var result = await super.checkInitialConditions(); - if (element is MethodElement2 && (element as MethodElement2).isOperator) { + if (element is MethodElement && (element as MethodElement).isOperator) { result.addFatalError('Cannot rename operator.'); } return result; @@ -66,9 +66,9 @@ class RenameExtensionMemberRefactoringImpl extends RenameRefactoringImpl { @override RefactoringStatus checkNewName() { var result = super.checkNewName(); - if (element is FieldElement2) { + if (element is FieldElement) { result.addStatus(validateFieldName(newName)); - } else if (element is MethodElement2) { + } else if (element is MethodElement) { result.addStatus(validateMethodName(newName)); } return result; @@ -80,7 +80,7 @@ class RenameExtensionMemberRefactoringImpl extends RenameRefactoringImpl { // Update the declaration. var renameElement = element; - if (renameElement.isSynthetic && renameElement is FieldElement2) { + if (renameElement.isSynthetic && renameElement is FieldElement) { processor.addDeclarationEdit(renameElement.getter2); processor.addDeclarationEdit(renameElement.setter2); } else { @@ -92,14 +92,14 @@ class RenameExtensionMemberRefactoringImpl extends RenameRefactoringImpl { } } -/// Helper to check if the created or renamed [Element2] will cause any +/// Helper to check if the created or renamed [Element] will cause any /// conflicts. class _ExtensionMemberValidator { final SearchEngine searchEngine; final AnalysisSessionHelper sessionHelper; - final LibraryElement2 library; - final Element2 element; - final ExtensionElement2 elementExtension; + final LibraryElement library; + final Element element; + final ExtensionElement elementExtension; final ElementKind elementKind; final String name; final bool isRename; @@ -154,10 +154,10 @@ class _ExtensionMemberValidator { } Future<_MatchShadowedByLocal?> _getShadowingLocalElement() async { - var localElementMap = >{}; - var visibleRangeMap = {}; + var localElementMap = >{}; + var visibleRangeMap = {}; - Future> getLocalElements(Element2 element) async { + Future> getLocalElements(Element element) async { var unitFragment = element.firstFragment.libraryFragment; if (unitFragment == null) { return const []; @@ -212,7 +212,7 @@ class _ExtensionMemberValidator { class _LocalElementsCollector extends GeneralizingAstVisitor { final String name; - final List elements = []; + final List elements = []; _LocalElementsCollector(this.name); @@ -244,7 +244,7 @@ class _LocalElementsCollector extends GeneralizingAstVisitor { void visitVariableDeclaration(VariableDeclaration node) { if (node.name.lexeme == name) { var element = node.declaredFragment?.element; - if (element is LocalVariableElement2) { + if (element is LocalVariableElement) { elements.add(element); } } @@ -255,7 +255,7 @@ class _LocalElementsCollector extends GeneralizingAstVisitor { class _MatchShadowedByLocal { final SearchMatch match; - final LocalElement2 localElement; + final LocalElement localElement; _MatchShadowedByLocal(this.match, this.localElement); } diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_label.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_label.dart index 1fe64d6c060..12b657c1ae9 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_label.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_label.dart @@ -8,16 +8,16 @@ import 'package:analysis_server/src/services/refactoring/legacy/refactoring.dart import 'package:analysis_server/src/services/refactoring/legacy/rename.dart'; import 'package:analyzer/dart/element/element.dart'; -/// A [Refactoring] for renaming [LabelElement2]s. +/// A [Refactoring] for renaming [LabelElement]s. class RenameLabelRefactoringImpl extends RenameRefactoringImpl { RenameLabelRefactoringImpl( super.workspace, super.sessionHelper, - LabelElement2 super.element, + LabelElement super.element, ) : super(); @override - LabelElement2 get element => super.element as LabelElement2; + LabelElement get element => super.element as LabelElement; @override String get refactoringName => 'Rename Label'; diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_library.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_library.dart index 056e4afac49..9fe4d0f607f 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_library.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_library.dart @@ -8,16 +8,16 @@ import 'package:analysis_server/src/services/refactoring/legacy/refactoring.dart import 'package:analysis_server/src/services/refactoring/legacy/rename.dart'; import 'package:analyzer/dart/element/element.dart'; -/// A [Refactoring] for renaming [LibraryElement2]s. +/// A [Refactoring] for renaming [LibraryElement]s. class RenameLibraryRefactoringImpl extends RenameRefactoringImpl { RenameLibraryRefactoringImpl( super.workspace, super.sessionHelper, - LibraryElement2 super.element2, + LibraryElement super.element2, ) : super(); @override - LibraryElement2 get element => super.element as LibraryElement2; + LibraryElement get element => super.element as LibraryElement; @override String get refactoringName { diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_local.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_local.dart index 2d42554ff96..b485e6f5ef9 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_local.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_local.dart @@ -22,9 +22,9 @@ import 'package:analyzer/src/generated/java_core.dart'; class ConflictValidatorVisitor extends RecursiveAstVisitor { final RefactoringStatus result; final String newName; - final LocalElement2 target; - final Map visibleRangeMap; - final Set conflictingLocals = {}; + final LocalElement target; + final Map visibleRangeMap; + final Set conflictingLocals = {}; ConflictValidatorVisitor( this.result, @@ -81,7 +81,7 @@ class ConflictValidatorVisitor extends RecursiveAstVisitor { } void _checkDeclaration({ - required Element2? declaredElement, + required Element? declaredElement, required Token nameToken, }) { if (declaredElement != null && nameToken.lexeme == newName) { @@ -101,13 +101,13 @@ class ConflictValidatorVisitor extends RecursiveAstVisitor { } } - SourceRange? _getVisibleRange(LocalElement2 element) { + SourceRange? _getVisibleRange(LocalElement element) { return visibleRangeMap[element]; } /// Returns whether [element] and [target] are visible together. - bool _isVisibleWithTarget(Element2 element) { - if (element is LocalElement2) { + bool _isVisibleWithTarget(Element element) { + if (element is LocalElement) { var targetRange = _getVisibleRange(target); var elementRange = _getVisibleRange(element); return elementRange != null && elementRange.intersects(targetRange); @@ -121,17 +121,17 @@ class ConflictValidatorVisitor extends RecursiveAstVisitor { } } -/// A [Refactoring] for renaming [LocalElement2]s (excluding +/// A [Refactoring] for renaming [LocalElement]s (excluding /// [FormalParameterElement]s). class RenameLocalRefactoringImpl extends RenameRefactoringImpl { RenameLocalRefactoringImpl( super.workspace, super.sessionHelper, - LocalElement2 super.element, + LocalElement super.element, ) : super(); @override - LocalElement2 get element => super.element as LocalElement2; + LocalElement get element => super.element as LocalElement; @override String get refactoringName { @@ -160,7 +160,7 @@ class RenameLocalRefactoringImpl extends RenameRefactoringImpl { @override RefactoringStatus checkNewName() { var result = super.checkNewName(); - if (element is LocalVariableElement2) { + if (element is LocalVariableElement) { result.addStatus(validateVariableName(newName)); } else if (element is LocalFunctionElement) { result.addStatus(validateFunctionName(newName)); @@ -173,7 +173,7 @@ class RenameLocalRefactoringImpl extends RenameRefactoringImpl { var processor = RenameProcessor(workspace, sessionHelper, change, newName); var element = this.element; - if (element is PatternVariableElement2) { + if (element is PatternVariableElement) { var rootVariable = (element.firstFragment as PatternVariableElementImpl).rootVariable; var declaredFragments = @@ -207,14 +207,14 @@ class RenameLocalRefactoringImpl extends RenameRefactoringImpl { } } -extension on Element2 { +extension on Element { String get declarationLocation { var sourceName = firstFragment.libraryFragment!.source.shortName; var executable = enclosingElement2; String className = ''; String executableName = ''; - if (executable is MethodElement2) { - var namescope = executable.enclosingElement2 as ClassElement2?; + if (executable is MethodElement) { + var namescope = executable.enclosingElement2 as ClassElement?; className = namescope?.displayName ?? ''; if (className.isNotEmpty && executable.displayName.isNotEmpty) { className += '.'; diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_parameter.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_parameter.dart index a572d1d048d..eb2e42f5287 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_parameter.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_parameter.dart @@ -9,23 +9,24 @@ import 'package:analysis_server/src/services/refactoring/legacy/rename.dart'; import 'package:analysis_server/src/services/refactoring/legacy/rename_local.dart'; import 'package:analysis_server/src/services/refactoring/legacy/visible_ranges_computer.dart'; import 'package:analysis_server/src/services/search/hierarchy.dart'; -import 'package:analyzer/dart/element/element.dart'; +import 'package:analyzer/dart/element/element.dart' as analyzer; import 'package:analyzer/src/generated/java_core.dart'; import 'package:analyzer_plugin/protocol/protocol_common.dart'; -/// A [Refactoring] for renaming [FormalParameterElement]s. +/// A [Refactoring] for renaming [analyzer.FormalParameterElement]s. class RenameParameterRefactoringImpl extends RenameRefactoringImpl { - List elements = []; + List elements = []; bool _renameAllPositionalOccurences = false; RenameParameterRefactoringImpl( super.workspace, super.sessionHelper, - FormalParameterElement super.element, + analyzer.FormalParameterElement super.element, ) : super(); @override - FormalParameterElement get element => super.element as FormalParameterElement; + analyzer.FormalParameterElement get element => + super.element as analyzer.FormalParameterElement; @override String get refactoringName { @@ -101,7 +102,7 @@ class RenameParameterRefactoringImpl extends RenameRefactoringImpl { continue; } var fieldRenamed = false; - if (element is FieldFormalParameterElement2) { + if (element is analyzer.FieldFormalParameterElement) { var field = element.field2; if (field != null) { await processor.renameElement(field); @@ -123,7 +124,7 @@ class RenameParameterRefactoringImpl extends RenameRefactoringImpl { // References to positional parameters from super-formal. if (element.isPositional) { references.removeWhere( - (match) => match.element is SuperFormalParameterElement2, + (match) => match.element is analyzer.SuperFormalParameterElement, ); } @@ -131,7 +132,7 @@ class RenameParameterRefactoringImpl extends RenameRefactoringImpl { } } - /// Fills [elements] with [Element2]s to rename. + /// Fills [elements] with [Element]s to rename. Future _prepareElements() async { var element = this.element; if (element.isNamed) { diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_type_parameter.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_type_parameter.dart index 6dfba2f5c95..ef195b51ac8 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_type_parameter.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_type_parameter.dart @@ -12,11 +12,11 @@ class RenameTypeParameterRefactoringImpl extends RenameRefactoringImpl { RenameTypeParameterRefactoringImpl( super.workspace, super.sessionHelper, - TypeParameterElement2 super.element2, + TypeParameterElement super.element2, ) : super(); @override - TypeParameterElement2 get element => super.element as TypeParameterElement2; + TypeParameterElement get element => super.element as TypeParameterElement; @override String get refactoringName { @@ -28,7 +28,7 @@ class RenameTypeParameterRefactoringImpl extends RenameRefactoringImpl { var result = RefactoringStatus(); var enclosing = element.enclosingElement2; - if (enclosing is TypeParameterizedElement2) { + if (enclosing is TypeParameterizedElement) { for (var sibling in enclosing.typeParameters2) { if (sibling.name3 == newName) { var nodeKind = sibling.kind.displayName; diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_unit_member.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_unit_member.dart index a1723a87a54..9f0fb70cce6 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_unit_member.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/rename_unit_member.dart @@ -21,7 +21,7 @@ import 'package:analyzer/src/utilities/extensions/flutter.dart'; /// will cause any conflicts. Future validateCreateFunction( SearchEngine searchEngine, - LibraryElement2 library, + LibraryElement library, String name, ) { return _CreateUnitMemberValidator( @@ -36,19 +36,19 @@ Future validateCreateFunction( /// will cause any conflicts. Future validateRenameTopLevel( SearchEngine searchEngine, - Element2 element, + Element element, String name, ) { return _RenameUnitMemberValidator(searchEngine, element, name).validate(); } -/// A [Refactoring] for renaming compilation unit member [Element2]s. +/// A [Refactoring] for renaming compilation unit member [Element]s. class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl { final ResolvedUnitResult resolvedUnit; /// If the element is a Flutter `StatefulWidget` declaration, this is the /// corresponding `State` declaration. - ClassElement2? _flutterWidgetState; + ClassElement? _flutterWidgetState; /// If [_flutterWidgetState] is set, this is the new name of it. String? _flutterWidgetStateNewName; @@ -62,19 +62,19 @@ class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl { @override String get refactoringName { - if (element is ExtensionElement2) { + if (element is ExtensionElement) { return 'Rename Extension'; } - if (element is ExtensionTypeElement2) { + if (element is ExtensionTypeElement) { return 'Rename Extension Type'; } if (element is TopLevelFunctionElement) { return 'Rename Top-Level Function'; } - if (element is TopLevelVariableElement2) { + if (element is TopLevelVariableElement) { return 'Rename Top-Level Variable'; } - if (element is TypeAliasElement2) { + if (element is TypeAliasElement) { return 'Rename Type Alias'; } return 'Rename Class'; @@ -107,19 +107,19 @@ class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl { @override RefactoringStatus checkNewName() { var result = super.checkNewName(); - if (element is ExtensionTypeElement2) { + if (element is ExtensionTypeElement) { result.addStatus(validateExtensionTypeName(newName)); } if (element is TopLevelFunctionElement) { result.addStatus(validateFunctionName(newName)); } - if (element is InterfaceElement2) { + if (element is InterfaceElement) { result.addStatus(validateClassName(newName)); } - if (element is TopLevelVariableElement2) { + if (element is TopLevelVariableElement) { result.addStatus(validateVariableName(newName)); } - if (element is TypeAliasElement2) { + if (element is TypeAliasElement) { result.addStatus(validateTypeAliasName(newName)); } return result; @@ -128,9 +128,9 @@ class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl { @override Future fillChange() async { // prepare elements - var elements = []; - if (element is PropertyInducingElement2 && element.isSynthetic) { - var property = element as PropertyInducingElement2; + var elements = []; + if (element is PropertyInducingElement && element.isSynthetic) { + var property = element as PropertyInducingElement; var getter = property.getter2; var setter = property.setter2; if (getter != null) { @@ -164,7 +164,7 @@ class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl { void _findFlutterStateClass() { var element = this.element; - if (element is ClassElement2 && element.isStatefulWidgetDeclaration) { + if (element is ClassElement && element.isStatefulWidgetDeclaration) { var oldStateName = '${oldName}State'; var library = element.library2; _flutterWidgetState = @@ -190,7 +190,7 @@ class RenameUnitMemberRefactoringImpl extends RenameRefactoringImpl { /// The base class for the create and rename validators. class _BaseUnitMemberValidator { final SearchEngine searchEngine; - final LibraryElement2 library; + final LibraryElement library; final ElementKind elementKind; final String name; @@ -204,7 +204,7 @@ class _BaseUnitMemberValidator { ); /// Returns `true` if [element] is visible at the given [SearchMatch]. - bool _isVisibleAt(Element2 element, SearchMatch at) { + bool _isVisibleAt(Element element, SearchMatch at) { var atLibrary = at.element.library2!; // may be the same library if (library == atLibrary) { @@ -228,7 +228,7 @@ class _BaseUnitMemberValidator { } /// Validates if an element with the [name] will conflict with another - /// top-level [Element2] in the same library. + /// top-level [Element] in the same library. void _validateWillConflict() { for (var element in library.children2) { if (hasDisplayName(element, name)) { @@ -242,12 +242,12 @@ class _BaseUnitMemberValidator { } } - /// Validates if renamed [element] will shadow any [Element2] named [name]. - Future _validateWillShadow(Element2? element) async { + /// Validates if renamed [element] will shadow any [Element] named [name]. + Future _validateWillShadow(Element? element) async { var declarations = await searchEngine.searchMemberDeclarations(name); for (var declaration in declarations) { var member = declaration.element; - var declaringClass = member.enclosingElement2 as InterfaceElement2; + var declaringClass = member.enclosingElement2 as InterfaceElement; var memberReferences = await searchEngine.searchReferences(member); for (var memberReference in memberReferences) { var refElement = memberReference.element; @@ -256,7 +256,7 @@ class _BaseUnitMemberValidator { continue; } // cannot be shadowed if declared in the same class as reference - var refClass = refElement.thisOrAncestorOfType2(); + var refClass = refElement.thisOrAncestorOfType2(); if (refClass == declaringClass) { continue; } @@ -297,7 +297,7 @@ class _CreateUnitMemberValidator extends _BaseUnitMemberValidator { /// Helper to check if the renamed element will cause any conflicts. class _RenameUnitMemberValidator extends _BaseUnitMemberValidator { - final Element2 element; + final Element element; List references = []; _RenameUnitMemberValidator( @@ -338,7 +338,7 @@ class _RenameUnitMemberValidator extends _BaseUnitMemberValidator { void _validateWillBeShadowed() { for (var reference in references) { var refElement = reference.element; - var refClass = refElement.thisOrAncestorOfType2(); + var refClass = refElement.thisOrAncestorOfType2(); if (refClass != null) { visitChildren(refClass, (shadow) { if (hasDisplayName(shadow, name)) { diff --git a/pkg/analysis_server/lib/src/services/refactoring/legacy/visible_ranges_computer.dart b/pkg/analysis_server/lib/src/services/refactoring/legacy/visible_ranges_computer.dart index fa1fd72a9cb..668451318ed 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/legacy/visible_ranges_computer.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/legacy/visible_ranges_computer.dart @@ -10,7 +10,7 @@ import 'package:analyzer_plugin/utilities/range_factory.dart'; /// Computer of local elements and source ranges in which they are visible. class VisibleRangesComputer extends GeneralizingAstVisitor { - final Map _map = {}; + final Map _map = {}; @override void visitCatchClause(CatchClause node) { @@ -77,15 +77,15 @@ class VisibleRangesComputer extends GeneralizingAstVisitor { } } - void _addLocalVariable(AstNode scopeNode, Element2? element) { + void _addLocalVariable(AstNode scopeNode, Element? element) { // TODO(brianwilkerson): Figure out whether this should be testing for // `PromotableElement`. The test is missing parameter elements. - if (element is LocalElement2) { + if (element is LocalElement) { _map[element] = range.node(scopeNode); } } - static Map forNode(AstNode unit) { + static Map forNode(AstNode unit) { var computer = VisibleRangesComputer(); unit.accept(computer); return computer._map; diff --git a/pkg/analysis_server/lib/src/services/refactoring/move_top_level_to_file.dart b/pkg/analysis_server/lib/src/services/refactoring/move_top_level_to_file.dart index dc376ba41d5..5cf077984a2 100644 --- a/pkg/analysis_server/lib/src/services/refactoring/move_top_level_to_file.dart +++ b/pkg/analysis_server/lib/src/services/refactoring/move_top_level_to_file.dart @@ -150,7 +150,7 @@ class MoveTopLevelToFile extends RefactoringProducer { builder.addDeletion(sourceRange); } }); - var libraries = >{}; + var libraries = >{}; for (var element2 in analyzer.movingDeclarations) { var element = element2; var matches = await searchEngine.searchReferences(element); @@ -174,13 +174,13 @@ class MoveTopLevelToFile extends RefactoringProducer { ); // And also for the getter if this might be something like a top-level // variable. - if (element case PropertyInducingElement2(:var getter2?)) { + if (element case PropertyInducingElement(:var getter2?)) { prefixes.addAll( await searchEngine.searchPrefixesUsedInLibrary(library, getter2), ); } // And setters. - if (element case PropertyInducingElement2(:var setter2?)) { + if (element case PropertyInducingElement(:var setter2?)) { prefixes.addAll( await searchEngine.searchPrefixesUsedInLibrary(library, setter2), ); @@ -501,10 +501,10 @@ class _SealedSubclassIndex { final CompilationUnit unit; /// The set of initial candidate elements. - final Set candidateElements; + final Set candidateElements; /// A map of sealed named classes/mixin elements to a set of their subclasses. - final Map> sealedTypeSubclasses = {}; + final Map> sealedTypeSubclasses = {}; /// Whether or not the candidate set is invalid. /// @@ -559,11 +559,11 @@ class _SealedSubclassIndex { } extension on CompilationUnitMember { - /// Gets all sealed [ClassElement2]s that are superclasses of this member. - Iterable get sealedSuperclassElements { + /// Gets all sealed [ClassElement]s that are superclasses of this member. + Iterable get sealedSuperclassElements { return superclasses .map((type) => type?.element2) - .whereType() + .whereType() .where((element) => element.isSealed); } diff --git a/pkg/analysis_server/lib/src/services/search/element_visitors.dart b/pkg/analysis_server/lib/src/services/search/element_visitors.dart index e8499a2cf3a..cbc5df14ea3 100644 --- a/pkg/analysis_server/lib/src/services/search/element_visitors.dart +++ b/pkg/analysis_server/lib/src/services/search/element_visitors.dart @@ -13,13 +13,13 @@ Fragment? findFragmentByNameOffset(LibraryFragment fragment, int nameOffset) { /// Uses [processor] to visit all of the children of [element]. /// If [processor] returns `true`, then children of a child are visited too. -void visitChildren(Element2 element, BoolElementProcessor processor) { +void visitChildren(Element element, BoolElementProcessor processor) { element.visitChildren2(_ElementVisitorAdapter(processor)); } -/// An [Element2] processor function type. +/// An [Element] processor function type. /// If `true` is returned, children of [element] will be visited. -typedef BoolElementProcessor = bool Function(Element2 element); +typedef BoolElementProcessor = bool Function(Element element); /// A [GeneralizingElementVisitor2] adapter for [BoolElementProcessor]. class _ElementVisitorAdapter extends GeneralizingElementVisitor2 { @@ -28,7 +28,7 @@ class _ElementVisitorAdapter extends GeneralizingElementVisitor2 { _ElementVisitorAdapter(this.processor); @override - void visitElement(Element2 element) { + void visitElement(Element element) { var visitChildren = processor(element); if (visitChildren == true) { element.visitChildren2(this); diff --git a/pkg/analysis_server/lib/src/services/search/hierarchy.dart b/pkg/analysis_server/lib/src/services/search/hierarchy.dart index af38d6a64c0..1d057853d9d 100644 --- a/pkg/analysis_server/lib/src/services/search/hierarchy.dart +++ b/pkg/analysis_server/lib/src/services/search/hierarchy.dart @@ -8,8 +8,8 @@ import 'package:analyzer/dart/element/element.dart'; import 'package:analyzer/src/util/performance/operation_performance.dart'; /// Returns direct children of [parent]. -List getChildren(Element2 parent, [String? name]) { - var children = []; +List getChildren(Element parent, [String? name]) { + var children = []; visitChildren(parent, (element) { if (name == null || element.name3 == name) { children.add(element); @@ -19,26 +19,26 @@ List getChildren(Element2 parent, [String? name]) { return children; } -/// Returns direct non-synthetic children of the given [InterfaceElement2]. +/// Returns direct non-synthetic children of the given [InterfaceElement]. /// /// Includes: fields, accessors and methods. /// Excludes: constructors and synthetic elements. -List getClassMembers(InterfaceElement2 clazz, [String? name]) { - var members = []; - visitChildren(clazz, (Element2 element) { +List getClassMembers(InterfaceElement clazz, [String? name]) { + var members = []; + visitChildren(clazz, (Element element) { if (element.isSynthetic) { return false; } - if (element is ConstructorElement2) { + if (element is ConstructorElement) { return false; } if (name != null && element.displayName != name) { return false; } - if (element is ExecutableElement2) { + if (element is ExecutableElement) { members.add(element); } - if (element is FieldElement2) { + if (element is FieldElement) { members.add(element); } return false; @@ -50,25 +50,19 @@ List getClassMembers(InterfaceElement2 clazz, [String? name]) { /// /// The given [searchEngineCache] will be used or filled out as needed /// so subsequent calls can utilize it to speed up the computation. -Future> getDirectSubClasses( +Future> getDirectSubClasses( SearchEngine searchEngine, - InterfaceElement2 seed, + InterfaceElement seed, SearchEngineCache searchEngineCache, ) async { var matches = await searchEngine.searchSubtypes(seed, searchEngineCache); - return matches - .map((match) => match.element) - .cast() - .toSet(); + return matches.map((match) => match.element).cast().toSet(); } /// Return the non-synthetic children of the given [extension]. This includes /// fields, accessors and methods, but excludes synthetic elements. -List getExtensionMembers( - ExtensionElement2 extension, [ - String? name, -]) { - var members = []; +List getExtensionMembers(ExtensionElement extension, [String? name]) { + var members = []; visitChildren(extension, (element) { if (element.isSynthetic) { return false; @@ -76,10 +70,10 @@ List getExtensionMembers( if (name != null && element.displayName != name) { return false; } - if (element is ExecutableElement2) { + if (element is ExecutableElement) { members.add(element); } - if (element is FieldElement2) { + if (element is FieldElement) { members.add(element); } return false; @@ -89,9 +83,9 @@ List getExtensionMembers( /// Returns all implementations of the given [member], including in its /// superclasses and their subclasses. -Future> getHierarchyMembers( +Future> getHierarchyMembers( SearchEngine searchEngine, - Element2 member, { + Element member, { OperationPerformanceImpl? performance, }) async { var (members, _) = await getHierarchyMembersAndParameters( @@ -105,35 +99,35 @@ Future> getHierarchyMembers( /// Returns all implementations of the given [member2], including in its /// superclasses and their subclasses. /// -/// If [includeParametersForFields] is true and [member2] is a [FieldElement2], -/// any [FieldFormalParameterElement2]s for the member will also be provided +/// If [includeParametersForFields] is true and [member2] is a [FieldElement], +/// any [FieldFormalParameterElement]s for the member will also be provided /// (otherwise, the parameter set will be empty in the result). -Future<(Set, Set)> +Future<(Set, Set)> getHierarchyMembersAndParameters( SearchEngine searchEngine, - Element2 member2, { + Element member2, { OperationPerformanceImpl? performance, bool includeParametersForFields = false, }) async { performance ??= OperationPerformanceImpl(''); - var members = {}; + var members = {}; var parameters = {}; // extension member var enclosingElement = member2.enclosingElement2; - if (enclosingElement is ExtensionElement2) { + if (enclosingElement is ExtensionElement) { members.add(member2); return (members, parameters); } // static elements switch (member2) { - case ConstructorElement2(): - case FieldElement2(isStatic: true): - case MethodElement2(isStatic: true): + case ConstructorElement(): + case FieldElement(isStatic: true): + case MethodElement(isStatic: true): members.add(member2); return (members, parameters); } // method, field, etc - if (enclosingElement is InterfaceElement2) { + if (enclosingElement is InterfaceElement) { var name = member2.displayName; var superElementsToSearch = @@ -144,7 +138,7 @@ getHierarchyMembersAndParameters( }) .toList(); var searchClasses = [...superElementsToSearch, enclosingElement]; - var subClasses = {}; + var subClasses = {}; for (var superClass in searchClasses) { // ignore if super- class does not declare member if (getClassMembers(superClass, name).isEmpty) { @@ -167,19 +161,19 @@ getHierarchyMembersAndParameters( var subClassMembers = getChildren(subClass, name); for (var member in subClassMembers) { switch (member) { - case ConstructorElement2(): + case ConstructorElement(): members.add(member); - case FieldElement2(): + case FieldElement(): members.add(member); - case MethodElement2(): + case MethodElement(): members.add(member); } } - if (includeParametersForFields && member2 is FieldElement2) { + if (includeParametersForFields && member2 is FieldElement) { for (var constructor in subClass.constructors2) { for (var parameter in constructor.formalParameters) { - if (parameter is FieldFormalParameterElement2 && + if (parameter is FieldFormalParameterElement && parameter.field2 == member2) { parameters.add(parameter); } @@ -193,7 +187,7 @@ getHierarchyMembersAndParameters( return (members, parameters); } -/// If the [element] is a named parameter in a [MethodElement2], return all +/// If the [element] is a named parameter in a [MethodElement], return all /// corresponding named parameters in the method hierarchy. Future> getHierarchyNamedParameters( SearchEngine searchEngine, @@ -201,11 +195,11 @@ Future> getHierarchyNamedParameters( ) async { if (element.isNamed) { var method = element.enclosingElement2; - if (method is MethodElement2) { + if (method is MethodElement) { var hierarchyParameters = []; var hierarchyMembers = await getHierarchyMembers(searchEngine, method); for (var hierarchyMethod in hierarchyMembers) { - if (hierarchyMethod is MethodElement2) { + if (hierarchyMethod is MethodElement) { for (var hierarchyParameter in hierarchyMethod.formalParameters) { if (hierarchyParameter.isNamed && hierarchyParameter.name3 == element.name3) { @@ -227,7 +221,7 @@ Future> getHierarchyPositionalParameters( ) async { if (element.isPositional) { var method = element.enclosingElement2; - if (method is MethodElement2) { + if (method is MethodElement) { var index = method.parameterIndex(element); // Should not ever happen but this means we can't find the index. if (index == null) { @@ -236,7 +230,7 @@ Future> getHierarchyPositionalParameters( var hierarchyParameters = []; var hierarchyMembers = await getHierarchyMembers(searchEngine, method); for (var hierarchyMethod in hierarchyMembers) { - if (hierarchyMethod is MethodElement2) { + if (hierarchyMethod is MethodElement) { for (var hierarchyParameter in hierarchyMethod.formalParameters) { if (hierarchyParameter.isPositional && hierarchyMethod.parameterIndex(hierarchyParameter) == index) { @@ -252,25 +246,25 @@ Future> getHierarchyPositionalParameters( return [element]; } -/// Returns non-synthetic members of the given [InterfaceElement2] and its super +/// Returns non-synthetic members of the given [InterfaceElement] and its super /// classes. /// /// Includes: fields, accessors and methods. /// /// Excludes: constructors and synthetic elements. -List getMembers(InterfaceElement2 clazz) { +List getMembers(InterfaceElement clazz) { var classElements = [...clazz.allSupertypes.map((e) => e.element3), clazz]; - var members = []; + var members = []; for (var superClass in classElements) { members.addAll(getClassMembers(superClass)); } return members; } -/// If the given [element] is a synthetic [PropertyAccessorElement2] returns +/// If the given [element] is a synthetic [PropertyAccessorElement] returns /// its variable, otherwise returns [element]. -Element2 getSyntheticAccessorVariable(Element2 element) { - if (element is PropertyAccessorElement2) { +Element getSyntheticAccessorVariable(Element element) { + if (element is PropertyAccessorElement) { if (element.isSynthetic) { return element.variable3 ?? element; } @@ -278,7 +272,7 @@ Element2 getSyntheticAccessorVariable(Element2 element) { return element; } -extension on MethodElement2 { +extension on MethodElement { int? parameterIndex(FormalParameterElement parameter) { var index = 0; for (var positionalParameter in formalParameters.where( diff --git a/pkg/analysis_server/lib/src/services/search/search_engine.dart b/pkg/analysis_server/lib/src/services/search/search_engine.dart index 8b628b09526..1a6a9cc7f86 100644 --- a/pkg/analysis_server/lib/src/services/search/search_engine.dart +++ b/pkg/analysis_server/lib/src/services/search/search_engine.dart @@ -80,15 +80,15 @@ abstract class SearchEngine { /// If [allSubtypes] already contains an element it is assumed that it /// contains the entire subtree and the element won't be search on further. Future appendAllSubtypes( - InterfaceElement2 type, - Set allSubtypes, + InterfaceElement type, + Set allSubtypes, OperationPerformanceImpl performance, ); /// If the [type] has subtypes, return the set of names of members which these /// subtypes declare, possibly empty. If the [type] does not have subtypes, /// return `null`. - Future?> membersOfSubtypes(InterfaceElement2 type); + Future?> membersOfSubtypes(InterfaceElement type); /// Returns references to the given [fragment]. Future> searchLibraryFragmentReferences( @@ -115,20 +115,20 @@ abstract class SearchEngine { /// compilation units in the [library]. The returned set will include an empty /// string if the element is referenced without a prefix. Future> searchPrefixesUsedInLibrary( - LibraryElement2 library, - Element2 element, + LibraryElement library, + Element element, ); /// Returns references to the given [element]. - Future> searchReferences(Element2 element); + Future> searchReferences(Element element); /// Returns direct subtypes of the given [type]. /// - /// [type] - the [InterfaceElement2] being subtyped by the found matches. + /// [type] - the [InterfaceElement] being subtyped by the found matches. /// [cache] - the [SearchEngineCache] used to speeding up the computation. If /// empty it will be filled out and can be used on any subsequent query. Future> searchSubtypes( - InterfaceElement2 type, + InterfaceElement type, SearchEngineCache cache, { OperationPerformanceImpl? performance, }); @@ -151,7 +151,7 @@ class SearchEngineCache { /// [SearchEngine]. abstract class SearchMatch { /// Return the element containing the match. - Element2 get element; + Element get element; /// The absolute path of the file containing the match. String get file; @@ -159,14 +159,14 @@ abstract class SearchMatch { /// Is `true` if field or method access is done using qualifier. bool get isQualified; - /// Is `true` if the match is a resolved reference to some [Element2]. + /// Is `true` if the match is a resolved reference to some [Element]. bool get isResolved; /// The kind of the match. MatchKind get kind; /// Return the library element for the [file]. - LibraryElement2 get libraryElement; + LibraryElement get libraryElement; /// The library [Source] of the reference. Source get librarySource; diff --git a/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart b/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart index 2a4ad98bfb8..b4f84a9c4f9 100644 --- a/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart +++ b/pkg/analysis_server/lib/src/services/search/search_engine_internal.dart @@ -22,13 +22,13 @@ class SearchEngineImpl implements SearchEngine { @override Future appendAllSubtypes( - InterfaceElement2 type, - Set allSubtypes, + InterfaceElement type, + Set allSubtypes, OperationPerformanceImpl performance, ) async { var searchEngineCache = SearchEngineCache(); - Future addSubtypes(InterfaceElement2 type) async { + Future addSubtypes(InterfaceElement type) async { var directResults = await performance.runAsync( '_searchDirectSubtypes', (performance) => @@ -36,7 +36,7 @@ class SearchEngineImpl implements SearchEngine { ); for (var directResult in directResults) { var directSubtype = - directResult.enclosingFragment.element as InterfaceElement2; + directResult.enclosingFragment.element as InterfaceElement; if (allSubtypes.add(directSubtype)) { await addSubtypes(directSubtype); } @@ -47,7 +47,7 @@ class SearchEngineImpl implements SearchEngine { } @override - Future?> membersOfSubtypes(InterfaceElement2 type) async { + Future?> membersOfSubtypes(InterfaceElement type) async { var drivers = _drivers.toList(); var searchedFiles = _createSearchedFiles(drivers); @@ -57,7 +57,7 @@ class SearchEngineImpl implements SearchEngine { var members = {}; Future addMembers( - InterfaceElement2? type, + InterfaceElement? type, SubtypeResult? subtype, ) async { if (subtype != null && !visitedIds.add(subtype.id)) { @@ -149,7 +149,7 @@ class SearchEngineImpl implements SearchEngine { @override Future> searchPrefixesUsedInLibrary( covariant LibraryElementImpl library, - Element2 element, + Element element, ) async { var driver = (library.session.analysisContext as DriverBasedAnalysisContext).driver; @@ -157,7 +157,7 @@ class SearchEngineImpl implements SearchEngine { } @override - Future> searchReferences(Element2 element) async { + Future> searchReferences(Element element) async { var allResults = []; var drivers = _drivers.toList(); var searchedFiles = _createSearchedFiles(drivers); @@ -170,7 +170,7 @@ class SearchEngineImpl implements SearchEngine { @override Future> searchSubtypes( - InterfaceElement2 type, + InterfaceElement type, SearchEngineCache searchEngineCache, { OperationPerformanceImpl? performance, }) async { @@ -185,7 +185,7 @@ class SearchEngineImpl implements SearchEngine { @override Future> searchTopLevelDeclarations(String pattern) async { - var allElements = HashSet( + var allElements = HashSet( hashCode: (e) => e.name3.hashCode, equals: (a, b) { return a.lookupName == b.lookupName && @@ -212,7 +212,7 @@ class SearchEngineImpl implements SearchEngine { } Future> _searchDirectSubtypes( - InterfaceElement2 type, + InterfaceElement type, SearchEngineCache searchEngineCache, OperationPerformanceImpl performance, ) async { @@ -265,10 +265,10 @@ class SearchMatchImpl implements SearchMatch { final Source unitSource; @override - final LibraryElement2 libraryElement; + final LibraryElement libraryElement; @override - final Element2 element; + final Element element; @override final bool isResolved; @@ -313,7 +313,7 @@ class SearchMatchImpl implements SearchMatch { return buffer.toString(); } - static SearchMatchImpl forElement(Element2 element) { + static SearchMatchImpl forElement(Element element) { var firstFragment = element.firstFragment; var libraryFragment = firstFragment.libraryFragment!; return SearchMatchImpl( diff --git a/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateful_widget.dart b/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateful_widget.dart index 0f80fa3423e..bbe99ec0fc7 100644 --- a/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateful_widget.dart +++ b/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateful_widget.dart @@ -14,12 +14,12 @@ class FlutterStatefulWidget extends FlutterSnippetProducer static const prefix = 'stful'; static const label = 'Flutter Stateful Widget'; - late ClassElement2? classStatefulWidget; - late ClassElement2? classState; + late ClassElement? classStatefulWidget; + late ClassElement? classState; @override - late ClassElement2? classBuildContext; + late ClassElement? classBuildContext; @override - late ClassElement2? classKey; + late ClassElement? classKey; FlutterStatefulWidget(super.request, {required super.elementImportCache}); diff --git a/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateful_widget_with_animation.dart b/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateful_widget_with_animation.dart index 262c2806832..f17722a394b 100644 --- a/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateful_widget_with_animation.dart +++ b/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateful_widget_with_animation.dart @@ -16,14 +16,14 @@ class FlutterStatefulWidgetWithAnimationController static const prefix = 'stanim'; static const label = 'Flutter Widget with AnimationController'; - late ClassElement2? classStatefulWidget; - late ClassElement2? classState; + late ClassElement? classStatefulWidget; + late ClassElement? classState; @override - late ClassElement2? classBuildContext; + late ClassElement? classBuildContext; @override - late ClassElement2? classKey; - late ClassElement2? classAnimationController; - late MixinElement2? classSingleTickerProviderStateMixin; + late ClassElement? classKey; + late ClassElement? classAnimationController; + late MixinElement? classSingleTickerProviderStateMixin; FlutterStatefulWidgetWithAnimationController( super.request, { diff --git a/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateless_widget.dart b/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateless_widget.dart index 475a4764dc7..d42bba93430 100644 --- a/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateless_widget.dart +++ b/pkg/analysis_server/lib/src/services/snippets/dart/flutter_stateless_widget.dart @@ -13,13 +13,13 @@ class FlutterStatelessWidget extends FlutterSnippetProducer static const prefix = 'stless'; static const label = 'Flutter Stateless Widget'; - late ClassElement2? classStatelessWidget; + late ClassElement? classStatelessWidget; @override - late ClassElement2? classBuildContext; + late ClassElement? classBuildContext; @override - late ClassElement2? classKey; + late ClassElement? classKey; FlutterStatelessWidget(super.request, {required super.elementImportCache}); diff --git a/pkg/analysis_server/lib/src/services/snippets/snippet_manager.dart b/pkg/analysis_server/lib/src/services/snippets/snippet_manager.dart index 30225b5d867..0dba83fae07 100644 --- a/pkg/analysis_server/lib/src/services/snippets/snippet_manager.dart +++ b/pkg/analysis_server/lib/src/services/snippets/snippet_manager.dart @@ -31,7 +31,7 @@ import 'package:analyzer/src/util/file_paths.dart' as file_paths; typedef SnippetProducerGenerator = SnippetProducer Function( DartSnippetRequest, { - required Map elementImportCache, + required Map elementImportCache, }); /// [DartSnippetManager] determines if a snippet request is Dart specific @@ -80,7 +80,7 @@ class DartSnippetManager { if (generators == null) { return snippets; } - var elementImportCache = {}; + var elementImportCache = {}; for (var generator in generators) { var producer = generator( request, diff --git a/pkg/analysis_server/lib/src/services/snippets/snippet_producer.dart b/pkg/analysis_server/lib/src/services/snippets/snippet_producer.dart index 05e40efb635..3a1e5db535f 100644 --- a/pkg/analysis_server/lib/src/services/snippets/snippet_producer.dart +++ b/pkg/analysis_server/lib/src/services/snippets/snippet_producer.dart @@ -21,18 +21,18 @@ import 'package:meta/meta.dart'; abstract class DartSnippetProducer extends SnippetProducer { final AnalysisSessionHelper sessionHelper; final CorrectionUtils utils; - final LibraryElement2 libraryElement; + final LibraryElement libraryElement; final bool useSuperParams; /// A cache of mappings from Elements to their public Library Elements. /// /// Callers can share this cache across multiple snippet producers to avoid /// repeated searches where they may add imports for the same elements. - final Map _elementImportCache; + final Map _elementImportCache; DartSnippetProducer( super.request, { - required Map elementImportCache, + required Map elementImportCache, }) : sessionHelper = AnalysisSessionHelper(request.analysisSession), utils = CorrectionUtils(request.unit), libraryElement = request.unit.libraryElement2, @@ -50,14 +50,14 @@ abstract class DartSnippetProducer extends SnippetProducer { } abstract class FlutterSnippetProducer extends DartSnippetProducer { - late ClassElement2? _classWidget; - late ClassElement2? _classPlaceholder; + late ClassElement? _classWidget; + late ClassElement? _classPlaceholder; /// Elements that need to be imported for generated code to be valid. /// /// Calling [addImports] will add any required imports to the supplied /// builder. - final Set _requiredElementImports = {}; + final Set _requiredElementImports = {}; FlutterSnippetProducer(super.request, {required super.elementImportCache}); @@ -75,7 +75,7 @@ abstract class FlutterSnippetProducer extends DartSnippetProducer { ); } - Future getClass(String name) async { + Future getClass(String name) async { var class_ = await sessionHelper.getFlutterClass(name); if (class_ != null) { _requiredElementImports.add(class_); @@ -83,7 +83,7 @@ abstract class FlutterSnippetProducer extends DartSnippetProducer { return class_; } - Future getMixin(String name) async { + Future getMixin(String name) async { var mixin = await sessionHelper.getMixin(widgetsUri, name); if (mixin != null) { _requiredElementImports.add(mixin); @@ -92,7 +92,7 @@ abstract class FlutterSnippetProducer extends DartSnippetProducer { } DartType getType( - InterfaceElement2 classElement, [ + InterfaceElement classElement, [ NullabilitySuffix nullabilitySuffix = NullabilitySuffix.none, ]) => classElement.instantiate( typeArguments: const [], @@ -117,8 +117,8 @@ abstract class FlutterSnippetProducer extends DartSnippetProducer { /// A mixin that provides some common methods for producers that build snippets /// for Flutter widget classes. mixin FlutterWidgetSnippetProducerMixin on FlutterSnippetProducer { - ClassElement2? get classBuildContext; - ClassElement2? get classKey; + ClassElement? get classBuildContext; + ClassElement? get classKey; String get widgetClassName => 'MyWidget'; void writeBuildMethod(DartEditBuilder builder) { diff --git a/pkg/analysis_server/lib/src/status/element_writer.dart b/pkg/analysis_server/lib/src/status/element_writer.dart index cc9836e2754..6e765f76925 100644 --- a/pkg/analysis_server/lib/src/status/element_writer.dart +++ b/pkg/analysis_server/lib/src/status/element_writer.dart @@ -17,7 +17,7 @@ class ElementWriter with TreeWriter { /// of visited elements on the given [buffer]. ElementWriter(this.buffer); - void write(Element2 element) { + void write(Element element) { _writeElement(element); writeProperties(_computeProperties(element)); _writeFragments(element); @@ -33,19 +33,19 @@ class ElementWriter with TreeWriter { /// Writes a representation of the properties of the given [element] to the /// buffer. - Map _computeProperties(Element2 element) { + Map _computeProperties(Element element) { var properties = {}; var firstFragment = element.firstFragment; if (element case Annotatable element) { properties['annotations'] = element.metadata2.annotations; } - if (element is InterfaceElement2) { + if (element is InterfaceElement) { properties['interfaces'] = element.interfaces; - properties['isEnum'] = element is EnumElement2; + properties['isEnum'] = element is EnumElement; properties['mixins'] = element.mixins; properties['supertype'] = element.supertype; - if (element is ClassElement2) { + if (element is ClassElement) { properties['hasNonFinalField'] = element.hasNonFinalField; properties['isAbstract'] = element.isAbstract; properties['isMixinApplication'] = element.isMixinApplication; @@ -61,37 +61,37 @@ class ElementWriter with TreeWriter { if (firstFragment is ConstTopLevelVariableElementImpl) { properties['evaluationResult'] = firstFragment.evaluationResult; } - if (element is ConstructorElement2) { + if (element is ConstructorElement) { properties['isConst'] = element.isConst; properties['isDefaultConstructor'] = element.isDefaultConstructor; properties['isFactory'] = element.isFactory; properties['redirectedConstructor'] = element.redirectedConstructor2; } - if (element is ExecutableElement2) { + if (element is ExecutableElement) { properties['hasImplicitReturnType'] = element.hasImplicitReturnType; properties['isAbstract'] = element.isAbstract; properties['isExternal'] = element.isExternal; - if (element is MethodElement2) { + if (element is MethodElement) { properties['isOperator'] = element.isOperator; } properties['isStatic'] = element.isStatic; properties['returnType'] = element.returnType; properties['type'] = element.type; } - if (element is FieldElement2) { + if (element is FieldElement) { properties['isEnumConstant'] = element.isEnumConstant; } - if (element is FieldFormalParameterElement2) { + if (element is FieldFormalParameterElement) { properties['field'] = element.field2; } if (element is TopLevelFunctionElement) { properties['isEntryPoint'] = element.isEntryPoint; } - if (element is FunctionTypedElement2) { + if (element is FunctionTypedElement) { properties['returnType'] = element.returnType; properties['type'] = element.type; } - if (element is LibraryElement2) { + if (element is LibraryElement) { properties['entryPoint'] = element.entryPoint2; properties['isDartAsync'] = element.isDartAsync; properties['isDartCore'] = element.isDartCore; @@ -112,16 +112,16 @@ class ElementWriter with TreeWriter { properties['parameterKind'] = 'unknown kind'; } } - if (element is PropertyInducingElement2) { + if (element is PropertyInducingElement) { properties['isStatic'] = element.isStatic; } - if (element is TypeParameterElement2) { + if (element is TypeParameterElement) { properties['bound'] = element.bound; } - if (element is TypeParameterizedElement2) { + if (element is TypeParameterizedElement) { properties['typeParameters'] = element.typeParameters2; } - if (element is VariableElement2) { + if (element is VariableElement) { properties['hasImplicitType'] = element.hasImplicitType; properties['isConst'] = element.isConst; properties['isFinal'] = element.isFinal; @@ -133,7 +133,7 @@ class ElementWriter with TreeWriter { } /// Write a representation of the given [element] to the buffer. - void _writeElement(Element2 element) { + void _writeElement(Element element) { indent(); if (element.isSynthetic) { buffer.write(''); @@ -186,7 +186,7 @@ class ElementWriter with TreeWriter { writeProperties(properties); } - void _writeFragments(Element2 element) { + void _writeFragments(Element element) { indentLevel++; try { var index = 0; diff --git a/pkg/analysis_server/lib/src/utilities/element_location2.dart b/pkg/analysis_server/lib/src/utilities/element_location2.dart index 1e9a9910217..1edbdc315f8 100644 --- a/pkg/analysis_server/lib/src/utilities/element_location2.dart +++ b/pkg/analysis_server/lib/src/utilities/element_location2.dart @@ -7,8 +7,8 @@ import 'package:analyzer/dart/analysis/session.dart'; import 'package:analyzer/dart/element/element.dart'; import 'package:collection/collection.dart'; -/// Represents the location of an [Element2] that exists in a chain of elements -/// from a [LibraryElement2]. +/// Represents the location of an [Element] that exists in a chain of elements +/// from a [LibraryElement]. /// /// Elements with [Fragment]s or Elements with `null` names anywhere in the /// chain are not representable. @@ -16,7 +16,7 @@ class ElementLocation { /// The library that this element belongs to. final String _libraryUri; - /// The [Element2.lookupName] for this element, or the containing element if + /// The [Element.lookupName] for this element, or the containing element if /// this location is a [_MemberElementLocation]. final String _topLevelName; @@ -39,11 +39,11 @@ class ElementLocation { String get encoding => '$_libraryUri;$_topLevelName'; - /// Locates the [Element2] represented by this [ElementLocation] in + /// Locates the [Element] represented by this [ElementLocation] in /// [session]. /// - /// Returns `null` if the [Element2] cannot be located. - Future locateIn(AnalysisSession session) async { + /// Returns `null` if the [Element] cannot be located. + Future locateIn(AnalysisSession session) async { var result = await session.getLibraryByUri(_libraryUri); if (result is! LibraryElementResult) return null; @@ -56,7 +56,7 @@ class ElementLocation { /// /// Returns `null` if this element is neither a top level element or a /// member of a top level element, or if either do not have a `lookupName`. - static ElementLocation? forElement(Element2 element) { + static ElementLocation? forElement(Element element) { var library = element.library2; if (library == null) return null; var libraryUri = library.uri.toString(); @@ -79,7 +79,7 @@ class ElementLocation { } class _MemberElementLocation extends ElementLocation { - /// The [Element2.lookupName] for this member within [_topLevelName]. + /// The [Element.lookupName] for this member within [_topLevelName]. final String _memberName; _MemberElementLocation._( @@ -91,12 +91,12 @@ class _MemberElementLocation extends ElementLocation { @override String get encoding => '${super.encoding};$_memberName'; - /// Locates the [Element2] represented by this [_MemberElementLocation] in + /// Locates the [Element] represented by this [_MemberElementLocation] in /// [session]. /// - /// Returns `null` if the [Element2] cannot be located. + /// Returns `null` if the [Element] cannot be located. @override - Future locateIn(AnalysisSession session) async { + Future locateIn(AnalysisSession session) async { var topLevel = await super.locateIn(session); return topLevel?.children2.firstWhereOrNull( diff --git a/pkg/analysis_server/lib/src/utilities/extensions/ast.dart b/pkg/analysis_server/lib/src/utilities/extensions/ast.dart index 48dd900815f..ea6cfac2f4c 100644 --- a/pkg/analysis_server/lib/src/utilities/extensions/ast.dart +++ b/pkg/analysis_server/lib/src/utilities/extensions/ast.dart @@ -75,8 +75,8 @@ extension AnnotatedNodeExtension on AnnotatedNode { } extension AstNodeExtension on AstNode { - /// Returns [ExtensionElement2] declared by an enclosing node. - ExtensionElement2? get enclosingExtensionElement { + /// Returns [ExtensionElement] declared by an enclosing node. + ExtensionElement? get enclosingExtensionElement { for (var node in withParents) { if (node is ExtensionDeclaration) { return node.declaredFragment?.element; @@ -97,8 +97,8 @@ extension AstNodeExtension on AstNode { return null; } - /// Returns [InterfaceElement2] declared by an enclosing node. - InterfaceElement2? get enclosingInterfaceElement { + /// Returns [InterfaceElement] declared by an enclosing node. + InterfaceElement? get enclosingInterfaceElement { for (var node in withParents) { if (node is ClassDeclaration) { return node.declaredFragment?.element; @@ -200,7 +200,7 @@ extension AstNodeExtension on AstNode { /// this work-around. /// /// Returns `null` if `this` is `null` or doesn't have an element. - Element2? getElement({bool useMockForImport = false}) { + Element? getElement({bool useMockForImport = false}) { AstNode? node = this; if (node is SimpleIdentifier && node.parent is LibraryIdentifier) { node = node.parent; @@ -212,7 +212,7 @@ extension AstNodeExtension on AstNode { return null; } - Element2? element; + Element? element; if (useMockForImport && node is ImportDirective) { element = MockLibraryImportElement(node.libraryImport!); } else { @@ -220,7 +220,7 @@ extension AstNodeExtension on AstNode { } if (useMockForImport && node is SimpleIdentifier && - element is PrefixElement2) { + element is PrefixElement) { element = MockLibraryImportElement(getImportElement(node)!); } return element; @@ -305,8 +305,8 @@ extension DeclaredVariablePatternExtension on DeclaredVariablePattern { } extension DirectiveExtension on Directive { - /// If the target imports or exports a [LibraryElement2], returns it. - LibraryElement2? get referencedLibrary { + /// If the target imports or exports a [LibraryElement], returns it. + LibraryElement? get referencedLibrary { switch (this) { case ExportDirective directive: return directive.libraryExport?.exportedLibrary2; @@ -375,21 +375,21 @@ extension MethodInvocationExtension on MethodInvocation { /// from either Iterable`, `List`, `Map`, or `Set`. bool get isCastMethodInvocation { var element = methodName.element; - return element is MethodElement2 && element.isCastMethod; + return element is MethodElement && element.isCastMethod; } /// Returns whether this expression is an invocation of the method `toList` /// from `Iterable`. bool get isToListMethodInvocation { var element = methodName.element; - return element is MethodElement2 && element.isToListMethod; + return element is MethodElement && element.isToListMethod; } /// Returns whether this expression is an invocation of the method `toSet` /// from `Iterable`. bool get isToSetMethodInvocation { var element = methodName.element; - return element is MethodElement2 && element.isToSetMethod; + return element is MethodElement && element.isToSetMethod; } } diff --git a/pkg/analysis_server/lib/src/utilities/extensions/completion_request.dart b/pkg/analysis_server/lib/src/utilities/extensions/completion_request.dart index 86a8d70a5bc..a4f56a2b29c 100644 --- a/pkg/analysis_server/lib/src/utilities/extensions/completion_request.dart +++ b/pkg/analysis_server/lib/src/utilities/extensions/completion_request.dart @@ -15,7 +15,7 @@ extension DartCompletionRequestExtensions on DartCompletionRequest { /// // TODO(scheglov): Validate that suggesting a tear-off instead of invocation // is statistically a good choice. - bool shouldSuggestTearOff(InterfaceElement2 element) { + bool shouldSuggestTearOff(InterfaceElement element) { if (!libraryElement.featureSet.isEnabled(Feature.constructor_tearoffs)) { return false; } diff --git a/pkg/analysis_server/lib/src/utilities/extensions/element.dart b/pkg/analysis_server/lib/src/utilities/extensions/element.dart index cfe0c0b5260..ce02cecb67d 100644 --- a/pkg/analysis_server/lib/src/utilities/extensions/element.dart +++ b/pkg/analysis_server/lib/src/utilities/extensions/element.dart @@ -4,7 +4,7 @@ import 'package:analyzer/dart/element/element.dart'; -extension ClassElementExtensions on ClassElement2 { +extension ClassElementExtensions on ClassElement { /// Return `true` if this element represents the class `Iterable` from /// `dart:core`. bool get isDartCoreIterable => name3 == 'Iterable' && library2.isDartCore; @@ -22,7 +22,7 @@ extension ClassElementExtensions on ClassElement2 { bool get isDartCoreSet => name3 == 'Set' && library2.isDartCore; } -extension ElementExtensions on Element2 { +extension ElementExtensions on Element { /// The content of the documentation comment (including delimiters) for this /// element. /// @@ -49,17 +49,17 @@ extension ElementExtensions on Element2 { } var ancestor = enclosingElement2; - if (ancestor is InterfaceElement2) { + if (ancestor is InterfaceElement) { if (ancestor.metadata2.hasDeprecated) { return true; } ancestor = ancestor.enclosingElement2; } - return ancestor is LibraryElement2 && ancestor.metadata2.hasDeprecated; + return ancestor is LibraryElement && ancestor.metadata2.hasDeprecated; } /// Return this element and all its enclosing elements. - Iterable get withAncestors sync* { + Iterable get withAncestors sync* { var current = this; while (true) { yield current; @@ -87,7 +87,7 @@ extension FragmentExtensions on Fragment { } } -extension MethodElementExtensions on MethodElement2 { +extension MethodElementExtensions on MethodElement { /// Return `true` if this element represents the method `cast` from either /// `Iterable`, `List`, `Map`, or `Set`. bool get isCastMethod { @@ -95,7 +95,7 @@ extension MethodElementExtensions on MethodElement2 { return false; } var definingClass = enclosingElement2; - if (definingClass is! ClassElement2) { + if (definingClass is! ClassElement) { return false; } return definingClass.isDartCoreIterable || @@ -111,7 +111,7 @@ extension MethodElementExtensions on MethodElement2 { return false; } var definingClass = enclosingElement2; - if (definingClass is! ClassElement2) { + if (definingClass is! ClassElement) { return false; } return definingClass.isDartCoreIterable; @@ -124,7 +124,7 @@ extension MethodElementExtensions on MethodElement2 { return false; } var definingClass = enclosingElement2; - if (definingClass is! ClassElement2) { + if (definingClass is! ClassElement) { return false; } return definingClass.isDartCoreIterable; diff --git a/pkg/analysis_server/lib/src/utilities/import_analyzer.dart b/pkg/analysis_server/lib/src/utilities/import_analyzer.dart index 4c23f374ecc..ec284bb6c6d 100644 --- a/pkg/analysis_server/lib/src/utilities/import_analyzer.dart +++ b/pkg/analysis_server/lib/src/utilities/import_analyzer.dart @@ -21,18 +21,18 @@ class ImportAnalyzer { final ResolvedLibraryResult result; /// The elements for the declarations to be moved. - final Set movingDeclarations = {}; + final Set movingDeclarations = {}; /// The elements for the declarations that are staying. - final Set stayingDeclarations = {}; + final Set stayingDeclarations = {}; /// A map from the elements referenced by the declarations to be moved to the /// set of imports used to reference those declarations. - final Map> movingReferences = {}; + final Map> movingReferences = {}; /// A map from the elements referenced by the declarations that are staying to /// the set of imports used to reference those declarations. - final Map> stayingReferences = {}; + final Map> stayingReferences = {}; /// Analyzes the given library [result] to find the declarations and /// references being moved and that are staying. @@ -103,7 +103,7 @@ class _ElementRecorder { /// is being moved. Not necessary the offset of the name. For example to /// a [MethodDeclaration] it would be the offset of the enclosing /// [ClassDeclaration] because we move the whole top-level declarations. - void recordDeclaration(int offset, Element2? declaredElement) { + void recordDeclaration(int offset, Element? declaredElement) { if (declaredElement == null) { return; } @@ -119,11 +119,11 @@ class _ElementRecorder { /// [referenceOffset]. [import] is the specific import used to reference the /// including any prefix, show, hide. void recordReference( - Element2 referencedElement, + Element referencedElement, int referenceOffset, LibraryImport? import, ) { - if (referencedElement is PropertyAccessorElement2) { + if (referencedElement is PropertyAccessorElement) { if (referencedElement.isSynthetic) { var variable = referencedElement.variable3; if (variable == null) { @@ -311,7 +311,7 @@ class _ReferenceFinder extends RecursiveAstVisitor { /// Finds the [LibraryImport] that is used to import [element] for use /// in [node]. - LibraryImport? _getImportForElement(AstNode? node, Element2 element) { + LibraryImport? _getImportForElement(AstNode? node, Element element) { var prefix = _getPrefixFromExpression(node)?.name3; var lookupName = () { @@ -343,7 +343,7 @@ class _ReferenceFinder extends RecursiveAstVisitor { // Extensions can be used without a prefix, so we can use any import that // brings in the extension. - if (import == null && prefix == null && element is ExtensionElement2) { + if (import == null && prefix == null && element is ExtensionElement) { import = _importsByPrefix.values.flattenedToList .where( @@ -364,18 +364,18 @@ class _ReferenceFinder extends RecursiveAstVisitor { } /// Return the prefix used in [node]. - PrefixElement2? _getPrefixFromExpression(AstNode? node) { + PrefixElement? _getPrefixFromExpression(AstNode? node) { if (node is PrefixedIdentifier) { var prefix = node.prefix; var element = prefix.element; - if (element is PrefixElement2) { + if (element is PrefixElement) { return element; } } else if (node is PropertyAccess) { var target = node.target; if (target is PrefixedIdentifier) { var element = target.prefix.element; - if (element is PrefixElement2) { + if (element is PrefixElement) { return element; } } @@ -383,7 +383,7 @@ class _ReferenceFinder extends RecursiveAstVisitor { var target = node.target; if (target is SimpleIdentifier) { var element = target.element; - if (element is PrefixElement2) { + if (element is PrefixElement) { return element; } } @@ -395,9 +395,9 @@ class _ReferenceFinder extends RecursiveAstVisitor { /// Records a reference to [element] (if not null) at the offset of [node], /// extracting any prefix from [prefixNode]. - void _recordReference(Element2? element, AstNode node, AstNode? prefixNode) { - if (element is ExecutableElement2 && - element.enclosingElement2 is ExtensionElement2 && + void _recordReference(Element? element, AstNode node, AstNode? prefixNode) { + if (element is ExecutableElement && + element.enclosingElement2 is ExtensionElement && !element.isStatic) { element = element.enclosingElement2; } @@ -413,10 +413,10 @@ class _ReferenceFinder extends RecursiveAstVisitor { } } -extension on Element2 { +extension on Element { /// Return `true` if this element reference is an interesting reference from /// the perspective of determining which imports need to be added. bool get isInterestingReference { - return this is! PrefixElement2 && enclosingElement2 is LibraryElement2; + return this is! PrefixElement && enclosingElement2 is LibraryElement; } } diff --git a/pkg/analysis_server/test/abstract_single_unit.dart b/pkg/analysis_server/test/abstract_single_unit.dart index dc0f8d2183f..09029967ad3 100644 --- a/pkg/analysis_server/test/abstract_single_unit.dart +++ b/pkg/analysis_server/test/abstract_single_unit.dart @@ -26,7 +26,7 @@ class AbstractSingleUnitTest extends AbstractContextTest { late CompilationUnit testUnit; late FindNode findNode; late FindElement2 findElement2; - late LibraryElement2 testLibraryElement; + late LibraryElement testLibraryElement; TestCode get parsedTestCode => _parsedTestCode!; set parsedTestCode(TestCode value) { if (_parsedTestCode != null) { diff --git a/pkg/analysis_server/test/services/refactoring/agnostic/change_method_signature_test.dart b/pkg/analysis_server/test/services/refactoring/agnostic/change_method_signature_test.dart index d2eaeb6fb6e..f3cc5c55e61 100644 --- a/pkg/analysis_server/test/services/refactoring/agnostic/change_method_signature_test.dart +++ b/pkg/analysis_server/test/services/refactoring/agnostic/change_method_signature_test.dart @@ -114,7 +114,7 @@ class AbstractChangeMethodSignatureTest extends AbstractContextTest { ); } - String _elementToReferenceString(Element2 element) { + String _elementToReferenceString(Element element) { var enclosingElement = element.enclosingElement2; var reference = switch (element) { ElementImpl2() => diff --git a/pkg/analysis_server/test/services/refactoring/legacy/abstract_rename.dart b/pkg/analysis_server/test/services/refactoring/legacy/abstract_rename.dart index 986550e2480..82491221b4a 100644 --- a/pkg/analysis_server/test/services/refactoring/legacy/abstract_rename.dart +++ b/pkg/analysis_server/test/services/refactoring/legacy/abstract_rename.dart @@ -43,7 +43,7 @@ class RenameRefactoringTest extends RefactoringTest { void createRenameRefactoringAtString(String search) { var node = findNode.any(search); - Element2? element; + Element? element; switch (node) { case ImportDirective(): element = MockLibraryImportElement(node.libraryImport!); @@ -51,7 +51,7 @@ class RenameRefactoringTest extends RefactoringTest { element = ElementLocator.locate2(node); } - if (node is SimpleIdentifier && element is PrefixElement2) { + if (node is SimpleIdentifier && element is PrefixElement) { element = MockLibraryImportElement(getImportElement(node)!); } @@ -60,7 +60,7 @@ class RenameRefactoringTest extends RefactoringTest { /// Creates a new [RenameRefactoring] in [refactoring] for [element]. /// Fails if no [RenameRefactoring] can be created. - void createRenameRefactoringForElement2(Element2? element) { + void createRenameRefactoringForElement2(Element? element) { var workspace = RefactoringWorkspace([driverFor(testFile)], searchEngine); var refactoring = RenameRefactoring.create( workspace, diff --git a/pkg/analysis_server/test/services/refactoring/legacy/convert_method_to_getter_test.dart b/pkg/analysis_server/test/services/refactoring/legacy/convert_method_to_getter_test.dart index da754d88d58..13235e85fb3 100644 --- a/pkg/analysis_server/test/services/refactoring/legacy/convert_method_to_getter_test.dart +++ b/pkg/analysis_server/test/services/refactoring/legacy/convert_method_to_getter_test.dart @@ -227,7 +227,7 @@ void test() {} assertTestChangeResult(expectedCode); } - void _createRefactoringForElement(ExecutableElement2 element) { + void _createRefactoringForElement(ExecutableElement element) { refactoring = ConvertMethodToGetterRefactoring( refactoringWorkspace, testAnalysisResult.session, diff --git a/pkg/analysis_server/test/services/search/search_engine_test.dart b/pkg/analysis_server/test/services/search/search_engine_test.dart index 5373a8e10dd..b651c429dd6 100644 --- a/pkg/analysis_server/test/services/search/search_engine_test.dart +++ b/pkg/analysis_server/test/services/search/search_engine_test.dart @@ -214,7 +214,7 @@ class C implements B {} var element = findElement2.class_('T'); - var subtypes = {}; + var subtypes = {}; await searchEngine.appendAllSubtypes( element, subtypes, @@ -243,7 +243,7 @@ class C extends B {} await resolveFile2(a); var element = findElement2.class_('T'); - var subtypes = {}; + var subtypes = {}; await searchEngine.appendAllSubtypes( element, subtypes, @@ -264,7 +264,7 @@ extension type C(int it) implements A {} var element = findElement2.class_('A'); - var subtypes = {}; + var subtypes = {}; await searchEngine.appendAllSubtypes( element, subtypes, @@ -290,7 +290,7 @@ mixin E implements C {} var element = findElement2.class_('T'); - var subtypes = {}; + var subtypes = {}; await searchEngine.appendAllSubtypes( element, subtypes, @@ -768,12 +768,12 @@ class B extends A {} } static void _assertContainsClass( - Set subtypes, + Set subtypes, String name, ) { expect( subtypes, - contains(predicate((InterfaceElement2 e) => e.name3 == name)), + contains(predicate((InterfaceElement e) => e.name3 == name)), ); } } @@ -797,7 +797,7 @@ void f(A a, A b) {} var element = findElement2.typeAlias('A'); var matches = await searchEngine.searchReferences(element); - Matcher hasOne(Element2 element, String search) { + Matcher hasOne(Element element, String search) { return predicate((SearchMatch match) { return match.element == element && match.sourceRange.offset == findNode.offset(search); diff --git a/pkg/analysis_server/test/services/snippets/snippet_manager_test.dart b/pkg/analysis_server/test/services/snippets/snippet_manager_test.dart index 542dd03af9d..b14b9135c8f 100644 --- a/pkg/analysis_server/test/services/snippets/snippet_manager_test.dart +++ b/pkg/analysis_server/test/services/snippets/snippet_manager_test.dart @@ -70,7 +70,7 @@ class SnippetManagerTest extends AbstractSingleUnitTest { SnippetContext.inClass: [ ( context, { - required Map elementImportCache, + required Map elementImportCache, }) => throw 'Tried to create producer for wrong context', ], }); @@ -114,7 +114,7 @@ class _NotValidSnippetProducer extends SnippetProducer { static _NotValidSnippetProducer newInstance( DartSnippetRequest request, { - required Map elementImportCache, + required Map elementImportCache, }) => _NotValidSnippetProducer._(request); } @@ -148,6 +148,6 @@ class _ValidSnippetProducer extends SnippetProducer { static _ValidSnippetProducer newInstance( DartSnippetRequest request, { - required Map elementImportCache, + required Map elementImportCache, }) => _ValidSnippetProducer._(request); } diff --git a/pkg/analysis_server/test/src/utilities/import_analyzer_test.dart b/pkg/analysis_server/test/src/utilities/import_analyzer_test.dart index 5ad211b8476..a4eceb08ede 100644 --- a/pkg/analysis_server/test/src/utilities/import_analyzer_test.dart +++ b/pkg/analysis_server/test/src/utilities/import_analyzer_test.dart @@ -39,10 +39,10 @@ class D {} !] ''', expectedMovingDeclarations: [ - element(name: 'A'), - element(name: 'B'), - element(name: 'C'), - element(name: 'D'), + element(name: 'A'), + element(name: 'B'), + element(name: 'C'), + element(name: 'D'), ], expectedStayingDeclarations: [], ); @@ -59,12 +59,12 @@ class C {} class D {} ''', expectedMovingDeclarations: [ - element(name: 'A'), - element(name: 'B'), + element(name: 'A'), + element(name: 'B'), ], expectedStayingDeclarations: [ - element(name: 'C'), - element(name: 'D'), + element(name: 'C'), + element(name: 'D'), ], ); } @@ -80,12 +80,12 @@ class D {} !] ''', expectedMovingDeclarations: [ - element(name: 'C'), - element(name: 'D'), + element(name: 'C'), + element(name: 'D'), ], expectedStayingDeclarations: [ - element(name: 'A'), - element(name: 'B'), + element(name: 'A'), + element(name: 'B'), ], ); } @@ -101,12 +101,12 @@ class C {} class D {} ''', expectedMovingDeclarations: [ - element(name: 'B'), - element(name: 'C'), + element(name: 'B'), + element(name: 'C'), ], expectedStayingDeclarations: [ - element(name: 'A'), - element(name: 'D'), + element(name: 'A'), + element(name: 'D'), ], ); } @@ -119,8 +119,8 @@ class C {} !] class D {} ''', - expectedMovingDeclarations: [element(name: 'C')], - expectedStayingDeclarations: [element(name: 'D')], + expectedMovingDeclarations: [element(name: 'C')], + expectedStayingDeclarations: [element(name: 'D')], ); } @@ -132,8 +132,8 @@ class B {} class C {} !] ''', - expectedMovingDeclarations: [element(name: 'C')], - expectedStayingDeclarations: [element(name: 'B')], + expectedMovingDeclarations: [element(name: 'C')], + expectedStayingDeclarations: [element(name: 'B')], ); } @@ -146,10 +146,10 @@ class C {} !] class D {} ''', - expectedMovingDeclarations: [element(name: 'C')], + expectedMovingDeclarations: [element(name: 'C')], expectedStayingDeclarations: [ - element(name: 'B'), - element(name: 'D'), + element(name: 'B'), + element(name: 'D'), ], ); } @@ -161,7 +161,7 @@ class D {} class C {} !] ''', - expectedMovingDeclarations: [element(name: 'C')], + expectedMovingDeclarations: [element(name: 'C')], expectedStayingDeclarations: [], ); } @@ -201,32 +201,32 @@ int set s2(x) {} int v2 = 0; ''', expectedMovingDeclarations: [ - element(name: 'C1'), - element(name: 'D1'), - element(name: 'E1'), - element(name: 'F1'), - element(name: 'G1'), - element(name: 'M1'), - element(name: 'T1'), - element(name: 'X1'), + element(name: 'C1'), + element(name: 'D1'), + element(name: 'E1'), + element(name: 'F1'), + element(name: 'G1'), + element(name: 'M1'), + element(name: 'T1'), + element(name: 'X1'), element(name: 'f1'), element(name: 'g1'), element(name: 's1'), - element(name: 'v1'), + element(name: 'v1'), ], expectedStayingDeclarations: [ - element(name: 'C2'), - element(name: 'D2'), - element(name: 'E2'), - element(name: 'F2'), - element(name: 'G2'), - element(name: 'M2'), - element(name: 'T2'), - element(name: 'X2'), + element(name: 'C2'), + element(name: 'D2'), + element(name: 'E2'), + element(name: 'F2'), + element(name: 'G2'), + element(name: 'M2'), + element(name: 'T2'), + element(name: 'X2'), element(name: 'f2'), element(name: 'g2'), element(name: 's2'), - element(name: 'v2'), + element(name: 'v2'), ], ); } @@ -249,7 +249,7 @@ class C { ''', expectedStayingReferences: {}, expectedMovingReferences: { - element(name: 'File'): [''], + element(name: 'File'): [''], }, ); } @@ -278,7 +278,7 @@ class C extends A {} ''', expectedStayingReferences: {}, expectedMovingReferences: { - element(name: 'A'): [''], + element(name: 'A'): [''], }, ); } @@ -296,7 +296,7 @@ class C {} !] ''', expectedStayingReferences: { - element(name: 'File'): [''], + element(name: 'File'): [''], }, expectedMovingReferences: {}, ); @@ -311,7 +311,7 @@ class C {} !] ''', expectedStayingReferences: { - element(name: 'C'): [''], + element(name: 'C'): [''], }, expectedMovingReferences: {}, ); @@ -346,7 +346,7 @@ class C {} !] ''', expectedStayingReferences: { - element(name: 'C'): [''], + element(name: 'C'): [''], }, ); } @@ -360,7 +360,7 @@ C? c; !] ''', expectedMovingReferences: { - element(name: 'C'): [''], + element(name: 'C'): [''], }, ); } @@ -374,7 +374,7 @@ enum E {} !] ''', expectedStayingReferences: { - element(name: 'E'): [''], + element(name: 'E'): [''], }, ); } @@ -388,7 +388,7 @@ E? e; !] ''', expectedMovingReferences: { - element(name: 'E'): [''], + element(name: 'E'): [''], }, ); } @@ -404,7 +404,7 @@ extension X on int { !] ''', expectedStayingReferences: { - element(name: 'X'): [''], + element(name: 'X'): [''], }, ); } @@ -420,7 +420,7 @@ var x = 2.g; !] ''', expectedMovingReferences: { - element(name: 'X'): [''], + element(name: 'X'): [''], }, ); } @@ -437,7 +437,7 @@ extension X on A { !] ''', expectedStayingReferences: { - element(name: 'X'): [''], + element(name: 'X'): [''], }, ); } @@ -454,8 +454,8 @@ var x = A() + A(); !] ''', expectedMovingReferences: { - element(name: 'X'): [''], - element(name: 'A'): [''], + element(name: 'X'): [''], + element(name: 'A'): [''], }, ); } @@ -471,7 +471,7 @@ extension X on int { !] ''', expectedStayingReferences: { - element(name: 'X'): [''], + element(name: 'X'): [''], }, ); } @@ -487,7 +487,7 @@ var x = X(2).g; !] ''', expectedMovingReferences: { - element(name: 'X'): [''], + element(name: 'X'): [''], }, ); } @@ -501,7 +501,7 @@ typedef void F(); !] ''', expectedStayingReferences: { - element(name: 'F'): [''], + element(name: 'F'): [''], }, ); } @@ -515,7 +515,7 @@ F? f; !] ''', expectedMovingReferences: { - element(name: 'F'): [''], + element(name: 'F'): [''], }, ); } @@ -529,7 +529,7 @@ typedef G = void Function(); !] ''', expectedStayingReferences: { - element(name: 'G'): [''], + element(name: 'G'): [''], }, ); } @@ -543,7 +543,7 @@ G? g; !] ''', expectedMovingReferences: { - element(name: 'G'): [''], + element(name: 'G'): [''], }, ); } @@ -557,7 +557,7 @@ mixin M {} !] ''', expectedStayingReferences: { - element(name: 'M'): [''], + element(name: 'M'): [''], }, ); } @@ -571,7 +571,7 @@ M? m; !] ''', expectedMovingReferences: { - element(name: 'M'): [''], + element(name: 'M'): [''], }, ); } @@ -587,7 +587,7 @@ mixin M {} !] ''', expectedStayingReferences: { - element(name: 'D'): [''], + element(name: 'D'): [''], }, ); } @@ -603,7 +603,7 @@ D? d; !] ''', expectedMovingReferences: { - element(name: 'D'): [''], + element(name: 'D'): [''], }, ); } @@ -740,7 +740,7 @@ int v = 0; !] ''', expectedStayingReferences: { - element(name: 'v'): [''], + element(name: 'v'): [''], }, ); } @@ -755,7 +755,7 @@ void f() => v += 1; !] ''', expectedMovingReferences: { - element(name: 'v'): [''], + element(name: 'v'): [''], }, ); } @@ -769,7 +769,7 @@ int v = 0; !] ''', expectedStayingReferences: { - element(name: 'v'): [''], + element(name: 'v'): [''], }, ); } @@ -783,7 +783,7 @@ var x = v; !] ''', expectedMovingReferences: { - element(name: 'v'): [''], + element(name: 'v'): [''], }, ); } @@ -832,7 +832,7 @@ int v = 0; !] ''', expectedStayingReferences: { - element(name: 'v'): [''], + element(name: 'v'): [''], }, ); } @@ -847,7 +847,7 @@ void f() => v++; !] ''', expectedMovingReferences: { - element(name: 'v'): [''], + element(name: 'v'): [''], }, ); } @@ -896,7 +896,7 @@ int v = 0; !] ''', expectedStayingReferences: { - element(name: 'v'): [''], + element(name: 'v'): [''], }, ); } @@ -911,7 +911,7 @@ void f() => ++v; !] ''', expectedMovingReferences: { - element(name: 'v'): [''], + element(name: 'v'): [''], }, ); } @@ -926,7 +926,7 @@ class C {} !] ''', expectedStayingReferences: { - element(name: 'T'): [''], + element(name: 'T'): [''], }, ); } @@ -941,7 +941,7 @@ T? t; !] ''', expectedMovingReferences: { - element(name: 'T'): [''], + element(name: 'T'): [''], }, ); } @@ -968,10 +968,10 @@ c.Directory? d2; d.Directory? d3; ''', expectedMovingReferences: { - element(name: 'File'): ['', 'a', 'b'], + element(name: 'File'): ['', 'a', 'b'], }, expectedStayingReferences: { - element(name: 'Directory'): ['', 'c', 'd'], + element(name: 'Directory'): ['', 'c', 'd'], }, ); } @@ -1042,16 +1042,16 @@ abstract class ImportAnalyzerTest extends PubPackageAnalysisServerTest { } } - _ExpectedElement element({required String name}) => + _ExpectedElement element({required String name}) => _ExpectedElement(name: name); } -class _ExpectedElement { +class _ExpectedElement { final String name; _ExpectedElement({required this.name}); - void assertMatches(Element2 element) { + void assertMatches(Element element) { expect(element, isA()); expect(element.name3, name); } diff --git a/pkg/analysis_server/test/src/utilities/selection_coverage_test.dart b/pkg/analysis_server/test/src/utilities/selection_coverage_test.dart index 79df7197a09..92eeffb2464 100644 --- a/pkg/analysis_server/test/src/utilities/selection_coverage_test.dart +++ b/pkg/analysis_server/test/src/utilities/selection_coverage_test.dart @@ -20,7 +20,7 @@ void main() { } class AstImplData { - final List instantiableInterfaces = []; + final List instantiableInterfaces = []; AstImplData(); } @@ -28,24 +28,24 @@ class AstImplData { class AstInterfaceData { /// A table mapping the element for a class to a list of the elements for the /// supertypes of that class. - final Map> supertypes = {}; + final Map> supertypes = {}; /// A table mapping class element to a list of the getters declared directly /// in that class that return a `NodeList`. - final Map> declaredLists = {}; + final Map> declaredLists = {}; AstInterfaceData(); - List nodeListsFor(ClassElement2 class_) { - var lists = []; - _addListsFor(lists, class_, {}); + List nodeListsFor(ClassElement class_) { + var lists = []; + _addListsFor(lists, class_, {}); return lists; } void _addListsFor( - List lists, - ClassElement2 class_, - Set visited, + List lists, + ClassElement class_, + Set visited, ) { if (!visited.add(class_)) { return; @@ -77,7 +77,7 @@ class SelectionCoverageTest { if (implementsClause != null) { for (var type in implementsClause.interfaces) { var element = type.type?.element3; - if (element is ClassElement2 && element.name3 == interfaceName) { + if (element is ClassElement && element.name3 == interfaceName) { data.instantiableInterfaces.add(element); } } @@ -99,7 +99,7 @@ class SelectionCoverageTest { if (implementsClause != null) { for (var supertype in implementsClause.interfaces) { var supertypeElement = supertype.type?.element3; - if (supertypeElement is ClassElement2) { + if (supertypeElement is ClassElement) { data.supertypes .putIfAbsent(subtypeElement, () => []) .add(supertypeElement); @@ -108,7 +108,7 @@ class SelectionCoverageTest { } // Build the node list map. - var nodeLists = []; + var nodeLists = []; for (var member in declaration.members) { if (member is MethodDeclaration && member.isGetter) { var returnType = member.returnType; @@ -145,7 +145,7 @@ class SelectionCoverageTest { ?.element .type .element3; - if (visitedClass is ClassElement2) { + if (visitedClass is ClassElement) { var visitor = VisitMethodVisitor(); member.body.accept(visitor); data.visitedLists[visitedClass] = visitor.visitedLists; @@ -245,7 +245,7 @@ class SelectionCoverageTest { for (var visitedNodeList in visitedNodeLists) { unvisitedNodeLists.remove(visitedNodeList); var overridden = inheritanceManager.getOverridden4( - visitedNodeList.enclosingElement2 as InterfaceElement2, + visitedNodeList.enclosingElement2 as InterfaceElement, Name(visitedNodeList.library2.uri, visitedNodeList.name3!), ); if (overridden != null) { @@ -269,13 +269,13 @@ class SelectionCoverageTest { } class SelectionData { - final Map> visitedLists = {}; + final Map> visitedLists = {}; SelectionData(); } class VisitMethodVisitor extends RecursiveAstVisitor { - List visitedLists = []; + List visitedLists = []; VisitMethodVisitor(); @@ -284,9 +284,9 @@ class VisitMethodVisitor extends RecursiveAstVisitor { if (node.methodName.name == '_fromList') { var argument = node.argumentList.arguments.first; if (argument is PrefixedIdentifier) { - visitedLists.add(argument.identifier.element as ExecutableElement2); + visitedLists.add(argument.identifier.element as ExecutableElement); } else if (argument is PropertyAccess) { - visitedLists.add(argument.propertyName.element as ExecutableElement2); + visitedLists.add(argument.propertyName.element as ExecutableElement); } } } diff --git a/pkg/analysis_server/tool/code_completion/completion_metrics.dart b/pkg/analysis_server/tool/code_completion/completion_metrics.dart index ff961a8d8f8..6fecad55959 100644 --- a/pkg/analysis_server/tool/code_completion/completion_metrics.dart +++ b/pkg/analysis_server/tool/code_completion/completion_metrics.dart @@ -26,20 +26,20 @@ import 'package:analyzer/dart/ast/ast.dart'; import 'package:analyzer/dart/ast/token.dart'; import 'package:analyzer/dart/element/element.dart' show - Element2, - EnumElement2, - ExecutableElement2, - ExtensionElement2, - FieldElement2, + Element, + EnumElement, + ExecutableElement, + ExtensionElement, + FieldElement, FormalParameterElement, - InterfaceElement2, - LibraryElement2, + InterfaceElement, + LibraryElement, LocalFunctionElement, - LocalVariableElement2, - MixinElement2, - PrefixElement2, - TypeParameterElement2, - VariableElement2; + LocalVariableElement, + MixinElement, + PrefixElement, + TypeParameterElement, + VariableElement; import 'package:analyzer/file_system/file_system.dart'; import 'package:analyzer/file_system/physical_file_system.dart'; import 'package:analyzer/src/util/performance/operation_performance.dart'; @@ -1713,23 +1713,23 @@ class CompletionResult { var element = _getElement(entity); if (element != null) { var parent = element.enclosingElement2; - if (parent is InterfaceElement2 || parent is ExtensionElement2) { + if (parent is InterfaceElement || parent is ExtensionElement) { if (_isStatic(element)) { return CompletionGroup.staticMember; } else { return CompletionGroup.instanceMember; } - } else if (parent is LibraryElement2 && - element is! InterfaceElement2 && - element is! ExtensionElement2) { + } else if (parent is LibraryElement && + element is! InterfaceElement && + element is! ExtensionElement) { return CompletionGroup.topLevelMember; } - if (element is EnumElement2) { + if (element is EnumElement) { return CompletionGroup.enumElement; - } else if (element is MixinElement2) { + } else if (element is MixinElement) { return CompletionGroup.mixinElement; - } else if (element is InterfaceElement2) { + } else if (element is InterfaceElement) { if (entity is SimpleIdentifier && entity.parent is NamedType && entity.parent!.parent is ConstructorName && @@ -1737,17 +1737,17 @@ class CompletionResult { return CompletionGroup.constructorElement; } return CompletionGroup.classElement; - } else if (element is ExtensionElement2) { + } else if (element is ExtensionElement) { return CompletionGroup.extensionElement; } else if (element is LocalFunctionElement) { return CompletionGroup.localFunctionElement; - } else if (element is LocalVariableElement2) { + } else if (element is LocalVariableElement) { return CompletionGroup.localVariableElement; } else if (element is FormalParameterElement) { return CompletionGroup.parameterElement; - } else if (element is PrefixElement2) { + } else if (element is PrefixElement) { return CompletionGroup.prefixElement; - } else if (element is TypeParameterElement2) { + } else if (element is TypeParameterElement) { return CompletionGroup.typeParameterElement; } } @@ -1782,7 +1782,7 @@ class CompletionResult { /// Return the element associated with the syntactic [entity], or `null` if /// there is no such element. - Element2? _getElement(SyntacticEntity entity) { + Element? _getElement(SyntacticEntity entity) { if (entity is SimpleIdentifier) { var element = entity.element; if (element != null) { @@ -1812,12 +1812,12 @@ class CompletionResult { /// Return `true` if the [element] is static (either top-level or a static /// member of a class or extension). - bool _isStatic(Element2 element) { - if (element is ExecutableElement2) { + bool _isStatic(Element element) { + if (element is ExecutableElement) { return element.isStatic; - } else if (element is FieldElement2) { + } else if (element is FieldElement) { return element.isStatic; - } else if (element is VariableElement2) { + } else if (element is VariableElement) { return element.isStatic; } return true; diff --git a/pkg/analysis_server/tool/code_completion/relevance_metrics.dart b/pkg/analysis_server/tool/code_completion/relevance_metrics.dart index 4774ef03e69..2f57be0e804 100644 --- a/pkg/analysis_server/tool/code_completion/relevance_metrics.dart +++ b/pkg/analysis_server/tool/code_completion/relevance_metrics.dart @@ -17,11 +17,11 @@ import 'package:analyzer/dart/ast/token.dart'; import 'package:analyzer/dart/ast/visitor.dart'; import 'package:analyzer/dart/element/element.dart' show - Element2, - ExecutableElement2, - ExtensionElement2, - InterfaceElement2, - LibraryElement2, + Element, + ExecutableElement, + ExtensionElement, + InterfaceElement, + LibraryElement, FormalParameterElement, SetterElement; import 'package:analyzer/dart/element/type.dart'; @@ -264,7 +264,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { InheritanceManager3 inheritanceManager = InheritanceManager3(); /// The library containing the compilation unit being visited. - late LibraryElement2 enclosingLibrary; + late LibraryElement enclosingLibrary; /// A flag indicating whether we are currently in a context in which type /// parameters are visible. @@ -1131,7 +1131,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { var fragment = node.declaredFragment!; var element = fragment.element; var enclosingElement = element.enclosingElement2; - if (!element.isStatic && enclosingElement is InterfaceElement2) { + if (!element.isStatic && enclosingElement is InterfaceElement) { var overriddenMembers = inheritanceManager.getOverridden4( enclosingElement, Name(fragment.libraryFragment.source.uri, element.name3!), @@ -1628,12 +1628,12 @@ class RelevanceDataCollector extends RecursiveAstVisitor { /// 2: top-level decl /// 3: class member /// 4+: local function - int _depth(Element2 element) { + int _depth(Element element) { if (element.library2 != enclosingLibrary) { return 0; } var depth = 0; - Element2? currentElement = element; + Element? currentElement = element; while (currentElement != enclosingLibrary) { depth++; currentElement = currentElement?.enclosingElement2; @@ -1656,8 +1656,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { /// Return the element associated with the left-most identifier that is a /// child of the [node]. - Element2? _leftMostElement(AstNode node) => - _leftMostIdentifier(node)?.element; + Element? _leftMostElement(AstNode node) => _leftMostIdentifier(node)?.element; /// Return the left-most child of the [node] if it is a simple identifier, or /// `null` if the left-most child is not a simple identifier. Comments and @@ -1689,7 +1688,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { if (element == null) { return null; } - if (element is InterfaceElement2) { + if (element is InterfaceElement) { var parent = node.parent; if (parent is Annotation && parent.arguments != null) { element = parent.element2!; @@ -1712,7 +1711,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { /// Return the number of functions between the [reference] and the [function] /// in which the referenced parameter is declared. - int _parameterReferenceDepth(AstNode? reference, Element2 function) { + int _parameterReferenceDepth(AstNode? reference, Element function) { var depth = 0; var node = reference; while (node != null) { @@ -1801,27 +1800,27 @@ class RelevanceDataCollector extends RecursiveAstVisitor { /// Record the distance between the static type of the target (the /// [targetType]) and the [member] to which the reference was resolved. - void _recordMemberDepth(DartType? targetType, Element2? member) { + void _recordMemberDepth(DartType? targetType, Element? member) { if (member == null) { return; } if (targetType is InterfaceType) { var targetClass = targetType.element3; - var extension = member.thisOrAncestorOfType2(); + var extension = member.thisOrAncestorOfType2(); if (extension != null) { _recordDistance('member (extension)', 0); return; } // TODO(brianwilkerson): It might be interesting to also know whether the // [element] was found in a class, interface, or mixin. - var memberClass = member.thisOrAncestorOfType2(); + var memberClass = member.thisOrAncestorOfType2(); if (memberClass != null) { /// Return the distance between the [targetClass] and the [memberClass] /// along the superclass chain. This includes all of the implicit /// superclasses caused by mixins. int getSuperclassDepth() { var depth = 0; - InterfaceElement2? currentClass = targetClass; + InterfaceElement? currentClass = targetClass; while (currentClass != null) { if (currentClass == memberClass) { return depth; @@ -1842,7 +1841,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { /// includes all of the implicit superclasses caused by mixins. int getTargetDepth() { var depth = 0; - InterfaceElement2? currentClass = targetClass; + InterfaceElement? currentClass = targetClass; while (currentClass != null) { depth += currentClass.mixins.length + 1; currentClass = currentClass.supertype?.element3; @@ -1873,8 +1872,8 @@ class RelevanceDataCollector extends RecursiveAstVisitor { } void _recordOverride( - ExecutableElement2 override, - ExecutableElement2 overridden, + ExecutableElement override, + ExecutableElement overridden, ) { var positionalInOverride = []; var namedInOverride = {}; @@ -2035,7 +2034,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { var firstTokenType = identifier.staticType; if (firstTokenType == null) { var element = identifier.element; - if (element is InterfaceElement2) { + if (element is InterfaceElement) { // This is effectively treating a reference to a class name as having // the same type as an instance of the class, which isn't valid, but // on the other hand, the spec doesn't define the static type of a @@ -2112,8 +2111,8 @@ class RelevanceDataCollector extends RecursiveAstVisitor { /// Return the return type of the [element], or `null` if the element doesn't /// have a return type. - DartType? _returnType(Element2? element) { - if (element is ExecutableElement2) { + DartType? _returnType(Element? element) { + if (element is ExecutableElement) { return element.returnType; } return null; diff --git a/pkg/analysis_server/tool/code_completion/relevance_table_generator.dart b/pkg/analysis_server/tool/code_completion/relevance_table_generator.dart index 6d2fe8780db..83bc4e53128 100644 --- a/pkg/analysis_server/tool/code_completion/relevance_table_generator.dart +++ b/pkg/analysis_server/tool/code_completion/relevance_table_generator.dart @@ -15,7 +15,7 @@ import 'package:analyzer/dart/ast/ast.dart'; import 'package:analyzer/dart/ast/token.dart'; import 'package:analyzer/dart/ast/visitor.dart'; import 'package:analyzer/dart/element/element.dart' - show Element2, InterfaceElement2, LibraryElement2; + show Element, InterfaceElement, LibraryElement; import 'package:analyzer/dart/element/type_provider.dart'; import 'package:analyzer/dart/element/type_system.dart'; import 'package:analyzer/diagnostic/diagnostic.dart'; @@ -306,7 +306,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { late InheritanceManager3 inheritanceManager = InheritanceManager3(); /// The library containing the compilation unit being visited. - late LibraryElement2 enclosingLibrary; + late LibraryElement enclosingLibrary; /// The type provider associated with the current compilation unit. late TypeProvider typeProvider; @@ -1525,8 +1525,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { /// Return the element associated with the left-most identifier that is a /// child of the [node]. - Element2? _leftMostElement(AstNode node) => - _leftMostIdentifier(node)?.element; + Element? _leftMostElement(AstNode node) => _leftMostIdentifier(node)?.element; /// Return the left-most child of the [node] if it is a simple identifier, or /// `null` if the left-most child is not a simple identifier. Comments and @@ -1558,7 +1557,7 @@ class RelevanceDataCollector extends RecursiveAstVisitor { if (element == null) { return null; } - if (element is InterfaceElement2) { + if (element is InterfaceElement) { var parent = node.parent; if (parent is Annotation && parent.arguments != null) { element = parent.element2!; diff --git a/pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart b/pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart index 618c92a3b82..c4b92288e9c 100644 --- a/pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart +++ b/pkg/analysis_server_plugin/lib/edit/dart/correction_producer.dart @@ -349,7 +349,7 @@ abstract class MultiCorrectionProducer /// The library element for the library in which a correction is being /// produced. - LibraryElement2 get libraryElement2 => unitResult.libraryElement2; + LibraryElement get libraryElement2 => unitResult.libraryElement2; @override ResolvedLibraryResult get libraryResult => @@ -400,7 +400,7 @@ abstract class ResolvedCorrectionProducer /// The library element for the library in which a correction is being /// produced. - LibraryElement2 get libraryElement2 => unitResult.libraryElement2; + LibraryElement get libraryElement2 => unitResult.libraryElement2; @override ResolvedLibraryResult get libraryResult => @@ -477,13 +477,13 @@ abstract class ResolvedCorrectionProducer /// Returns the class element associated with the [target], or `null` if there /// is no such element. - InterfaceElement2? getTargetInterfaceElement(Expression target) { + InterfaceElement? getTargetInterfaceElement(Expression target) { var type = target.staticType; if (type is InterfaceType) { return type.element3; } else if (target is Identifier) { var element = target.element; - if (element is InterfaceElement2) { + if (element is InterfaceElement) { return element; } } @@ -769,7 +769,7 @@ sealed class _AbstractCorrectionProducer { /// library, and has the requested base name. /// /// For getters and setters the corresponding top-level variable is returned. - Future> getTopLevelDeclarations( + Future> getTopLevelDeclarations( String baseName, ) async { return await _context.dartFixContext!.getTopLevelDeclarations(baseName); @@ -799,7 +799,7 @@ sealed class _AbstractCorrectionProducer { /// Returns libraries with extensions that declare non-static public /// extension members with the [memberName]. - Stream librariesWithExtensions(Name memberName) { + Stream librariesWithExtensions(Name memberName) { return _context.dartFixContext!.librariesWithExtensions(memberName); } } diff --git a/pkg/analysis_server_plugin/lib/edit/fix/dart_fix_context.dart b/pkg/analysis_server_plugin/lib/edit/fix/dart_fix_context.dart index 334341794b9..36e22000800 100644 --- a/pkg/analysis_server_plugin/lib/edit/fix/dart_fix_context.dart +++ b/pkg/analysis_server_plugin/lib/edit/fix/dart_fix_context.dart @@ -45,7 +45,7 @@ class DartFixContext implements FixContext { /// It's been observed that the same request is fired multiple times for at /// least some getFixes requsts. Caching the response can speed up such /// requests. - final Map>> + final Map>> _cachedTopLevelDeclarations = {}; @override @@ -65,7 +65,7 @@ class DartFixContext implements FixContext { /// this library, and has the requested base name. /// /// For getters and setters the corresponding top-level variable is returned. - Future> getTopLevelDeclarations(String name) { + Future> getTopLevelDeclarations(String name) { var cachedResult = _cachedTopLevelDeclarations[name]; if (cachedResult != null) return cachedResult; var result = TopLevelDeclarations(unitResult).withName(name); @@ -75,7 +75,7 @@ class DartFixContext implements FixContext { /// Returns libraries with extensions that declare non-static public /// extension members with the [memberName]. - Stream librariesWithExtensions(Name memberName) async* { + Stream librariesWithExtensions(Name memberName) async* { var analysisContext = unitResult.session.analysisContext; if (analysisContext is! DriverBasedAnalysisContext) { return; diff --git a/pkg/analyzer/CHANGELOG.md b/pkg/analyzer/CHANGELOG.md index 763df4a3108..f0af91e7a09 100644 --- a/pkg/analyzer/CHANGELOG.md +++ b/pkg/analyzer/CHANGELOG.md @@ -5,6 +5,7 @@ * Remove deprecated `RecordType.sortedNamedTypes`. * Remove `ElementLocation` class, its values are not returned anymore. * Deprecated `element2.dart` library, import `element.dart`. +* Deprecated `XyzElement2` classes, use `XyzElement` instead. ## 7.4.1 * Restore `InstanceElement.augmented` getter. diff --git a/pkg/analyzer/api.txt b/pkg/analyzer/api.txt index 5fec3f9fb71..c103a89da7f 100644 --- a/pkg/analyzer/api.txt +++ b/pkg/analyzer/api.txt @@ -189,7 +189,7 @@ package:analyzer/dart/analysis/results.dart: new (constructor: InvalidResult Function()) LibraryElementResult (class extends Object implements SomeLibraryElementResult): new (constructor: LibraryElementResult Function()) - element2 (getter: LibraryElement2, experimental) + element2 (getter: LibraryElement, experimental) NotElementOfThisSessionResult (class extends Object implements InvalidResult, SomeParsedLibraryResult, SomeResolvedLibraryResult): new (constructor: NotElementOfThisSessionResult Function()) NotLibraryButPartResult (class extends Object implements InvalidResult, SomeLibraryElementResult, SomeParsedLibraryResult, SomeResolvedLibraryResult): @@ -212,14 +212,14 @@ package:analyzer/dart/analysis/results.dart: unit (getter: CompilationUnit) ResolvedLibraryResult (class extends Object implements ParsedLibraryResult, SomeResolvedLibraryResult): new (constructor: ResolvedLibraryResult Function()) - element2 (getter: LibraryElement2, experimental) + element2 (getter: LibraryElement, experimental) typeProvider (getter: TypeProvider) units (getter: List) unitWithPath (method: ResolvedUnitResult? Function(String)) ResolvedUnitResult (class extends Object implements ParsedUnitResult, SomeResolvedUnitResult): new (constructor: ResolvedUnitResult Function()) exists (getter: bool) - libraryElement2 (getter: LibraryElement2, experimental) + libraryElement2 (getter: LibraryElement, experimental) libraryFragment (getter: LibraryFragment, experimental) typeProvider (getter: TypeProvider) typeSystem (getter: TypeSystem) @@ -257,10 +257,10 @@ package:analyzer/dart/analysis/session.dart: getFile (method: SomeFileResult Function(String)) getLibraryByUri (method: Future Function(String)) getParsedLibrary (method: SomeParsedLibraryResult Function(String)) - getParsedLibraryByElement2 (method: SomeParsedLibraryResult Function(LibraryElement2), experimental) + getParsedLibraryByElement2 (method: SomeParsedLibraryResult Function(LibraryElement), experimental) getParsedUnit (method: SomeParsedUnitResult Function(String)) getResolvedLibrary (method: Future Function(String)) - getResolvedLibraryByElement2 (method: Future Function(LibraryElement2), experimental) + getResolvedLibraryByElement2 (method: Future Function(LibraryElement), experimental) getResolvedLibraryContaining (method: Future Function(String)) getResolvedUnit (method: Future Function(String)) getUnitElement (method: Future Function(String)) @@ -287,7 +287,7 @@ package:analyzer/dart/ast/ast.dart: arguments (getter: ArgumentList?) atSign (getter: Token) constructorName (getter: SimpleIdentifier?) - element2 (getter: Element2?, experimental) + element2 (getter: Element?, experimental) elementAnnotation (getter: ElementAnnotation?) name (getter: Identifier) parent (getter: AstNode) @@ -312,7 +312,7 @@ package:analyzer/dart/ast/ast.dart: message (getter: Expression?) rightParenthesis (getter: Token) AssignedVariablePattern (class extends Object implements VariablePattern): - element2 (getter: Element2?, experimental) + element2 (getter: Element?, experimental) AssignmentExpression (class extends Object implements NullShortableExpression, MethodReferenceExpression, CompoundAssignmentExpression): leftHandSide (getter: Expression) operator (getter: Token) @@ -565,7 +565,7 @@ package:analyzer/dart/ast/ast.dart: rightParenthesis (getter: Token?) stackTraceParameter (getter: CatchClauseParameter?) CatchClauseParameter (class extends AstNode): - declaredElement2 (getter: LocalVariableElement2?, experimental) + declaredElement2 (getter: LocalVariableElement?, experimental) declaredFragment (getter: LocalVariableFragment?, experimental) name (getter: Token) ClassDeclaration (class extends Object implements NamedCompilationUnitMember): @@ -629,9 +629,9 @@ package:analyzer/dart/ast/ast.dart: sortedDirectivesAndDeclarations (getter: List) CompilationUnitMember (class extends Object implements Declaration) CompoundAssignmentExpression (class extends Object implements Expression): - readElement2 (getter: Element2?, experimental) + readElement2 (getter: Element?, experimental) readType (getter: DartType?) - writeElement2 (getter: Element2?, experimental) + writeElement2 (getter: Element?, experimental) writeType (getter: DartType?) ConditionalExpression (class extends Object implements Expression): colon (getter: Token) @@ -679,7 +679,7 @@ package:analyzer/dart/ast/ast.dart: ConstructorReference (class extends Object implements Expression, CommentReferableExpression): constructorName (getter: ConstructorName) ConstructorReferenceNode (class extends Object implements AstNode): - element (getter: ConstructorElement2?, experimental) + element (getter: ConstructorElement?, experimental) ConstructorSelector (class extends Object implements AstNode): name (getter: SimpleIdentifier) period (getter: Token) @@ -695,7 +695,7 @@ package:analyzer/dart/ast/ast.dart: Declaration (class extends Object implements AnnotatedNode): declaredFragment (getter: Fragment?, experimental) DeclaredIdentifier (class extends Object implements Declaration): - declaredElement2 (getter: LocalVariableElement2?, experimental) + declaredElement2 (getter: LocalVariableElement?, experimental) declaredFragment (getter: LocalVariableFragment?) isConst (getter: bool) isFinal (getter: bool) @@ -703,7 +703,7 @@ package:analyzer/dart/ast/ast.dart: name (getter: Token) type (getter: TypeAnnotation?) DeclaredVariablePattern (class extends Object implements VariablePattern, sealed (immediate subtypes: DeclaredVariablePatternImpl)): - declaredElement2 (getter: BindPatternVariableElement2?, experimental) + declaredElement2 (getter: BindPatternVariableElement?, experimental) declaredFragment (getter: BindPatternVariableFragment?) keyword (getter: Token?) type (getter: TypeAnnotation?) @@ -745,7 +745,7 @@ package:analyzer/dart/ast/ast.dart: EnumConstantDeclaration (class extends Object implements Declaration): arguments (getter: EnumConstantArguments?) augmentKeyword (getter: Token?, experimental) - constructorElement2 (getter: ConstructorElement2?, experimental) + constructorElement2 (getter: ConstructorElement?, experimental) declaredFragment (getter: FieldFragment?, experimental) name (getter: Token) EnumDeclaration (class extends Object implements NamedCompilationUnitMember): @@ -798,7 +798,7 @@ package:analyzer/dart/ast/ast.dart: onKeyword (getter: Token) ExtensionOverride (class extends Object implements Expression): argumentList (getter: ArgumentList) - element2 (getter: ExtensionElement2, experimental) + element2 (getter: ExtensionElement, experimental) extendedType (getter: DartType?) importPrefix (getter: ImportPrefixReference?) isNullAware (getter: bool) @@ -899,7 +899,7 @@ package:analyzer/dart/ast/ast.dart: isSynchronous (getter: bool) keyword (getter: Token?) star (getter: Token?) - isPotentiallyMutatedInScope2 (method: bool Function(VariableElement2), experimental) + isPotentiallyMutatedInScope2 (method: bool Function(VariableElement), experimental) FunctionDeclaration (class extends Object implements NamedCompilationUnitMember): augmentKeyword (getter: Token?, experimental) declaredFragment (getter: ExecutableFragment?, experimental) @@ -917,7 +917,7 @@ package:analyzer/dart/ast/ast.dart: parameters (getter: FormalParameterList?) typeParameters (getter: TypeParameterList?) FunctionExpressionInvocation (class extends Object implements NullShortableExpression, InvocationExpression): - element (getter: ExecutableElement2?, experimental) + element (getter: ExecutableElement?, experimental) function (getter: Expression) FunctionReference (class extends Object implements Expression, CommentReferableExpression): function (getter: Expression) @@ -952,7 +952,7 @@ package:analyzer/dart/ast/ast.dart: hiddenNames (getter: NodeList) Identifier (class extends Object implements Expression, CommentReferableExpression, sealed (immediate subtypes: IdentifierImpl, LibraryIdentifier, PrefixedIdentifier, SimpleIdentifier)): isPrivateName (static method: bool Function(String)) - element (getter: Element2?, experimental) + element (getter: Element?, experimental) name (getter: String) IfElement (class extends Object implements CollectionElement): caseClause (getter: CaseClause?) @@ -986,7 +986,7 @@ package:analyzer/dart/ast/ast.dart: libraryImport (getter: LibraryImport?, experimental) prefix (getter: SimpleIdentifier?) ImportPrefixReference (class extends Object implements AstNode): - element2 (getter: Element2?, experimental) + element2 (getter: Element?, experimental) name (getter: Token) period (getter: Token) IndexExpression (class extends Object implements NullShortableExpression, MethodReferenceExpression): @@ -1038,7 +1038,7 @@ package:analyzer/dart/ast/ast.dart: labels (getter: NodeList