From b2eb0c5eb28e7fba112f7158e7be0d263bf62d70 Mon Sep 17 00:00:00 2001 From: pq Date: Fri, 10 Sep 2021 19:13:27 +0000 Subject: [PATCH] skip result use checking in comments Fixes: https://github.com/dart-lang/sdk/issues/47181 Change-Id: I1761b600d3a8b94551f853896544b64f590af0b6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/213102 Reviewed-by: Brian Wilkerson Commit-Queue: Phil Quitslund --- pkg/analyzer/lib/src/error/use_result_verifier.dart | 5 +++++ .../test/src/diagnostics/unused_result_test.dart | 13 +++++++++++++ 2 files changed, 18 insertions(+) diff --git a/pkg/analyzer/lib/src/error/use_result_verifier.dart b/pkg/analyzer/lib/src/error/use_result_verifier.dart index fd0eaedd354..1899064b2e3 100644 --- a/pkg/analyzer/lib/src/error/use_result_verifier.dart +++ b/pkg/analyzer/lib/src/error/use_result_verifier.dart @@ -52,6 +52,11 @@ class UseResultVerifier { } void _check(AstNode node, Element element) { + if (node.parent is CommentReference) { + // Don't flag references in comments. + return; + } + var annotation = _getUseResultMetadata(element); if (annotation == null) { return; diff --git a/pkg/analyzer/test/src/diagnostics/unused_result_test.dart b/pkg/analyzer/test/src/diagnostics/unused_result_test.dart index 5d1c5a69e0b..250479bee09 100644 --- a/pkg/analyzer/test/src/diagnostics/unused_result_test.dart +++ b/pkg/analyzer/test/src/diagnostics/unused_result_test.dart @@ -765,6 +765,19 @@ void main() { '''); } + test_topLevelVariable_result_unusedInDoc() async { + // https://github.com/dart-lang/sdk/issues/47181 + await assertNoErrorsInCode(r''' +import 'package:meta/meta.dart'; + +@useResult +int get f => 1; + +/// I love [f]. +int g = 1; +'''); + } + test_topLevelVariable_returned() async { await assertNoErrorsInCode(r''' import 'package:meta/meta.dart';