From ad562fdbbe1a260afbc8aeea8c0bc9dab1f1a2e1 Mon Sep 17 00:00:00 2001 From: Jens Johansen Date: Thu, 9 Jan 2025 00:33:12 -0800 Subject: [PATCH] [parser] Rename accidentally committed 'allowLazyFoo' parameter In https://dart-review.googlesource.com/c/sdk/+/382162 I accidentally left in the debug-named version of a parameter. This renames it to not be called foo. Change-Id: Ib9421b4a5ee63b9b6296a09d14b4ab73ae414742 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403586 Commit-Queue: Jens Johansen Reviewed-by: Johnni Winther --- .../lib/src/scanner/string_scanner.dart | 4 +--- pkg/_fe_analyzer_shared/lib/src/scanner/token_impl.dart | 8 ++++---- .../lib/src/scanner/utf8_bytes_scanner.dart | 2 +- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/pkg/_fe_analyzer_shared/lib/src/scanner/string_scanner.dart b/pkg/_fe_analyzer_shared/lib/src/scanner/string_scanner.dart index 44266cae6b4..39feb42fd23 100644 --- a/pkg/_fe_analyzer_shared/lib/src/scanner/string_scanner.dart +++ b/pkg/_fe_analyzer_shared/lib/src/scanner/string_scanner.dart @@ -100,9 +100,7 @@ class StringScanner extends AbstractScanner { bool asciiOnly, int extraOffset, bool allowLazy) { return new StringTokenImpl.fromSubstring( type, _string, start, scanOffset + extraOffset, tokenStart, - canonicalize: true, - precedingComments: comments, - allowLazyFoo: allowLazy); + canonicalize: true, precedingComments: comments, allowLazy: allowLazy); } @override diff --git a/pkg/_fe_analyzer_shared/lib/src/scanner/token_impl.dart b/pkg/_fe_analyzer_shared/lib/src/scanner/token_impl.dart index b384fc57043..bcccc277a81 100644 --- a/pkg/_fe_analyzer_shared/lib/src/scanner/token_impl.dart +++ b/pkg/_fe_analyzer_shared/lib/src/scanner/token_impl.dart @@ -54,10 +54,10 @@ class StringTokenImpl extends SimpleToken implements StringToken { TokenType type, String data, int start, int end, int charOffset, {bool canonicalize = false, CommentToken? precedingComments, - bool allowLazyFoo = true}) + bool allowLazy = true}) : super(type, charOffset, precedingComments) { int length = end - start; - if (!allowLazyFoo || length <= LAZY_THRESHOLD) { + if (!allowLazy || length <= LAZY_THRESHOLD) { valueOrLazySubstring = canonicalize ? canonicalizeSubString(data, start, end) : data.substring(start, end); @@ -73,10 +73,10 @@ class StringTokenImpl extends SimpleToken implements StringToken { */ StringTokenImpl.fromUtf8Bytes(TokenType type, Uint8List data, int start, int end, bool asciiOnly, int charOffset, - {CommentToken? precedingComments, bool allowLazyFoo = true}) + {CommentToken? precedingComments, bool allowLazy = true}) : super(type, charOffset, precedingComments) { int length = end - start; - if (!allowLazyFoo || length <= LAZY_THRESHOLD) { + if (!allowLazy || length <= LAZY_THRESHOLD) { valueOrLazySubstring = canonicalizeUtf8SubString(data, start, end, asciiOnly); } else { diff --git a/pkg/_fe_analyzer_shared/lib/src/scanner/utf8_bytes_scanner.dart b/pkg/_fe_analyzer_shared/lib/src/scanner/utf8_bytes_scanner.dart index 57c34d205bd..ed412624753 100644 --- a/pkg/_fe_analyzer_shared/lib/src/scanner/utf8_bytes_scanner.dart +++ b/pkg/_fe_analyzer_shared/lib/src/scanner/utf8_bytes_scanner.dart @@ -251,7 +251,7 @@ class Utf8BytesScanner extends AbstractScanner { bool asciiOnly, int extraOffset, bool allowLazy) { return new StringTokenImpl.fromUtf8Bytes( type, _bytes, start, byteOffset + extraOffset, asciiOnly, tokenStart, - precedingComments: comments, allowLazyFoo: allowLazy); + precedingComments: comments, allowLazy: allowLazy); } @override