From a8ef8cf84ea0bee8b57f7a37e032af95dd09ea08 Mon Sep 17 00:00:00 2001 From: pq Date: Fri, 13 Nov 2015 10:25:29 -0800 Subject: [PATCH] Fix to suppress (redundant) parse error reporting. Background: https://github.com/dart-lang/sdk/issues/24911 BUG=24911 R=scheglov@google.com Review URL: https://codereview.chromium.org/1439403002 . --- pkg/analysis_server/lib/src/context_manager.dart | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/pkg/analysis_server/lib/src/context_manager.dart b/pkg/analysis_server/lib/src/context_manager.dart index 0c32ebfb50c..7bce2851886 100644 --- a/pkg/analysis_server/lib/src/context_manager.dart +++ b/pkg/analysis_server/lib/src/context_manager.dart @@ -470,16 +470,8 @@ class ContextManagerImpl implements ContextManager { Map options; try { options = analysisOptionsProvider.getOptions(folder); - } catch (e, stacktrace) { - AnalysisEngine.instance.logger.logError( - 'Error processing .analysis_options', - new CaughtException(e, stacktrace)); - // TODO(pquitslund): contribute plugin that sends error notification on - // options file. - // Related test: - // context_manager_test.test_analysis_options_parse_failure() - // AnalysisEngine.instance.optionsPlugin.optionsProcessors - // .forEach((OptionsProcessor p) => p.onError(e)); + } catch (_) { + // Parse errors are reported by GenerateOptionsErrorsTask. } if (options == null && !optionsRemoved) { @@ -838,7 +830,7 @@ class ContextManagerImpl implements ContextManager { return new CustomPackageResolverDisposition(resolver); } } - + ServerPerformanceStatistics.pub.makeCurrentWhile(() { packageMapInfo = _packageMapProvider.computePackageMap(folder); });