dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Revert "[vm] Switch datastream Write/WriteUnsigned to (S)LEB128."

Browse Source 
This reverts commit 80102c981b.

Reason for revert: b/186359854

Original change's description:
> [vm] Switch datastream Write/WriteUnsigned to (S)LEB128.
>
> This reduces the number of variable-length integer encodings in our
> database from 2 to 1, and chooses the more standard one.
>
> TEST=Existing tests, in particular any that involve snapshots.
>
> Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-asan-linux-release-x64-try,vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-precomp-ubsan-linux-release-x64-try,vm-kernel-precomp-tsan-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-debug-simarm_x64-try,vm-kernel-precomp-linux-debug-simarm64c-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try
> Change-Id: Ia700158ac873ad32ac28c1027a669895961bc715
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196321
> Commit-Queue: Tess Strickland <sstrickl@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Idf32bdd879cf8bb7407f6dae764312140ad6eeb2
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-asan-linux-release-x64-try,vm-kernel-precomp-dwarf-linux-product-x64-try,vm-kernel-precomp-msan-linux-release-x64-try,vm-kernel-precomp-ubsan-linux-release-x64-try,vm-kernel-precomp-tsan-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-debug-simarm_x64-try,vm-kernel-precomp-linux-debug-simarm64c-try,vm-kernel-precomp-linux-debug-simarm_x64-try,vm-kernel-precomp-linux-debug-x64-try,vm-kernel-precomp-linux-debug-x64c-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196920
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
This commit is contained in:
Ivan Inozemtsev
2021-04-26 07:52:47 +00:00
committed by commit-bot@chromium.org
parent 50de84a3fb
commit a5ff656da1
14 changed files with 251 additions and 187 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/platform/utils.h
+19 -13
View File
@@ -395,23 +395,29 @@ class Utils {
return ((-0x20000000000000LL <= value) && (value <= 0x20000000000000LL));
}
static constexpr uword NBitMaskUnsafe(uint32_t n) {
static_assert((sizeof(uword) * kBitsPerByte) == kBitsPerWord,
"Unexpected uword size");
return n == kBitsPerWord ? std::numeric_limits<uword>::max()
: (static_cast<uword>(1) << n) - 1;
}
// The lowest n bits are 1, the others are 0.
template <typename T = uword>
static constexpr T NBitMask(size_t n) {
static_assert(std::is_integral<T>::value, "Must be integral type");
using Unsigned = typename std::make_unsigned<T>::type;
assert(n <= sizeof(T) * kBitsPerByte);
return n == sizeof(T) * kBitsPerByte
? static_cast<T>(-1)
: static_cast<T>((static_cast<Unsigned>(1) << n) - 1);
static uword NBitMask(uint32_t n) {
ASSERT(n <= kBitsPerWord);
return NBitMaskUnsafe(n);
}
static word SignedNBitMask(uint32_t n) {
uword mask = NBitMask(n);
return bit_cast<word>(mask);
}
template <typename T = uword>
static constexpr T Bit(size_t n) {
static_assert(std::is_integral<T>::value, "Must be integral type");
using Unsigned = typename std::make_unsigned<T>::type;
assert(n < sizeof(T) * kBitsPerByte);
return static_cast<T>(static_cast<Unsigned>(1) << n);
static T Bit(uint32_t n) {
ASSERT(n < sizeof(T) * kBitsPerByte);
T bit = 1;
return bit << n;
}
template <typename T>