From a58adbc7eaee41b0a13260dcd58eda670edf274a Mon Sep 17 00:00:00 2001 From: Devon Carew Date: Tue, 24 Mar 2020 15:21:13 +0000 Subject: [PATCH] Revert "Use the 'any' constraint for the recommended dep on package:test." This reverts commit c27af755043b0b82f52e18c24164893cdd9ac24c. Reason for revert: There's not consensus on the `^1.0.0` vs. `any` constraint on package:test; see https://github.com/dart-lang/stagehand/pull/657 for the conversation. I'm reverting this change for now so that stagehand and dartdev are in agreement. We can update them both if we decide that `any` is a better constraint to recommand. Original change's description: > Use the 'any' constraint for the recommended dep on package:test. > > Change-Id: I4052cf0653d827795e120b9b2beecc285935973a > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139680 > Reviewed-by: Gary Roumanis > Reviewed-by: Jaime Wren > Reviewed-by: Michael Thomsen > Commit-Queue: Devon Carew TBR=mit@google.com,devoncarew@google.com,jwren@google.com,grouma@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I60c09b399530f4860f59bd31535d29ca3adb70f3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140764 Reviewed-by: Jaime Wren Commit-Queue: Devon Carew --- pkg/dartdev/lib/src/commands/test.dart | 2 +- pkg/dartdev/test/commands/test_test.dart | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/pkg/dartdev/lib/src/commands/test.dart b/pkg/dartdev/lib/src/commands/test.dart index a9ffa422caf..da856748571 100644 --- a/pkg/dartdev/lib/src/commands/test.dart +++ b/pkg/dartdev/lib/src/commands/test.dart @@ -50,7 +50,7 @@ class TestCommand extends DartdevCommand { In order to run tests, you need to add a dependency on package:test in your pubspec.yaml file: -${ansi.emphasized('dev_dependencies:\n test: any')} +${ansi.emphasized('dev_dependencies:\n test: ^1.0.0')} See https://pub.dev/packages/test#-installing-tab- for more information on adding package:test, and https://dart.dev/guides/testing for general diff --git a/pkg/dartdev/test/commands/test_test.dart b/pkg/dartdev/test/commands/test_test.dart index 1b390ff65f3..e1e9b5cffa1 100644 --- a/pkg/dartdev/test/commands/test_test.dart +++ b/pkg/dartdev/test/commands/test_test.dart @@ -43,12 +43,6 @@ void defineTest() { 'In order to run tests, you need to add a dependency on package:test', ), ); - expect( - result.stdout, - contains( - 'dev_dependencies:\n test: any', - ), - ); }, skip: 'https://github.com/dart-lang/sdk/issues/40854'); test('has dependency', () {