From a5758a0dc373e137ee2cf486b5a537fbd5696a95 Mon Sep 17 00:00:00 2001 From: Tess Strickland Date: Fri, 12 Jan 2024 15:21:23 +0000 Subject: [PATCH] [gardening] Assert no errors in CompilerState::TypedListClass. The assert, which is only triggered if we need to generate calls to the _nativeGetX/_nativeSetX methods, should be checking for no error, not that there is an error. TEST=vm-aot-linux-debug-simriscv64 builds Cq-Include-Trybots: luci.dart.try:vm-aot-linux-debug-simriscv64-try Change-Id: Ie360a067a6432503fa82ca7eb3d5f9281e0579f0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346041 Reviewed-by: Daco Harkes Commit-Queue: Tess Strickland --- runtime/vm/compiler/compiler_state.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/vm/compiler/compiler_state.cc b/runtime/vm/compiler/compiler_state.cc index 8085d2dd264..8aa90efb229 100644 --- a/runtime/vm/compiler/compiler_state.cc +++ b/runtime/vm/compiler/compiler_state.cc @@ -139,7 +139,7 @@ const Class& CompilerState::TypedListClass() { zone, lib.LookupClassAllowPrivate(Symbols::_TypedList())); ASSERT(!cls.IsNull()); const Error& error = Error::Handle(zone, cls.EnsureIsFinalized(thread)); - ASSERT(!error.IsNull()); + ASSERT(error.IsNull()); typed_list_class_ = &cls; } return *typed_list_class_;