From 9fa681712f6184565ab3e6b9aec11ab09be93594 Mon Sep 17 00:00:00 2001 From: Konstantin Shcheglov Date: Mon, 11 Apr 2022 20:11:11 +0000 Subject: [PATCH] Issue 48682. Run 'dart pub' in PluginManager. Bug: https://github.com/dart-lang/sdk/issues/48682 Change-Id: Ifc024b381bce23b914a6849c9d82cf89292706a3 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240901 Reviewed-by: Samuel Rawlins Commit-Queue: Konstantin Shcheglov --- pkg/analysis_server/lib/src/plugin/plugin_manager.dart | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/pkg/analysis_server/lib/src/plugin/plugin_manager.dart b/pkg/analysis_server/lib/src/plugin/plugin_manager.dart index ae25ec114cf..7dc3e9884eb 100644 --- a/pkg/analysis_server/lib/src/plugin/plugin_manager.dart +++ b/pkg/analysis_server/lib/src/plugin/plugin_manager.dart @@ -632,13 +632,8 @@ class PluginManager { .getChildAssumingFolder(file_paths.dotDartTool) .getChildAssumingFile(file_paths.packageConfigJson); if (pubCommand != null) { - var vmPath = Platform.executable; - var pubPath = path.join(path.dirname(vmPath), 'pub'); - if (Platform.isWindows) { - // Process.run requires the `.bat` suffix on Windows - pubPath = '$pubPath.bat'; - } - var result = Process.runSync(pubPath, [pubCommand], + var result = Process.runSync( + Platform.executable, ['pub', pubCommand], stderrEncoding: utf8, stdoutEncoding: utf8, workingDirectory: pluginFolder.path,