dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

Stop reporting duplicate diagnostics for other ambiguous extensions

Browse Source 
Change-Id: Ia81c43f0ccd41aa09697b6f629fd1d5a3acd3923
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112643
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This commit is contained in:
Brian Wilkerson
2019-08-12 18:04:11 +00:00
committed by commit-bot@chromium.org
parent 1f7e6370b4
commit 9eb2e8d111
6 changed files with 185 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/language_2/extension_methods/static_extension_internal_resolution_3_error_test.dart
-18
View File
@@ -96,24 +96,18 @@ extension MyExt on A {
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t0);
bool t1 = this.getterInGlobalScope;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t1);
this.setterInGlobalScope = extensionValue;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_SETTER
bool t2 = this.methodInGlobalScope();
// ^^^
// [cfe] unspecified
@@ -150,24 +144,18 @@ extension MyExt on A {
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t0);
bool t1 = self.getterInGlobalScope;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t1);
self.setterInGlobalScope = extensionValue;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_SETTER
bool t2 = self.methodInGlobalScope();
// ^^^
// [cfe] unspecified
@@ -245,22 +233,16 @@ void main() {
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t0);
bool t1 = a.getterInGlobalScope;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t1);
a.setterInGlobalScope = extensionValue;
//^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
//^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_SETTER
// ^^^
// [cfe] unspecified
bool t2 = a.methodInGlobalScope();
tests/language_2/extension_methods/static_extension_internal_resolution_4_error_test.dart
-36
View File
@@ -96,24 +96,18 @@ extension MyExt on A {
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t0);
bool t1 = this.getterInGlobalScope;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t1);
this.setterInGlobalScope = extensionValue;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_SETTER
bool t2 = this.methodInGlobalScope();
// ^^^
// [cfe] unspecified
@@ -135,24 +129,18 @@ extension MyExt on A {
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t0);
bool t1 = this.getterInExtensionScope;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t1);
this.setterInExtensionScope = extensionValue;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_SETTER
bool t2 = this.methodInExtensionScope();
// ^^^
// [cfe] unspecified
@@ -178,24 +166,18 @@ extension MyExt on A {
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t0);
bool t1 = self.getterInGlobalScope;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t1);
self.setterInGlobalScope = extensionValue;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_SETTER
bool t2 = self.methodInGlobalScope();
// ^^^
// [cfe] unspecified
@@ -217,24 +199,18 @@ extension MyExt on A {
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t0);
bool t1 = self.getterInExtensionScope;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t1);
self.setterInExtensionScope = extensionValue;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_SETTER
bool t2 = self.methodInExtensionScope();
// ^^^
// [cfe] unspecified
@@ -330,22 +306,16 @@ void main() {
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t0);
bool t1 = a.getterInGlobalScope;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t1);
a.setterInGlobalScope = extensionValue;
//^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
//^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_SETTER
// ^^^
// [cfe] unspecified
bool t2 = a.methodInGlobalScope();
@@ -369,22 +339,16 @@ void main() {
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t0);
bool t1 = a.getterInExtensionScope;
// ^^^
// [cfe] unspecified
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
// ^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_GETTER
checkExtensionValue(t1);
a.setterInExtensionScope = extensionValue;
//^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] COMPILE_TIME_ERROR.AMBIGUOUS_EXTENSION_METHOD_ACCESS
//^^^^^^^^^^^^^^^^^^^^^^
// [analyzer] STATIC_TYPE_WARNING.UNDEFINED_SETTER
// ^^^
// [cfe] unspecified
bool t2 = a.methodInExtensionScope();