diff --git a/DEPS b/DEPS index 36353ae18ce..048f03b1e3f 100644 --- a/DEPS +++ b/DEPS @@ -80,7 +80,7 @@ vars = { "jsc_tag": "version:308651", # https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang - "clang_version": "git_revision:80743bd43fd5b38fedc503308e7a652e23d3ec93", + "clang_version": "git_revision:d0ddae678e3f634c988542dfbdde1dd0afe66344", # https://chrome-infra-packages.appspot.com/p/gn/gn "gn_version": "git_revision:2941d2a26fa9cef3103f10e1dee5da7cd404008a", diff --git a/runtime/.clang-tidy b/runtime/.clang-tidy index 15dc4993b1e..278f01eeb4c 100644 --- a/runtime/.clang-tidy +++ b/runtime/.clang-tidy @@ -1 +1,2 @@ Checks: -*,readability-implicit-bool-conversion,bugprone-argument-comment +ExcludeHeaderFilterRegex: "third_party.boringssl.src.include.openssl.err\\.h" # breaks readability-implicit-bool-conversion \ No newline at end of file diff --git a/runtime/bin/dart_io_api_impl.cc b/runtime/bin/dart_io_api_impl.cc index c64094469c7..d1ab03a3136 100644 --- a/runtime/bin/dart_io_api_impl.cc +++ b/runtime/bin/dart_io_api_impl.cc @@ -144,9 +144,10 @@ Dart_Handle SetupDartIoLibrary(const DartIoSettings& settings) { if (settings.enable_network_profiling) { #if !defined(PRODUCT) + auto dart_type = + DartUtils::GetDartType(DartUtils::kIOLibURL, "_NetworkProfiling"); ASSIGN_OR_RETURN( - Dart_Handle network_profiling_type, - DartUtils::GetDartType(DartUtils::kIOLibURL, "_NetworkProfiling")); + Dart_Handle network_profiling_type, dart_type); RETURN_IF_ERROR(Dart_Invoke( network_profiling_type, DartUtils::NewString("_registerServiceExtension"), 0, nullptr));