dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[vm/bytecode] Cleanup support for bytecode formats older than v7

Browse Source 
Bytecode format v7 was introduced 2019 May 08,
in 68de477535.

Change-Id: I79d94f7153d66d418088707c3658d928a3ec41ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106969
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
This commit is contained in:
Alexander Markov
2019-06-21 21:38:09 +00:00
committed by commit-bot@chromium.org
parent 7a57e241a3
commit 9b5718ca7e
10 changed files with 229 additions and 551 deletions
Download Patch File Download Diff File Expand all files Collapse all files
runtime/vm/compiler/assembler/disassembler_kbc.cc
-41
View File
@@ -160,32 +160,6 @@ static void FormatT(char* buf,
Apply(&buf, &size, instr, op1, x, "");
}
static void FormatA_D(char* buf,
intptr_t size,
KernelBytecode::Opcode opcode,
const KBCInstr* instr,
Fmt op1,
Fmt op2,
Fmt op3) {
const int32_t a = KernelBytecode::DecodeA(instr);
const int32_t bc = KernelBytecode::DecodeD(instr);
Apply(&buf, &size, instr, op1, a, ", ");
Apply(&buf, &size, instr, op2, bc, "");
}
static void FormatA_X(char* buf,
intptr_t size,
KernelBytecode::Opcode opcode,
const KBCInstr* instr,
Fmt op1,
Fmt op2,
Fmt op3) {
const int32_t a = KernelBytecode::DecodeA(instr);
const int32_t bc = KernelBytecode::DecodeX(instr);
Apply(&buf, &size, instr, op1, a, ", ");
Apply(&buf, &size, instr, op2, bc, "");
}
static void FormatA_E(char* buf,
intptr_t size,
KernelBytecode::Opcode opcode,
@@ -257,21 +231,6 @@ static const BytecodeFormatter kFormatters[] = {
static intptr_t GetConstantPoolIndex(const KBCInstr* instr) {
switch (KernelBytecode::DecodeOpcode(instr)) {
case KernelBytecode::kLoadConstant_Old:
case KernelBytecode::kInstantiateTypeArgumentsTOS_Old:
case KernelBytecode::kAssertAssignable_Old:
case KernelBytecode::kPushConstant_Old:
case KernelBytecode::kStoreStaticTOS_Old:
case KernelBytecode::kPushStatic_Old:
case KernelBytecode::kAllocate_Old:
case KernelBytecode::kAllocateClosure_Old:
case KernelBytecode::kInstantiateType_Old:
case KernelBytecode::kDirectCall_Old:
case KernelBytecode::kInterfaceCall_Old:
case KernelBytecode::kUncheckedInterfaceCall_Old:
case KernelBytecode::kDynamicCall_Old:
return KernelBytecode::DecodeD(instr);
case KernelBytecode::kLoadConstant:
case KernelBytecode::kLoadConstant_Wide:
case KernelBytecode::kInstantiateTypeArgumentsTOS: