From 8af57275eb9025dfde30aefaf2b74722b91210ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20von=20der=20Ahe=CC=81?= Date: Wed, 20 Mar 2019 10:56:33 +0000 Subject: [PATCH] Can't override implied setter covariantly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I1704001605f01721b01254fdc032aacebf472c80 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/97304 Commit-Queue: Peter von der Ahé Auto-Submit: Peter von der Ahé Reviewed-by: Erik Ernst --- tests/language_2/language_2_kernel.status | 1 + tests/language_2/override_inheritance_field_test.dart | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status index eee513d3880..14bef317644 100644 --- a/tests/language_2/language_2_kernel.status +++ b/tests/language_2/language_2_kernel.status @@ -306,6 +306,7 @@ mixin_declaration/mixin_declaration_superinvocation_application_test/06: Missing mixin_declaration/mixin_declaration_superinvocation_application_test/07: MissingCompileTimeError mixin_declaration/mixin_declaration_superinvocation_application_test/08: MissingCompileTimeError mixin_method_override_test/G5: Crash # Issue 34354 +override_inheritance_field_test/42: MissingCompileTimeError regress_22976_test/*: CompileTimeError # Issue 31935 set_literals/invalid_set_literal_test/08: MissingCompileTimeError # Requires constant evaluation set_literals/invalid_set_literal_test/09: MissingCompileTimeError # Requires constant evaluation diff --git a/tests/language_2/override_inheritance_field_test.dart b/tests/language_2/override_inheritance_field_test.dart index b752b5d9705..d9430e171bb 100644 --- a/tests/language_2/override_inheritance_field_test.dart +++ b/tests/language_2/override_inheritance_field_test.dart @@ -27,7 +27,7 @@ class A { set setter11(int _) => null; //# 31: compile-time error @virtual int field1; //# 41: ok - num field2; //# 42: ok + num field2; //# 42: compile-time error int field3; //# 43: compile-time error int field4; //# 44: compile-time error int field5; //# 45: compile-time error