From 8a965f86c150f7aa9530952dc0da5de45c7c313d Mon Sep 17 00:00:00 2001
From: Kevin Moore <kevmoo@google.com>
Date: Thu, 7 May 2026 13:16:29 -0700
Subject: [PATCH] [dartfuzz] Fix analysis issues

Mostly adding types

Change-Id: I2f161654a8fee33380075a64ebe7968ac1e741e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/501704
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Nate Biggs <natebiggs@google.com>
---
 runtime/tools/dartfuzz/flag_fuzzer.dart           | 12 ++++++------
 runtime/tools/dartfuzz/flag_fuzzer_dart2js.dart   |  2 +-
 runtime/tools/dartfuzz/flag_fuzzer_dart2wasm.dart |  2 +-
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/runtime/tools/dartfuzz/flag_fuzzer.dart b/runtime/tools/dartfuzz/flag_fuzzer.dart
index 0b638ade9cc..4e01b439e9a 100644
--- a/runtime/tools/dartfuzz/flag_fuzzer.dart
+++ b/runtime/tools/dartfuzz/flag_fuzzer.dart
@@ -142,7 +142,7 @@ Duration get remainingTimeout => overallTimeout - stopwatch.elapsed;
 const statusTimeout = Duration(minutes: 5);
 int pendingTaskCount = 0;
 late Timer pendingTimer;
-taskStart() {
+void taskStart() {
   if (pendingTaskCount++ == 0) {
     pendingTimer = new Timer.periodic(statusTimeout, (timer) {
       print(
@@ -153,13 +153,13 @@ taskStart() {
   }
 }
 
-taskEnd() {
+void taskEnd() {
   if (--pendingTaskCount == 0) {
     pendingTimer.cancel();
   }
 }
 
-test(
+Future<void> test(
   List<String> Function(String) createDartCommand,
   int taskIndex,
   String extension,
@@ -171,7 +171,7 @@ test(
   var dartArguments = dartCommand.getRange(1, dartCommand.length).toList();
 
   var buildDir = oneOf(buildDirs);
-  var commands;
+  List<List<String>> commands;
   if (random.nextBool()) {
     // JIT
     commands = [
@@ -266,7 +266,7 @@ test(
   taskEnd();
 }
 
-shard(
+Future<void> shard(
   List<String> Function(String) createDartCommand,
   int shardIndex,
   String extension,
@@ -276,7 +276,7 @@ shard(
   }
 }
 
-flagFuzz(
+Future<void> flagFuzz(
   List<String> Function(String) createDartCommand,
   String extension,
 ) async {
diff --git a/runtime/tools/dartfuzz/flag_fuzzer_dart2js.dart b/runtime/tools/dartfuzz/flag_fuzzer_dart2js.dart
index 16cb486082b..7a4d6b3ab46 100644
--- a/runtime/tools/dartfuzz/flag_fuzzer_dart2js.dart
+++ b/runtime/tools/dartfuzz/flag_fuzzer_dart2js.dart
@@ -7,7 +7,7 @@
 
 import "flag_fuzzer.dart";
 
-main() => flagFuzz(
+Future<void> main() => flagFuzz(
   (String output) => [
     "pkg/compiler/lib/src/dart2js.dart",
     "--invoker=test",
diff --git a/runtime/tools/dartfuzz/flag_fuzzer_dart2wasm.dart b/runtime/tools/dartfuzz/flag_fuzzer_dart2wasm.dart
index 56a39c6018c..27a8f029b63 100644
--- a/runtime/tools/dartfuzz/flag_fuzzer_dart2wasm.dart
+++ b/runtime/tools/dartfuzz/flag_fuzzer_dart2wasm.dart
@@ -7,7 +7,7 @@
 
 import "flag_fuzzer.dart";
 
-main() => flagFuzz(
+Future<void> main() => flagFuzz(
   (String output) => [
     "pkg/dart2wasm/bin/dart2wasm.dart",
     "--platform=out/ReleaseX64/dart2wasm_platform.dill",