From 86a63cf8900a30cd9590ecc0715f39a059190090 Mon Sep 17 00:00:00 2001 From: "sigmund@google.com" Date: Fri, 1 Aug 2014 02:15:53 +0000 Subject: [PATCH] Fix js test for firefox now that null becomes 'null' and not 'undefined' R=sra@google.com Review URL: https://codereview.chromium.org//438503003 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38821 260f80e4-7a28-3924-810f-c04153c831b5 --- sdk/lib/js/dart2js/js_dart2js.dart | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sdk/lib/js/dart2js/js_dart2js.dart b/sdk/lib/js/dart2js/js_dart2js.dart index 8e1b371f69c..9bf0a20f043 100644 --- a/sdk/lib/js/dart2js/js_dart2js.dart +++ b/sdk/lib/js/dart2js/js_dart2js.dart @@ -455,7 +455,8 @@ class JsArray extends JsObject with ListMixin { } void sort([int compare(E a, E b)]) { - callMethod('sort', [compare]); + // Note: arr.sort(null) is a type error in FF + callMethod('sort', compare == null ? [] : [compare]); } }