From 850bfe016e08d39d03d85de2418666bf6d3eed07 Mon Sep 17 00:00:00 2001 From: Liam Appelbe Date: Fri, 29 Sep 2023 20:58:07 +0000 Subject: [PATCH] Fix samples/ffi/http/test/http_test.dart Bug: https://github.com/dart-lang/sdk/issues/53657 Fixes: https://github.com/dart-lang/sdk/issues/53657 Change-Id: Ib055eca57e6aba9329d94d5113ae59ffbdadf3ae TEST=samples/ffi/http/test/http_test.dart Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/328683 Reviewed-by: Ryan Macnak Commit-Queue: Liam Appelbe --- samples/ffi/http/test/http_test.dart | 6 +++++- samples/samples.status | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/samples/ffi/http/test/http_test.dart b/samples/ffi/http/test/http_test.dart index 509d8dd76c7..501bef7a85a 100644 --- a/samples/ffi/http/test/http_test.dart +++ b/samples/ffi/http/test/http_test.dart @@ -18,7 +18,11 @@ Future main() async { test('httpServe', () async { final completer = Completer(); - httpServe((request) => completer.complete(request)); + httpServe((request) { + if (!completer.isCompleted) { + completer.complete(request); + } + }); final request = await completer.future; expect(request, contains('www.example.com')); }); diff --git a/samples/samples.status b/samples/samples.status index 0cea15b080b..1124deee938 100644 --- a/samples/samples.status +++ b/samples/samples.status @@ -15,6 +15,7 @@ ffi/*: SkipByDesign # FFI skips, see ffi.status *: Skip # Not yet triaged. [ $arch != x64 || $compiler != dartk || $system != linux || $hot_reload || $hot_reload_rollback ] +ffi/http/test/http_test: SkipByDesign ffi/sqlite/test/sqlite_test: SkipByDesign # FFI not supported or libsqlite3.so not available. [ $runtime == d8 || $browser ]