dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

[build] Remove the last absolute paths from RBE builds.

Browse Source 
Extend --check-clean (enabled on bots) to verify build commands don't include absolute paths.

The non-RBE GCC and MSVC builds still have absolute paths. GCC doesn't have -ffile-compilation-dir so it uses -fdebug-prefix-map, which is not fixable. The MSVC build has absolute path in the toolchain wrappers, which might be fixable.

TEST=ci
Change-Id: I3b984aaab7aefa7ff527f0a039ca42281224a09d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/506505
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This commit is contained in:
Ryan Macnak
2026-06-01 08:46:47 -07:00
committed by dart-scoped@luci-project-accounts.iam.gserviceaccount.com
parent bd304d04bc
commit 7d6c973ed9
7 changed files with 52 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
utils/compiler/BUILD.gn
+2 -2
View File
@@ -108,7 +108,7 @@ aot_snapshot("dart2js_sdk_aot_product") {
compile_platform("compile_dart2js_platform") {
single_root_scheme = "org-dartlang-sdk"
single_root_base = rebase_path("$sdk_root/")
single_root_base = rebase_path("$sdk_root/", root_build_dir)
libraries_specification_uri = "org-dartlang-sdk:///lib/libraries.json"
outputs = [
@@ -124,7 +124,7 @@ compile_platform("compile_dart2js_platform") {
}
compile_platform("compile_dart2js_server_platform") {
single_root_scheme = "org-dartlang-sdk"
single_root_base = rebase_path("$sdk_root/")
single_root_base = rebase_path("$sdk_root/", root_build_dir)
libraries_specification_uri = "org-dartlang-sdk:///lib/libraries.json"
outputs = [
utils/dart2wasm/BUILD.gn
+3 -3
View File
@@ -44,7 +44,7 @@ aot_snapshot("dart2wasm_product_snapshot") {
compile_platform("compile_dart2wasm_platform") {
single_root_scheme = "org-dartlang-sdk"
single_root_base = rebase_path("$sdk_root/")
single_root_base = rebase_path("$sdk_root/", root_build_dir)
libraries_specification_uri = "org-dartlang-sdk:///lib/libraries.json"
outputs = [
@@ -60,7 +60,7 @@ compile_platform("compile_dart2wasm_platform") {
compile_platform("compile_dart2wasm_js_compatibility_platform") {
single_root_scheme = "org-dartlang-sdk"
single_root_base = rebase_path("$sdk_root/")
single_root_base = rebase_path("$sdk_root/", root_build_dir)
libraries_specification_uri = "org-dartlang-sdk:///lib/libraries.json"
outputs = [
@@ -77,7 +77,7 @@ compile_platform("compile_dart2wasm_js_compatibility_platform") {
compile_platform("compile_dart2wasm_standalone_platform") {
single_root_scheme = "org-dartlang-sdk"
single_root_base = rebase_path("$sdk_root/")
single_root_base = rebase_path("$sdk_root/", root_build_dir)
libraries_specification_uri = "org-dartlang-sdk:///lib/libraries.json"
outputs = [
utils/ddc/BUILD.gn
+1 -1
View File
@@ -409,7 +409,7 @@ ddc_compile("meta_canary_ddc_js") {
compile_platform("ddc_platform") {
single_root_scheme = "org-dartlang-sdk"
single_root_base = rebase_path("$sdk_root/")
single_root_base = rebase_path("$sdk_root/", root_build_dir)
libraries_specification_uri = "org-dartlang-sdk:///lib/libraries.json"
args = [