From 77c65d60ec6fd597f7dde72f96ae91c1415cfe53 Mon Sep 17 00:00:00 2001 From: Nicholas Shahan Date: Fri, 8 May 2026 12:57:06 -0700 Subject: [PATCH] [ddc] Fix type in matcher in scope offset test It looks like the type expectation in the block visitor of this test has always been wrong and we might have never visited a block before. It looks like fixing the failing type expectation reveals an actual failure that this test is trying to catch: The block node doesn't have a valid offset. Issue: https://github.com/dart-lang/sdk/issues/63226 Change-Id: I4b8d7b60350b627e10a974a2d794db1973b3fff1 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/502184 Reviewed-by: Nate Biggs Auto-Submit: Nicholas Shahan Commit-Queue: Nate Biggs --- .../test/expression_compiler/scope_offset_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/dev_compiler/test/expression_compiler/scope_offset_test.dart b/pkg/dev_compiler/test/expression_compiler/scope_offset_test.dart index aa1e16566d5..a441f1a62ae 100644 --- a/pkg/dev_compiler/test/expression_compiler/scope_offset_test.dart +++ b/pkg/dev_compiler/test/expression_compiler/scope_offset_test.dart @@ -144,7 +144,7 @@ class ScopeOffsetValidator extends VisitorDefault with VisitorVoidMixin { blockCount++; expect( block, - const TypeMatcher().having( + const TypeMatcher().having( (c) => c.fileOffset, '${block.toText(astTextStrategyForTesting)} : fileOffset', isNot(equals(-1)),