diff --git a/pkg/analyzer_experimental/lib/src/generated/element.dart b/pkg/analyzer_experimental/lib/src/generated/element.dart index 3d7e2a43beb..e3e9d023be1 100644 --- a/pkg/analyzer_experimental/lib/src/generated/element.dart +++ b/pkg/analyzer_experimental/lib/src/generated/element.dart @@ -2133,7 +2133,7 @@ class ElementLocationImpl implements ElementLocation { List components = new List(); Element ancestor = element; while (ancestor != null) { - components.insertRange(0, 1, ((ancestor as ElementImpl)).identifier); + components.insert(0, ((ancestor as ElementImpl)).identifier); ancestor = ancestor.enclosingElement; } this._components = new List.from(components); diff --git a/pkg/pathos/lib/path.dart b/pkg/pathos/lib/path.dart index 0fe031d64ab..5136871f732 100644 --- a/pkg/pathos/lib/path.dart +++ b/pkg/pathos/lib/path.dart @@ -11,6 +11,18 @@ import 'dart:io' as io; /// functional interface and not require users to create one. final _builder = new Builder(); +/** + * Inserts [length] elements in front of the [list] and fills them with the + * [fillValue]. + */ +void _growListFront(List list, int length, fillValue) { + list.length += length; + list.setRange(length, list.length, list); + for (var i = 0; i < length; i++) { + list[i] = fillValue; + } +} + /// Gets the path to the current working directory. String get current => new io.Directory.current().path; @@ -408,7 +420,7 @@ class Builder { // Filter out empty parts that exist due to multiple separators in a row. parsed.parts = parsed.parts.where((part) => !part.isEmpty) .toList(); - if (parsed.root != null) parsed.parts.insertRange(0, 1, parsed.root); + if (parsed.root != null) parsed.parts.insert(0, parsed.root); return parsed.parts; } @@ -503,9 +515,9 @@ class Builder { // If there are any directories left in the root path, we need to walk up // out of them. - pathParsed.parts.insertRange(0, fromParsed.parts.length, '..'); - pathParsed.separators.insertRange(0, fromParsed.parts.length, - style.separator); + _growListFront(pathParsed.parts, fromParsed.parts.length, '..'); + _growListFront( + pathParsed.separators, fromParsed.parts.length, style.separator); // Corner case: the paths completely collapsed. if (pathParsed.parts.length == 0) return '.'; @@ -678,7 +690,7 @@ class _ParsedPath { // A relative path can back out from the start directory. if (!isAbsolute) { - newParts.insertRange(0, leadingDoubles, '..'); + _growListFront(newParts, leadingDoubles, '..'); } // If we collapsed down to nothing, do ".". @@ -688,7 +700,7 @@ class _ParsedPath { // Canonicalize separators. var newSeparators = []; - newSeparators.insertRange(0, newParts.length, style.separator); + _growListFront(newSeparators, newParts.length, style.separator); parts = newParts; separators = newSeparators; diff --git a/pkg/serialization/lib/src/serialization_rule.dart b/pkg/serialization/lib/src/serialization_rule.dart index 57e8cf270d0..d63f07ab884 100644 --- a/pkg/serialization/lib/src/serialization_rule.dart +++ b/pkg/serialization/lib/src/serialization_rule.dart @@ -566,7 +566,6 @@ class _LazyList extends IterableBase implements List { getRange(x, y) => _throw(); setRange(x, y, z, [a]) => _throw(); removeRange(x, y) => _throw(); - insertRange(x, y, [z]) => _throw(); get reversed => _throw(); void set length(x) => _throw(); } diff --git a/pkg/yaml/lib/model.dart b/pkg/yaml/lib/model.dart index 5c09aa5d962..ac237a02051 100644 --- a/pkg/yaml/lib/model.dart +++ b/pkg/yaml/lib/model.dart @@ -190,8 +190,7 @@ class _ScalarNode extends _Node { /// long. String zeroPad(String str, int length) { assert(length >= str.length); - var prefix = []; - prefix.insertRange(0, length - str.length, '0'); + var prefix = new List.filled(length - str.length, '0'); return '${prefix.join()}$str'; } diff --git a/pkg/yaml/lib/parser.dart b/pkg/yaml/lib/parser.dart index 9621b135d04..b923fe3301d 100644 --- a/pkg/yaml/lib/parser.dart +++ b/pkg/yaml/lib/parser.dart @@ -1637,7 +1637,7 @@ class _Parser { if (!truth(s_indent(indent))) return null; return c_l_blockSeqEntry(indent); })); - content.insertRange(0, 1, first); + content.insert(0, first); return new _SequenceNode("?", content); }); @@ -1720,7 +1720,7 @@ class _Parser { if (!truth(s_indent(indent))) return null; return ns_l_blockMapEntry(indent); })); - pairs.insertRange(0, 1, first); + pairs.insert(0, first); return map(pairs); }); diff --git a/pkg/yaml/test/yaml_test.dart b/pkg/yaml/test/yaml_test.dart index 6013dc9457c..047c2738b0e 100644 --- a/pkg/yaml/test/yaml_test.dart +++ b/pkg/yaml/test/yaml_test.dart @@ -1350,8 +1350,7 @@ main() { bar: invalid ]"""))); // TODO(nweiz): enable this when we throw an error for long keys - // var dotList = []; - // dotList.insertRange(0, 1024, ' '); + // var dotList = new List.filled(1024, ' '); // var dots = dotList.join(); // Expect.throws(() => loadYaml('[ "foo...$dots...bar": invalid ]')); }); diff --git a/runtime/lib/array.dart b/runtime/lib/array.dart index ef49b7eec28..bd736aac4c0 100644 --- a/runtime/lib/array.dart +++ b/runtime/lib/array.dart @@ -86,12 +86,6 @@ class _ObjectArray implements List { "Cannot remove range of a non-extendable array"); } - void insertRange(int start, int length, [E initialValue = null]) { - throw new UnsupportedError( - "Cannot insert range in a non-extendable array"); - } - - List sublist(int start, [int end]) { Arrays.indicesCheck(this, start, end); if (end == null) end = this.length; @@ -318,11 +312,6 @@ class _ImmutableArray implements List { "Cannot remove range of an immutable array"); } - void insertRange(int start, int length, [E initialValue = null]) { - throw new UnsupportedError( - "Cannot insert range in an immutable array"); - } - List sublist(int start, [int end]) { Arrays.indicesCheck(this, start, end); if (end == null) end = this.length; diff --git a/runtime/lib/growable_array.dart b/runtime/lib/growable_array.dart index 6813485435a..d19cc2f9df8 100644 --- a/runtime/lib/growable_array.dart +++ b/runtime/lib/growable_array.dart @@ -79,28 +79,6 @@ class _GrowableObjectArray implements List { this.length = this.length - (end - start); } - void insertRange(int start, int length, [T initialValue = null]) { - if (length == 0) { - return; - } - if ((length < 0) || (length is! int)) { - throw new ArgumentError("invalid length specified $length"); - } - if (start < 0 || start > this.length) { - throw new RangeError.value(start); - } - var old_length = this.length; - this.length = old_length + length; // Will expand if needed. - Arrays.copy(this, - start, - this, - start + length, - old_length - start); - for (int i = start; i < start + length; i++) { - this[i] = initialValue; - } - } - List sublist(int start, [int end]) { Arrays.indicesCheck(this, start, end); if (end == null) end = length; diff --git a/runtime/lib/typeddata.dart b/runtime/lib/typeddata.dart index e99a06caa90..6b55a6c6ee6 100644 --- a/runtime/lib/typeddata.dart +++ b/runtime/lib/typeddata.dart @@ -542,11 +542,6 @@ abstract class _TypedListBase { "Cannot remove from a non-extendable array"); } - void insertRange(int start, int length, [initialValue]) { - throw new UnsupportedError( - "Cannot add to a non-extendable array"); - } - List toList() { return new List.from(this); } diff --git a/runtime/tests/vm/dart/byte_array_optimized_test.dart b/runtime/tests/vm/dart/byte_array_optimized_test.dart index 9fc6c604f1f..45604fde353 100644 --- a/runtime/tests/vm/dart/byte_array_optimized_test.dart +++ b/runtime/tests/vm/dart/byte_array_optimized_test.dart @@ -33,8 +33,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -118,8 +116,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -192,8 +188,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -278,8 +272,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -352,8 +344,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -444,8 +434,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -524,8 +512,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -617,8 +603,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -694,8 +678,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0.0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -758,8 +740,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0.0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -852,8 +832,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -981,8 +959,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1090,8 +1066,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1227,8 +1201,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1342,8 +1314,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1498,8 +1468,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1629,8 +1597,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1830,8 +1796,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1986,8 +1950,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0.0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -2091,8 +2053,6 @@ class OptimizedByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0.0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, diff --git a/runtime/tests/vm/dart/byte_array_test.dart b/runtime/tests/vm/dart/byte_array_test.dart index 7102bd277f3..876642a3e12 100644 --- a/runtime/tests/vm/dart/byte_array_test.dart +++ b/runtime/tests/vm/dart/byte_array_test.dart @@ -31,8 +31,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -123,8 +121,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -204,8 +200,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -281,8 +275,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -374,8 +366,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -455,8 +445,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -554,8 +542,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -639,8 +625,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -739,8 +723,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -823,8 +805,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0.0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -894,8 +874,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0.0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -1138,8 +1116,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1269,8 +1245,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1380,8 +1354,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1519,8 +1491,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1636,8 +1606,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1792,8 +1760,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -1925,8 +1891,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -2128,8 +2092,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { view.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { view.insertRange(0, view.length, 0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { view.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { view.removeLast(); }, @@ -2286,8 +2248,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0.0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, @@ -2393,8 +2353,6 @@ class ByteArrayTest { (e) { return e is UnsupportedError; }); Expect.throws(() { array.clear(); }, (e) { return e is UnsupportedError; }); - Expect.throws(() { array.insertRange(0, array.length, 0.0); }, - (e) { return e is UnsupportedError; }); Expect.throws(() { array.length = 0; }, (e) { return e is UnsupportedError; }); Expect.throws(() { array.removeLast(); }, diff --git a/sdk/lib/_collection_dev/list.dart b/sdk/lib/_collection_dev/list.dart index 11811dfaa18..3deb4050772 100644 --- a/sdk/lib/_collection_dev/list.dart +++ b/sdk/lib/_collection_dev/list.dart @@ -74,11 +74,6 @@ abstract class FixedLengthListMixin { throw new UnsupportedError( "Cannot remove from a fixed-length list"); } - - void insertRange(int start, int length, [E initialValue]) { - throw new UnsupportedError( - "Cannot insert range in a fixed-length list"); - } } /** @@ -169,11 +164,6 @@ abstract class UnmodifiableListMixin { throw new UnsupportedError( "Cannot remove from an unmodifiable list"); } - - void insertRange(int start, int length, [E initialValue]) { - throw new UnsupportedError( - "Cannot insert range in an unmodifiable list"); - } } /** diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart index 5e3140032e6..b82e58afaed 100644 --- a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart +++ b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart @@ -160,34 +160,6 @@ class JSArray extends Interceptor implements List, JSIndexable { return IterableMixinWorkaround.getRangeList(this, start, end); } - void insertRange(int start, int length, [E initialValue]) { - checkGrowable(this, 'insertRange'); - if (length == 0) { - return; - } - if (length is !int) throw new ArgumentError(length); - if (length < 0) throw new ArgumentError(length); - if (start is !int) throw new ArgumentError(start); - - var receiver = this; - var receiverLength = receiver.length; - if (start < 0 || start > receiverLength) { - throw new RangeError.value(start); - } - receiver.length = receiverLength + length; - Arrays.copy(receiver, - start, - receiver, - start + length, - receiverLength - start); - if (initialValue != null) { - for (int i = start; i < start + length; i++) { - receiver[i] = initialValue; - } - } - receiver.length = receiverLength + length; - } - E get first { if (length > 0) return this[0]; throw new StateError("No elements"); diff --git a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart index cfc4734a015..936ad61ced3 100644 --- a/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart +++ b/sdk/lib/_internal/compiler/implementation/ssa/codegen.dart @@ -234,7 +234,7 @@ abstract class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor { } void insertStatementAtStart(js.Statement statement) { - currentContainer.statements.insertRange(0, 1, statement); + currentContainer.statements.insert(0, statement); } /** diff --git a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart index 94b13d772df..fdea2577661 100644 --- a/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart +++ b/sdk/lib/_internal/compiler/implementation/ssa/nodes.dart @@ -659,7 +659,7 @@ class HBasicBlock extends HInstructionList { if (index == dominatedBlocks.length) { dominatedBlocks.add(block); } else { - dominatedBlocks.insertRange(index, 1, block); + dominatedBlocks.insert(index, block); } assert(block.dominator == null); block.dominator = this; diff --git a/sdk/lib/_internal/dartdoc/lib/src/markdown/inline_parser.dart b/sdk/lib/_internal/dartdoc/lib/src/markdown/inline_parser.dart index ae630e7c0a0..d3ec7ae36e4 100644 --- a/sdk/lib/_internal/dartdoc/lib/src/markdown/inline_parser.dart +++ b/sdk/lib/_internal/dartdoc/lib/src/markdown/inline_parser.dart @@ -80,8 +80,7 @@ class InlineParser { syntaxes = defaultSyntaxes; } // Custom link resolver goes after the generic text syntax. - syntaxes.insertRange(1, 1, - new LinkSyntax(linkResolver: document.linkResolver)); + syntaxes.insert(1, new LinkSyntax(linkResolver: document.linkResolver)); } List parse() { diff --git a/sdk/lib/collection/list.dart b/sdk/lib/collection/list.dart index 84d9208f21b..84c00363435 100644 --- a/sdk/lib/collection/list.dart +++ b/sdk/lib/collection/list.dart @@ -327,21 +327,6 @@ abstract class ListMixin implements List { return new SubListIterable(this, start, end); } - void insertRange(int start, int length, [E initialValue]) { - if (start < 0 || start > this.length) { - throw new RangeError.range(start, 0, this.length); - } - int oldLength = this.length; - int moveLength = oldLength - start; - this.length += length; - if (moveLength > 0) { - this.setRange(start + length, oldLength, this, start); - } - for (int i = 0; i < length; i++) { - this[start + i] = initialValue; - } - } - void removeRange(int start, int end) { if (start < 0 || start > this.length) { throw new RangeError.range(start, 0, this.length); diff --git a/sdk/lib/core/list.dart b/sdk/lib/core/list.dart index d0442c0b0b4..8978978e682 100644 --- a/sdk/lib/core/list.dart +++ b/sdk/lib/core/list.dart @@ -285,20 +285,6 @@ abstract class List implements Iterable { */ void removeRange(int start, int end); - /** - * Inserts a new range into the list, starting from [start] to - * [:start + length - 1:]. The entries are filled with [fill]. - * Throws an [UnsupportedError] if the list is - * not extendable. - * If [length] is 0, this method does not do anything. - * If [start] is the length of the list, this method inserts the - * range at the end of the list. - * Throws an [ArgumentError] if [length] is negative. - * Throws an [RangeError] if [start] is negative or if - * [start] is greater than the length of the list. - */ - void insertRange(int start, int length, [E fill]); - /** * Returns an unmodifiable [Map] view of `this`. * diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart index d26803edb4b..6ddde507c4f 100644 --- a/sdk/lib/html/dart2js/html_dart2js.dart +++ b/sdk/lib/html/dart2js/html_dart2js.dart @@ -7024,10 +7024,6 @@ class DomMimeTypeArray implements JavaScriptIndexingBehavior, List throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [DomMimeType initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -7307,10 +7303,6 @@ class DomPluginArray implements JavaScriptIndexingBehavior, List nati throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [DomPlugin initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -7717,10 +7709,6 @@ class DomStringList implements JavaScriptIndexingBehavior, List native " throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [String initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -7979,10 +7967,6 @@ class _ChildrenElementList extends ListBase { throw new UnimplementedError(); } - void insertRange(int start, int rangeLength, [initialValue = null]) { - throw new UnimplementedError(); - } - Iterable getRange(int start, int end) { throw new UnimplementedError(); } @@ -8105,10 +8089,6 @@ class _FrozenElementList extends ListBase { throw new UnsupportedError(''); } - void insertRange(int start, int rangeLength, [initialValue = null]) { - throw new UnsupportedError(''); - } - List sublist(int start, [int end]) { return new _FrozenElementList._wrap(_nodeList.sublist(start, end)); } @@ -10457,10 +10437,6 @@ class FileList implements JavaScriptIndexingBehavior, List native "*FileLi throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [File initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -10941,10 +10917,6 @@ class Float32Array extends ArrayBufferView implements JavaScriptIndexingBehavior throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [num initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -11167,10 +11139,6 @@ class Float64Array extends ArrayBufferView implements JavaScriptIndexingBehavior throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [num initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -11880,10 +11848,6 @@ class HtmlAllCollection implements JavaScriptIndexingBehavior, List native throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -12095,10 +12059,6 @@ class HtmlCollection implements JavaScriptIndexingBehavior, List native "* throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -14133,10 +14093,6 @@ class Int16Array extends ArrayBufferView implements JavaScriptIndexingBehavior, throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -14359,10 +14315,6 @@ class Int32Array extends ArrayBufferView implements JavaScriptIndexingBehavior, throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -14585,10 +14537,6 @@ class Int8Array extends ArrayBufferView implements JavaScriptIndexingBehavior, L throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -17021,10 +16969,6 @@ class _ChildNodeListLazy extends ListBase { throw new UnsupportedError( "Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError( - "Cannot insertRange on immutable List."); - } Iterable getRange(int start, int end) { throw new UnimplementedError("NodeList.getRange"); @@ -17588,10 +17532,6 @@ class NodeList implements JavaScriptIndexingBehavior, List native "*NodeLi throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -19998,10 +19938,6 @@ class SourceBufferList extends EventTarget implements JavaScriptIndexingBehavior throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [SourceBuffer initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -20286,10 +20222,6 @@ class SpeechGrammarList implements JavaScriptIndexingBehavior, List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -21737,10 +21669,6 @@ class TextTrackCueList implements List, JavaScriptIndexingBehavior throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [TextTrackCue initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -21950,10 +21878,6 @@ class TextTrackList extends EventTarget implements JavaScriptIndexingBehavior, L throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [TextTrack initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -22389,10 +22313,6 @@ class TouchList implements JavaScriptIndexingBehavior, List native "*Touc throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Touch initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -22865,10 +22785,6 @@ class Uint16Array extends ArrayBufferView implements JavaScriptIndexingBehavior, throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -23091,10 +23007,6 @@ class Uint32Array extends ArrayBufferView implements JavaScriptIndexingBehavior, throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -23317,10 +23229,6 @@ class Uint8Array extends ArrayBufferView implements JavaScriptIndexingBehavior, throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -23540,10 +23448,6 @@ class Uint8ClampedArray extends Uint8Array implements JavaScriptIndexingBehavior throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -25829,10 +25733,6 @@ class _ClientRectList implements JavaScriptIndexingBehavior, List native " throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Rect initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -26043,10 +25943,6 @@ class _CssRuleList implements JavaScriptIndexingBehavior, List native " throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [CssRule initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -26248,10 +26144,6 @@ class _CssValueList extends _CSSValue implements JavaScriptIndexingBehavior, Lis throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [_CSSValue initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable<_CSSValue> getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -26521,10 +26413,6 @@ class _EntryArray implements JavaScriptIndexingBehavior, List native "*En throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Entry initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -26726,10 +26614,6 @@ class _EntryArraySync implements JavaScriptIndexingBehavior, List<_EntrySync> na throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [_EntrySync initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable<_EntrySync> getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -26974,10 +26858,6 @@ class _GamepadList implements JavaScriptIndexingBehavior, List native " throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Gamepad initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -27242,10 +27122,6 @@ class _NamedNodeMap implements JavaScriptIndexingBehavior, List native "*N throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -27518,10 +27394,6 @@ class _SpeechInputResultList implements JavaScriptIndexingBehavior, List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -27723,10 +27595,6 @@ class _SpeechRecognitionResultList implements JavaScriptIndexingBehavior, List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -27928,10 +27796,6 @@ class _StyleSheetList implements JavaScriptIndexingBehavior, List na throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [StyleSheet initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -31069,10 +30933,6 @@ class _WrappedList implements List { void removeRange(int start, int end) { _list.removeRange(start, end); } - void insertRange(int start, int length, [E fill]) { - _list.insertRange(start, length, fill); - } - Map asMap() => _list.asMap(); String toString() { diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart index b58be2facc5..8b660526251 100644 --- a/sdk/lib/html/dartium/html_dartium.dart +++ b/sdk/lib/html/dartium/html_dartium.dart @@ -7619,10 +7619,6 @@ class DomMimeTypeArray extends NativeFieldWrapperClass1 implements List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -7920,10 +7916,6 @@ class DomPluginArray extends NativeFieldWrapperClass1 implements List throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [DomPlugin initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -8348,10 +8340,6 @@ class DomStringList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [String initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -8631,10 +8619,6 @@ class _ChildrenElementList extends ListBase { throw new UnimplementedError(); } - void insertRange(int start, int rangeLength, [initialValue = null]) { - throw new UnimplementedError(); - } - Iterable getRange(int start, int end) { throw new UnimplementedError(); } @@ -8757,10 +8741,6 @@ class _FrozenElementList extends ListBase { throw new UnsupportedError(''); } - void insertRange(int start, int rangeLength, [initialValue = null]) { - throw new UnsupportedError(''); - } - List sublist(int start, [int end]) { return new _FrozenElementList._wrap(_nodeList.sublist(start, end)); } @@ -11033,10 +11013,6 @@ class FileList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [File initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -11547,10 +11523,6 @@ class Float32Array extends ArrayBufferView implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [num initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -11790,10 +11762,6 @@ class Float64Array extends ArrayBufferView implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [num initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -12543,10 +12511,6 @@ class HtmlAllCollection extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -12760,10 +12724,6 @@ class HtmlCollection extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -15133,10 +15093,6 @@ class Int16Array extends ArrayBufferView implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -15376,10 +15332,6 @@ class Int32Array extends ArrayBufferView implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -15619,10 +15571,6 @@ class Int8Array extends ArrayBufferView implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -18350,10 +18298,6 @@ class _ChildNodeListLazy extends ListBase { throw new UnsupportedError( "Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError( - "Cannot insertRange on immutable List."); - } Iterable getRange(int start, int end) { throw new UnimplementedError("NodeList.getRange"); @@ -18915,10 +18859,6 @@ class NodeList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -21613,10 +21553,6 @@ class SourceBufferList extends EventTarget implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [SourceBuffer initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -21939,10 +21875,6 @@ class SpeechGrammarList extends NativeFieldWrapperClass1 implements List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -23680,10 +23612,6 @@ class TextTrackCueList extends NativeFieldWrapperClass1 implements List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -23897,10 +23825,6 @@ class TextTrackList extends EventTarget implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [TextTrack initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -24331,10 +24255,6 @@ class TouchList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Touch initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -24848,10 +24768,6 @@ class Uint16Array extends ArrayBufferView implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -25091,10 +25007,6 @@ class Uint32Array extends ArrayBufferView implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -25334,10 +25246,6 @@ class Uint8Array extends ArrayBufferView implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -25575,10 +25483,6 @@ class Uint8ClampedArray extends Uint8Array implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [int initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -27698,10 +27602,6 @@ class _ClientRectList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Rect initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -27920,10 +27820,6 @@ class _CssRuleList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [CssRule initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -28129,10 +28025,6 @@ class _CssValueList extends _CSSValue implements List<_CSSValue> { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [_CSSValue initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable<_CSSValue> getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -28574,10 +28466,6 @@ class _EntryArray extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Entry initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -28783,10 +28671,6 @@ class _EntryArraySync extends NativeFieldWrapperClass1 implements List<_EntrySyn throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [_EntrySync initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable<_EntrySync> getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -29053,10 +28937,6 @@ class _GamepadList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Gamepad initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -29353,10 +29233,6 @@ class _NamedNodeMap extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -29647,10 +29523,6 @@ class _SpeechInputResultList extends NativeFieldWrapperClass1 implements List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -29856,10 +29728,6 @@ class _SpeechRecognitionResultList extends NativeFieldWrapperClass1 implements L throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [SpeechRecognitionResult initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -30065,10 +29933,6 @@ class _StyleSheetList extends NativeFieldWrapperClass1 implements List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -32652,10 +32516,6 @@ class _WrappedList implements List { void removeRange(int start, int end) { _list.removeRange(start, end); } - void insertRange(int start, int length, [E fill]) { - _list.insertRange(start, length, fill); - } - Map asMap() => _list.asMap(); String toString() { diff --git a/sdk/lib/html/html_common/filtered_element_list.dart b/sdk/lib/html/html_common/filtered_element_list.dart index 654d0b7fb24..cad661e7b0a 100644 --- a/sdk/lib/html/html_common/filtered_element_list.dart +++ b/sdk/lib/html/html_common/filtered_element_list.dart @@ -80,10 +80,6 @@ class FilteredElementList extends ListBase { _filtered.sublist(start, end).forEach((el) => el.remove()); } - void insertRange(int start, int rangeLength, [initialValue = null]) { - throw new UnimplementedError(); - } - void clear() { // Currently, ElementList#clear clears even non-element nodes, so we follow // that behavior. diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart index a8bca7127da..aa7de54a4f5 100644 --- a/sdk/lib/io/http_impl.dart +++ b/sdk/lib/io/http_impl.dart @@ -951,7 +951,7 @@ class _ChunkedTransformer extends StreamEventTransformer, List> { header.add(hexDigits[length]); } else { while (length > 0) { - header.insertRange(0, 1, hexDigits[length % 16]); + header.insert(0, hexDigits[length % 16]); length = length >> 4; } } diff --git a/sdk/lib/svg/dart2js/svg_dart2js.dart b/sdk/lib/svg/dart2js/svg_dart2js.dart index 6f995be5af6..cf7fe00a63c 100644 --- a/sdk/lib/svg/dart2js/svg_dart2js.dart +++ b/sdk/lib/svg/dart2js/svg_dart2js.dart @@ -3176,10 +3176,6 @@ class LengthList implements JavaScriptIndexingBehavior, List native "*SV throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Length initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -3808,10 +3804,6 @@ class NumberList implements JavaScriptIndexingBehavior, List native "*SV throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Number initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -4671,10 +4663,6 @@ class PathSegList implements JavaScriptIndexingBehavior, List native "* throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [PathSeg initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -5564,10 +5552,6 @@ class StringList implements JavaScriptIndexingBehavior, List native "*SV throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [String initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -6730,10 +6714,6 @@ class TransformList implements List, JavaScriptIndexingBehavior nativ throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Transform initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -7257,10 +7237,6 @@ class _ElementInstanceList implements JavaScriptIndexingBehavior, List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); diff --git a/sdk/lib/svg/dartium/svg_dartium.dart b/sdk/lib/svg/dartium/svg_dartium.dart index 06ccc3c5677..99286f5c63a 100644 --- a/sdk/lib/svg/dartium/svg_dartium.dart +++ b/sdk/lib/svg/dartium/svg_dartium.dart @@ -3437,10 +3437,6 @@ class LengthList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Length initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -4146,10 +4142,6 @@ class NumberList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Number initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -5282,10 +5274,6 @@ class PathSegList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [PathSeg initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -6272,10 +6260,6 @@ class StringList extends NativeFieldWrapperClass1 implements List { throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [String initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -7527,10 +7511,6 @@ class TransformList extends NativeFieldWrapperClass1 implements List throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Transform initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); @@ -8108,10 +8088,6 @@ class _ElementInstanceList extends NativeFieldWrapperClass1 implements List getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); diff --git a/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart b/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart index ac38e9d3787..ddacca4236e 100644 --- a/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart +++ b/sdk/lib/web_sql/dart2js/web_sql_dart2js.dart @@ -371,10 +371,6 @@ class SqlResultSetRowList implements JavaScriptIndexingBehavior, List nativ throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Map initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); diff --git a/sdk/lib/web_sql/dartium/web_sql_dartium.dart b/sdk/lib/web_sql/dartium/web_sql_dartium.dart index 1de61209fa3..21bcdbbf476 100644 --- a/sdk/lib/web_sql/dartium/web_sql_dartium.dart +++ b/sdk/lib/web_sql/dartium/web_sql_dartium.dart @@ -389,10 +389,6 @@ class SqlResultSetRowList extends NativeFieldWrapperClass1 implements List throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Map initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); diff --git a/tests/co19/co19-compiler.status b/tests/co19/co19-compiler.status index fa01ccd19af..0c26470b435 100644 --- a/tests/co19/co19-compiler.status +++ b/tests/co19/co19-compiler.status @@ -214,6 +214,14 @@ LibTest/core/Map/putIfAbsent_A01_t04: Fail # Uses deprecated Expect class, issue LibTest/core/int/operator_division_A01_t01: Fail # truncate/ceil/floor/round returns ints, issue 389 +LibTest/core/List/List_A01_t02: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A01_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A03_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A04_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A05_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A06_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A07_t01: Fail # insertRange is removed. Issue 403 + Language/11_Expressions/06_Lists_A06_t01: Fail # Issue 397 LibTest/core/Iterable/where_A01_t07: Fail # Issue 397 LibTest/core/List/addLast_A01_t01: Fail # Issue 397 diff --git a/tests/co19/co19-dart2dart.status b/tests/co19/co19-dart2dart.status index 63bfca0c52a..e1fd4a2c9ff 100644 --- a/tests/co19/co19-dart2dart.status +++ b/tests/co19/co19-dart2dart.status @@ -543,6 +543,13 @@ LibTest/core/List/removeRange_A01_t01: Fail # removeRange now takes end-argument LibTest/core/List/removeRange_A03_t01: Fail # removeRange now takes end-argument. Issue 404 LibTest/core/List/removeRange_A05_t01: Fail # removeRange now takes end-argument. Issue 404 +LibTest/core/List/insertRange_A01_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A03_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A04_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A05_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A06_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/every_A01_t01: Fail # insertRange is removed. Issue 403 + Language/11_Expressions/05_Strings/1_String_Interpolation_A03_t02: Fail # Issue 397 Language/11_Expressions/05_Strings/1_String_Interpolation_A04_t02: Fail # Issue 397 Language/11_Expressions/11_Instance_Creation/1_New_A08_t01: Fail # Issue 397 diff --git a/tests/co19/co19-dart2js.status b/tests/co19/co19-dart2js.status index c75dc5c1213..e57d5502c3b 100644 --- a/tests/co19/co19-dart2js.status +++ b/tests/co19/co19-dart2js.status @@ -506,13 +506,20 @@ LibTest/core/List/setRange_A02_t02: Fail # setRange now takes end-argument. Issu LibTest/core/List/setRange_A03_t01: Fail # setRange throws StateError if there aren't enough elements in the iterable. Issue 402 LibTest/core/List/setRange_A03_t02: Fail # setRange throws StateError if there aren't enough elements in the iterable. Issue 402 +LibTest/core/List/removeRange_A01_t01: Fail # removeRange now takes end-argument. Issue TODO +LibTest/core/List/removeRange_A03_t01: Fail # removeRange now takes end-argument. Issue TODO +LibTest/core/List/removeRange_A05_t01: Fail # removeRange now takes end-argument. Issue TODO + +LibTest/core/List/insertRange_A01_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A03_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A04_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A05_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A06_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/every_A01_t01: Fail # insertRange is removed. Issue 403 + [ $compiler == dart2js && $unchecked ] LibTest/core/List/setRange_A05_t01: Fail # setRange throws StateError if there aren't enough elements in the iterable. Issue 402 -LibTest/core/List/removeRange_A01_t01: Fail # removeRange now takes end-argument. Issue 404 -LibTest/core/List/removeRange_A03_t01: Fail # removeRange now takes end-argument. Issue 404 -LibTest/core/List/removeRange_A05_t01: Fail # removeRange now takes end-argument. Issue 404 - # Issues with co19 test suite in checked mode. [ $compiler == dart2js && $checked ] LibTest/core/Set/intersection_A01_t01: Fail # issue 390 diff --git a/tests/co19/co19-runtime.status b/tests/co19/co19-runtime.status index fb2a7ef159c..78f2b84cb5b 100644 --- a/tests/co19/co19-runtime.status +++ b/tests/co19/co19-runtime.status @@ -440,6 +440,13 @@ LibTest/core/List/removeRange_A01_t01: Fail # removeRange now takes end-argument LibTest/core/List/removeRange_A03_t01: Fail # removeRange now takes end-argument. Issue 404 LibTest/core/List/removeRange_A05_t01: Fail # removeRange now takes end-argument. Issue 404 +LibTest/core/List/insertRange_A01_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A03_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A04_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A05_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/insertRange_A06_t01: Fail # insertRange is removed. Issue 403 +LibTest/core/List/every_A01_t01: Fail # insertRange is removed. Issue 403 + [ $compiler == none && $runtime == vm && $checked ] LibTest/core/Set/intersection_A01_t01: Fail # issue 390 LibTest/core/Set/intersection_A01_t02: Fail # issue 390 diff --git a/tests/corelib/list_insert_range_test.dart b/tests/corelib/list_insert_range_test.dart deleted file mode 100644 index 8670c62b3d7..00000000000 --- a/tests/corelib/list_insert_range_test.dart +++ /dev/null @@ -1,47 +0,0 @@ -// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file -// for details. All rights reserved. Use of this source code is governed by a -// BSD-style license that can be found in the LICENSE file. - -import "package:expect/expect.dart"; - -main() { - var list = []; - list.insertRange(-1, 0); - Expect.listEquals([], list); - list.insertRange(0, 0); - Expect.listEquals([], list); - list.insertRange(0, 0, 2); - Expect.listEquals([], list); - list.insertRange(0, 0, 2); - Expect.listEquals([], list); - - expectIOORE(() { [1, 2].insertRange(-1, 1); }); - expectIOORE(() { [1, 2].insertRange(3, 1); }); - expectIAE(() { [1, 2].insertRange(0, -1); }); - - list = []; list.insertRange(0, 3); - Expect.listEquals([null, null, null], list); - - list = []; list.insertRange(0, 3, 1); - Expect.listEquals([1, 1, 1], list); - - list = [1, 1]; list.insertRange(1, 1, 2); - Expect.listEquals([1, 2, 1], list); - - list = [1, 1]; list.insertRange(2, 2, 9); - Expect.listEquals([1, 1, 9, 9], list); - - list = [1, 1]; list.insertRange(2, 1); - Expect.listEquals([1, 1, null], list); - - list = [1, 1]; list.insertRange(0, 3, 3); - Expect.listEquals([3, 3, 3, 1, 1], list); -} - -void expectIOORE(Function f) { - Expect.throws(f, (e) => e is RangeError); -} - -void expectIAE(Function f) { - Expect.throws(f, (e) => e is ArgumentError); -} diff --git a/tests/html/element_test.dart b/tests/html/element_test.dart index 449a0b8d0a9..f9531296d91 100644 --- a/tests/html/element_test.dart +++ b/tests/html/element_test.dart @@ -608,8 +608,6 @@ main() { testUnsupported('removeRange', () => getQueryAll().removeRange(0, 1)); - testUnsupported('insertangeRange', () => getQueryAll().insertRange(0, 1)); - testUnsupported('clear', () => getQueryAll().clear()); testUnsupported('removeLast', () => getQueryAll().removeLast()); diff --git a/tools/dom/src/WrappedList.dart b/tools/dom/src/WrappedList.dart index fcdcd065f38..7bec71467e8 100644 --- a/tools/dom/src/WrappedList.dart +++ b/tools/dom/src/WrappedList.dart @@ -118,10 +118,6 @@ class _WrappedList implements List { void removeRange(int start, int end) { _list.removeRange(start, end); } - void insertRange(int start, int length, [E fill]) { - _list.insertRange(start, length, fill); - } - Map asMap() => _list.asMap(); String toString() { diff --git a/tools/dom/templates/html/impl/impl_Element.darttemplate b/tools/dom/templates/html/impl/impl_Element.darttemplate index 57c1d4c0cf0..02ff65f2d26 100644 --- a/tools/dom/templates/html/impl/impl_Element.darttemplate +++ b/tools/dom/templates/html/impl/impl_Element.darttemplate @@ -192,10 +192,6 @@ class _ChildrenElementList extends ListBase { throw new UnimplementedError(); } - void insertRange(int start, int rangeLength, [initialValue = null]) { - throw new UnimplementedError(); - } - Iterable getRange(int start, int end) { throw new UnimplementedError(); } @@ -318,10 +314,6 @@ class _FrozenElementList extends ListBase { throw new UnsupportedError(''); } - void insertRange(int start, int rangeLength, [initialValue = null]) { - throw new UnsupportedError(''); - } - List sublist(int start, [int end]) { return new _FrozenElementList._wrap(_nodeList.sublist(start, end)); } diff --git a/tools/dom/templates/html/impl/impl_Node.darttemplate b/tools/dom/templates/html/impl/impl_Node.darttemplate index 575c769f49c..0fde760019c 100644 --- a/tools/dom/templates/html/impl/impl_Node.darttemplate +++ b/tools/dom/templates/html/impl/impl_Node.darttemplate @@ -161,10 +161,6 @@ $endif throw new UnsupportedError( "Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [Node initialValue]) { - throw new UnsupportedError( - "Cannot insertRange on immutable List."); - } Iterable getRange(int start, int end) { throw new UnimplementedError("NodeList.getRange"); diff --git a/tools/dom/templates/immutable_list_mixin.darttemplate b/tools/dom/templates/immutable_list_mixin.darttemplate index 950c780ba59..ae81f68e0bc 100644 --- a/tools/dom/templates/immutable_list_mixin.darttemplate +++ b/tools/dom/templates/immutable_list_mixin.darttemplate @@ -171,10 +171,6 @@ $endif throw new UnsupportedError("Cannot removeRange on immutable List."); } - void insertRange(int start, int rangeLength, [$E initialValue]) { - throw new UnsupportedError("Cannot insertRange on immutable List."); - } - Iterable<$E> getRange(int start, int end) => IterableMixinWorkaround.getRangeList(this, start, end); diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart index 6381a12bb2d..f5c07e8d596 100644 --- a/tools/testing/dart/test_suite.dart +++ b/tools/testing/dart/test_suite.dart @@ -1094,7 +1094,7 @@ class StandardTestSuite extends TestSuite { } if (executable.endsWith('.dart')) { // Run the compiler script via the Dart VM. - args.insertRange(0, 1, executable); + args.insert(0, executable); executable = dartShellFileName; } if (['dart2js', 'dart2dart'].contains(configuration['compiler'])) { diff --git a/utils/pub/git_source.dart b/utils/pub/git_source.dart index cea2bacf59f..2802ad8a09d 100644 --- a/utils/pub/git_source.dart +++ b/utils/pub/git_source.dart @@ -148,7 +148,7 @@ class GitSource extends Source { // directory. ensureDir(to); var args = ["clone", from, to]; - if (mirror) args.insertRange(1, 1, "--mirror"); + if (mirror) args.insert(1, "--mirror"); return git.run(args); }).then((result) => null); } diff --git a/utils/tests/string_encoding/benchmark_runner.dart b/utils/tests/string_encoding/benchmark_runner.dart index de90cf5b43e..f29c4f994d1 100644 --- a/utils/tests/string_encoding/benchmark_runner.dart +++ b/utils/tests/string_encoding/benchmark_runner.dart @@ -168,15 +168,13 @@ class TestReport { } String _leftAlign(String s, int width) { - List outCodes = []; - outCodes.insertRange(0, width, spaceChar); + List outCodes = new List.filled(width, spaceChar); outCodes.setRange(0, Math.min(width, s.length), s.codeUnits); return new String.fromCharCodes(outCodes); } String _rightAlign(String s, int width) { - List outCodes = []; - outCodes.insertRange(0, width, spaceChar); + List outCodes = new List.filled(width, spaceChar); int fromIndex = Math.max(0, width - s.length); int length = Math.min(width, s.length); outCodes.setRange(fromIndex, fromIndex + length, s.codeUnits);