From 738d9f9666d13945659c29c7977e96823637f4c1 Mon Sep 17 00:00:00 2001 From: Stephen Adams Date: Thu, 4 Jul 2019 01:01:26 +0000 Subject: [PATCH] Avoid non-web integer literal in language2/list_test Change-Id: I926dc7b9e9eabd098c4561ea95e1e3568522902f Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107922 Commit-Queue: Stephen Adams Auto-Submit: Stephen Adams Reviewed-by: Leaf Petersen --- tests/language_2/language_2_dart2js.status | 2 -- tests/language_2/language_2_dartdevc.status | 1 - tests/language_2/list_test.dart | 2 +- 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/language_2/language_2_dart2js.status b/tests/language_2/language_2_dart2js.status index c78e9264cbe..f71b085361a 100644 --- a/tests/language_2/language_2_dart2js.status +++ b/tests/language_2/language_2_dart2js.status @@ -36,7 +36,6 @@ const_constructor3_test/04: MissingCompileTimeError # OK - Subtype check uses JS const_constructor_nonconst_param_test/01: MissingCompileTimeError const_dynamic_type_literal_test/03: Pass # but it shouldn't until we fix issue 17207 const_evaluation_test/01: RuntimeError -const_list_test: RuntimeError const_map2_test/00: MissingCompileTimeError const_map3_test/00: MissingCompileTimeError const_switch_test/02: RuntimeError, OK # constant identity based on JS constants @@ -116,7 +115,6 @@ library_env_test/has_mirror_support: RuntimeError library_env_test/has_mirror_support: Fail # mirrors not supported on web library_env_test/has_no_html_support: RuntimeError, OK library_env_test/has_no_mirror_support: Pass # fails for the wrong reason. -list_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351 local_function2_test/none: RuntimeError local_function3_test/none: RuntimeError local_function_test/none: RuntimeError diff --git a/tests/language_2/language_2_dartdevc.status b/tests/language_2/language_2_dartdevc.status index 45c343c1c5a..b2b9294c43f 100644 --- a/tests/language_2/language_2_dartdevc.status +++ b/tests/language_2/language_2_dartdevc.status @@ -355,7 +355,6 @@ left_shift_test: RuntimeError # Ints and doubles are unified.; Expect.equals(exp library_env_test/has_io_support: RuntimeError, OK # Intended to fail, bool.fromEnvironment("dart.library.async") is false library_env_test/has_mirror_support: RuntimeError, OK # Intended to fail, bool.fromEnvironment("dart.library.async") is false library_env_test/has_no_html_support: RuntimeError, OK # Intended to fail, bool.fromEnvironment("dart.library.async") is false -list_test: CompileTimeError, OK # Error if web int literal cannot be represented exactly, see http://dartbug.com/33351 local_function2_test/none: RuntimeError # ReferenceError: TToNull is not defined local_function3_test/none: RuntimeError # Expect.equals(expected: , actual: ) fails. local_function_test/none: RuntimeError # Expect.equals(expected: , actual: ) fails. diff --git a/tests/language_2/list_test.dart b/tests/language_2/list_test.dart index 910840904db..e5475c493f2 100644 --- a/tests/language_2/list_test.dart +++ b/tests/language_2/list_test.dart @@ -118,7 +118,7 @@ class ListTest { Expect.equals(9, element); Expect.throws(() => new List(-1)); - Expect.throws(() => new List(0x7fffffffffffffff)); + Expect.throws(() => new List(0x7ffffffffffff000)); List list = new List(); Expect.throwsRangeError(list.removeLast);