[benchmark] Cleanup lint violations

Fix violations of lints that I expect have no influence on the
performance characteristics of this benchmark:

* annotate_overrides
* directives_ordering

Change-Id: I49f33347aea5cfdcbac5c9195a18427bdb7c667e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/433266
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
This commit is contained in:
Nicholas Shahan
2025-06-09 14:01:29 -07:00
committed by Commit Queue
parent 6310de0424
commit 6f076f90e1
@@ -2,9 +2,10 @@
// for details. All rights reserved. Use of this source code is governed by a // for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file. // BSD-style license that can be found in the LICENSE file.
import 'package:benchmark_harness/benchmark_harness.dart';
import 'dart:js_interop'; import 'dart:js_interop';
import 'package:benchmark_harness/benchmark_harness.dart';
// Static js-interop benchmarks. // Static js-interop benchmarks.
// //
// Type checks: // Type checks:
@@ -140,6 +141,7 @@ abstract class CastsBase extends Base {
class Casts1 extends CastsBase { class Casts1 extends CastsBase {
Casts1() : super('JSObject', data: allJSObjects()); Casts1() : super('JSObject', data: allJSObjects());
@override
void run() { void run() {
for (final o in data) { for (final o in data) {
sink = o as JSObject; sink = o as JSObject;
@@ -150,6 +152,7 @@ class Casts1 extends CastsBase {
class Casts2 extends CastsBase { class Casts2 extends CastsBase {
Casts2() : super('JSAny', data: allJSAnys()); Casts2() : super('JSAny', data: allJSAnys());
@override
void run() { void run() {
for (final o in data) { for (final o in data) {
sink = o as JSAny; sink = o as JSAny;
@@ -160,6 +163,7 @@ class Casts2 extends CastsBase {
class Casts3 extends CastsBase { class Casts3 extends CastsBase {
Casts3() : super('JSAnyQ', data: allJSAnyQs()); Casts3() : super('JSAnyQ', data: allJSAnyQs());
@override
void run() { void run() {
for (final o in data) { for (final o in data) {
sink = o as JSAny?; sink = o as JSAny?;
@@ -170,6 +174,7 @@ class Casts3 extends CastsBase {
class Casts4 extends CastsBase { class Casts4 extends CastsBase {
Casts4() : super('JSNumber', data: allJSNumbers); Casts4() : super('JSNumber', data: allJSNumbers);
@override
void run() { void run() {
for (final o in data) { for (final o in data) {
sink = o as JSNumber; sink = o as JSNumber;
@@ -180,6 +185,7 @@ class Casts4 extends CastsBase {
class Casts5 extends CastsBase { class Casts5 extends CastsBase {
Casts5() : super('JSString', data: allJSStrings); Casts5() : super('JSString', data: allJSStrings);
@override
void run() { void run() {
for (final o in data) { for (final o in data) {
sink = o as JSString; sink = o as JSString;
@@ -190,6 +196,7 @@ class Casts5 extends CastsBase {
class Casts6 extends CastsBase { class Casts6 extends CastsBase {
Casts6() : super('JSUint8Array', data: allJSUint8Array); Casts6() : super('JSUint8Array', data: allJSUint8Array);
@override
void run() { void run() {
for (final o in data) { for (final o in data) {
sink = o as JSUint8Array; sink = o as JSUint8Array;
@@ -200,6 +207,7 @@ class Casts6 extends CastsBase {
class CastsT<T> extends CastsBase { class CastsT<T> extends CastsBase {
CastsT(String name, {required super.data}) : super('T.$name'); CastsT(String name, {required super.data}) : super('T.$name');
@override
void run() { void run() {
for (final o in data) { for (final o in data) {
sink = o as T; sink = o as T;
@@ -210,6 +218,7 @@ class CastsT<T> extends CastsBase {
class Calls1SSS extends Base { class Calls1SSS extends Base {
Calls1SSS() : super('JSInterop.calls.inline3ArgsSSS'); Calls1SSS() : super('JSInterop.calls.inline3ArgsSSS');
@override
void run() { void run() {
String s = 'hello'; String s = 'hello';
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -225,6 +234,7 @@ class Calls1SSS extends Base {
class Calls1NNN extends Base { class Calls1NNN extends Base {
Calls1NNN() : super('JSInterop.calls.inline3ArgsIII'); Calls1NNN() : super('JSInterop.calls.inline3ArgsIII');
@override
void run() { void run() {
String s = 'hello'; String s = 'hello';
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -244,6 +254,7 @@ class Calls2SSS extends Base {
static final _b = 'b'.toJS; static final _b = 'b'.toJS;
static final _c = 'c'.toJS; static final _c = 'c'.toJS;
@override
void run() { void run() {
String s = 'hello'; String s = 'hello';
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -262,6 +273,7 @@ class Calls2NNN extends Base {
static final _b = 2.toJS; static final _b = 2.toJS;
static final _c = 3.toJS; static final _c = 3.toJS;
@override
void run() { void run() {
String s = 'hello'; String s = 'hello';
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -276,6 +288,7 @@ class Calls2NNN extends Base {
class Calls3SSS extends Base { class Calls3SSS extends Base {
Calls3SSS() : super('JSInterop.calls.implicit3ArgsSSS'); Calls3SSS() : super('JSInterop.calls.implicit3ArgsSSS');
@override
void run() { void run() {
String s = 'hello'; String s = 'hello';
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -289,6 +302,7 @@ class Calls3SSS extends Base {
class Calls3NNN extends Base { class Calls3NNN extends Base {
Calls3NNN() : super('JSInterop.calls.implicit3ArgsIII'); Calls3NNN() : super('JSInterop.calls.implicit3ArgsIII');
@override
void run() { void run() {
String s = 'hello'; String s = 'hello';
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -302,6 +316,7 @@ class Calls3NNN extends Base {
class Calls4 extends Base { class Calls4 extends Base {
Calls4() : super('JSInterop.calls.inline7Args'); Calls4() : super('JSInterop.calls.inline7Args');
@override
void run() { void run() {
String s = 'hello'; String s = 'hello';
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -324,6 +339,8 @@ class Calls5 extends Base {
Calls5() : super('JSInterop.calls.moveJSObject'); Calls5() : super('JSInterop.calls.moveJSObject');
static final _o = JSObject(); static final _o = JSObject();
@override
void run() { void run() {
JSObject o = _o; JSObject o = _o;
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -337,6 +354,8 @@ class Calls6 extends Base {
Calls6() : super('JSInterop.calls.moveJSArray'); Calls6() : super('JSInterop.calls.moveJSArray');
static final _o = JSArray.withLength(2); static final _o = JSArray.withLength(2);
@override
void run() { void run() {
JSArray o = _o; JSArray o = _o;
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -350,6 +369,8 @@ class Calls7 extends Base {
Calls7() : super('JSInterop.calls.moveJSUint8Array'); Calls7() : super('JSInterop.calls.moveJSUint8Array');
static final _o = JSUint8Array.withLength(2); static final _o = JSUint8Array.withLength(2);
@override
void run() { void run() {
JSUint8Array o = _o; JSUint8Array o = _o;
for (int i = 0; i < N; i++) { for (int i = 0; i < N; i++) {
@@ -382,6 +403,8 @@ abstract class IsABase extends Base {
class IsA1 extends IsABase { class IsA1 extends IsABase {
IsA1() : super('JSObject'); IsA1() : super('JSObject');
@override
void run() { void run() {
for (final o in objects) { for (final o in objects) {
sink = o.isA<JSObject>(); sink = o.isA<JSObject>();
@@ -391,6 +414,8 @@ class IsA1 extends IsABase {
class IsA2 extends IsABase { class IsA2 extends IsABase {
IsA2() : super('JSAny'); IsA2() : super('JSAny');
@override
void run() { void run() {
for (final o in objects) { for (final o in objects) {
sink = o.isA<JSAny>(); sink = o.isA<JSAny>();
@@ -400,6 +425,8 @@ class IsA2 extends IsABase {
class IsA3 extends IsABase { class IsA3 extends IsABase {
IsA3() : super('JSString'); IsA3() : super('JSString');
@override
void run() { void run() {
for (final o in objects) { for (final o in objects) {
sink = o.isA<JSString>(); sink = o.isA<JSString>();
@@ -409,6 +436,8 @@ class IsA3 extends IsABase {
class IsA4 extends IsABase { class IsA4 extends IsABase {
IsA4() : super('JSArray'); IsA4() : super('JSArray');
@override
void run() { void run() {
for (final o in objects) { for (final o in objects) {
sink = o.isA<JSArray>(); sink = o.isA<JSArray>();
@@ -418,6 +447,8 @@ class IsA4 extends IsABase {
class IsA5 extends IsABase { class IsA5 extends IsABase {
IsA5() : super('Date'); IsA5() : super('Date');
@override
void run() { void run() {
for (final o in objects) { for (final o in objects) {
sink = o.isA<Date>(); sink = o.isA<Date>();
@@ -427,6 +458,8 @@ class IsA5 extends IsABase {
class IsA6 extends IsABase { class IsA6 extends IsABase {
IsA6() : super('DateQ'); IsA6() : super('DateQ');
@override
void run() { void run() {
for (final o in objects) { for (final o in objects) {
sink = o.isA<Date?>(); sink = o.isA<Date?>();
@@ -436,6 +469,8 @@ class IsA6 extends IsABase {
class IsA7 extends IsABase { class IsA7 extends IsABase {
IsA7() : super('JSUint8Array'); IsA7() : super('JSUint8Array');
@override
void run() { void run() {
for (final o in objects) { for (final o in objects) {
sink = o.isA<JSUint8Array>(); sink = o.isA<JSUint8Array>();