From 6eb220bbcf1dd7b9a2949324b96c22f58f41b404 Mon Sep 17 00:00:00 2001 From: Sigurd Meldgaard Date: Thu, 11 Apr 2024 13:53:08 +0000 Subject: [PATCH] Close pub http client in finally block Change-Id: I63efbdbcaeef787d07ce38c44d30425cdc96c65d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362360 Reviewed-by: Jonas Jensen Commit-Queue: Sigurd Meldgaard --- pkg/dartdev/bin/dartdev.dart | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/pkg/dartdev/bin/dartdev.dart b/pkg/dartdev/bin/dartdev.dart index 0719ddbf22a..10751b1ca73 100644 --- a/pkg/dartdev/bin/dartdev.dart +++ b/pkg/dartdev/bin/dartdev.dart @@ -9,8 +9,11 @@ import 'package:pub/src/http.dart'; /// The entry point for dartdev. Future main(List args, SendPort? port) async { - await runDartdev(args, port); - // TODO(https://github.com/dart-lang/pub/issues/4209). Handle this in a more - // structured way. - globalHttpClient.close(); + try { + await runDartdev(args, port); + } finally { + // TODO(https://github.com/dart-lang/pub/issues/4209). Handle this in a more + // structured way. + globalHttpClient.close(); + } }