From 6ea61b568612e69e40779d4efbf8317cf204edeb Mon Sep 17 00:00:00 2001 From: "paulberry@google.com" Date: Tue, 10 Feb 2015 16:04:50 +0000 Subject: [PATCH] Partial backport of analyzer async/await fixes to Java. Backport of r43613, r43537, r43446, r43427, r43424, r43418, r43403, r43361 to the Java-based analyzer. The backport is partial in that the TypeProvider was not modified to include Future and Stream types (this would have required substantial additional effort), and consequently not all static warnings are correctly produced. However, all NonErrorResolverTest cases were successfully backported and pass, meaning that the Java-based analyzer shouldn't produce false positive warnings for async/await code anymore. BUG=dartbug.com/22252 R=brianwilkerson@google.com Review URL: https://codereview.chromium.org//913623002 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43655 260f80e4-7a28-3924-810f-c04153c831b5 --- pkg/pkg.status | 13 ------------- tests/language/language_analyzer.status | 13 +++++++++---- 2 files changed, 9 insertions(+), 17 deletions(-) diff --git a/pkg/pkg.status b/pkg/pkg.status index 35af9a7be57..fb2fc499a47 100644 --- a/pkg/pkg.status +++ b/pkg/pkg.status @@ -182,19 +182,6 @@ docgen/test/*: Skip # Uses dart:io [ $compiler == dartanalyzer || $compiler == dart2analyzer ] third_party/angular_tests/vm_test: StaticWarning # Uses removed APIs. See issue 18733. -[ $compiler == dartanalyzer ] -analysis_server/test/edit/sort_members_test: StaticWarning # Issue 22252 -analysis_server/test/edit/assists_test: StaticWarning # Issue 22252 -analysis_server/test/edit/format_test: StaticWarning # Issue 22252 -analysis_server/test/edit/refactoring_test: StaticWarning # Issue 22252 -analysis_server/test/edit/fixes_test: StaticWarning # Issue 22252 -analysis_server/test/socket_server_test: StaticWarning # Issue 22252 -analysis_server/test/search/type_hierarchy_test: StaticWarning # Issue 22252 -analysis_server/test/search/top_level_declarations_test: StaticWarning # Issue 22252 -analysis_server/test/search/member_references_test: StaticWarning # Issue 22252 -analysis_server/test/search/member_declarations_test: StaticWarning # Issue 22252 -analysis_server/test/search/element_references_test: StaticWarning # Issue 22252 - [ $runtime == safari || $runtime == safarimobilesim || $runtime == chrome || $runtime == ff || $ie ] # Various issues due to limited browser testing in Angular. third_party/angular_tests/*: Skip diff --git a/tests/language/language_analyzer.status b/tests/language/language_analyzer.status index f3e5afa314d..5dcff2dfa93 100644 --- a/tests/language/language_analyzer.status +++ b/tests/language/language_analyzer.status @@ -4,12 +4,18 @@ [ $compiler == dartanalyzer ] -asyncstar_yield_test: fail - await_backwards_compatibility_test/none: CompileTimeError # Issue 22052 await_test: CompileTimeError # Issue 22052 -sync_generator2_test: Skip # +sync_generator1_test: StaticWarning +sync_generator2_test/01: MissingCompileTimeError # Issue 22252 +sync_generator2_test/02: MissingCompileTimeError # Issue 22252 +sync_generator2_test/03: MissingCompileTimeError # Issue 22252 +sync_generator2_test/04: MissingCompileTimeError # Issue 22252 +sync_generator2_test/05: MissingCompileTimeError # Issue 22252 +sync_generator2_test/06: MissingCompileTimeError # Issue 22252 +sync_generator2_test/07: MissingCompileTimeError # Issue 22252 +sync_generator2_test/10: MissingCompileTimeError # Issue 22252 async_test/type-mismatch2: MissingStaticWarning # Issue 22053 async_test/type-mismatch3: MissingStaticWarning # Issue 22053 @@ -21,7 +27,6 @@ async_await_syntax_test/a05f: MissingCompileTimeError async_await_syntax_test/a10a: MissingStaticWarning async_await_syntax_test/b10a: MissingStaticWarning async_await_syntax_test/c10a: MissingStaticWarning -async_await_syntax_test/d08b: MissingStaticWarning async_await_syntax_test/d10a: MissingStaticWarning # Runtime negative test. No static errors or warnings.