From 6cd25af6846c0eddd361f4e4c24b399ef4921bf4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20von=20der=20Ahe=CC=81?= Date: Tue, 9 Oct 2018 11:06:29 +0000 Subject: [PATCH] Configure defines correctly in config_import_test.dart MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I5ad46c03c92fa55249e35e83d9f78dabdfcc69f2 Reviewed-on: https://dart-review.googlesource.com/c/78521 Commit-Queue: Peter von der Ahé Auto-Submit: Peter von der Ahé Reviewed-by: William Hesse --- tests/language_2/config_import_test.dart | 3 +-- tests/language_2/language_2_dartdevc.status | 3 +-- tests/language_2/language_2_kernel.status | 2 -- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/language_2/config_import_test.dart b/tests/language_2/config_import_test.dart index 6aab2236a55..2e15460cbea 100644 --- a/tests/language_2/config_import_test.dart +++ b/tests/language_2/config_import_test.dart @@ -2,8 +2,7 @@ // for details. All rights reserved. Use of this source code is governed by a // BSD-style license that can be found in the LICENSE file. // -// DartOptions=-Did=true -Ddotted.id=some_string -Dlots.of.dots.In.id=false -// VMOptions=-Did=true -Ddotted.id=some_string -Dlots.of.dots.In.id=false +// SharedOptions=-Did=true -Ddotted.id=some_string -Dlots.of.dots.In.id=false import 'package:expect/expect.dart'; diff --git a/tests/language_2/language_2_dartdevc.status b/tests/language_2/language_2_dartdevc.status index f8060b625c9..a349516039a 100644 --- a/tests/language_2/language_2_dartdevc.status +++ b/tests/language_2/language_2_dartdevc.status @@ -239,7 +239,7 @@ compile_time_constant_static5_test/21: CompileTimeError # Issue 31537 compile_time_constant_static5_test/23: CompileTimeError # Issue 31537 conditional_import_string_test: CompileTimeError # Test is broken conditional_import_test: CompileTimeError # Test is broken -config_import_test: CompileTimeError +config_import_test: RuntimeError const_cast1_test/02: MissingCompileTimeError const_constructor3_test/04: MissingCompileTimeError const_constructor_mixin3_test: CompileTimeError # Issue 33644. @@ -411,7 +411,6 @@ closure_call_wrong_argument_count_negative_test: Fail compile_time_constant_d_test: RuntimeError # Issue 30876; Expect.isTrue(false) fails. compile_time_constant_e_test: RuntimeError # Issue 30876; Expect.identical(expected: , actual: ) fails. config_import_corelib_test: CompileTimeError -config_import_test: RuntimeError # Expect.equals(expected: , actual: ) fails. const_evaluation_test/01: RuntimeError # dart:mirrors not supported in DDC const_list_test: RuntimeError # Expect.equals(expected: , actual: ) fails. const_map4_test: RuntimeError # Expect.equals(expected: , actual: ) fails. diff --git a/tests/language_2/language_2_kernel.status b/tests/language_2/language_2_kernel.status index 5d8f770597b..349ebbc8aa3 100644 --- a/tests/language_2/language_2_kernel.status +++ b/tests/language_2/language_2_kernel.status @@ -733,7 +733,6 @@ compile_time_constant_static5_test/23: CompileTimeError conditional_import_string_test: CompileTimeError conditional_import_test: CompileTimeError config_import_corelib_test: CompileTimeError -config_import_test: Crash const_constructor3_test/04: MissingCompileTimeError constants_test/05: MissingCompileTimeError deferred_load_library_wrong_args_test/01: CompileTimeError @@ -1390,7 +1389,6 @@ conditional_property_increment_decrement_test/33: MissingCompileTimeError conditional_property_increment_decrement_test/34: MissingCompileTimeError conditional_property_increment_decrement_test/39: MissingCompileTimeError conditional_property_increment_decrement_test/40: MissingCompileTimeError -config_import_test: Crash const_conditional_test/08: MissingCompileTimeError const_constructor2_test/05: MissingCompileTimeError const_constructor2_test/06: MissingCompileTimeError