From 6c3cf9ea517860b8703286c274df78cf02fd611f Mon Sep 17 00:00:00 2001 From: Ryan Macnak Date: Wed, 10 Jun 2026 11:05:58 -0700 Subject: [PATCH] Roll Clang from a3f244e2d555 to deb6854eec93 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/clang-dart-sdk Please CC dart-engprod@google.com,dart-vm-gardener@rotations.google.com,dart-vm-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md TEST=ci Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-linux-arm64-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try;luci.dart.try:vm-asan-mac-release-arm64-try Change-Id: Iddd7439c096af8c37076756330a067ccb7d10a35 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/510520 Reviewed-by: Ryan Macnak Reviewed-by: Alexander Aprelev Commit-Queue: Ryan Macnak --- DEPS | 2 +- runtime/vm/constants_arm64.h | 6 +++--- runtime/vm/dart_api_impl.cc | 2 +- runtime/vm/object.h | 2 +- runtime/vm/regexp/regexp-interpreter.cc | 4 +++- 5 files changed, 9 insertions(+), 7 deletions(-) diff --git a/DEPS b/DEPS index 2b0ffc049f4..647bccd9750 100644 --- a/DEPS +++ b/DEPS @@ -80,7 +80,7 @@ vars = { "jsc_tag": "version:313485", # https://chrome-infra-packages.appspot.com/p/fuchsia/third_party/clang - "clang_version": "git_revision:a3f244e2d5550e110daee562b88bee247b75d66c", + "clang_version": "git_revision:deb6854eec93529b2bd30178d400ad2ee7665cd4", # https://chrome-infra-packages.appspot.com/p/gn/gn "gn_version": "git_revision:6f8c0328ee29c76e3566a216f2f0cf2992daa6ed", diff --git a/runtime/vm/constants_arm64.h b/runtime/vm/constants_arm64.h index 4d46a466a68..9a918dc85ad 100644 --- a/runtime/vm/constants_arm64.h +++ b/runtime/vm/constants_arm64.h @@ -804,7 +804,7 @@ enum SystemOp { SystemFixed = CompareBranchFixed | B31 | B30 | B24, HINT = SystemFixed | B17 | B16 | B13 | B4 | B3 | B2 | B1 | B0, CLREX = SystemFixed | B17 | B16 | B13 | B12 | B11 | B10 | B9 | B8 | B6 | B4 | - B3 | B2 | B1 | B0, + B3 | B2 | B1 | B0, }; // C3.2.5 @@ -1054,8 +1054,8 @@ enum SIMDTwoRegOp { VABSD = SIMDTwoRegFixed | B30 | B23 | B22 | B15 | B14 | B13 | B12, VNEGD = SIMDTwoRegFixed | B30 | B29 | B23 | B22 | B15 | B14 | B13 | B12, VSQRTS = SIMDTwoRegFixed | B30 | B29 | B23 | B16 | B15 | B14 | B13 | B12, - VSQRTD = - SIMDTwoRegFixed | B30 | B29 | B23 | B22 | B16 | B15 | B14 | B13 | B12, + VSQRTD = SIMDTwoRegFixed | B30 | B29 | B23 | B22 | B16 | B15 | B14 | B13 | + B12, VRECPES = SIMDTwoRegFixed | B30 | B23 | B16 | B15 | B14 | B12, VRSQRTES = SIMDTwoRegFixed | B30 | B29 | B23 | B16 | B15 | B14 | B12, }; diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc index 19264959778..77e6df1b869 100644 --- a/runtime/vm/dart_api_impl.cc +++ b/runtime/vm/dart_api_impl.cc @@ -6722,7 +6722,7 @@ static void CreateAppAOTSnapshotHelper( Dwarf* const dwarf = (format == Dart_AotBinaryFormat_Assembly || strip) ? nullptr - : generate_debug ? debug_dwarf + : generate_debug ? debug_dwarf : new (Z) Dwarf(Z, deobfuscation_trie, identifier); SharedObjectWriter* so = nullptr; if (format == Dart_AotBinaryFormat_Elf) { diff --git a/runtime/vm/object.h b/runtime/vm/object.h index 66e9a7e402c..6b3515bff4d 100644 --- a/runtime/vm/object.h +++ b/runtime/vm/object.h @@ -2719,7 +2719,7 @@ class ICData : public CallSiteData { kCachedICDataZeroArgTestedWithoutExactnessTrackingIdx = 0, kCachedICDataMaxArgsTestedWithoutExactnessTracking = 2, kCachedICDataOneArgWithExactnessTrackingIdx = - kCachedICDataZeroArgTestedWithoutExactnessTrackingIdx + + kCachedICDataZeroArgTestedWithoutExactnessTrackingIdx + kCachedICDataMaxArgsTestedWithoutExactnessTracking + 1, kCachedICDataArrayCount = kCachedICDataOneArgWithExactnessTrackingIdx + 1, }; diff --git a/runtime/vm/regexp/regexp-interpreter.cc b/runtime/vm/regexp/regexp-interpreter.cc index b841077f23f..f4a31e87f3b 100644 --- a/runtime/vm/regexp/regexp-interpreter.cc +++ b/runtime/vm/regexp/regexp-interpreter.cc @@ -1084,7 +1084,9 @@ IrregexpInterpreter::Result RawMatch(Thread* thread, } // Label we jump to in DISPATCH(). There must be no instructions between the // end of the switch, this label and the end of the loop. - switch_dispatch_continuation: {} + switch_dispatch_continuation: + { + } #endif // V8_USE_COMPUTED_GOTO } }