From 68ff3d28cc7d4e2e5a625df7e7cf25cb06c8d652 Mon Sep 17 00:00:00 2001 From: "kasperl@google.com" Date: Fri, 1 Nov 2013 08:47:49 +0000 Subject: [PATCH] Revert "fix nested bindings" This reverts r29722. R=jmesserly@google.com BUG= Review URL: https://codereview.chromium.org//54603008 git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29728 260f80e4-7a28-3924-810f-c04153c831b5 --- pkg/pkg.status | 2 - pkg/polymer/test/nested_binding_test.dart | 43 ------------------- pkg/polymer/test/nested_binding_test.html | 31 ------------- .../lib/polymer_expressions.dart | 11 ----- 4 files changed, 87 deletions(-) delete mode 100644 pkg/polymer/test/nested_binding_test.dart delete mode 100644 pkg/polymer/test/nested_binding_test.html diff --git a/pkg/pkg.status b/pkg/pkg.status index e4dcebfc3eb..da33bb89571 100644 --- a/pkg/pkg.status +++ b/pkg/pkg.status @@ -51,7 +51,6 @@ polymer/test/event_path_declarative_test: Skip #uses dart:html polymer/test/event_path_test: Skip #uses dart:html polymer/test/events_test: Skip #uses dart:html polymer/test/instance_attrs_test: Skip #uses dart:html -polymer/test/nested_binding_test: Skip # uses dart:html polymer/test/noscript_test: Skip #uses dart:html polymer/test/prop_attr_bind_reflection_test: Skip #uses dart:html polymer/test/prop_attr_reflection_test: Skip #uses dart:html @@ -99,7 +98,6 @@ polymer/test/event_handlers_test: Pass, Timeout # Issue 13260 polymer/test/event_path_declarative_test: Pass, Timeout # Issue 13260 polymer/test/event_path_test: Pass, Timeout # Issue 13260 polymer/test/events_test: Pass, Timeout # Issue 13260 -polymer/test/nested_binding_test: Pass, Timeout # Issue 13260 polymer/test/noscript_test: Pass, Timeout # Issue 13260 polymer/test/prop_attr_reflection_test: Pass, Timeout # Issue 13260 polymer/test/prop_attr_bind_reflection_test: Pass, Timeout # Issue 13260 diff --git a/pkg/polymer/test/nested_binding_test.dart b/pkg/polymer/test/nested_binding_test.dart deleted file mode 100644 index b8db84ef718..00000000000 --- a/pkg/polymer/test/nested_binding_test.dart +++ /dev/null @@ -1,43 +0,0 @@ -// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file -// for details. All rights reserved. Use of this source code is governed by a -// BSD-style license that can be found in the LICENSE file. - -library polymer.test.nested_binding_test; - -import 'dart:async'; -import 'dart:html'; -import 'dart:mirrors'; // import mirrors so we include String.length -import 'package:polymer/polymer.dart'; -import 'package:unittest/unittest.dart'; -import 'package:unittest/html_config.dart'; -import 'package:unittest/matcher.dart'; - -@CustomTag('my-test') -class MyTest extends PolymerElement { - final List fruits = toObservable(['apples', 'oranges', 'pears']); - - final _testDone = new Completer(); - - MyTest.created() : super.created(); - - _runTest(_) { - expect($['fruit'].text.trim(), 'Short name: [pears]'); - _testDone.complete(); - } - - ready() { - onMutation($['fruit']).then(_runTest); - } - -} - -main() { - reflectClass(String); // use the mirrors import to suppress a warning. - - initPolymer(); - useHtmlConfiguration(); - - setUp(() => Polymer.onReady); - - test('ready called', () => (query('my-test') as MyTest)._testDone.future); -} diff --git a/pkg/polymer/test/nested_binding_test.html b/pkg/polymer/test/nested_binding_test.html deleted file mode 100644 index bfc6a30956c..00000000000 --- a/pkg/polymer/test/nested_binding_test.html +++ /dev/null @@ -1,31 +0,0 @@ - - - - - - bind simple - - - - - - - - - - - - diff --git a/pkg/polymer_expressions/lib/polymer_expressions.dart b/pkg/polymer_expressions/lib/polymer_expressions.dart index 0d4d06192fe..354fb5eb995 100644 --- a/pkg/polymer_expressions/lib/polymer_expressions.dart +++ b/pkg/polymer_expressions/lib/polymer_expressions.dart @@ -70,17 +70,6 @@ class PolymerExpressions extends BindingDelegate { prepareBinding(String path, name, node) { if (path == null) return null; var expr = new Parser(path).parse(); - - // For template bind/repeat to an empty path, just pass through the model. - // We don't want to unwrap the Scope. - // TODO(jmesserly): a custom element extending