From 68e17083b95a5f55b8c851e72919bdfa40ba89f2 Mon Sep 17 00:00:00 2001 From: sgrekhov Date: Mon, 15 Jun 2020 15:14:41 +0000 Subject: [PATCH] [co19] Enable Subtyping tests * Skip tests that use type aliases on analyzer configurations. * Shard co19 test more on VM AOT builder (to avoid shard timeouts). Change-Id: I5834091e91f229242329ee9e7456ca822d18c0b5 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151223 Reviewed-by: Alexander Thomas --- tests/co19/co19-co19.status | 6 +++++- tools/bots/test_matrix.json | 4 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/co19/co19-co19.status b/tests/co19/co19-co19.status index 9aea031703a..ac41401b537 100644 --- a/tests/co19/co19-co19.status +++ b/tests/co19/co19-co19.status @@ -101,7 +101,6 @@ LanguageFeatures/Simple-bounds/dynamic/type-aliases/*: Skip # Not migrated to NN LanguageFeatures/Simple-bounds/static/*: Skip # Not migrated to NNBD LanguageFeatures/Simple-bounds/static/type-aliases/*: Skip # Not migrated to NNBD LanguageFeatures/Spread-collections/*: Skip # Not migrated to NNBD -LanguageFeatures/Subtyping/*: Skip # Not migrated to NNBD LanguageFeatures/Super-bounded-types/*: Skip # Not migrated to NNBD LanguageFeatures/Super-mixins/*: Skip # Not migrated to NNBD LanguageFeatures/Triple-Shift/*: Skip # Not migrated to NNBD @@ -309,6 +308,11 @@ LibTest/typed_data/Uint8ClampedList/*: Skip # Not migrated to NNBD LibTest/typed_data/Uint8List/*: Skip # Not migrated to NNBD Utils/tests/Expect/*: Skip # Not migrated to NNBD +[ $compiler == dart2analyzer ] +LanguageFeatures/Subtyping/static/tests/left_bottom_A01_t02: Skip # Type aliases are not supported by analyzer +LanguageFeatures/Subtyping/static/tests/left_bottom_A01_t04: Skip # Type aliases are not supported by analyzer +LanguageFeatures/Subtyping/static/tests/left_bottom_A01_t06: Skip # Type aliases are not supported by analyzer + [ $compiler != fasta ] Language/Classes/Abstract_Instance_Members/inherited_t13: Skip # github.com/dart-lang/language/issues/115 Language/Classes/Abstract_Instance_Members/inherited_t14: Skip # github.com/dart-lang/language/issues/115 diff --git a/tools/bots/test_matrix.json b/tools/bots/test_matrix.json index bdc666cfce9..31eea7f3b7f 100644 --- a/tools/bots/test_matrix.json +++ b/tools/bots/test_matrix.json @@ -1376,7 +1376,7 @@ "co19" ], "fileset": "vm-kernel", - "shards": 1 + "shards": 2 }, { "name": "co19 nnbd tests in strong mode", @@ -1385,7 +1385,7 @@ "co19" ], "fileset": "vm-kernel", - "shards": 1 + "shards": 2 }, { "name": "vm nnbd tests in weak mode with asserts",