From 6676a4548845dec4e59e671445a9adf2caa1918e Mon Sep 17 00:00:00 2001 From: Johnni Winther Date: Mon, 10 Jan 2022 14:24:14 +0000 Subject: [PATCH] [cfe] Remove outcommented code in hierarchy_node The code was commented out during a refactoring but was not removed as intended. Change-Id: Iba2ba900c8f25446b2aa985c9dbcd012fd1fa4be Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226689 Reviewed-by: Chloe Stefantsova Commit-Queue: Johnni Winther --- .../kernel/hierarchy/hierarchy_node.dart | 70 ++++--------------- 1 file changed, 12 insertions(+), 58 deletions(-) diff --git a/pkg/front_end/lib/src/fasta/kernel/hierarchy/hierarchy_node.dart b/pkg/front_end/lib/src/fasta/kernel/hierarchy/hierarchy_node.dart index 27a3b7a5f4e..30bd3730020 100644 --- a/pkg/front_end/lib/src/fasta/kernel/hierarchy/hierarchy_node.dart +++ b/pkg/front_end/lib/src/fasta/kernel/hierarchy/hierarchy_node.dart @@ -168,24 +168,13 @@ class ClassHierarchyNodeBuilder { } } - /*ClassHierarchyMemberNode memberNode = - buildMemberNode(supernode, directInterfaceBuilders);*/ - return new ClassHierarchyNode( - classBuilder, - supernode, - directInterfaceBuilders, - /*classMemberMap, - classSetterMap, - interfaceMemberMap, - interfaceSetterMap,*/ - superclasses, - interfacesList, - maxInheritancePath, - /*hasNoSuchMethod, - dataForTesting,*/ - /*memberNode*/ - ); + classBuilder, + supernode, + directInterfaceBuilders, + superclasses, + interfacesList, + maxInheritancePath); } Supertype recordSupertype(Supertype supertype) { @@ -344,27 +333,6 @@ class ClassHierarchyNode { final List? directInterfaceBuilders; - /*/// All the members of this class including [classMembers] of its - /// superclasses. The members are sorted by [compareDeclarations]. - final Map classMemberMap; - - /// Similar to [classMembers] but for setters. - final Map classSetterMap; - - /// All the interface members of this class including [interfaceMembers] of - /// its supertypes. The members are sorted by [compareDeclarations]. - /// - /// In addition to the members of [classMembers] this also contains members - /// from interfaces. - /// - /// This may be null, in which case [classMembers] is the interface members. - final Map? interfaceMemberMap; - - /// Similar to [interfaceMembers] but for setters. - /// - /// This may be null, in which case [classSetters] is the interface setters. - final Map? interfaceSetterMap;*/ - /// All superclasses of [classBuilder] excluding itself. The classes are /// sorted by depth from the root (Object) in ascending order. final List superclasses; @@ -378,27 +346,13 @@ class ClassHierarchyNode { int get depth => superclasses.length; - /*final bool hasNoSuchMethod; - - final ClassHierarchyNodeDataForTesting? dataForTesting;*/ - - //final ClassHierarchyMemberNode memberNode; - ClassHierarchyNode( - this.classBuilder, - this.supernode, - this.directInterfaceBuilders, - /*this.classMemberMap, - this.classSetterMap, - this.interfaceMemberMap, - this.interfaceSetterMap,*/ - this.superclasses, - this.interfaces, - this.maxInheritancePath, - /*this.hasNoSuchMethod, - this.dataForTesting,*/ - /*this.memberNode*/ - ); + this.classBuilder, + this.supernode, + this.directInterfaceBuilders, + this.superclasses, + this.interfaces, + this.maxInheritancePath); /// Returns a list of all supertypes of [classBuilder], including this node. List computeAllSuperNodes(