From 65a5876e0d51f957279dbba63f2d65d175b13402 Mon Sep 17 00:00:00 2001 From: Sam Rawlins Date: Mon, 23 Mar 2026 07:12:02 -0700 Subject: [PATCH] [front_end] Remove dead code regarding null values in collections of non-null values These will soon be reported by the analyzer for https://github.com/dart-lang/sdk/issues/57101. Change-Id: I7fe2a9dca107c8c69b5dff0f527fa501c41a2c74 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/489503 Reviewed-by: Johnni Winther Commit-Queue: Samuel Rawlins --- pkg/_fe_analyzer_shared/lib/src/testing/id_testing.dart | 5 ----- pkg/front_end/test/incremental_utils.dart | 1 - 2 files changed, 6 deletions(-) diff --git a/pkg/_fe_analyzer_shared/lib/src/testing/id_testing.dart b/pkg/_fe_analyzer_shared/lib/src/testing/id_testing.dart index 960bd6ced7c..4483e1a554b 100644 --- a/pkg/_fe_analyzer_shared/lib/src/testing/id_testing.dart +++ b/pkg/_fe_analyzer_shared/lib/src/testing/id_testing.dart @@ -1199,11 +1199,6 @@ bool skipForConfig( print("Skip: ${testName} for config '${configMarker}'"); return true; } - skipList = skipMap[null]; - if (skipList != null && skipList.contains(testName)) { - print("Skip: ${testName} for config '${configMarker}'"); - return true; - } } return false; } diff --git a/pkg/front_end/test/incremental_utils.dart b/pkg/front_end/test/incremental_utils.dart index f9e669c0dcb..fb88b6cd000 100644 --- a/pkg/front_end/test/incremental_utils.dart +++ b/pkg/front_end/test/incremental_utils.dart @@ -74,7 +74,6 @@ Future throwOnInsufficientUriToSource( component.accept(uriFinder); Set uris = uriFinder.seenUris.toSet(); uris.removeAll(component.uriToSource.keys); - uris.remove(null); if (uris.length != 0) { throw "Expected 0 uris with no source, but found ${uris.length} ($uris)"; }